coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: soc/amd/common/data_fabric/domain: write _STA method in SSDT
by Nico Huber (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Raul Rangel. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74993?usp=email ) Change subject: soc/amd/common/data_fabric/domain: write _STA method in SSDT ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: > the domain could be set to off in the devicetree. […] SSDT wouldn't get generated for an `off` device (non of the device ops would be called). I guess the original _STA method is just redundant. Specs says ``` If a device object describes a device that is not on an enumerable bus and the device object does not have an _STA object, then OSPM assumes that the device is present, enabled, shown in the UI, and functioning. ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/74993?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied48b48113f6e871e90d17cbd216be003f05b5ef Gerrit-Change-Number: 74993 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 02 Jun 2023 16:23:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/amd/common/data_fabric/domain: write _STA method in SSDT
by Felix Held (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Nico Huber, Raul Rangel. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74993?usp=email ) Change subject: soc/amd/common/data_fabric/domain: write _STA method in SSDT ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: > This seems odd, I wonder why it should have an _STA object at all? […] the domain could be set to off in the devicetree. not that that case would make much sense to me, but that would cover that case. the newer socs from cezanne on had an _sta method that always returned 0xf which is why i implemented this -- To view, visit https://review.coreboot.org/c/coreboot/+/74993?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied48b48113f6e871e90d17cbd216be003f05b5ef Gerrit-Change-Number: 74993 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 16:12:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: lib/dimm_info_util.c: Add newlines to log messages
by Fred Reitberger (Code Review) 02 Jun '23

02 Jun '23

Fred Reitberger has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75589?usp=email ) Change subject: lib/dimm_info_util.c: Add newlines to log messages ...................................................................... lib/dimm_info_util.c: Add newlines to log messages Add newlines to log messages to prevent them from running into each other. Change-Id: I4f61c80385f384a3734a5122ccb4161c1ed7c6c5 Signed-off-by: Fred Reitberger <reitbergerfred(a)gmail.com> --- M src/lib/dimm_info_util.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/75589/1 diff --git a/src/lib/dimm_info_util.c b/src/lib/dimm_info_util.c index 3507366..d16cb46 100644 --- a/src/lib/dimm_info_util.c +++ b/src/lib/dimm_info_util.c @@ -26,7 +26,7 @@ out = MEMORY_BUS_WIDTH_8; break; default: - printk(BIOS_NOTICE, "Unknown memory size %hu", data_width); + printk(BIOS_NOTICE, "Unknown memory size %hu\n", data_width); /* * The SMBIOS spec says we should set 0xFFFF on an unknown * value, but we don't have a way of passing that signal via SPD @@ -49,7 +49,7 @@ /* No extension bits */ break; default: - printk(BIOS_NOTICE, "Unknown number of extension bits %hu", + printk(BIOS_NOTICE, "Unknown number of extension bits %hu\n", extension_bits); break; } -- To view, visit https://review.coreboot.org/c/coreboot/+/75589?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f61c80385f384a3734a5122ccb4161c1ed7c6c5 Gerrit-Change-Number: 75589 Gerrit-PatchSet: 1 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: soc/intel/apollolake: Switch to snake case for SataPortsEnable
by Felix Singer (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Mario Scheithauer, Maxim Polyakov, Nico Huber, Sean Rhodes, Werner Zeh. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75553?usp=email ) Change subject: soc/intel/apollolake: Switch to snake case for SataPortsEnable ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75553?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0df35125360eb42a03d5445011d72842cb2b8d7e Gerrit-Change-Number: 75553 Gerrit-PatchSet: 4 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 15:40:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/rex: Create ovis variant
by Subrata Banik (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Jakub Czapiga, Jan Dabros, Kapil Porwal, Paul Menzel, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75385?usp=email ) Change subject: mb/google/rex: Create ovis variant ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75385?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c8f290cfdcb4d47c0e5e9d72c1e34073b957681 Gerrit-Change-Number: 75385 Gerrit-PatchSet: 7 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jan Dabros <dabros(a)google.com> Gerrit-CC: Jan Dabros <jsd(a)semihalf.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Jan Dabros <dabros(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 15:32:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex: Select SOC_INTEL_METEORLAKE_U_P
by Subrata Banik (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Kapil Porwal, Tarun Tuli. Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75612?usp=email ) Change subject: mb/google/rex: Select SOC_INTEL_METEORLAKE_U_P ...................................................................... mb/google/rex: Select SOC_INTEL_METEORLAKE_U_P Google/Rex is built with Intel Meteor Lake-U SoC, so select it. Currently, there is no functional difference, but in the future FSP UPD parameters can be overridden properly. BUG=b:276697173 TEST=Able to build and boot google/rex. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I4c233e0a8ce58998dc1a0379662e386f9b3d0073 --- M src/mainboard/google/rex/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/75612/1 diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig index e6313bf..39d5157 100644 --- a/src/mainboard/google/rex/Kconfig +++ b/src/mainboard/google/rex/Kconfig @@ -38,7 +38,7 @@ select HAVE_SLP_S0_GATE select MAINBOARD_HAS_CHROMEOS select MEMORY_SOLDERDOWN - select SOC_INTEL_METEORLAKE + select SOC_INTEL_METEORLAKE_U_P select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select SYSTEM_TYPE_LAPTOP select TPM_GOOGLE_TI50 -- To view, visit https://review.coreboot.org/c/coreboot/+/75612?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c233e0a8ce58998dc1a0379662e386f9b3d0073 Gerrit-Change-Number: 75612 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: mb/intel/mtlrvp: Select SOC_INTEL_METEORLAKE_U_P
by Subrata Banik (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Eric Lai, Ivy Jian, Kapil Porwal, Paul Menzel, Tarun Tuli. Hello Eric Lai, Ivy Jian, Kapil Porwal, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75607?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Eric Lai, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: mb/intel/mtlrvp: Select SOC_INTEL_METEORLAKE_U_P ...................................................................... mb/intel/mtlrvp: Select SOC_INTEL_METEORLAKE_U_P Intel/MTLRVP is built with Intel Meteor Lake-U SoC, so select it. Currently, there is no functional difference, but in the future FSP UPD parameters can be overridden properly. BUG=b:276697173 TEST=Able to build and boot intel/mtlrvp. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I8b1dec47ef9d12ac50317b86c4f0bc5fbe4e4dc3 --- M src/mainboard/intel/mtlrvp/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/75607/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75607?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b1dec47ef9d12ac50317b86c4f0bc5fbe4e4dc3 Gerrit-Change-Number: 75607 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/{google,intel}: Choose correct SoC type between MTL-U/P and MTL-S
by Subrata Banik (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Ivy Jian, Kapil Porwal, Paul Menzel, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75607?usp=email ) Change subject: mb/{google,intel}: Choose correct SoC type between MTL-U/P and MTL-S ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75607/comment/f3be2792_3e6bcb0f : PS1, Line 7: mb/{google,intel}: Choose correct SoC type between MTL-U/P and MTL-S > I’d make it two commits: […] Acknowledged https://review.coreboot.org/c/coreboot/+/75607/comment/0ec79c7d_b1ffddf1 : PS1, Line 9: This patch ensures that mainboards built with Intel Meteor Lake SoC : are able to specify the correct SoC type between MTL-U/P and MTL-S. : : It will help to override the FSP UPD parameters properly. > Looking at the diff, that’s too broad? Maybe (for each board): […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/75607?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b1dec47ef9d12ac50317b86c4f0bc5fbe4e4dc3 Gerrit-Change-Number: 75607 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 15:30:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: allocator_v4: Treat above 4G resources more natively
by Paul Menzel (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Felix Held, Nico Huber, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75012?usp=email ) Change subject: allocator_v4: Treat above 4G resources more natively ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75012/comment/ac1e1299_0b1b0f3c : PS4, Line 45: Original-reviewed-on: https://review.coreboot.org/c/coreboot/+/65413 Sorry, the Gerrit search failed me. Maybe clarify that with a small note: > An earlier version is commit 117e43611548 (allocator_v4: Treat above 4G resources more natively), reverted by commit 38aafa329f45 due to missing top-down allocation. Either way, feel free to mark my comment as resolved. -- To view, visit https://review.coreboot.org/c/coreboot/+/75012?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia822f0ce648c7f7afc801d9cb00b6459fe7cebea Gerrit-Change-Number: 75012 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 02 Jun 2023 15:24:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/rex: Create ovis variant
by Jakub Czapiga (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Jan Dabros, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun Tuli. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75385?usp=email ) Change subject: mb/google/rex: Create ovis variant ...................................................................... Patch Set 7: (3 comments) File src/mainboard/google/rex/variants/baseboard/ovis/include/baseboard/ec.h: https://review.coreboot.org/c/coreboot/+/75385/comment/3bdcbc9e_b9fb772c : PS4, Line 66: #define EC_ENABLE_MKBP_DEVICE > Good question. Looking at brask, these are still enabled, so you are right. Done File src/mainboard/google/rex/variants/baseboard/ovis/memory.c: https://review.coreboot.org/c/coreboot/+/75385/comment/991d7c04_a2f4a9c9 : PS4, Line 16: .lpx_dq_map = { > These values are the same as on Rex. Let me double check whether these needs to be adjusted. I checked it with Intel-provided tools and also with schematics. It's the same as on Rex. File src/mainboard/google/rex/variants/baseboard/ovis/memory.c: https://review.coreboot.org/c/coreboot/+/75385/comment/348f6457_340d2259 : PS5, Line 64: 0x66 > please reconfirm this value? I checked it and it's the same as in case of Rex, so the value is correct. -- To view, visit https://review.coreboot.org/c/coreboot/+/75385?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c8f290cfdcb4d47c0e5e9d72c1e34073b957681 Gerrit-Change-Number: 75385 Gerrit-PatchSet: 7 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jan Dabros <dabros(a)google.com> Gerrit-CC: Jan Dabros <jsd(a)semihalf.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jan Dabros <dabros(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 15:15:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jan Dabros <dabros(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023