coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: drivers/usb/pci_xhci: Add xhci DID for phoenix
by Karthik Ramasubramanian (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Eric Lai, Felix Held, Jon Murphy, Matt DeVillier. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75659?usp=email ) Change subject: drivers/usb/pci_xhci: Add xhci DID for phoenix ...................................................................... Patch Set 1: (1 comment) File src/include/device/pci_ids.h: https://review.coreboot.org/c/coreboot/+/75659/comment/28063aa1_43432a5d : PS1, Line 604: PCI_DID_AMD_FAM19H_MODEL70H_XHCI1 Also how about DIDs 0x15C0 and 0x15C1 -- To view, visit https://review.coreboot.org/c/coreboot/+/75659?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib59874948725966b04b54def3f6de463afeda709 Gerrit-Change-Number: 75659 Gerrit-PatchSet: 1 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 07:13:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: drivers/usb/pci_xhci: Add xhci DID for phoenix
by Eric Lai (Code Review) 06 Jun '23

06 Jun '23

Eric Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75659?usp=email ) Change subject: drivers/usb/pci_xhci: Add xhci DID for phoenix ...................................................................... drivers/usb/pci_xhci: Add xhci DID for phoenix Add xhci DID for phoenix to get xhci SSDT. BUG=b:285981912 TEST=check coreboot log shows below. [INFO ] \_SB.PCI0.GP41.XHC0.RHUB.SS01: USB3 Type-A Port A0 (MLB) Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Change-Id: Ib59874948725966b04b54def3f6de463afeda709 --- M src/drivers/usb/pci_xhci/pci_xhci.c M src/include/device/pci_ids.h 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/75659/1 diff --git a/src/drivers/usb/pci_xhci/pci_xhci.c b/src/drivers/usb/pci_xhci/pci_xhci.c index 63a98c7..0039dc5 100644 --- a/src/drivers/usb/pci_xhci/pci_xhci.c +++ b/src/drivers/usb/pci_xhci/pci_xhci.c @@ -260,6 +260,8 @@ PCI_DID_AMD_FAM17H_MODELA0H_XHCI0, PCI_DID_AMD_FAM17H_MODELA0H_XHCI1, PCI_DID_AMD_FAM17H_MODELA0H_XHCI2, + PCI_DID_AMD_FAM19H_MODEL70H_XHCI0, + PCI_DID_AMD_FAM19H_MODEL70H_XHCI1, 0 }; diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 40df090..dc2577a 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -600,6 +600,8 @@ #define PCI_DID_AMD_FAM17H_MODELA0H_XHCI0 0x1503 #define PCI_DID_AMD_FAM17H_MODELA0H_XHCI1 0x1504 #define PCI_DID_AMD_FAM17H_MODELA0H_XHCI2 0x1505 +#define PCI_DID_AMD_FAM19H_MODEL70H_XHCI0 0x15b9 +#define PCI_DID_AMD_FAM19H_MODEL70H_XHCI1 0x15ba #define PCI_DID_AMD_FAM17H_MODEL18H_DF0 0x15E8 #define PCI_DID_AMD_FAM17H_MODEL18H_DF1 0x15E9 #define PCI_DID_AMD_FAM17H_MODEL18H_DF2 0x15EA -- To view, visit https://review.coreboot.org/c/coreboot/+/75659?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib59874948725966b04b54def3f6de463afeda709 Gerrit-Change-Number: 75659 Gerrit-PatchSet: 1 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: mb/google/nissa/var/joxer: disable PCIE RP7
by Mark Hsieh (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Felix Held, Henry Sun, Paul Fagerburg, Reka Norman, Shou-Chieh Hsu. Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75658?usp=email ) Change subject: mb/google/nissa/var/joxer: disable PCIE RP7 ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/75658?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3486d665ddb1de521ab4e656addb2209055174c7 Gerrit-Change-Number: 75658 Gerrit-PatchSet: 1 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 07:03:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: src/mainboard: Add Inventec transfomers setting
by Annie Chen (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Angel Pons, Arthur Heymans, David Hendricks, Felix Singer, Lean Sheng Tan. Annie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75598?usp=email ) Change subject: src/mainboard: Add Inventec transfomers setting ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75598/comment/69d5faa1_6d946be6 : PS1, Line 9: Modify Inventec transformers coreboot setting based on ArcherCity. > how does it differ? @Felix Singer It's the same thing, in inventec our platform name is fransfomers so we create a new folder for this. We just modify some GPIO, PCIE hardware config in it based on our schmatic. -- To view, visit https://review.coreboot.org/c/coreboot/+/75598?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9d99c3aadaa9f69e6d14d4b1a6c5157f5590684 Gerrit-Change-Number: 75598 Gerrit-PatchSet: 2 Gerrit-Owner: Annie Chen <chen.annieet(a)inventec.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Hung-Wei Chen <Chen.HW(a)inventec.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Tue, 06 Jun 2023 06:11:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: src/mainboard: Add Inventec transfomers setting
by Annie Chen (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Angel Pons, Arthur Heymans, David Hendricks, Felix Singer, Lean Sheng Tan. Hello Angel Pons, Arthur Heymans, David Hendricks, Hung-Wei Chen, Johnny Lin, Lean Sheng Tan, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75598?usp=email to look at the new patch set (#2). Change subject: src/mainboard: Add Inventec transfomers setting ...................................................................... src/mainboard: Add Inventec transfomers setting CPU: - 2 SPR sockets - 64 total PCIe 5.0 lanes with up to 64 lanes of Flex Bus/CXL per CPU - Up to 32 DDR5 DIMM - 1Gbase-T NIC port - 1 USB3.0 type A, 1 USB2.0 connector - 1 VGA connector BMC: - ASPEED AST2600 BMC - 1 DDR4 8Gb memory - 1 8GB eMMC Test: The board boots to Linux 4.19.6 with all 192 cores available. Change-Id: Ic9d99c3aadaa9f69e6d14d4b1a6c5157f5590684 Signed-off-by: Annie Chen <Chen.AnnieET(a)inventec.com> --- A configs/builder/config.transformers A src/mainboard/inventec/Kconfig A src/mainboard/inventec/Kconfig.name A src/mainboard/inventec/transformers/Kconfig A src/mainboard/inventec/transformers/Kconfig.name A src/mainboard/inventec/transformers/Makefile.inc A src/mainboard/inventec/transformers/acpi/platform.asl A src/mainboard/inventec/transformers/board.fmd A src/mainboard/inventec/transformers/board_info.txt A src/mainboard/inventec/transformers/bootblock.c A src/mainboard/inventec/transformers/devicetree.cb A src/mainboard/inventec/transformers/dsdt.asl A src/mainboard/inventec/transformers/include/mainboard_ras.h A src/mainboard/inventec/transformers/include/sprsp_ac_iio.h A src/mainboard/inventec/transformers/include/sprsp_gpio.h A src/mainboard/inventec/transformers/ipmi.c A src/mainboard/inventec/transformers/ipmi.h A src/mainboard/inventec/transformers/ramstage.c A src/mainboard/inventec/transformers/romstage.c 19 files changed, 939 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/75598/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75598?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9d99c3aadaa9f69e6d14d4b1a6c5157f5590684 Gerrit-Change-Number: 75598 Gerrit-PatchSet: 2 Gerrit-Owner: Annie Chen <chen.annieet(a)inventec.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Hung-Wei Chen <Chen.HW(a)inventec.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: libpayload/uhci: Re-write UHCI RH driver w/ generic_hub API
by Paul Menzel (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Nico Huber. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75504?usp=email ) Change subject: libpayload/uhci: Re-write UHCI RH driver w/ generic_hub API ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75504/comment/eeb7e8a6_18e3d8c1 : PS1, Line 21: > Nice. Thank you. […] I tried that on Debian sid/unstable with $ git log --oneline --no-decorate -1 14e215b241 mb/google/rex/var/rex0: probe for i2c1 touchscreen and FILO’s CLI was shown and my entered characters were shown. Do I need to do something else to make it hang? -- To view, visit https://review.coreboot.org/c/coreboot/+/75504?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5211728775eb94dfc23fa82ebf00fe5c99039709 Gerrit-Change-Number: 75504 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 06:01:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: libpayload/drivers/usb/uhci: Fix regression
by Paul Menzel (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23686?usp=email ) Change subject: libpayload/drivers/usb/uhci: Fix regression ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I believe, Nico fixed this in commit 2a976f0d072c (libpayload/uhci: Return expected length for control/bulk transfers), Change-Id: I31d7de495a46af401e2cbe5a3b8f6349facad8ff [1], so this change-set could be abandoned. [1]: https://review.coreboot.org/c/coreboot/+/75349 -- To view, visit https://review.coreboot.org/c/coreboot/+/23686?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I823521e24f6f9e04c86d36fda751c449cd884ce3 Gerrit-Change-Number: 23686 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 06 Jun 2023 05:29:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config
by Himanshu Sahdev (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Kangheui Won, Reka Norman, Tarun Tuli, Yu-Ping Wu. Himanshu Sahdev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75641?usp=email ) Change subject: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/75641?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7dda8ad59046a1dd9a28595e037eda86e91c98df Gerrit-Change-Number: 75641 Gerrit-PatchSet: 2 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 06 Jun 2023 05:24:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu/x86: Support SMBASE relocation-only use-case
by Subrata Banik (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Angel Pons, Benjamin Doron, Dinesh Gehlot, Felix Held, Fred Reitberger, Jason Glenesk, Kapil Porwal, Matt DeVillier, Maulik Vaghela, Raul Rangel, Ron Minnich, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70376?usp=email ) Change subject: cpu/x86: Support SMBASE relocation-only use-case ...................................................................... Patch Set 6: (1 comment) File src/cpu/x86/Kconfig: https://review.coreboot.org/c/coreboot/+/70376/comment/e31e2af8_33152301 : PS6, Line 139: COREBOOT we are in coreboot repo, don't know if there is any way to avoid `COREBOOT` from the Kconfig name? -- To view, visit https://review.coreboot.org/c/coreboot/+/70376?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec96bab19cdcf80622756f02a3dae49b42036c8d Gerrit-Change-Number: 70376 Gerrit-PatchSet: 6 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Maulik Vaghela <maulikvaghela(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Ron Minnich <rminnich(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Maulik Vaghela <maulikvaghela(a)google.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 05:16:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/common: Make get_ramtop_addr non static
by Subrata Banik (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Pratikkumar V Prajapati. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75624?usp=email ) Change subject: soc/intel/common: Make get_ramtop_addr non static ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75624?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ef8a65b93645f25ca5e887342b18679d65e74b4 Gerrit-Change-Number: 75624 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Tue, 06 Jun 2023 05:08:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023