coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[S] Change in coreboot[master]: soc/intel/common: Introduce configs for TME exclusion range and new k...
by Subrata Banik (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Pratikkumar V Prajapati. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75625?usp=email ) Change subject: soc/intel/common: Introduce configs for TME exclusion range and new key generation ...................................................................... Patch Set 1: (2 comments) File src/soc/intel/common/block/cpu/Kconfig: https://review.coreboot.org/c/coreboot/+/75625/comment/1e7e0b8a_76dfa24b : PS1, Line 150: Exclude CBMEM from being encrypted by Intel TME. can u please elaborate this statement? https://review.coreboot.org/c/coreboot/+/75625/comment/621b39f1_70aa75b3 : PS1, Line 157: reboot we should clarify what does reboot refers to? -- To view, visit https://review.coreboot.org/c/coreboot/+/75625?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5008fee07b97faadc7dd585f445295425173782 Gerrit-Change-Number: 75625 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Tue, 06 Jun 2023 05:05:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common: Introduce configs for TME exclusion range and new k...
by Subrata Banik (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Pratikkumar V Prajapati. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75625?usp=email ) Change subject: soc/intel/common: Introduce configs for TME exclusion range and new key generation ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: merge with the next CL -- To view, visit https://review.coreboot.org/c/coreboot/+/75625?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5008fee07b97faadc7dd585f445295425173782 Gerrit-Change-Number: 75625 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Tue, 06 Jun 2023 05:03:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: soc/intel/meteorlake: Add support for crashlog
by Subrata Banik (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Kane Chen, Kapil Porwal, Paul Menzel, Pratikkumar V Prajapati, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74769?usp=email ) Change subject: soc/intel/meteorlake: Add support for crashlog ...................................................................... Patch Set 22: (1 comment) File src/soc/intel/meteorlake/crashlog.c: https://review.coreboot.org/c/coreboot/+/74769/comment/11e7e1b6_2c8ab42d : PS22, Line 63: dev what is `dev`? -- To view, visit https://review.coreboot.org/c/coreboot/+/74769?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0abd697fba35edf1c03d2a3a325b7785b985cd5 Gerrit-Change-Number: 74769 Gerrit-PatchSet: 22 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Tue, 06 Jun 2023 04:58:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common: Use memcpy library function
by Sridhar Siricilla (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Nico Huber. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75620?usp=email ) Change subject: soc/intel/common: Use memcpy library function ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > If I found the right types, `hotfix` and `build` are swapped. You are right..binary_version and fw_version are different user defined types. struct { uint16_t major; uint16_t minor; uint16_t build; uint16_t hotfix; } binary_version; struct fw_version { uint16_t major; uint16_t minor; uint16_t hotfix; uint16_t build; } __packed -- To view, visit https://review.coreboot.org/c/coreboot/+/75620?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iff6c9a663e9e3f80cf3fb2f6d6203a95c3fea20c Gerrit-Change-Number: 75620 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 04:49:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex: add Elan HID over SPI ASL for Rex0
by Subrata Banik (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74886?usp=email ) Change subject: mb/google/rex: add Elan HID over SPI ASL for Rex0 ...................................................................... Patch Set 15: (2 comments) Patchset: PS13: > how about a Done PS13: > I guess Ovis is now added too? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74886?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I231482d56dd4afa150766c07cfde105158e5e124 Gerrit-Change-Number: 74886 Gerrit-PatchSet: 15 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Tue, 06 Jun 2023 04:46:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex: add Elan HID over SPI ASL for Rex0
by Subrata Banik (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74886?usp=email ) Change subject: mb/google/rex: add Elan HID over SPI ASL for Rex0 ...................................................................... Patch Set 15: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74886?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I231482d56dd4afa150766c07cfde105158e5e124 Gerrit-Change-Number: 74886 Gerrit-PatchSet: 15 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Tue, 06 Jun 2023 04:46:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex/var/rex0: probe for i2c1 touchscreen
by Subrata Banik (Code Review) 06 Jun '23

06 Jun '23

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75565?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/rex/var/rex0: probe for i2c1 touchscreen ...................................................................... mb/google/rex/var/rex0: probe for i2c1 touchscreen Touchscreen may either use I2C1 or SPI0. FW_CONFIG.TOUCHSCREEN is set to determine which is used. This CL adds a probe to enable I2C1. BUG=b:278783755 TEST=Tested on rex, confimed i2c1 is disabled when TOUCHSCREEN != TOUCHSCREEN_I2C Signed-off-by: Eran Mitrani <mitrani(a)google.com> Change-Id: I0bee176298fddd2aee35cf084db037a3ce7672f7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75565 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Subrata Banik <subratabanik(a)google.com> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/rex0/overridetree.cb 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Subrata Banik: Looks good to me, approved diff --git a/src/mainboard/google/rex/variants/rex0/overridetree.cb b/src/mainboard/google/rex/variants/rex0/overridetree.cb index 39a0a4d..d67794e 100644 --- a/src/mainboard/google/rex/variants/rex0/overridetree.cb +++ b/src/mainboard/google/rex/variants/rex0/overridetree.cb @@ -553,7 +553,9 @@ register "generic.stop_off_delay_ms" = "2" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" - device i2c 10 on end + device i2c 10 on + probe TOUCHSCREEN TOUCHSCREEN_I2C + end end chip drivers/generic/gpio_keys register "name" = ""PENH"" -- To view, visit https://review.coreboot.org/c/coreboot/+/75565?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0bee176298fddd2aee35cf084db037a3ce7672f7 Gerrit-Change-Number: 75565 Gerrit-PatchSet: 3 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: soc/amd/phoenix: Update USB device alias
by Eric Lai (Code Review) 06 Jun '23

06 Jun '23

Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75615?usp=email ) Change subject: soc/amd/phoenix: Update USB device alias ...................................................................... soc/amd/phoenix: Update USB device alias Follow 57263_FP8_MBDG_rev_0_92 Table.57 to update the alias. We can match the schematic for now. BUG=b:285793461 TEST=USB still works. Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Change-Id: Id1058279fe5b0e3131608a0b9bbd708dbbde7e87 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75615 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Reviewed-by: Jon Murphy <jpmurphy(a)google.com> Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> --- M src/mainboard/amd/birman/devicetree_phoenix.cb M src/mainboard/amd/mayan/devicetree_phoenix.cb M src/mainboard/google/myst/variants/baseboard/devicetree.cb M src/soc/amd/phoenix/chipset.cb 4 files changed, 44 insertions(+), 44 deletions(-) Approvals: Karthik Ramasubramanian: Looks good to me, approved Ivy Jian: Looks good to me, approved build bot (Jenkins): Verified Jon Murphy: Looks good to me, approved Felix Held: Looks good to me, approved diff --git a/src/mainboard/amd/birman/devicetree_phoenix.cb b/src/mainboard/amd/birman/devicetree_phoenix.cb index f1b88a3..6cbb36f 100644 --- a/src/mainboard/amd/birman/devicetree_phoenix.cb +++ b/src/mainboard/amd/birman/devicetree_phoenix.cb @@ -217,16 +217,10 @@ chip drivers/usb/acpi device ref xhci_0_root_hub on chip drivers/usb/acpi - device ref usb3_port0 on end + device ref usb3_port2 on end end chip drivers/usb/acpi - device ref usb3_port1 on end - end - chip drivers/usb/acpi - device ref usb2_port0 on end - end - chip drivers/usb/acpi - device ref usb2_port1 on end + device ref usb3_port3 on end end chip drivers/usb/acpi device ref usb2_port2 on end @@ -237,6 +231,12 @@ chip drivers/usb/acpi device ref usb2_port4 on end end + chip drivers/usb/acpi + device ref usb2_port5 on end + end + chip drivers/usb/acpi + device ref usb2_port6 on end + end end end end @@ -244,10 +244,10 @@ chip drivers/usb/acpi device ref xhci_1_root_hub on chip drivers/usb/acpi - device ref usb3_port5 on end + device ref usb3_port7 on end end chip drivers/usb/acpi - device ref usb2_port5 on end + device ref usb2_port7 on end end end end diff --git a/src/mainboard/amd/mayan/devicetree_phoenix.cb b/src/mainboard/amd/mayan/devicetree_phoenix.cb index 766aeef..3a6d76c 100644 --- a/src/mainboard/amd/mayan/devicetree_phoenix.cb +++ b/src/mainboard/amd/mayan/devicetree_phoenix.cb @@ -199,16 +199,10 @@ chip drivers/usb/acpi device ref xhci_0_root_hub on chip drivers/usb/acpi - device ref usb3_port0 on end + device ref usb3_port2 on end end chip drivers/usb/acpi - device ref usb3_port1 on end - end - chip drivers/usb/acpi - device ref usb2_port0 on end - end - chip drivers/usb/acpi - device ref usb2_port1 on end + device ref usb3_port3 on end end chip drivers/usb/acpi device ref usb2_port2 on end @@ -219,6 +213,12 @@ chip drivers/usb/acpi device ref usb2_port4 on end end + chip drivers/usb/acpi + device ref usb2_port5 on end + end + chip drivers/usb/acpi + device ref usb2_port6 on end + end end end end @@ -226,10 +226,10 @@ chip drivers/usb/acpi device ref xhci_1_root_hub on chip drivers/usb/acpi - device ref usb3_port5 on end + device ref usb3_port7 on end end chip drivers/usb/acpi - device ref usb2_port5 on end + device ref usb2_port7 on end end end end diff --git a/src/mainboard/google/myst/variants/baseboard/devicetree.cb b/src/mainboard/google/myst/variants/baseboard/devicetree.cb index 2b6fa89..f53f5b7 100644 --- a/src/mainboard/google/myst/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/myst/variants/baseboard/devicetree.cb @@ -246,7 +246,7 @@ register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "use_custom_pld" = "true" register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, LEFT, ACPI_PLD_GROUP(1, 1))" - device ref usb3_port0 on end + device ref usb3_port2 on end end chip drivers/usb/acpi register "desc" = ""USB3 Type-A Port A1 (DB)"" @@ -254,31 +254,31 @@ register "use_custom_pld" = "true" register "custom_pld" = "ACPI_PLD_TYPE_C(RIGHT, RIGHT, ACPI_PLD_GROUP(1, 2))" register "group" = "ACPI_PLD_GROUP(1, 2)" - device ref usb3_port1 on end + device ref usb3_port3 on end end chip drivers/usb/acpi register "desc" = ""USB2 Type-A Port A0 (MLB)"" register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "use_custom_pld" = "true" register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, LEFT, ACPI_PLD_GROUP(1, 1))" - device ref usb2_port0 on end + device ref usb2_port2 on end end chip drivers/usb/acpi register "desc" = ""USB2 Type-A Port A1 (DB)"" register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "use_custom_pld" = "true" register "custom_pld" = "ACPI_PLD_TYPE_C(RIGHT, RIGHT, ACPI_PLD_GROUP(1, 2))" - device ref usb2_port1 on end + device ref usb2_port3 on end end chip drivers/usb/acpi register "desc" = ""User-Facing Camera"" register "type" = "UPC_TYPE_INTERNAL" - device ref usb2_port2 on end + device ref usb2_port4 on end end chip drivers/usb/acpi register "desc" = ""World-Facing Camera"" register "type" = "UPC_TYPE_INTERNAL" - device ref usb2_port3 on end + device ref usb2_port5 on end end chip drivers/usb/acpi register "desc" = ""Bluetooth"" @@ -288,7 +288,7 @@ register "enable_delay_ms" = "500" register "enable_off_delay_ms" = "200" register "use_gpio_for_status" = "true" - device ref usb2_port4 on end + device ref usb2_port6 on end end end end @@ -306,14 +306,14 @@ register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "use_custom_pld" = "true" register "custom_pld" = "ACPI_PLD_TYPE_C(RIGHT, RIGHT, ACPI_PLD_GROUP(3, 1))" - device ref usb3_port6 on end + device ref usb3_port0 on end end chip drivers/usb/acpi register "desc" = ""USB4 Type-C Port C0 (MLB)"" register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "use_custom_pld" = "true" register "custom_pld" = "ACPI_PLD_TYPE_C(RIGHT, RIGHT, ACPI_PLD_GROUP(3, 1))" - device ref usb2_port6 on end + device ref usb2_port0 on end end end end @@ -327,14 +327,14 @@ register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "use_custom_pld" = "true" register "custom_pld" = "ACPI_PLD_TYPE_C(RIGHT, RIGHT, ACPI_PLD_GROUP(4, 1))" - device ref usb3_port7 on end + device ref usb3_port1 on end end chip drivers/usb/acpi register "desc" = ""USB2 Type-C Port C1 (MLB)"" register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "use_custom_pld" = "true" register "custom_pld" = "ACPI_PLD_TYPE_C(RIGHT, RIGHT, ACPI_PLD_GROUP(4, 1))" - device ref usb2_port7 on end + device ref usb2_port1 on end end end end diff --git a/src/soc/amd/phoenix/chipset.cb b/src/soc/amd/phoenix/chipset.cb index 97b7ec1..6525936 100644 --- a/src/soc/amd/phoenix/chipset.cb +++ b/src/soc/amd/phoenix/chipset.cb @@ -42,25 +42,25 @@ register "type" = "UPC_TYPE_HUB" device usb 0.0 alias xhci_0_root_hub off chip drivers/usb/acpi - device usb 3.0 alias usb3_port0 off end + device usb 3.0 alias usb3_port2 off end end chip drivers/usb/acpi - device usb 3.1 alias usb3_port1 off end + device usb 3.1 alias usb3_port3 off end end chip drivers/usb/acpi - device usb 2.0 alias usb2_port0 off end + device usb 2.0 alias usb2_port2 off end end chip drivers/usb/acpi - device usb 2.1 alias usb2_port1 off end + device usb 2.1 alias usb2_port3 off end end chip drivers/usb/acpi - device usb 2.2 alias usb2_port2 off end + device usb 2.2 alias usb2_port4 off end end chip drivers/usb/acpi - device usb 2.3 alias usb2_port3 off end + device usb 2.3 alias usb2_port5 off end end chip drivers/usb/acpi - device usb 2.4 alias usb2_port4 off end + device usb 2.4 alias usb2_port6 off end end end end @@ -70,10 +70,10 @@ register "type" = "UPC_TYPE_HUB" device usb 0.0 alias xhci_1_root_hub off chip drivers/usb/acpi - device usb 3.0 alias usb3_port5 off end + device usb 3.0 alias usb3_port7 off end end chip drivers/usb/acpi - device usb 2.0 alias usb2_port5 off end + device usb 2.0 alias usb2_port7 off end end end end @@ -96,10 +96,10 @@ register "type" = "UPC_TYPE_HUB" device usb 0.0 alias usb4_xhci_0_root_hub off chip drivers/usb/acpi - device usb 3.0 alias usb3_port6 off end + device usb 3.0 alias usb3_port0 off end end chip drivers/usb/acpi - device usb 2.0 alias usb2_port6 off end + device usb 2.0 alias usb2_port0 off end end end end @@ -109,10 +109,10 @@ register "type" = "UPC_TYPE_HUB" device usb 0.0 alias usb4_xhci_1_root_hub off chip drivers/usb/acpi - device usb 3.0 alias usb3_port7 off end + device usb 3.0 alias usb3_port1 off end end chip drivers/usb/acpi - device usb 2.0 alias usb2_port7 off end + device usb 2.0 alias usb2_port1 off end end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/75615?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1058279fe5b0e3131608a0b9bbd708dbbde7e87 Gerrit-Change-Number: 75615 Gerrit-PatchSet: 3 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: soc/amd/phoenix: Update USB device alias
by Ivy Jian (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Eric Lai, Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier. Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75615?usp=email ) Change subject: soc/amd/phoenix: Update USB device alias ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75615?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1058279fe5b0e3131608a0b9bbd708dbbde7e87 Gerrit-Change-Number: 75615 Gerrit-PatchSet: 2 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Tue, 06 Jun 2023 03:52:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/myst: Correct CROS_WP_GPIO to active high
by Ivy Jian (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Tim Van Patten. Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75628?usp=email ) Change subject: mb/google/myst: Correct CROS_WP_GPIO to active high ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75628?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54c578e5df5f1b24743cc9506e1e31b0b18bfb25 Gerrit-Change-Number: 75628 Gerrit-PatchSet: 1 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 06 Jun 2023 03:45:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023