Attention is currently required from: Arthur Heymans, Benjamin Doron, Kyösti Mälkki, Lance Zhao, Nico Huber, Tim Wawrzynczak.
Hello Benjamin Doron, Kyösti Mälkki, Lance Zhao, Lean Sheng Tan, Nico Huber, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75677?usp=email
to look at the new patch set (#3).
Change subject: acpi: Add a debug option to print out tables in ACPICA compatible hex
......................................................................
acpi: Add a debug option to print out tables in ACPICA compatible hex
Sometimes systems don't boot to the OS due to wrong ACPI tables.
Printing the tables in an ACPICA compatible format makes analysis of
ACPI tables easier.
To achieve this capture the coreboot log between "Printing ACPI in
ACPICA compatible table" and "Done printing ACPI in ACPICA compatible
table". Remove the prefix "[SPEW ] " and then call 'acpixtract -a
dump' to extract all the tables. Then use iasl on the .dat files to
decompile the tables.
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: I7b5d879014563f7a2e1f70c45cf871ba72f142dc
---
M src/Kconfig
M src/acpi/acpi.c
2 files changed, 89 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/75677/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/75677?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b5d879014563f7a2e1f70c45cf871ba72f142dc
Gerrit-Change-Number: 75677
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Benjamin Doron, Kyösti Mälkki, Lance Zhao, Nico Huber, Tim Wawrzynczak.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75677?usp=email )
Change subject: acpi: Add a debug option to print out tables in ACPICA compatible hex
......................................................................
Patch Set 2:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/75677/comment/3b8c3ba7_c09f3da9 :
PS2, Line 1854: printk(BIOS_SPEW, " %04lX:", i);
There is build error here from Jenkins:
src/acpi/acpi.c:1854:36: error: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Werror,-Wformat]
printk(BIOS_SPEW, " %04lX:", i);
~~~~~ ^
%04zX
--
To view, visit https://review.coreboot.org/c/coreboot/+/75677?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b5d879014563f7a2e1f70c45cf871ba72f142dc
Gerrit-Change-Number: 75677
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Wed, 07 Jun 2023 09:32:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Benjamin Doron, Kyösti Mälkki, Lance Zhao, Lean Sheng Tan, Nico Huber, Tim Wawrzynczak.
Hello Benjamin Doron, Kyösti Mälkki, Lance Zhao, Lean Sheng Tan, Nico Huber, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75677?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by Lean Sheng Tan
Change subject: acpi: Add a debug option to print out tables in ACPICA compatible hex
......................................................................
acpi: Add a debug option to print out tables in ACPICA compatible hex
Sometimes systems don't boot to the OS due to wrong ACPI tables.
Printing the tables in an ACPICA compatible format makes analysis of
ACPI tables easier.
To achieve this capture the coreboot log between "Printing ACPI in
ACPICA compatible table" and "Done printing ACPI in ACPICA compatible
table". Remove the prefix "[SPEW ] " and then call 'acpixtract -a
dump' to extract all the tables. Then use iasl on the .dat files to
decompile the tables.
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: I7b5d879014563f7a2e1f70c45cf871ba72f142dc
---
M src/Kconfig
M src/acpi/acpi.c
2 files changed, 89 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/75677/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75677?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b5d879014563f7a2e1f70c45cf871ba72f142dc
Gerrit-Change-Number: 75677
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: newpatchset
ChiaLing has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/75396?usp=email )
Change subject: mb/google/dedede: Support variant specific power limits
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/75396?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If38a9b7923f19885f6d47b83c92b68ef6dfa88db
Gerrit-Change-Number: 75396
Gerrit-PatchSet: 11
Gerrit-Owner: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Reka Norman <rekanorman(a)google.com>
Gerrit-CC: Super Ni <super.ni(a)intel.com>
Gerrit-CC: Super Ni <super.ni(a)intel.corp-partner.google.com>
Gerrit-MessageType: abandon
ChiaLing has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/75395?usp=email )
Change subject: soc/intel/jasperlake: Add per-SKU power limits
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/75395?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74affa6bc6ca8203459820f2530b6f20793cf857
Gerrit-Change-Number: 75395
Gerrit-PatchSet: 5
Gerrit-Owner: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Reka Norman <rekanorman(a)google.com>
Gerrit-CC: Super Ni <super.ni(a)intel.com>
Gerrit-CC: Super Ni <super.ni(a)intel.corp-partner.google.com>
Gerrit-MessageType: abandon
ChiaLing has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/75406?usp=email )
Change subject: soc/intel/common: Add PsysPl1 support
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/75406?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51907859956631d5f54ba8237d92586431fe17b7
Gerrit-Change-Number: 75406
Gerrit-PatchSet: 3
Gerrit-Owner: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Reka Norman <rekanorman(a)google.com>
Gerrit-CC: Super Ni <super.ni(a)intel.com>
Gerrit-CC: Super Ni <super.ni(a)intel.corp-partner.google.com>
Gerrit-MessageType: abandon
ChiaLing has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/75404?usp=email )
Change subject: dedede/variants/dibbi: Update power limit on Dibbi
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/75404?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3571ff850cc2ec1a1ffecf39dded004c8cf89e6
Gerrit-Change-Number: 75404
Gerrit-PatchSet: 4
Gerrit-Owner: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-CC: Reka Norman <rekanorman(a)google.com>
Gerrit-CC: Super Ni <super.ni(a)intel.com>
Gerrit-CC: Super Ni <super.ni(a)intel.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Attention is currently required from: ChiaLing.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75681?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: mb/google/dedede/var/dibbi: Update power limits
......................................................................
mb/google/dedede/var/dibbi: Update power limits
Update Dibbi power limit in ramstage
BUG=b:281479111
TEST=emerge-dedede coreboot and check psys and PLx
on DUT
Signed-off-by: Chia-Ling Hou <chia-ling.hou(a)intel.com>
Change-Id: Ieaff856b762b546f3e99acb7ba2ce15791193da6
---
M src/mainboard/google/dedede/variants/dibbi/Makefile.inc
A src/mainboard/google/dedede/variants/dibbi/ramstage.c
2 files changed, 73 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/75681/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75681?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieaff856b762b546f3e99acb7ba2ce15791193da6
Gerrit-Change-Number: 75681
Gerrit-PatchSet: 2
Gerrit-Owner: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-MessageType: newpatchset