coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XL] Change in blobs[main]: soc/amd: Add Merlin Falcon video, AGESA and PSP
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Felix Held, Richard Spiegel. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/33615?usp=email ) Change subject: soc/amd: Add Merlin Falcon video, AGESA and PSP ...................................................................... Patch Set 3: Verified+1 (1 comment) Patchset: PS3: Is this still relevant? -- To view, visit https://review.coreboot.org/c/blobs/+/33615?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: If755552702ae7b412859a2504a285fdee1e73378 Gerrit-Change-Number: 33615 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Charles Marslett <charles.marslett(a)silverbackltd.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 10 Jun 2023 04:16:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in blobs[main]: intel: update microcode: fix most of the shellsheck warning
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Alexander Couzens. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/35660?usp=email ) Change subject: intel: update microcode: fix most of the shellsheck warning ...................................................................... Patch Set 1: Code-Review+1 (1 comment) This change is ready for review. Commit Message: https://review.coreboot.org/c/blobs/+/35660/comment/4b046adc_0bcc90f4 : PS1, Line 7: intel: update microcode: fix most of the shellsheck warning shellcheck -- To view, visit https://review.coreboot.org/c/blobs/+/35660?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Iff7484695557f8d6e5f9beb0887d1c81ea1ec131 Gerrit-Change-Number: 35660 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 10 Jun 2023 04:15:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[NoOp] Change in blobs[main]: 00730F01/binaryPI: fix firmware table lookup
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/blobs/+/35969?usp=email ) Change subject: 00730F01/binaryPI: fix firmware table lookup ...................................................................... 00730F01/binaryPI: fix firmware table lookup The bug was discussed in CB:31074, referred to as "off-by-one" error. AGESA looks for ROM signature of the firmware table at 5 offsets instead of all 6 possible offsets. As a result placing the AMD firmware with amdfwtool at offset FFFA0000 will lead to the incorrect xHCI controller initialization by not loading the xHCI firmware from the firmware table. Increase the loop iterations to 6 in order to allow offset FFFA0000 to be checked for ROM signature presence. The goal is to save even more space in the SPI flash by putting the AMD firmware at the highest possible address. The bug was present in both AGESA 1.0.0.A and 1.0.0.4 used by PC Engines apu2 platforms. TEST=Set the AMD FW offset to FFFA0000, build apu2 firmware and check whether xHCI controller appears in lspci on Linux and USB 3.0 devices get enumerated properly. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I7d81998b34c24d8294c81631224d92133bb67f24 --- M mainboard/pcengines/apu2/AGESA.bin M pi/amd/00730F01/FT3b/AGESA.bin 2 files changed, 0 insertions(+), 0 deletions(-) Approvals: Stefan Reinauer: Verified; Looks good to me, approved diff --git a/mainboard/pcengines/apu2/AGESA.bin b/mainboard/pcengines/apu2/AGESA.bin index 71d8dba..12b57e8 100644 --- a/mainboard/pcengines/apu2/AGESA.bin +++ b/mainboard/pcengines/apu2/AGESA.bin Binary files differ diff --git a/pi/amd/00730F01/FT3b/AGESA.bin b/pi/amd/00730F01/FT3b/AGESA.bin index f307daa..cbae8c5 100644 --- a/pi/amd/00730F01/FT3b/AGESA.bin +++ b/pi/amd/00730F01/FT3b/AGESA.bin Binary files differ -- To view, visit https://review.coreboot.org/c/blobs/+/35969?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I7d81998b34c24d8294c81631224d92133bb67f24 Gerrit-Change-Number: 35969 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[NoOp] Change in blobs[main]: 00730F01/binaryPI: fix firmware table lookup
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Michał Żygowski. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/35969?usp=email ) Change subject: 00730F01/binaryPI: fix firmware table lookup ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://review.coreboot.org/c/blobs/+/35969?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I7d81998b34c24d8294c81631224d92133bb67f24 Gerrit-Change-Number: 35969 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Sat, 10 Jun 2023 03:59:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[NoOp] Change in blobs[main]: 00730F01/binaryPI: fix firmware table lookup
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Michał Żygowski. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/35969?usp=email ) Change subject: 00730F01/binaryPI: fix firmware table lookup ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/35969?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I7d81998b34c24d8294c81631224d92133bb67f24 Gerrit-Change-Number: 35969 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Sat, 10 Jun 2023 03:59:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in blobs[main]: cpu/intel/stm: Use URLs so a link is generated
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/blobs/+/38809?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: cpu/intel/stm: Use URLs so a link is generated ...................................................................... cpu/intel/stm: Use URLs so a link is generated Change-Id: I21b1f681a3e6def66149b74c62eb9b0c52bd7249 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M cpu/intel/stm/README.md 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Stefan Reinauer: Verified; Looks good to me, approved diff --git a/cpu/intel/stm/README.md b/cpu/intel/stm/README.md index 361fecf..ed62c19 100644 --- a/cpu/intel/stm/README.md +++ b/cpu/intel/stm/README.md @@ -39,7 +39,7 @@ SMI Transfer Monitor (STM) User Guide, August 2015 -The above document can be obtained from firmware.intel.com. +The above document can be obtained from https://firmware.intel.com. The STM-PE interface is defined in the Readme.STMPE file found on -the stmpe branch of review.coreboot.org/STM. +the stmpe branch of https://review.coreboot.org/STM. -- To view, visit https://review.coreboot.org/c/blobs/+/38809?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I21b1f681a3e6def66149b74c62eb9b0c52bd7249 Gerrit-Change-Number: 38809 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in blobs[main]: cpu/intel/stm: Use URLs so a link is generated
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Paul Menzel. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/38809?usp=email ) Change subject: cpu/intel/stm: Use URLs so a link is generated ...................................................................... Patch Set 4: Verified+1 -- To view, visit https://review.coreboot.org/c/blobs/+/38809?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I21b1f681a3e6def66149b74c62eb9b0c52bd7249 Gerrit-Change-Number: 38809 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sat, 10 Jun 2023 03:58:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in blobs[main]: cpu/intel/stm: Mark up file name as code/monospace
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/blobs/+/38808?usp=email ) Change subject: cpu/intel/stm: Mark up file name as code/monospace ...................................................................... cpu/intel/stm: Mark up file name as code/monospace Change-Id: Ib86fb06d5b1824ae445fac2ba11a6cc54974e0f0 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M cpu/intel/stm/README.md 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Stefan Reinauer: Verified; Looks good to me, approved diff --git a/cpu/intel/stm/README.md b/cpu/intel/stm/README.md index 99566d2..361fecf 100644 --- a/cpu/intel/stm/README.md +++ b/cpu/intel/stm/README.md @@ -16,8 +16,8 @@ ## Instructions: -This folder serves as the location for the stm.bin file. The developer -can use the default stm.bin provided or replace it with one that has +This folder serves as the location for the `stm.bin` file. The developer +can use the default `stm.bin` provided or replace it with one that has been custom built. The coreboot build system will look here for the STM binary when the STM has been configured. -- To view, visit https://review.coreboot.org/c/blobs/+/38808?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Ib86fb06d5b1824ae445fac2ba11a6cc54974e0f0 Gerrit-Change-Number: 38808 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in blobs[main]: cpu/intel/stm: Mark up file name as code/monospace
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Paul Menzel. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/38808?usp=email ) Change subject: cpu/intel/stm: Mark up file name as code/monospace ...................................................................... Patch Set 4: Verified+1 -- To view, visit https://review.coreboot.org/c/blobs/+/38808?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Ib86fb06d5b1824ae445fac2ba11a6cc54974e0f0 Gerrit-Change-Number: 38808 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sat, 10 Jun 2023 03:58:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in blobs[main]: cpu/intel/stm: Mark up file name as code/monospace
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Paul Menzel. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/38808?usp=email ) Change subject: cpu/intel/stm: Mark up file name as code/monospace ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/38808?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Ib86fb06d5b1824ae445fac2ba11a6cc54974e0f0 Gerrit-Change-Number: 38808 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sat, 10 Jun 2023 03:58:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023