Dinesh Gehlot has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/75688?usp=email )
Change subject: soc/intel/cmd/blk: Implement an API to get CSE version
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/75688?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I361d34589124ecf4f7cf70010ecc63d0cd8e6ddc
Gerrit-Change-Number: 75688
Gerrit-PatchSet: 1
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Attention is currently required from: Felix Held, Jason Glenesk, Matt DeVillier, Paul Menzel, ritul guru.
Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74069?usp=email )
Change subject: mb/amd/mayan: Enable the DT and M.2 SSD1 PCIE slots
......................................................................
Patch Set 16:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74069/comment/997d7400_d9120788 :
PS6, Line 7: mb/amd/mayan:Enable the DT and M.2 SSD1 PCIE slots
> It’s missing in patch set 15.
thanks Paul, addressed it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74069?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id141e5e55ef6e25722b411975a59c9764b86f624
Gerrit-Change-Number: 74069
Gerrit-PatchSet: 16
Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 10 Jun 2023 08:33:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Anand Vaikar, Felix Held, Jason Glenesk, Matt DeVillier, ritul guru.
Hello Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, build bot (Jenkins), ritul guru,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74069?usp=email
to look at the new patch set (#16).
Change subject: mb/amd/mayan: Enable the DT and M.2 SSD1 PCIE slots
......................................................................
mb/amd/mayan: Enable the DT and M.2 SSD1 PCIE slots
Follow the EC GPIO programming sequence to enable either the DT or M.2 SSD1 slot based on the config option selected during build.
Change-Id: Id141e5e55ef6e25722b411975a59c9764b86f624
Signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com>
---
M src/mainboard/amd/mayan/Kconfig
M src/mainboard/amd/mayan/devicetree_phoenix.cb
M src/mainboard/amd/mayan/ec.c
M src/mainboard/amd/mayan/port_descriptors.c
4 files changed, 57 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/74069/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/74069?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id141e5e55ef6e25722b411975a59c9764b86f624
Gerrit-Change-Number: 74069
Gerrit-PatchSet: 16
Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset