coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: Update arm-trusted-firmware submodule to upstream master
by Elyes Haouas (Code Review) 10 Jun '23

10 Jun '23

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75507?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Update arm-trusted-firmware submodule to upstream master ...................................................................... Update arm-trusted-firmware submodule to upstream master Updating from commit id 4c985e867: 2023-03-14 19:53:19 +0100 - (Merge "fix(cpus): workaround for Neoverse V1 errata 2743233" into integration) to commit id c161772f4: 2023-06-08 15:47:09 +0200 - (Merge "refactor(el3-spmc): add emad_advance()" into integration) This brings in 598 new commits. Change-Id: I412de5518c1dbde2f0ef950ff4837ab86e0a1106 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M 3rdparty/arm-trusted-firmware 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/75507/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75507?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I412de5518c1dbde2f0ef950ff4837ab86e0a1106 Gerrit-Change-Number: 75507 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[4.11_branch]: security/intel/stm/Makefile.inc: Fix typo
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55624?usp=email ) Change subject: security/intel/stm/Makefile.inc: Fix typo ...................................................................... security/intel/stm/Makefile.inc: Fix typo In both the Kconfig and Makefile in this directory, "STM_TTYS0_BASE" is used. Therefore, fix the typo. Original-Change-Id: Ie83ec31c7bb0f6805c0225ee7405e137a666a5d3 Original-Signed-off-by: Benjamin Doron <benjamin.doron00(a)gmail.com> Original-Reviewed-on: https://review.coreboot.org/c/coreboot/+/51206 Original-Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Original-Reviewed-by: Eugene Myers <cedarhouse1(a)comcast.net> Original-Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Change-Id: I8aa81a51380d48b172284e534ffd203f30a10286 Signed-off-by: Eugene Myers <edmyers(a)tycho.nsa.gov> Reviewed-on: https://review.coreboot.org/c/coreboot/+/55624 Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/security/intel/stm/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Stefan Reinauer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/security/intel/stm/Makefile.inc b/src/security/intel/stm/Makefile.inc index 3f5b9ee..d4da605 100644 --- a/src/security/intel/stm/Makefile.inc +++ b/src/security/intel/stm/Makefile.inc @@ -11,7 +11,7 @@ 3rdparty/stm/Stm/build/StmPkg/Core/stm.bin: $(obj)/config.h $(MAKE) -C src/security/intel/stm \ - CONFIG_STM_TTYSO_BASE=$(CONFIG_STM_TTYSO_BASE) \ + CONFIG_STM_TTYS0_BASE=$(CONFIG_STM_TTYS0_BASE) \ CONFIG_STM_HEAPSIZE=$(CONFIG_STM_HEAPSIZE) \ CONFIG_STM_CONSOLE_DEBUG=$(CONFIG_STM_CONSOLE_DEBUG) \ CONFIG_STM_CONSOLE_RELEASE=$(CONFIG_STM_CONSOLE_RELEASE) \ -- To view, visit https://review.coreboot.org/c/coreboot/+/55624?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.11_branch Gerrit-Change-Id: I8aa81a51380d48b172284e534ffd203f30a10286 Gerrit-Change-Number: 55624 Gerrit-PatchSet: 3 Gerrit-Owner: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: mb/amd/mayan:Enable the DT and M.2 SSD1 PCIE slots
by Paul Menzel (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Anand Vaikar, Felix Held, Jason Glenesk, Matt DeVillier, ritul guru. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74069?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/amd/mayan:Enable the DT and M.2 SSD1 PCIE slots ...................................................................... Patch Set 15: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74069/comment/700d8e37_66d2f257 : PS6, Line 7: mb/amd/mayan:Enable the DT and M.2 SSD1 PCIE slots > Done It’s missing in patch set 15. -- To view, visit https://review.coreboot.org/c/coreboot/+/74069?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id141e5e55ef6e25722b411975a59c9764b86f624 Gerrit-Change-Number: 74069 Gerrit-PatchSet: 15 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 10 Jun 2023 04:28:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/skyrim: Use CMOS bit to toggle ABL WA for Hynix DRAM
by Paul Menzel (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Felix Held, Jason Glenesk, Jason Nien, Karthik Ramasubramanian, Martin Roth, Matt DeVillier. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75698?usp=email ) Change subject: mb/google/skyrim: Use CMOS bit to toggle ABL WA for Hynix DRAM ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75698/comment/03a8c3a5_c634e8c1 : PS2, Line 18: uses already uses One *uses* should be enough. File src/mainboard/google/skyrim/bootblock.c: https://review.coreboot.org/c/coreboot/+/75698/comment/37041eec_20b0802b : PS2, Line 43: /* If problematic Hynix module, ensure bit set */ Most of the comments could be dropped, as they are redundant to the code or the same thing is set by the log messages (which I like). -- To view, visit https://review.coreboot.org/c/coreboot/+/75698?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb6e145f6cdba7270e0a322ef414bf1cb09c5eaa Gerrit-Change-Number: 75698 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 10 Jun 2023 04:25:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[NoOp] Change in blobs[main]: mb/google/skyrim/var/markarth: Add custom ABL
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Jon Murphy, Karthik Ramasubramanian, Martin Roth, Paul Menzel. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/75693?usp=email ) Change subject: mb/google/skyrim/var/markarth: Add custom ABL ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://review.coreboot.org/c/blobs/+/75693?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I3e48a16e0a46b2948260fd427b76a2ed88303996 Gerrit-Change-Number: 75693 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Sat, 10 Jun 2023 04:19:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[NoOp] Change in blobs[main]: mainboard/amd/onyx: Add APCB blobs
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Arthur Heymans. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/74588?usp=email ) Change subject: mainboard/amd/onyx: Add APCB blobs ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://review.coreboot.org/c/blobs/+/74588?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Ic55a7a9647e3c8810c8ae2648f45ef8358174961 Gerrit-Change-Number: 74588 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 10 Jun 2023 04:18:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[NoOp] Change in blobs[main]: mainboard/amd/onyx: Add APCB blobs
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Arthur Heymans. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/74588?usp=email ) Change subject: mainboard/amd/onyx: Add APCB blobs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/74588?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Ic55a7a9647e3c8810c8ae2648f45ef8358174961 Gerrit-Change-Number: 74588 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 10 Jun 2023 04:18:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in blobs[main]: mb/ocp/deltalake: Add descriptor + ME ignition binary
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Angel Pons, Arthur Heymans, Isaac W Oram, Nathaniel L Desimone, Nico Huber. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/57477?usp=email ) Change subject: mb/ocp/deltalake: Add descriptor + ME ignition binary ...................................................................... Patch Set 4: Verified+1 -- To view, visit https://review.coreboot.org/c/blobs/+/57477?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I6f0a404edebf982ee56f5fa30fb0880bdf138006 Gerrit-Change-Number: 57477 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Isaac W Oram <isaac.w.oram(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Attention: Isaac W Oram <isaac.w.oram(a)intel.com> Gerrit-Comment-Date: Sat, 10 Jun 2023 04:17:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in blobs[main]: mb/ocp/deltalake: Add descriptor + ME ignition binary
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Angel Pons, Arthur Heymans, Isaac W Oram, Nathaniel L Desimone, Nico Huber. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/57477?usp=email ) Change subject: mb/ocp/deltalake: Add descriptor + ME ignition binary ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/57477?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I6f0a404edebf982ee56f5fa30fb0880bdf138006 Gerrit-Change-Number: 57477 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Isaac W Oram <isaac.w.oram(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Attention: Isaac W Oram <isaac.w.oram(a)intel.com> Gerrit-Comment-Date: Sat, 10 Jun 2023 04:17:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in blobs[main]: soc/amd: Add Merlin Falcon video, AGESA and PSP
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Felix Held, Richard Spiegel. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/33615?usp=email ) Change subject: soc/amd: Add Merlin Falcon video, AGESA and PSP ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/33615?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: If755552702ae7b412859a2504a285fdee1e73378 Gerrit-Change-Number: 33615 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Charles Marslett <charles.marslett(a)silverbackltd.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 10 Jun 2023 04:17:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023