coreboot-gerrit May 2023

coreboot-gerrit@coreboot.org

1 participants
5262 discussions

[M] Change in coreboot[master]: mb/google/poppy/variant/nami - Move FPMCU IO setup back to ramstage
by Eric Lai (Code Review) 03 May '23

03 May '23

Attention is currently required from: Tarun Tuli. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74695 ) Change subject: mb/google/poppy/variant/nami - Move FPMCU IO setup back to ramstage ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia428ec5aec1a0438e91bc48903bda043046b740e Gerrit-Change-Number: 74695 Gerrit-PatchSet: 5 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Comment-Date: Thu, 04 May 2023 00:20:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/amdfwtool: Consolidate entry line regex pattern
by Karthik Ramasubramanian (Code Review) 03 May '23

03 May '23

Attention is currently required from: Bao Zheng, Raul Rangel, Martin Roth, Tim Van Patten, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74950 ) Change subject: util/amdfwtool: Consolidate entry line regex pattern ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > SHA is changing because the compressed bootblock (Type 0x62 entry) keeps changing before and after t […] Digging some more found that the bootblock.elf is diffing in 2 places before and after this change: 1) Head Commit ID 2) Build timestamp Before: ``` 00149ad0 30 33 20 32 31 3a 35 31 3a 30 31 20 55 54 43 20 |03 21:51:01 UTC | 00149ae0 32 30 32 33 00 00 66 90 34 2e 31 39 2d 31 34 37 |2023..f.4.19-147| 00149af0 38 2d 67 63 63 39 39 31 63 35 38 63 66 2d 64 69 |8-gcc991c58cf-di| ``` After: ``` 00149ad0 30 33 20 32 32 3a 32 34 3a 32 33 20 55 54 43 20 |03 22:24:23 UTC | 00149ae0 32 30 32 33 00 00 66 90 34 2e 31 39 2d 31 34 37 |2023..f.4.19-147| 00149af0 39 2d 67 37 37 34 37 33 36 63 33 34 34 2d 64 69 |9-g774736c344-di| 00149b00 72 74 79 00 44 65 6c 61 79 65 64 20 25 64 20 6d |rty.Delayed %d m| ``` Even when I try `BUILD_TIMELESS=1 util/abuild/abuild -t GOOGLE_GUYBRUSH`, I keep seeing the timestamp is changing. This change in timestamp and commit ID is causing changes in the compressed bootblock output and in turn amdfw.rom -- To view, visit https://review.coreboot.org/c/coreboot/+/74950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7289ddbbec4d5daefe64f59b687ba3a4af46d052 Gerrit-Change-Number: 74950 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 04 May 2023 00:03:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Increase pcie snoop/no-snoop latency
by Eric Lai (Code Review) 03 May '23

03 May '23

Attention is currently required from: Bora Guvendik, Tarun Tuli, Jérémy Compostella, Ravishankar Sarawadi, Paul Menzel, Kapil Porwal. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68308 ) Change subject: soc/intel/meteorlake: Increase pcie snoop/no-snoop latency ...................................................................... Patch Set 9: Code-Review+1 (1 comment) File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/68308/comment/c0961333_6b5726f9 PS9, Line 394: default 0x100f better add help like previous patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/68308 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dfb9edbac95d28d50653777466ea172be64f612 Gerrit-Change-Number: 68308 Gerrit-PatchSet: 9 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 03 May 2023 23:55:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/cmn/pcie: Allow SoC to overwrite snoop/no-snoop latency
by Eric Lai (Code Review) 03 May '23

03 May '23

Attention is currently required from: Bora Guvendik, Hannah Williams, Nico Huber, Subrata Banik, Jérémy Compostella, Paul Menzel. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74141 ) Change subject: soc/intel/cmn/pcie: Allow SoC to overwrite snoop/no-snoop latency ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74141 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2b9a158d219e6c6e7f6e7f0ae0f093c1183b402 Gerrit-Change-Number: 74141 Gerrit-PatchSet: 7 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 03 May 2023 23:55:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/octopus: Disable unused devices in devicetree
by Eric Lai (Code Review) 03 May '23

03 May '23

Attention is currently required from: Sean Rhodes, Matt DeVillier. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74893 ) Change subject: mb/google/octopus: Disable unused devices in devicetree ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74893 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ee99b5c45881a4cf3624bf487bc9d83fb3d07a1 Gerrit-Change-Number: 74893 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 03 May 2023 23:53:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: soc/intel/xeon_sp/spr: Add Sapphire Rapids ramstage code
by Felix Singer (Code Review) 03 May '23

03 May '23

Attention is currently required from: Jonathan Zhang. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72443 ) Change subject: soc/intel/xeon_sp/spr: Add Sapphire Rapids ramstage code ...................................................................... Patch Set 13: (1 comment) File src/soc/intel/xeon_sp/spr/cpu.c: https://review.coreboot.org/c/coreboot/+/72443/comment/6d685892_536959b8 PS13, Line 177: static const struct cpu_device_id cpu_table[] = { : {X86_VENDOR_INTEL, CPUID_SAPPHIRERAPIDS_SP_D}, : {X86_VENDOR_INTEL, CPUID_SAPPHIRERAPIDS_SP_E0}, : {X86_VENDOR_INTEL, CPUID_SAPPHIRERAPIDS_SP_E2}, : {X86_VENDOR_INTEL, CPUID_SAPPHIRERAPIDS_SP_E3}, : {X86_VENDOR_INTEL, CPUID_SAPPHIRERAPIDS_SP_E4}, : {X86_VENDOR_INTEL, CPUID_SAPPHIRERAPIDS_SP_Ex}, : {0, 0}, : }; > Good catch, thanks for helping on this Felix :) Fix got submitted. Done. -- To view, visit https://review.coreboot.org/c/coreboot/+/72443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I128fdc6e58c49fb5abf911d6ffa91e7411f6d1e2 Gerrit-Change-Number: 72443 Gerrit-PatchSet: 13 Gerrit-Owner: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Comment-Date: Wed, 03 May 2023 23:18:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/smm_stub.S: Add a retpoline around the main C handler
by Maximilian Brune (Code Review) 03 May '23

03 May '23

Attention is currently required from: Nico Huber, Martin L Roth, Subrata Banik, Patrick Rudolph, Benjamin Doron, Julius Werner, Arthur Heymans. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67735 ) Change subject: cpu/x86/smm_stub.S: Add a retpoline around the main C handler ...................................................................... Patch Set 2: (1 comment) File src/cpu/x86/smm/smm_stub.S: https://review.coreboot.org/c/coreboot/+/67735/comment/d60b2064_f324f21b PS2, Line 266: int3 is that needed? -- To view, visit https://review.coreboot.org/c/coreboot/+/67735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I93be3cd6a8c5f1ec29b3bc43195823ac49ec61c5 Gerrit-Change-Number: 67735 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 03 May 2023 23:12:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/smm_stub.S: Add a retpoline around the main C handler
by Maximilian Brune (Code Review) 03 May '23

03 May '23

Attention is currently required from: Nico Huber, Martin L Roth, Subrata Banik, Patrick Rudolph, Benjamin Doron, Julius Werner, Arthur Heymans. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67735 ) Change subject: cpu/x86/smm_stub.S: Add a retpoline around the main C handler ...................................................................... Patch Set 2: (1 comment) File src/cpu/x86/smm/smm_stub.S: https://review.coreboot.org/c/coreboot/+/67735/comment/933a08ec_f01a5bb6 PS2, Line 256: jmp 2f would it make sense to do: call call_c_handler here and leave the 1: and 2: label code out? So it would basically result in this: ``` call call_c_handler trap: pause lfence jmp trap call_c_handler: movq %rax, (%rsp) ret int3 ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/67735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I93be3cd6a8c5f1ec29b3bc43195823ac49ec61c5 Gerrit-Change-Number: 67735 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 03 May 2023 23:11:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/poppy/variant/nami - Move FPMCU IO setup back to ramstage
by Tarun Tuli (Code Review) 03 May '23

03 May '23

Attention is currently required from: Tarun Tuli. Hello build bot (Jenkins), Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74695 to look at the new patch set (#5). Change subject: mb/google/poppy/variant/nami - Move FPMCU IO setup back to ramstage ...................................................................... mb/google/poppy/variant/nami - Move FPMCU IO setup back to ramstage variant_board_sku() is missing dependences in order to work correctly in romstage. Rather than more intrusive rework as its use is limited, move the FPMCU early GPIO init back to ramstage. We still meet sufficient power off time to fully power cycle the MCU. BUG=b:245954151 TEST=Confirmed FPMCU is still functional on Nami and FP tests all pass Signed-off-by: Tarun Tuli <taruntuli(a)google.com> Change-Id: Ia428ec5aec1a0438e91bc48903bda043046b740e --- M src/mainboard/google/poppy/variants/nami/gpio.c 1 file changed, 19 insertions(+), 36 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/74695/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/74695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia428ec5aec1a0438e91bc48903bda043046b740e Gerrit-Change-Number: 74695 Gerrit-PatchSet: 5 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: util/amdfwtool: Consolidate entry line regex pattern
by Karthik Ramasubramanian (Code Review) 03 May '23

03 May '23

Attention is currently required from: Bao Zheng, Raul Rangel, Martin Roth, Tim Van Patten, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74950 ) Change subject: util/amdfwtool: Consolidate entry line regex pattern ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: > Can you verify the SHAs? SHA is changing because the compressed bootblock (Type 0x62 entry) keeps changing before and after this change. I am trying to figure out why. File util/amdfwtool/data_parse.c: https://review.coreboot.org/c/coreboot/+/74950/comment/499b10fe_561f21b9 PS1, Line 651: 3 > `OPT_LEVEL` = 4 now, meaning the index has changed. […] Nothing outside this file uses/rely on it. Again this is added for clarity. https://review.coreboot.org/c/coreboot/+/74950/comment/f2ee5154_994066bb PS1, Line 56: OPT_SPACE1, > This value is shifting `OPT_LEVEL` from `3` to `4`. It's also never used. […] If you look at the regex pattern capture group, a new group got introduced as part of consolidation. Optional level field also includes an optional whitespace separator. OPT_SPACE1 is not used, but defined for clarity. -- To view, visit https://review.coreboot.org/c/coreboot/+/74950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7289ddbbec4d5daefe64f59b687ba3a4af46d052 Gerrit-Change-Number: 74950 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 03 May 2023 22:48:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2023