coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: mainboard/intel/mtlrvp: Refactor the kconfig selections
by Jan Samek (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Harsha B R, Sridhar Siricilla, Ronak Kanabar. Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74838 ) Change subject: mainboard/intel/mtlrvp: Refactor the kconfig selections ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74838 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8557aab2848a384fba5203e5f3d62407b2566ef Gerrit-Change-Number: 74838 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 13:43:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common/block/pmc: Sort Kconfig in alphabetical order
by Felix Held (Code Review) 28 Apr '23

28 Apr '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74810 ) Change subject: soc/intel/common/block/pmc: Sort Kconfig in alphabetical order ...................................................................... soc/intel/common/block/pmc: Sort Kconfig in alphabetical order Change-Id: I7392ede4226a940896c805fc0b0bc0dd615a964c Signed-off-by: Christian Walter <christian.walter(a)9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74810 Reviewed-by: Subrata Banik <subratabanik(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/intel/common/block/pmc/Kconfig 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Subrata Banik: Looks good to me, approved diff --git a/src/soc/intel/common/block/pmc/Kconfig b/src/soc/intel/common/block/pmc/Kconfig index 181ad81..44dc2aa 100644 --- a/src/soc/intel/common/block/pmc/Kconfig +++ b/src/soc/intel/common/block/pmc/Kconfig @@ -2,9 +2,9 @@ depends on SOC_INTEL_COMMON_BLOCK_GPIO depends on ACPI_INTEL_HARDWARE_SLEEP_VALUES bool + select ACPI_S1_NOT_SUPPORTED select HAVE_POWER_STATE_AFTER_FAILURE select HAVE_POWER_STATE_PREVIOUS_AFTER_FAILURE - select ACPI_S1_NOT_SUPPORTED help Intel Processor common code for Power Management controller(PMC) subsystem -- To view, visit https://review.coreboot.org/c/coreboot/+/74810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7392ede4226a940896c805fc0b0bc0dd615a964c Gerrit-Change-Number: 74810 Gerrit-PatchSet: 2 Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: treewide: Add missing include guards to chip.h
by Felix Held (Code Review) 28 Apr '23

28 Apr '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74749 ) Change subject: treewide: Add missing include guards to chip.h ...................................................................... treewide: Add missing include guards to chip.h Some of the chip.h files in the tree are missing the include guards. This patch adds them in order to avoid potential redefinions of symbols contained in these headers, when they are included multiple times in static.c generated by sconfig. Change-Id: I550a514e72a8dd4db602e7ceffccd81aa36446e3 Signed-off-by: Jan Samek <jan.samek(a)siemens.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74749 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/cpu/intel/haswell/chip.h M src/cpu/intel/model_2065x/chip.h M src/cpu/intel/model_206ax/chip.h M src/drivers/generic/alc1015/chip.h M src/drivers/generic/bayhub/chip.h M src/drivers/generic/bayhub_lv2/chip.h M src/drivers/generic/max98357a/chip.h M src/drivers/generic/nau8315/chip.h M src/drivers/i2c/cs35l53/chip.h M src/drivers/i2c/cs42l42/chip.h M src/drivers/i2c/da7219/chip.h M src/drivers/i2c/max98373/chip.h M src/drivers/i2c/max98390/chip.h M src/drivers/i2c/max98396/chip.h M src/drivers/i2c/max98927/chip.h M src/drivers/i2c/nau8825/chip.h M src/drivers/i2c/pca9538/chip.h M src/drivers/i2c/pcf8523/chip.h M src/drivers/i2c/ptn3460/chip.h M src/drivers/i2c/rt1011/chip.h M src/drivers/i2c/rt5663/chip.h M src/drivers/i2c/rtd2132/chip.h M src/drivers/i2c/rx6110sa/chip.h M src/drivers/i2c/tas5825m/chip.h M src/drivers/i2c/tpm/chip.h M src/drivers/intel/ish/chip.h M src/drivers/net/phy/m88e1512/chip.h 27 files changed, 154 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved diff --git a/src/cpu/intel/haswell/chip.h b/src/cpu/intel/haswell/chip.h index 5f2324c..02f2f1c 100644 --- a/src/cpu/intel/haswell/chip.h +++ b/src/cpu/intel/haswell/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __CPU_INTEL_HASWELL_CHIP_H__ +#define __CPU_INTEL_HASWELL_CHIP_H__ + #include <stdbool.h> #include <stdint.h> @@ -35,3 +38,5 @@ /* Enable S0iX support */ bool s0ix_enable; }; + +#endif /* __CPU_INTEL_HASWELL_CHIP_H__ */ diff --git a/src/cpu/intel/model_2065x/chip.h b/src/cpu/intel/model_2065x/chip.h index 9e89793..90921f7 100644 --- a/src/cpu/intel/model_2065x/chip.h +++ b/src/cpu/intel/model_2065x/chip.h @@ -1,5 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __CPU_INTEL_MODEL_2065X_CHIP_H__ +#define __CPU_INTEL_MODEL_2065X_CHIP_H__ + struct cpu_intel_model_2065x_config { int tcc_offset; /* TCC Activation Offset */ }; + +#endif /* __CPU_INTEL_MODEL_2065X_CHIP_H__ */ diff --git a/src/cpu/intel/model_206ax/chip.h b/src/cpu/intel/model_206ax/chip.h index 13cf3163..57e145e 100644 --- a/src/cpu/intel/model_206ax/chip.h +++ b/src/cpu/intel/model_206ax/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __CPU_INTEL_MODEL_206AX_CHIP_H__ +#define __CPU_INTEL_MODEL_206AX_CHIP_H__ + /* Keep this in sync with acpi.c */ enum cpu_acpi_level { CPU_ACPI_DISABLED = 0, @@ -18,3 +21,5 @@ int tcc_offset; /* TCC Activation Offset */ }; + +#endif /* __CPU_INTEL_MODEL_206AX_CHIP_H__ */ diff --git a/src/drivers/generic/alc1015/chip.h b/src/drivers/generic/alc1015/chip.h index fa84177..16b0d22 100644 --- a/src/drivers/generic/alc1015/chip.h +++ b/src/drivers/generic/alc1015/chip.h @@ -1,8 +1,13 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_GENERIC_ALC1015_CHIP_H__ +#define __DRIVERS_GENERIC_ALC1015_CHIP_H__ + #include <acpi/acpi_device.h> struct drivers_generic_alc1015_config { const char *hid; /* ACPI _HID */ struct acpi_gpio sdb; /* SDMODE GPIO */ }; + +#endif /* __DRIVERS_GENERIC_ALC1015_CHIP_H__ */ diff --git a/src/drivers/generic/bayhub/chip.h b/src/drivers/generic/bayhub/chip.h index 77b7512..82fe670 100644 --- a/src/drivers/generic/bayhub/chip.h +++ b/src/drivers/generic/bayhub/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_GENERIC_BAYHUB_CHIP_H__ +#define __DRIVERS_GENERIC_BAYHUB_CHIP_H__ + #include <acpi/acpi_device.h> /* @@ -15,3 +18,5 @@ /* CLK and DAT tuning values */ uint8_t vih_tuning_value; }; + +#endif /* __DRIVERS_GENERIC_BAYHUB_CHIP_H__ */ diff --git a/src/drivers/generic/bayhub_lv2/chip.h b/src/drivers/generic/bayhub_lv2/chip.h index aa8f3fd..ea5c55f 100644 --- a/src/drivers/generic/bayhub_lv2/chip.h +++ b/src/drivers/generic/bayhub_lv2/chip.h @@ -1,8 +1,13 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_GENERIC_BAYHUB_LV2_CHIP_H__ +#define __DRIVERS_GENERIC_BAYHUB_LV2_CHIP_H__ + #include <stdbool.h> /* Bayhub LV2 PCIe to SD bridge */ struct drivers_generic_bayhub_lv2_config { bool enable_power_saving; }; + +#endif /* __DRIVERS_GENERIC_BAYHUB_LV2_CHIP_H__ */ diff --git a/src/drivers/generic/max98357a/chip.h b/src/drivers/generic/max98357a/chip.h index 66ebecf..3916b80 100644 --- a/src/drivers/generic/max98357a/chip.h +++ b/src/drivers/generic/max98357a/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_GENERIC_MAX98357A_CHIP_H__ +#define __DRIVERS_GENERIC_MAX98357A_CHIP_H__ + #include <acpi/acpi_device.h> struct drivers_generic_max98357a_config { @@ -16,3 +19,5 @@ unsigned int device_present_gpio; unsigned int device_present_gpio_invert; }; + +#endif /* __DRIVERS_GENERIC_MAX98357A_CHIP_H__ */ diff --git a/src/drivers/generic/nau8315/chip.h b/src/drivers/generic/nau8315/chip.h index 45cb412..550f11e 100644 --- a/src/drivers/generic/nau8315/chip.h +++ b/src/drivers/generic/nau8315/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_GENERIC_NAU8315_CHIP_H__ +#define __DRIVERS_GENERIC_NAU8315_CHIP_H__ + #include <acpi/acpi_device.h> struct drivers_generic_nau8315_config { @@ -12,3 +15,5 @@ /* ENABLE GPIO */ struct acpi_gpio enable_gpio; }; + +#endif /* __DRIVERS_GENERIC_NAU8315_CHIP_H__ */ diff --git a/src/drivers/i2c/cs35l53/chip.h b/src/drivers/i2c/cs35l53/chip.h index 8631666..93905c2 100644 --- a/src/drivers/i2c/cs35l53/chip.h +++ b/src/drivers/i2c/cs35l53/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_CS35L53_CHIP_H__ +#define __DRIVERS_I2C_CS35L53_CHIP_H__ + #include <acpi/acpi_device.h> #define CS35L53_MAX_GPIOS 2 @@ -153,3 +156,5 @@ */ enum cs35l53_gpio2_src gpio2_src_select; }; + +#endif /* __DRIVERS_I2C_CS35L53_CHIP_H__ */ diff --git a/src/drivers/i2c/cs42l42/chip.h b/src/drivers/i2c/cs42l42/chip.h index 1adffe7..61e0213 100644 --- a/src/drivers/i2c/cs42l42/chip.h +++ b/src/drivers/i2c/cs42l42/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_CS42L42_CHIP_H__ +#define __DRIVERS_I2C_CS42L42_CHIP_H__ + #include <acpi/acpi_device.h> enum cs42l42_ts_dbnc_rise { @@ -117,3 +120,5 @@ */ bool hs_bias_sense_disable; }; + +#endif /* __DRIVERS_I2C_CS42L42_CHIP_H__ */ diff --git a/src/drivers/i2c/da7219/chip.h b/src/drivers/i2c/da7219/chip.h index 203bd8f..5ca787c 100644 --- a/src/drivers/i2c/da7219/chip.h +++ b/src/drivers/i2c/da7219/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_DA7219_CHIP_H__ +#define __DRIVERS_I2C_DA7219_CHIP_H__ + #include <acpi/acpi_device.h> /* @@ -115,3 +118,5 @@ */ const char *mclk_name; }; + +#endif /* __DRIVERS_I2C_DA7219_CHIP_H__ */ diff --git a/src/drivers/i2c/max98373/chip.h b/src/drivers/i2c/max98373/chip.h index c184531..aea5226 100644 --- a/src/drivers/i2c/max98373/chip.h +++ b/src/drivers/i2c/max98373/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_MAX98373_CHIP_H__ +#define __DRIVERS_I2C_MAX98373_CHIP_H__ + /* * Maxim MAX98373 audio codec devicetree bindings */ @@ -22,3 +25,5 @@ /* slot number where current feedback will be received */ uint32_t imon_slot_no; }; + +#endif /* __DRIVERS_I2C_MAX98373_CHIP_H__ */ diff --git a/src/drivers/i2c/max98390/chip.h b/src/drivers/i2c/max98390/chip.h index c60b44c..6744c73 100644 --- a/src/drivers/i2c/max98390/chip.h +++ b/src/drivers/i2c/max98390/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ +#ifndef __DRIVERS_I2C_MAX98390_CHIP_H__ +#define __DRIVERS_I2C_MAX98390_CHIP_H__ + /* * MAXIM MAX98390 audio codec devicetree bindings */ @@ -19,3 +22,5 @@ /* slot number where current feedback will be received */ uint32_t imon_slot_no; }; + +#endif /* __DRIVERS_I2C_MAX98390_CHIP_H__ */ diff --git a/src/drivers/i2c/max98396/chip.h b/src/drivers/i2c/max98396/chip.h index 63a2440..7a1c118 100644 --- a/src/drivers/i2c/max98396/chip.h +++ b/src/drivers/i2c/max98396/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_MAX98396_CHIP_H__ +#define __DRIVERS_I2C_MAX98396_CHIP_H__ + /* * Maxim MAX98396 audio codec devicetree bindings */ @@ -24,3 +27,5 @@ /* Use GPIO based reset gpio */ struct acpi_gpio reset_gpio; }; + +#endif /* __DRIVERS_I2C_MAX98396_CHIP_H__ */ diff --git a/src/drivers/i2c/max98927/chip.h b/src/drivers/i2c/max98927/chip.h index fcdb9e0..9311487 100644 --- a/src/drivers/i2c/max98927/chip.h +++ b/src/drivers/i2c/max98927/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_MAX98927_CHIP_H__ +#define __DRIVERS_I2C_MAX98927_CHIP_H__ + /* * Maxim MAX98927 audio codec devicetree bindings */ @@ -19,3 +22,5 @@ /* slot number where current feedback will be received */ unsigned int imon_slot_no; }; + +#endif /* __DRIVERS_I2C_MAX98927_CHIP_H__ */ diff --git a/src/drivers/i2c/nau8825/chip.h b/src/drivers/i2c/nau8825/chip.h index ce17d3f..e47f466 100644 --- a/src/drivers/i2c/nau8825/chip.h +++ b/src/drivers/i2c/nau8825/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_NAU8825_CHIP_H__ +#define __DRIVERS_I2C_NAU8825_CHIP_H__ + #include <acpi/acpi_device.h> #define NAU8825_MAX_BUTTONS 8 @@ -102,3 +105,5 @@ */ bool adcout_ds; }; + +#endif /* __DRIVERS_I2C_NAU8825_CHIP_H__ */ diff --git a/src/drivers/i2c/pca9538/chip.h b/src/drivers/i2c/pca9538/chip.h index 96fd02f..c9254a4 100644 --- a/src/drivers/i2c/pca9538/chip.h +++ b/src/drivers/i2c/pca9538/chip.h @@ -1,7 +1,12 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_PCA9538_CHIP_H__ +#define __DRIVERS_I2C_PCA9538_CHIP_H__ + struct drivers_i2c_pca9538_config { unsigned char in_out; /* Use bit as input(1) or output (0). */ unsigned char invert; /* If a bit is 1, the input will be inverted. */ unsigned char out_val; /* Initial output value to drive. */ }; + +#endif /* __DRIVERS_I2C_PCA9538_CHIP_H__ */ diff --git a/src/drivers/i2c/pcf8523/chip.h b/src/drivers/i2c/pcf8523/chip.h index b318da3..3c32599 100644 --- a/src/drivers/i2c/pcf8523/chip.h +++ b/src/drivers/i2c/pcf8523/chip.h @@ -2,6 +2,9 @@ #include "pcf8523.h" +#ifndef __DRIVERS_I2C_PCF8523_CHIP_H__ +#define __DRIVERS_I2C_PCF8523_CHIP_H__ + struct drivers_i2c_pcf8523_config { unsigned char cap_sel; /* Internal capacitor selection */ unsigned char second_int_en; /* Enable IRQ for seconds */ @@ -29,3 +32,5 @@ unsigned char user_day; /* User day to set */ unsigned char user_weekday; /* User weekday to set */ }; + +#endif /* __DRIVERS_I2C_PCF8523_CHIP_H__ */ diff --git a/src/drivers/i2c/ptn3460/chip.h b/src/drivers/i2c/ptn3460/chip.h index 2bf7e5e..0ec26ca 100644 --- a/src/drivers/i2c/ptn3460/chip.h +++ b/src/drivers/i2c/ptn3460/chip.h @@ -1,5 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_PTN3460_CHIP_H__ +#define __DRIVERS_I2C_PTN3460_CHIP_H__ + struct drivers_i2c_ptn3460_config { }; + +#endif /* __DRIVERS_I2C_PTN3460_CHIP_H__ */ diff --git a/src/drivers/i2c/rt1011/chip.h b/src/drivers/i2c/rt1011/chip.h index 84a73dc..b4e9fc4 100644 --- a/src/drivers/i2c/rt1011/chip.h +++ b/src/drivers/i2c/rt1011/chip.h @@ -4,6 +4,9 @@ * Realtek RT1011 audio codec devicetree bindings */ +#ifndef __DRIVERS_I2C_RT1011_CHIP_H__ +#define __DRIVERS_I2C_RT1011_CHIP_H__ + struct drivers_i2c_rt1011_config { const char *name; /* ACPI Device Name */ const char *desc; /* Device Description */ @@ -14,3 +17,5 @@ /* The VPD key of temperature during speaker calibration. */ const char *temperature_calib_key; }; + +#endif /* __DRIVERS_I2C_RT1011_CHIP_H__ */ diff --git a/src/drivers/i2c/rt5663/chip.h b/src/drivers/i2c/rt5663/chip.h index 49b107c..1c177b3 100644 --- a/src/drivers/i2c/rt5663/chip.h +++ b/src/drivers/i2c/rt5663/chip.h @@ -4,6 +4,9 @@ * Realtek RT5663 audio codec devicetree bindings */ +#ifndef __DRIVERS_I2C_RT5663_CHIP_H__ +#define __DRIVERS_I2C_RT5663_CHIP_H__ + #include <acpi/acpi_device.h> #include <stdint.h> @@ -23,3 +26,5 @@ uint32_t dc_offset_l_manual_mic; uint32_t dc_offset_r_manual_mic; }; + +#endif /* __DRIVERS_I2C_RT5663_CHIP_H__ */ diff --git a/src/drivers/i2c/rtd2132/chip.h b/src/drivers/i2c/rtd2132/chip.h index 7b02248..b65182f 100644 --- a/src/drivers/i2c/rtd2132/chip.h +++ b/src/drivers/i2c/rtd2132/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_RTD2132_CHIP_H__ +#define __DRIVERS_I2C_RTD2132_CHIP_H__ + struct drivers_i2c_rtd2132_config { /* Panel Power Sequencing. All units in ms. */ u16 t1; /* Delay from panel Vcc enable to LVDS output enable. */ @@ -32,3 +35,5 @@ */ u8 sscg_percent; }; + +#endif /* __DRIVERS_I2C_RTD2132_CHIP_H__ */ diff --git a/src/drivers/i2c/rx6110sa/chip.h b/src/drivers/i2c/rx6110sa/chip.h index 1c0abe8..2b18426 100644 --- a/src/drivers/i2c/rx6110sa/chip.h +++ b/src/drivers/i2c/rx6110sa/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_RX6110SA_CHIP_H__ +#define __DRIVERS_I2C_RX6110SA_CHIP_H__ + #include "rx6110sa.h" struct drivers_i2c_rx6110sa_config { @@ -25,3 +28,5 @@ unsigned char bks_off; unsigned char iocut_en; /* Disable backup of I/O circuit. */ }; + +#endif /* __DRIVERS_I2C_RX6110SA_CHIP_H__ */ diff --git a/src/drivers/i2c/tas5825m/chip.h b/src/drivers/i2c/tas5825m/chip.h index 23af491..34f75cc 100644 --- a/src/drivers/i2c/tas5825m/chip.h +++ b/src/drivers/i2c/tas5825m/chip.h @@ -1,6 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_TAS5825M_CHIP_H__ +#define __DRIVERS_I2C_TAS5825M_CHIP_H__ + struct drivers_i2c_tas5825m_config { // Used to uniquely identify the AMP int id; }; + +#endif /* __DRIVERS_I2C_TAS5825M_CHIP_H__ */ diff --git a/src/drivers/i2c/tpm/chip.h b/src/drivers/i2c/tpm/chip.h index 4eac7e1..156f8dd 100644 --- a/src/drivers/i2c/tpm/chip.h +++ b/src/drivers/i2c/tpm/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_TPM_CHIP_H__ +#define __DRIVERS_I2C_TPM_CHIP_H__ + #include <acpi/acpi_device.h> #include <device/i2c_simple.h> @@ -18,3 +21,5 @@ struct acpi_gpio irq_gpio; /* GPIO interrupt */ enum tpm_power_managed_mode power_managed_mode; /* TPM power managed mode */ }; + +#endif /* __DRIVERS_I2C_TPM_CHIP_H__ */ diff --git a/src/drivers/intel/ish/chip.h b/src/drivers/intel/ish/chip.h index e7bb8f8..69f3253 100644 --- a/src/drivers/intel/ish/chip.h +++ b/src/drivers/intel/ish/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_INTEL_ISH_CHIP_H__ +#define __DRIVERS_INTEL_ISH_CHIP_H__ + /* * Intel Integrated Sensor Hub (ISH) */ @@ -10,3 +13,5 @@ /* Add `DmaProperty` in _DSD */ bool add_acpi_dma_property; }; + +#endif /* __DRIVERS_INTEL_ISH_CHIP_H__ */ diff --git a/src/drivers/net/phy/m88e1512/chip.h b/src/drivers/net/phy/m88e1512/chip.h index f1e313b..4af3b4d 100644 --- a/src/drivers/net/phy/m88e1512/chip.h +++ b/src/drivers/net/phy/m88e1512/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_NET_PHY_M88E1512_CHIP_H__ +#define __DRIVERS_NET_PHY_M88E1512_CHIP_H__ + #include "m88e1512.h" struct drivers_net_phy_m88e1512_config { @@ -15,3 +18,5 @@ unsigned char pmos_val; /* Set PMOS calibration value */ unsigned char nmos_val; /* Set NMOS calibration value */ }; + +#endif /* __DRIVERS_NET_PHY_M88E1512_CHIP_H__ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/74749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I550a514e72a8dd4db602e7ceffccd81aa36446e3 Gerrit-Change-Number: 74749 Gerrit-PatchSet: 5 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[L] Change in coreboot[master]: [RFC] drivers/option: Add option list in cbtable
by Nico Huber (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Benjamin Doron, Angel Pons, Maximilian Brune, Lean Sheng Tan. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 ) Change subject: [RFC] drivers/option: Add option list in cbtable ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Is this like an extension of the current option table format or a complete rewrite? -- To view, visit https://review.coreboot.org/c/coreboot/+/74121 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772 Gerrit-Change-Number: 74121 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Maslowski <info(a)orangecms.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 13:38:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/prodrive/atlas: Enable/disable sleep states based on EC
by Nico Huber (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Lance Zhao, Paul Menzel, Tim Wawrzynczak, Christian Walter, Angel Pons, Arthur Heymans, Lean Sheng Tan. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74421 ) Change subject: mb/prodrive/atlas: Enable/disable sleep states based on EC ...................................................................... Patch Set 20: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I424db7e712a705c628aa3a10a486d3313404987a Gerrit-Change-Number: 74421 Gerrit-PatchSet: 20 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 13:28:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/prodrive/atlas: Enable/disable sleep states based on EC
by Arthur Heymans (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Lance Zhao, Paul Menzel, Tim Wawrzynczak, Christian Walter, Angel Pons, Arthur Heymans, Lean Sheng Tan. Hello Lance Zhao, build bot (Jenkins), Nico Huber, Tim Wawrzynczak, Christian Walter, Angel Pons, Lean Sheng Tan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74421 to look at the new patch set (#20). Change subject: mb/prodrive/atlas: Enable/disable sleep states based on EC ...................................................................... mb/prodrive/atlas: Enable/disable sleep states based on EC With the profile ATLAS_PROF_REALTIME_PERFORMANCE it is desired to not have the option to be able to enter sleep. The reason is that Microsoft Windows goes to sleep after 30min of inactivity by default. TEST: See that Microsoft Windows 11 has no 'Sleep' option in the start menu. Change-Id: I424db7e712a705c628aa3a10a486d3313404987a Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/prodrive/atlas/mainboard.c 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/74421/20 -- To view, visit https://review.coreboot.org/c/coreboot/+/74421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I424db7e712a705c628aa3a10a486d3313404987a Gerrit-Change-Number: 74421 Gerrit-PatchSet: 20 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: acpigen: Add a runtime method to override exposed _Sx sleep states
by Jan Samek (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Lance Zhao, Paul Menzel, Tim Wawrzynczak, Maximilian Brune, Arthur Heymans, Werner Zeh. Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74762 ) Change subject: acpigen: Add a runtime method to override exposed _Sx sleep states ...................................................................... Patch Set 12: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic21830c1ef9c183b1e3005cc1f8b7daf7e9ea998 Gerrit-Change-Number: 74762 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 13:01:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/prodrive/atlas: Enable/disable sleep states based on EC
by Nico Huber (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Lance Zhao, Paul Menzel, Tim Wawrzynczak, Christian Walter, Angel Pons, Arthur Heymans, Lean Sheng Tan. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74421 ) Change subject: mb/prodrive/atlas: Enable/disable sleep states based on EC ...................................................................... Patch Set 19: Code-Review+1 (1 comment) File src/mainboard/prodrive/atlas/mainboard.c: https://review.coreboot.org/c/coreboot/+/74421/comment/bd48495f_40690890 PS19, Line 75: CONFIG(HAVE_ACPI_RESUME) ? sleep_enable : false, Same as `&&` -- To view, visit https://review.coreboot.org/c/coreboot/+/74421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I424db7e712a705c628aa3a10a486d3313404987a Gerrit-Change-Number: 74421 Gerrit-PatchSet: 19 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 13:01:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpigen: Add a runtime method to override exposed _Sx sleep states
by Jakub Czapiga (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Lance Zhao, Paul Menzel, Tim Wawrzynczak, Maximilian Brune, Arthur Heymans, Werner Zeh. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74762 ) Change subject: acpigen: Add a runtime method to override exposed _Sx sleep states ...................................................................... Patch Set 12: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic21830c1ef9c183b1e3005cc1f8b7daf7e9ea998 Gerrit-Change-Number: 74762 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 13:00:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpigen: Add a runtime method to override exposed _Sx sleep states
by Nico Huber (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Lance Zhao, Jakub Czapiga, Paul Menzel, Tim Wawrzynczak, Maximilian Brune, Arthur Heymans, Werner Zeh. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74762 ) Change subject: acpigen: Add a runtime method to override exposed _Sx sleep states ...................................................................... Patch Set 12: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic21830c1ef9c183b1e3005cc1f8b7daf7e9ea998 Gerrit-Change-Number: 74762 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 12:59:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023