coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: 3rdparty/fsp: Update pointer from 6f2f17f3d339 to cf40b9ec6c7b
by Elyes Haouas (Code Review) 07 Apr '23

07 Apr '23

Attention is currently required from: Felix Singer, Martin L Roth, Paul Menzel. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74242 ) Change subject: 3rdparty/fsp: Update pointer from 6f2f17f3d339 to cf40b9ec6c7b ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74242/comment/a2118ad8_0c10b6d5 PS1, Line 8: > Please add a summary. we have a tool to update submodules. just run "./util/scripts/update_submodules -R 3rdparty/fsp" -- To view, visit https://review.coreboot.org/c/coreboot/+/74242 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I583fc3af6eff823ef1e5ddc8bde9e042691358b6 Gerrit-Change-Number: 74242 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 07 Apr 2023 00:05:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Set max variable size to 0x8000 for SMMSTORE
by Benjamin Doron (Code Review) 07 Apr '23

07 Apr '23

Attention is currently required from: Sean Rhodes, Martin L Roth, Matt DeVillier, Stefan Reinauer, Arthur Heymans. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74176 ) Change subject: payloads/edk2: Set max variable size to 0x8000 for SMMSTORE ...................................................................... Patch Set 3: (1 comment) File payloads/external/edk2/Makefile: https://review.coreboot.org/c/coreboot/+/74176/comment/c512243c_a5f4ff62 PS3, Line 65: 8000 > just wondering. […] From memory, no. I've confirmed this with the build report too. Good catch -- To view, visit https://review.coreboot.org/c/coreboot/+/74176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10d2a5a0c1d729d83e0b62bb9430863317b883cc Gerrit-Change-Number: 74176 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 07 Apr 2023 00:04:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Documentation/releases/coreboot-4.20: Add toolchain updates section
by Elyes Haouas (Code Review) 06 Apr '23

06 Apr '23

Hello Felix Singer, build bot (Jenkins), Jason Glenesk, Martin L Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72621 to look at the new patch set (#7). Change subject: Documentation/releases/coreboot-4.20: Add toolchain updates section ...................................................................... Documentation/releases/coreboot-4.20: Add toolchain updates section Change-Id: I5fff8b97f6b85165a71aa2a86417f27986fd25fe Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Documentation/releases/coreboot-4.20-relnotes.md 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/72621/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/72621 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5fff8b97f6b85165a71aa2a86417f27986fd25fe Gerrit-Change-Number: 72621 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: Documentation/releases/coreboot-4.20: Add toolchain updates section
by Elyes Haouas (Code Review) 06 Apr '23

06 Apr '23

Elyes Haouas has restored this change. ( https://review.coreboot.org/c/coreboot/+/72621 ) Change subject: Documentation/releases/coreboot-4.20: Add toolchain updates section ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/72621 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5fff8b97f6b85165a71aa2a86417f27986fd25fe Gerrit-Change-Number: 72621 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: restore

1 0

[M] Change in coreboot[master]: sb/intel/i82371eb/chip.h: Use 'bool' instead of 'int'
by Elyes Haouas (Code Review) 06 Apr '23

06 Apr '23

Attention is currently required from: Paul Menzel, Arthur Heymans. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73794 ) Change subject: sb/intel/i82371eb/chip.h: Use 'bool' instead of 'int' ...................................................................... Patch Set 7: (2 comments) File src/southbridge/intel/i82371eb/chip.h: https://review.coreboot.org/c/coreboot/+/73794/comment/a9ab103e_f3c04ac8 PS7, Line 19: int gpo22:1; : int gpo23:1; They should be unsigned. As they are not used, let keep them as they are ... File src/southbridge/intel/i82371eb/chip.h: https://review.coreboot.org/c/coreboot/+/73794/comment/3182c4ef_1dd92d71 PS3, Line 9: unsigned int ide0_enable:1; : unsigned int ide0_drive0_udma33_enable:1; : unsigned int ide0_drive1_udma33_enable:1; : unsigned int ide1_enable:1; : unsigned int ide1_drive0_udma33_enable:1; : unsigned int ide1_drive1_udma33_enable:1; : unsigned int ide_legacy_enable:1; : unsigned int usb_enable:1; : unsigned int gpo22_enable:1; /* GPO22/GPO23 (1) vs. XDIR#/XOE# (0) */ : unsigned int gpo22:1; : unsigned int gpo23:1; > I prefer changing multiple files and using bool instead. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/73794 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36cc19bc2908119fe940941e108ee217a7b26f50 Gerrit-Change-Number: 73794 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 06 Apr 2023 23:46:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: crossgcc: Upgrade IASL from 20221020 to 20230331
by Elyes Haouas (Code Review) 06 Apr '23

06 Apr '23

Attention is currently required from: Felix Singer, Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74272 ) Change subject: crossgcc: Upgrade IASL from 20221020 to 20230331 ...................................................................... Patch Set 2: (1 comment) File util/crossgcc/buildgcc: https://review.coreboot.org/c/coreboot/+/74272/comment/d2e5da59_9471380f PS2, Line 42: R10_20_22 This is just a tag and not a release version -- To view, visit https://review.coreboot.org/c/coreboot/+/74272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43fc180bd51ff7cb06a67619c8350d28b086bc90 Gerrit-Change-Number: 74272 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Thu, 06 Apr 2023 23:42:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: crossgcc: Upgrade IASL from 20221020 to 20230331
by Elyes Haouas (Code Review) 06 Apr '23

06 Apr '23

Attention is currently required from: Felix Singer, Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74272 ) Change subject: crossgcc: Upgrade IASL from 20221020 to 20230331 ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > Let's wait with this until the release is done, so that we don't get any surprises. Done File util/crossgcc/buildgcc: https://review.coreboot.org/c/coreboot/+/74272/comment/536e3e65_ce6f7b15 PS2, Line 74: IASL_BASE_URL="https://acpica.org/sites/acpica/files" > I would like to keep using GitHub. acpica.org turned out as pretty unreliable in the past. github tag was only a workaround This point was/is discussed here: https://github.com/acpica/acpica/issues/810 I clearly prefer acpica.org where hosted the tarballs. -- To view, visit https://review.coreboot.org/c/coreboot/+/74272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43fc180bd51ff7cb06a67619c8350d28b086bc90 Gerrit-Change-Number: 74272 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Thu, 06 Apr 2023 23:39:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: Enable chromeOS EC
by build bot (Jenkins) (Code Review) 06 Apr '23

06 Apr '23

Attention is currently required from: Raul Rangel, Jon Murphy, Mark Hasemeyer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74099 ) Change subject: mb/google/myst: Enable chromeOS EC ...................................................................... Patch Set 17: (2 comments) File src/mainboard/google/myst/variants/baseboard/include/baseboard/ec.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173573): https://review.coreboot.org/c/coreboot/+/74099/comment/aa5b5917_ccc04a97 PS17, Line 71: #define SIO_EC_PS2K_IRQ Interrupt (ResourceConsumer, Level, ActiveLow, Shared) {1} space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173573): https://review.coreboot.org/c/coreboot/+/74099/comment/dc1e3af6_543ec61a PS17, Line 71: #define SIO_EC_PS2K_IRQ Interrupt (ResourceConsumer, Level, ActiveLow, Shared) {1} Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/c/coreboot/+/74099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id18a311097d575973087eb92fd446a5c511f570e Gerrit-Change-Number: 74099 Gerrit-PatchSet: 17 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Thu, 06 Apr 2023 23:38:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: Add new mainboard
by build bot (Jenkins) (Code Review) 06 Apr '23

06 Apr '23

Attention is currently required from: Raul Rangel, Martin L Roth, Jon Murphy, Martin Roth, Tim Van Patten, Felix Held, Mark Hasemeyer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74093 ) Change subject: mb/google/myst: Add new mainboard ...................................................................... Patch Set 11: (1 comment) File src/mainboard/google/myst/port_descriptors.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173567): https://review.coreboot.org/c/coreboot/+/74093/comment/b2d389ae_fedaf446 PS11, Line 7: const fsp_dxio_descriptor **dxio_descs, size_t *dxio_num, need consistent spacing around '*' (ctx:WxO) -- To view, visit https://review.coreboot.org/c/coreboot/+/74093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7d731ce4d6cb6d4e9041f46eb5a799865bb0b9a Gerrit-Change-Number: 74093 Gerrit-PatchSet: 11 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Thu, 06 Apr 2023 23:38:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/myst: Store XHCI PCI resources
by Jon Murphy (Code Review) 06 Apr '23

06 Apr '23

Jon Murphy has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74281 ) Change subject: mb/google/myst: Store XHCI PCI resources ...................................................................... mb/google/myst: Store XHCI PCI resources Implement `smm_mainboard_pci_resource_store_init` to store the resources for XHCI devices. These stored resources are later used by the elog code to log XHCI wake events. BUG=b:277273428 TEST=builds Signed-off-by: Jon Murphy <jpmurphy(a)google.com> Change-Id: I608d51f438681ac529323c23cc707845a3d609d1 --- M src/mainboard/google/myst/mainboard.c 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/74281/1 diff --git a/src/mainboard/google/myst/mainboard.c b/src/mainboard/google/myst/mainboard.c index 4ac41da..2da7068 100644 --- a/src/mainboard/google/myst/mainboard.c +++ b/src/mainboard/google/myst/mainboard.c @@ -3,8 +3,10 @@ #include <amdblocks/acpimmio.h> #include <amdblocks/amd_pci_util.h> #include <amdblocks/psp.h> +#include <amdblocks/xhci.h> #include <baseboard/variants.h> #include <console/console.h> +#include <cpu/x86/smm.h> #include <device/device.h> #include <drivers/i2c/tpm/chip.h> #include <soc/acpi.h> @@ -93,6 +95,11 @@ pm_write32(PM_ESPI_INTR_CTRL, PM_ESPI_DEV_INTR_MASK & ~(BIT(1))); } +void smm_mainboard_pci_resource_store_init(struct smm_pci_resource_info *slots, size_t size) +{ + soc_xhci_store_resources(slots, size); +} + struct chip_operations mainboard_ops = { .init = mainboard_init, .enable_dev = mainboard_enable, -- To view, visit https://review.coreboot.org/c/coreboot/+/74281 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I608d51f438681ac529323c23cc707845a3d609d1 Gerrit-Change-Number: 74281 Gerrit-PatchSet: 1 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023