coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: src/ec/purism,system76: Provide probe for fixed Librem-EC jack detect
by Jonathon Hall (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tim Crawford, Jeremy Soller. Jonathon Hall has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74390 ) Change subject: src/ec/purism,system76: Provide probe for fixed Librem-EC jack detect ...................................................................... src/ec/purism,system76: Provide probe for fixed Librem-EC jack detect Provide system76_ec_cmd() to send arbitrary commands to the EC. Provide librem_ec_has_jack_detect() to probe for the jack detect fix. Change-Id: Ic7bda0ce230a3ad68dfeb7b01a0e04f70dab9e5d Signed-off-by: Jonathon Hall <jonathon.hall(a)puri.sm> --- M src/ec/purism/librem-ec/Makefile.inc A src/ec/purism/librem-ec/librem_ec.c A src/ec/purism/librem-ec/librem_ec.h M src/ec/system76/ec/system76_ec.c A src/ec/system76/ec/system76_ec.h 5 files changed, 119 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/74390/1 diff --git a/src/ec/purism/librem-ec/Makefile.inc b/src/ec/purism/librem-ec/Makefile.inc index 5e2b2df..464371f 100644 --- a/src/ec/purism/librem-ec/Makefile.inc +++ b/src/ec/purism/librem-ec/Makefile.inc @@ -2,6 +2,7 @@ ifeq ($(CONFIG_EC_LIBREM_EC),y) all-y += ../../system76/ec/system76_ec.c +all-y += librem_ec.c smm-$(CONFIG_DEBUG_SMI) += ../../system76/ec/system76_ec.c endif diff --git a/src/ec/purism/librem-ec/librem_ec.c b/src/ec/purism/librem-ec/librem_ec.c new file mode 100644 index 0000000..8298b73 --- /dev/null +++ b/src/ec/purism/librem-ec/librem_ec.c @@ -0,0 +1,22 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include "librem_ec.h" +#include "../../system76/ec/system76_ec.h" +#include <stddef.h> + +#define CMD_PROBE 1 + +bool librem_ec_has_jack_detect(void) +{ + /* The 'flags' field in the probe command reply was added in an update. + Send 4 bytes of zeroes in the "request" to zero out the field if the + EC does not set it for its reply. */ + const uint8_t request_data[4] = {0}; + uint8_t reply_data[4] = {0}; + bool ec_cmd_success = system76_ec_cmd(CMD_PROBE, request_data, + ARRAY_SIZE(request_data), reply_data, ARRAY_SIZE(reply_data)); + if (!ec_cmd_success) + return false; + /* Byte 3 is flags, bit 0 is the jack detect flag */ + return reply_data[3] & 0x01; +} diff --git a/src/ec/purism/librem-ec/librem_ec.h b/src/ec/purism/librem-ec/librem_ec.h new file mode 100644 index 0000000..f3a6a78 --- /dev/null +++ b/src/ec/purism/librem-ec/librem_ec.h @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef LIBREM_EC_H +#define LIBREM_EC_H + +#include <stdbool.h> + +/* + * Check whether librem-ec has working jack detect. This was fixed in librem-ec + * 1.13, so we only use the verbs with jack detect if the EC has been updated. + */ +bool librem_ec_has_jack_detect(void); + +#endif diff --git a/src/ec/system76/ec/system76_ec.c b/src/ec/system76/ec/system76_ec.c index ddcb602..e649d85 100644 --- a/src/ec/system76/ec/system76_ec.c +++ b/src/ec/system76/ec/system76_ec.c @@ -1,7 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include "system76_ec.h" #include <arch/io.h> #include <console/system76_ec.h> +#include <console/console.h> #include <timer.h> // This is the command region for System76 EC firmware. It must be @@ -11,10 +13,13 @@ #define REG_CMD 0 #define REG_RESULT 1 +#define REG_DATA 2 // Start of command data // When command register is 0, command is complete #define CMD_FINISHED 0 +#define RESULT_OK 0 + // Print command. Registers are unique for each command #define CMD_PRINT 4 #define CMD_PRINT_REG_FLAGS 2 @@ -59,3 +64,49 @@ if (byte == '\n' || len >= (SYSTEM76_EC_SIZE - CMD_PRINT_REG_DATA)) system76_ec_flush(); } + +bool system76_ec_cmd(uint8_t cmd, const uint8_t *request_data, + uint8_t request_size, uint8_t *reply_data, uint8_t reply_size) +{ + if (request_size > SYSTEM76_EC_SIZE - REG_DATA || + reply_size > SYSTEM76_EC_SIZE - REG_DATA) { + printk(BIOS_ERR, "EC command %d too long - request size %d, reply size %d\n", + cmd, request_size, reply_size); + return false; + } + + /* If any data were buffered by system76_ec_print(), flush it first */ + uint8_t buffered_len = system76_ec_read(CMD_PRINT_REG_LEN); + if (buffered_len > 0) + system76_ec_flush(); + + /* Write the data */ + uint8_t i; + for (i = 0; i < request_size; ++i) + system76_ec_write(REG_DATA + i, request_data[i]); + + /* Write the command */ + system76_ec_write(REG_CMD, cmd); + + /* Wait for the command to complete */ + bool ret = true; + int elapsed = wait_ms(1000, system76_ec_read(REG_CMD) == CMD_FINISHED); + if (elapsed == 0) { + /* Timed out: fail the command, don't attempt to read a reply. */ + printk(BIOS_WARNING, "EC command %d timed out - request size %d, reply size %d\n", + cmd, request_size, reply_size); + ret = false; + } else { + /* Read the reply */ + for (i = 0; i < reply_size; ++i) + reply_data[i] = system76_ec_read(REG_DATA+i); + /* Check the reply status */ + ret = (system76_ec_read(REG_RESULT) == RESULT_OK); + } + + /* Reset the flags and length so we can buffer console prints again */ + system76_ec_write(CMD_PRINT_REG_FLAGS, 0); + system76_ec_write(CMD_PRINT_REG_LEN, 0); + + return ret; +} diff --git a/src/ec/system76/ec/system76_ec.h b/src/ec/system76/ec/system76_ec.h new file mode 100644 index 0000000..9675bd0 --- /dev/null +++ b/src/ec/system76/ec/system76_ec.h @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef SYSTEM76_EC_H +#define SYSTEM76_EC_H + +#include <stdbool.h> +#include <stdint.h> + +/* + * Send a command to the EC. request_data/request_size are the request payload, + * request_data can be NULL if request_size is 0. reply_data/reply_size are + * the reply payload, reply_data can be NULL if reply_size is 0. + */ +bool system76_ec_cmd(uint8_t cmd, const uint8_t *request_data, + uint8_t request_size, uint8_t *reply_data, uint8_t reply_size); + +#endif -- To view, visit https://review.coreboot.org/c/coreboot/+/74390 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7bda0ce230a3ad68dfeb7b01a0e04f70dab9e5d Gerrit-Change-Number: 74390 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: src/mb/purism/librem_cnl: Enable Librem 14 jack detect with fixed EC
by Jonathon Hall (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tim Crawford, Jeremy Soller, Angel Pons, Jonathon Hall, Felix Held. Hello build bot (Jenkins), Tim Crawford, Jeremy Soller, Paul Menzel, Angel Pons, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74364 to look at the new patch set (#2). Change subject: src/mb/purism/librem_cnl: Enable Librem 14 jack detect with fixed EC ...................................................................... src/mb/purism/librem_cnl: Enable Librem 14 jack detect with fixed EC Use verbs enabling jack detect if the EC firmware has been updated with fixed jack detection. Test: Build Librem 14 and boot with latest EC, test headset jack detection. Change-Id: I57a27b1d51e4f6c7c712bcb2823d21692b9c5ce6 Signed-off-by: Jonathon Hall <jonathon.hall(a)puri.sm> --- M src/mainboard/purism/librem_cnl/variants/librem_14/hda_verb.c 1 file changed, 45 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/74364/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74364 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57a27b1d51e4f6c7c712bcb2823d21692b9c5ce6 Gerrit-Change-Number: 74364 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: amdfwtool: Add --fsp-version option
by Karthik Ramasubramanian (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Paul Menzel, Grzegorz Bernacki, Arthur Heymans, Fred Reitberger, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74266 ) Change subject: amdfwtool: Add --fsp-version option ...................................................................... Patch Set 1: (1 comment) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/74266/comment/639a1b78_c8f936c0 PS1, Line 214: FSP blobs > oh, so this is mainly a misnomer. […] This is basically a misnomer. I recommend updating the command line option name as 'log-blob-version' or '-sbom'. The goal is to capture the version of PSP Bootloaders, SMU, ABL etc. that go into amdfw.rom and in turn into each FW slots of BIOS image. From that standpoint, amdfwtool seems the right place to automate capturing the blob version and putting it into a file. The choice of the option name probably makes it confusing. -- To view, visit https://review.coreboot.org/c/coreboot/+/74266 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idaa3a02ace524f44cfa656e34308bd896016dff6 Gerrit-Change-Number: 74266 Gerrit-PatchSet: 1 Gerrit-Owner: Grzegorz Bernacki Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Grzegorz Bernacki Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 12 Apr 2023 20:08:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Grzegorz Bernacki Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: vc/intel/fsp: Update JSL FSP headers from v2385.04 to v4155.00
by build bot (Jenkins) (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Saurabh Mishra, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69107 ) Change subject: vc/intel/fsp: Update JSL FSP headers from v2385.04 to v4155.00 ...................................................................... Patch Set 7: Verified-1 (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174071): https://review.coreboot.org/c/coreboot/+/69107/comment/92b94eaf_380393c5 PS7, Line 9: The headers added are generated as per FSP v4155.00. Previous headers were Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/69107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4fae89d8d7fbbcb0448222d39dd829bc3f99644 Gerrit-Change-Number: 69107 Gerrit-PatchSet: 7 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com> Gerrit-CC: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 20:08:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Add B0 stepping CPU ID
by Paul Menzel (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Kapil Porwal, Musse Abdullahi. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74300 ) Change subject: soc/intel/meteorlake: Add B0 stepping CPU ID ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Thank you for updating the commit message. If you addressed the comments/remarks, please mark those as resolved/done. -- To view, visit https://review.coreboot.org/c/coreboot/+/74300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b939ccc8b05e3648c55f8f2a0a391cb08f04184 Gerrit-Change-Number: 74300 Gerrit-PatchSet: 2 Gerrit-Owner: Musse Abdullahi <musse.abdullahi(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Musse Abdullahi <musse.abdullahi(a)intel.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 19:53:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: src/mb/purism/librem_cnl: Enable Librem 14 jack detect with fixed EC
by Paul Menzel (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tim Crawford, Jeremy Soller, Angel Pons, Jonathon Hall, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74364 ) Change subject: src/mb/purism/librem_cnl: Enable Librem 14 jack detect with fixed EC ...................................................................... Patch Set 1: (13 comments) Patchset: PS1: If possible, it’d be nice to split the mainboard change out into a separate commit. File src/ec/purism/librem-ec/librem_ec.h: https://review.coreboot.org/c/coreboot/+/74364/comment/c7c3611e_1e2919ca PS1, Line 9: update If you know the version, please mention it. https://review.coreboot.org/c/coreboot/+/74364/comment/487dec2e_8ff51d8a PS1, Line 8: /* Check whether librem-ec has working jack detect. This was fixed in an : * update, so we only use the verbs with jack detect if the EC has been updated. : */ Please use the recommended multi-line comment style. File src/ec/purism/librem-ec/librem_ec.c: https://review.coreboot.org/c/coreboot/+/74364/comment/eab5594e_65bd8bcb PS1, Line 11: /* The 'flags' field in the probe command reply was added in an update. : * Send 4 bytes of zeroes in the "request" to zero out the field if the : * EC does not set it for its reply. */ Please use the recommended multi-line comment style. https://review.coreboot.org/c/coreboot/+/74364/comment/6c02ad7a_1230d3b0 PS1, Line 17: reply_data, ARRAY_SIZE(reply_data))) : return false; Aligning both lines the same is a little confusing to me. No idea, what `indent` or `clang-format` does. File src/ec/system76/ec/system76_ec.h: https://review.coreboot.org/c/coreboot/+/74364/comment/a556f4ec_b5f787a1 PS1, Line 9: /* Send a command to the EC. request_data/request_size are the request payload, : * request_data can be NULL if request_size is 0. reply_data/reply_size are : * the reply payload, reply_data can be NULL if reply_size is 0. */ Please use the recommended multi-line comment style. File src/ec/system76/ec/system76_ec.c: https://review.coreboot.org/c/coreboot/+/74364/comment/e2c5dcfa_a19a09f6 PS1, Line 84: uint8_t i; No need to limit the length. https://notabs.org/coding/smallIntsBigPenalty.htm https://review.coreboot.org/c/coreboot/+/74364/comment/516fae9d_b059b227 PS1, Line 86: REG_DATA+i Please spaces around the operator. https://review.coreboot.org/c/coreboot/+/74364/comment/5ee087db_c0688d6f PS1, Line 96: ret = false; Log an error? File src/mainboard/purism/librem_cnl/variants/librem_14/hda_verb.c: https://review.coreboot.org/c/coreboot/+/74364/comment/239b9f21_d2cae7cc PS1, Line 64: /* Older verbs with no jack detect - needed if an older Librem EC is in use that : * lacks jack detect. Headphones can be selected manually. */ Please use the recommended multi-line comment style. https://review.coreboot.org/c/coreboot/+/74364/comment/34392bab_fcd88430 PS1, Line 74: /* Now that the codec is configured, we can check if the EC has : * jack detect. */ Please use the recommended multi-line comment style. https://review.coreboot.org/c/coreboot/+/74364/comment/f2b49096_12aabe0b PS1, Line 79: printk(BIOS_WARNING, "EC firmware lacks jack detect, applying workaround\n"); Add a comment to update the EC firmware? https://review.coreboot.org/c/coreboot/+/74364/comment/42411afd_76eb3b80 PS1, Line 80: /* The EC firmware lacks jack detect. Program the : * older workaround verbs with no jack detect. */ Please use the recommended multi-line comment style. -- To view, visit https://review.coreboot.org/c/coreboot/+/74364 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57a27b1d51e4f6c7c712bcb2823d21692b9c5ce6 Gerrit-Change-Number: 74364 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 12 Apr 2023 19:42:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/purism/librem_cnl: Provide CBFS setting for Mini auto power on
by Paul Menzel (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Angel Pons, Jonathon Hall, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74363 ) Change subject: mb/purism/librem_cnl: Provide CBFS setting for Mini auto power on ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74363/comment/468f2418_ebc1eab6 PS2, Line 9: Control Mini v1/v2 automatic power on by adding a 'board_settings' file : to CBFS. This allows us to use one build each for Mini v1/v2 that is : configured differently for different uses. By default, the EC setting is : not configured by coreboot, and the OS could configure it. : : Add ITE SuperIO configuration to device tree and configure base address : of BRAM1. (BRAM1 contains the EC firmware setting for automatic power : on.) : : Test: Build Mini v2, boot with no settings in CBFS. Add board_settings : configured for automatic power-on, flash, boot, confirm EC now powers : on automatically when power applied. > Good catch, did not realize the Gerrit web editor allows 74 chars per line, d'oh Done Patchset: PS2: > I'll split that up. […] I only found the general `Documentation/lib/option.md`. Otherwise, `cmos.layout` and `cmos.default` in the source code tree. -- To view, visit https://review.coreboot.org/c/coreboot/+/74363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0a4ea02d71f6f99e344484726a629e0552e4941 Gerrit-Change-Number: 74363 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 12 Apr 2023 19:32:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/purism/librem_cnl: Configure SuperIO for Librem Mini v1/v2
by Paul Menzel (Code Review) 12 Apr '23

12 Apr '23

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Add B0 stepping CPU ID
by Musse Abdullahi (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Paul Menzel, Kapil Porwal, Musse Abdullahi. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Paul Menzel, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74300 to look at the new patch set (#2). Change subject: soc/intel/meteorlake: Add B0 stepping CPU ID ...................................................................... soc/intel/meteorlake: Add B0 stepping CPU ID doc#723567 Signed-off-by: Musse Abdullahi <musse.abdullahi(a)intel.com> Change-Id: I8b939ccc8b05e3648c55f8f2a0a391cb08f04184 Signed-off-by: Musse Abdullahi <musse.abdullahi(a)intel.com> --- M src/include/cpu/intel/cpu_ids.h M src/soc/intel/common/block/cpu/mp_init.c M src/soc/intel/meteorlake/bootblock/report_platform.c 3 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/74300/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b939ccc8b05e3648c55f8f2a0a391cb08f04184 Gerrit-Change-Number: 74300 Gerrit-PatchSet: 2 Gerrit-Owner: Musse Abdullahi <musse.abdullahi(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Musse Abdullahi <musse.abdullahi(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: device: Correct D3Cold Kconfig option
by Michael Niewöhner (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Felix Singer, Sean Rhodes, Nico Huber, Maximilian Brune. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74328 ) Change subject: device: Correct D3Cold Kconfig option ...................................................................... Patch Set 4: (1 comment) File src/device/Kconfig: https://review.coreboot.org/c/coreboot/+/74328/comment/e818ba50_b57b38f7 PS2, Line 1007: config D3COLD_SUPPORT > Are there any specific reasons for that? At least S0IX_SUPPORT is just an ACPI "hint" that S0IX_SUPP […] Yes, Windows and Linux both respect the ACPI spec and prefer s0ix over S3 if the flag is set. However, that previous changeset (which was reverted now) had introduced a additional Kconfig (additional to the existing dt option). -- To view, visit https://review.coreboot.org/c/coreboot/+/74328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9bdb6589e98ac81d0ce25df52fb916b5c2fd0157 Gerrit-Change-Number: 74328 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 18:49:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023