Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74048 )
Change subject: mb/google/corsola: Add detachable Starmie as variant
......................................................................
Patch Set 11:
(1 comment)
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/74048/comment/49d23a5d_f21d060f
PS10, Line 143: bridge->power_on
> It seems that all bridge callbacks are required. […]
If all callbacks are required, can we check only `if (!bridge)`, and then use assertions for the callbacks?
--
To view, visit https://review.coreboot.org/c/coreboot/+/74048
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1556ad0031e9a24bf26fa84d7713b7b7928312a
Gerrit-Change-Number: 74048
Gerrit-PatchSet: 11
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 02:54:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, cong yang, Yidi Lin.
Hello Hung-Te Lin, build bot (Jenkins), Paul Menzel, Ruihai Zhou, Yu-Ping Wu, Yidi Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74341
to look at the new patch set (#5).
Change subject: soc/mediatek: Add support for regulator VIO18
......................................................................
soc/mediatek: Add support for regulator VIO18
To provide power to MIPI panel STA_HIMAX83102_J02, add support for
regulator VIO18.
BUG=b:272425116
TEST=test firmware display pass for STA_HIMAX83102_J02 on Starmie.
Change-Id: I3c3aa105e648b87fc39f881d762002f67b4422b5
Signed-off-by: Cong Yang <yangcong5(a)huaqin.corp-partner.google.com>
---
M src/soc/mediatek/common/include/soc/regulator.h
M src/soc/mediatek/mt8186/include/soc/mt6366.h
M src/soc/mediatek/mt8186/mt6366.c
3 files changed, 35 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/74341/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/74341
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c3aa105e648b87fc39f881d762002f67b4422b5
Gerrit-Change-Number: 74341
Gerrit-PatchSet: 5
Gerrit-Owner: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74048 )
Change subject: mb/google/corsola: Add detachable Starmie as variant
......................................................................
Patch Set 10:
(2 comments)
Patchset:
PS10:
> sorry, I don't know why I accidentally added too many reviewers
This is expected.
The gerrit will add Hung-Te, Yu-Ping and me to the CLs related to MTK platform from now on.
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/74048/comment/b9a64dd7_42dc9ec2
PS10, Line 143: bridge->power_on
It seems that all bridge callbacks are required. Just check them before proceeding to the display initialization.
```
if (!bridge || !bridge->power_on || !bridge->get_edid || !bridge->post_power_on)
return -1;
```
And remove the assertions in the below.
(We may need to refactor this file after adding the MIPI support.)
--
To view, visit https://review.coreboot.org/c/coreboot/+/74048
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1556ad0031e9a24bf26fa84d7713b7b7928312a
Gerrit-Change-Number: 74048
Gerrit-PatchSet: 10
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 02:35:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Yu-Ping Wu, Yidi Lin.
Hello build bot (Jenkins), Paul Menzel, cong yang, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74048
to look at the new patch set (#11).
Change subject: mb/google/corsola: Add detachable Starmie as variant
......................................................................
mb/google/corsola: Add detachable Starmie as variant
The 'Starmie' is a mt8186 detachable reference design that will share
most of Corsola design. For AP firmware, there will be a few changes,
mostly in display (MIPI interface and w/o bridge), so we create it
as a variant in Corsola.
BUG=b:275470328
BRANCH=corsola
TEST=./util/abuild/abuild -t google/corsola -b starmie -a
Change-Id: Ic1556ad0031e9a24bf26fa84d7713b7b7928312a
Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/corsola/Kconfig
M src/mainboard/google/corsola/Kconfig.name
M src/mainboard/google/corsola/display.c
3 files changed, 35 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/74048/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/74048
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1556ad0031e9a24bf26fa84d7713b7b7928312a
Gerrit-Change-Number: 74048
Gerrit-PatchSet: 11
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nick Vaccaro, Eric Lai.
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74371 )
Change subject: mb/google/hades: move PCIEXP_SUPPORT_RESIZABLE_BARS to common
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/74371
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If8618f2da3133c6b52427375c55a69d7014c4881
Gerrit-Change-Number: 74371
Gerrit-PatchSet: 2
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 01:51:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Yu-Ping Wu, Yidi Lin.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74048 )
Change subject: mb/google/corsola: Add detachable Starmie as variant
......................................................................
Patch Set 10:
(4 comments)
Patchset:
PS10:
sorry, I don't know why I accidentally added too many reviewers
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/74048/comment/ea86fd9a_7864b4ce
PS9, Line 135: const struct edp_bridge *bridge;
> `const struct edp_bridge *bridge = NULL;`
Done
https://review.coreboot.org/c/coreboot/+/74048/comment/4f7a32d2_1014a1f6
PS9, Line 143: else /* BOARD_GOOGLE_KRABBY_COMMON */
> The static assertion above is actually for this. […]
Done, but in mipi case for starmie board, there maybe another `else if` case if remove the static assertion.
https://review.coreboot.org/c/coreboot/+/74048/comment/5d2e0328_32d32154
PS9, Line 153: assert(bridge->power_on);
> Just return -1 and move to line 145. […]
Done, thank you.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74048
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1556ad0031e9a24bf26fa84d7713b7b7928312a
Gerrit-Change-Number: 74048
Gerrit-PatchSet: 10
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 01:36:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Ruihai Zhou.
Hello build bot (Jenkins), Paul Menzel, cong yang, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74048
to look at the new patch set (#10).
Change subject: mb/google/corsola: Add detachable Starmie as variant
......................................................................
mb/google/corsola: Add detachable Starmie as variant
The 'Starmie' is a mt8186 detachable reference design that will share
most of Corsola design. For AP firmware, there will be a few changes,
mostly in display (MIPI interface and w/o bridge), so we create it
as a variant in Corsola.
BUG=b:275470328
BRANCH=corsola
TEST=./util/abuild/abuild -t google/corsola -b starmie -a
Change-Id: Ic1556ad0031e9a24bf26fa84d7713b7b7928312a
Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/corsola/Kconfig
M src/mainboard/google/corsola/Kconfig.name
M src/mainboard/google/corsola/display.c
3 files changed, 35 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/74048/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/74048
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1556ad0031e9a24bf26fa84d7713b7b7928312a
Gerrit-Change-Number: 74048
Gerrit-PatchSet: 10
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Simon Chou, Paul Menzel, Tim Chu.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71969 )
Change subject: configs/builder: add default config for Intel Archer City CRB
......................................................................
Patch Set 13: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/71969
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15aefc3edb2d22fc00d854850e948fe2048a992e
Gerrit-Change-Number: 71969
Gerrit-PatchSet: 13
Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Christian Walter <christian.walter(a)9elements.com>
Gerrit-CC: Jian-Ming Wang <jianmingW(a)supermicro.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-CC: TimLiu-SMCI <timliu(a)supermicro.com.tw>
Gerrit-CC: Ziang Wang <ziang.wang(a)intel.com>
Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 00:59:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Simon Chou, Paul Menzel, Tim Chu.
Johnny Lin has uploaded a new patch set (#13) to the change originally created by Simon Chou. ( https://review.coreboot.org/c/coreboot/+/71969 )
Change subject: configs/builder: add default config for Intel Archer City CRB
......................................................................
configs/builder: add default config for Intel Archer City CRB
which is based on Intel Sapphire Rapids Scalable Processor chipset
which was product launched on Jan. 10 2023.
The site-local/* files are Intel binaries that are not published yet
but coreboot build validation system would skip these binaries when
they are in "site-local" directory.
Please make sure you have the correct Intel binaries for your AC CRB
and place them to the right location accordingly.
CONFIG_PAYLOAD_FILE="site-local/archercity/linuxboot_bzImage" is
LinuxBoot payload, there are several ways to build it, one way is to
build it from the x86_64 qemu example from osf-builder:
git clone https://github.com/linuxboot/osf-builder
cd examples/qemu; make kernel
commit ae90fc0bb (soc/intel/xeon_sp/spr: Default to X2APIC support)
would enable DEFAULT_X2APIC_RUNTIME, your LinuxBoot kernel needs to
enable X2APIC support, otherwise need to set CONFIG_XAPIC_ONLY=y in
your defconfig.
Change-Id: I15aefc3edb2d22fc00d854850e948fe2048a992e
Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com>
---
A configs/builder/config.intel.crb.ac
1 file changed, 53 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/71969/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/71969
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15aefc3edb2d22fc00d854850e948fe2048a992e
Gerrit-Change-Number: 71969
Gerrit-PatchSet: 13
Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Christian Walter <christian.walter(a)9elements.com>
Gerrit-CC: Jian-Ming Wang <jianmingW(a)supermicro.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-CC: TimLiu-SMCI <timliu(a)supermicro.com.tw>
Gerrit-CC: Ziang Wang <ziang.wang(a)intel.com>
Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Simon Chou, Paul Menzel, Tim Chu.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71969 )
Change subject: configs/builder: add default config for Intel Archer City CRB
......................................................................
Patch Set 12: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/71969
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15aefc3edb2d22fc00d854850e948fe2048a992e
Gerrit-Change-Number: 71969
Gerrit-PatchSet: 12
Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Christian Walter <christian.walter(a)9elements.com>
Gerrit-CC: Jian-Ming Wang <jianmingW(a)supermicro.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-CC: TimLiu-SMCI <timliu(a)supermicro.com.tw>
Gerrit-CC: Ziang Wang <ziang.wang(a)intel.com>
Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 00:52:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment