coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: cpu/x86/Kconfig: Disable choice X2APIC_ONLY
by Patrick Rudolph (Code Review) 18 Apr '23

18 Apr '23

Patrick Rudolph has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/74484 ) Change subject: cpu/x86/Kconfig: Disable choice X2APIC_ONLY ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/74484 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74831efa25c01a44c4994fe8f35131c6e67ba67b Gerrit-Change-Number: 74484 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: SMBIOS: Move identification strings
by Kyösti Mälkki (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Sean Rhodes, Jason Nien, Patrick Rudolph, Caveh Jalali, Christian Walter, Martin Roth, Boris Mittelberg. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74452 ) Change subject: SMBIOS: Move identification strings ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74452/comment/d0f28a6c_e6e213c9 PS3, Line 9: This improve ccache hit rate > is there a better argument to be made for moving […] The motivation was to split these strings away from build/config.h to build/board_id.h, which will only be an input for lib/identity.c. I am still experimenting with ccache to see if I am able to transform hits from "preprocessor hit" to "direct hit", latter is typically much faster and may result with smaller memory footprint. I have not inspected the binaries that closely yet to check if constant Kconfig strings currently appear twice expanded in the binaries. Output of "objdump -r -d" may actually appear nicer since the references are to symbolic names found in source. -- To view, visit https://review.coreboot.org/c/coreboot/+/74452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28a8199b4a5482984dd7fdde67e90acca5af5ca6 Gerrit-Change-Number: 74452 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Tue, 18 Apr 2023 07:54:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Caveh Jalali <caveh(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: configs/config.amd_mayan: Add defconfig file for Mayan board
by Anand Vaikar (Code Review) 18 Apr '23

18 Apr '23

Anand Vaikar has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/74057 ) Change subject: configs/config.amd_mayan: Add defconfig file for Mayan board ...................................................................... Abandoned Abandoning this PR, as we will share the config file to customer directly. -- To view, visit https://review.coreboot.org/c/coreboot/+/74057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibddd49a6611e95c2c986c4de1d7052e70622ad32 Gerrit-Change-Number: 74057 Gerrit-PatchSet: 4 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: cpu/x86/Kconfig: Disable choice X2APIC_ONLY
by Kyösti Mälkki (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Patrick Rudolph, Wonkyu Kim, Arthur Heymans. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74484 ) Change subject: cpu/x86/Kconfig: Disable choice X2APIC_ONLY ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74484/comment/f7bb2e81_eb1959d1 PS1, Line 10: accesses X2APIC registers itself before enabling X2APIC mode. Did you bisect which commit changed this? We have both initial_lapicid() from CPUID and lapicid() from LAPIC. Might be a matter of simply changing one of those instances to keep supporting X2APIC_ONLY. https://review.coreboot.org/c/coreboot/+/74484/comment/d8052870_a1ba2eda PS1, Line 17: using the LAPIC API before MPinit causes a crash. One should not have placed any LAPIC register accesses prior to enable_lapic() in the first place? One should not assume LAPIC is enabled at default address on reset, so in theory XAPIC register access is equally done too early. File src/cpu/x86/Kconfig: https://review.coreboot.org/c/coreboot/+/74484/comment/48da2119_34827dfb PS1, Line 55: are supported. With this option, if CPU has X2APIC support, OS may make the switch. This again means, one cannot make lapicid() call inside SMM, as LAPIC MMIO access is then disabled. So if we are not willing to keep track of proper call-sites for LAPIC register accesses, XAPIC_ONLY should only be the default for platforms with no X2APIC support in silicon. -- To view, visit https://review.coreboot.org/c/coreboot/+/74484 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74831efa25c01a44c4994fe8f35131c6e67ba67b Gerrit-Change-Number: 74484 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 18 Apr 2023 07:45:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util: Use common ARRAY_SIZE define
by Konrad Adamczyk (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Konrad Adamczyk, Jakub Czapiga, Grzegorz Bernacki. Konrad Adamczyk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74474 ) Change subject: util: Use common ARRAY_SIZE define ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/74474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29b776586b4f0548d4026b2ac77095791fc9f3a3 Gerrit-Change-Number: 74474 Gerrit-PatchSet: 2 Gerrit-Owner: Konrad Adamczyk <konrada(a)google.com> Gerrit-Reviewer: Grzegorz Bernacki Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Konrad Adamczyk <konrada(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Grzegorz Bernacki Gerrit-Comment-Date: Tue, 18 Apr 2023 07:35:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/kukui: Add sdram configs for RAM code 0x33 and 0x34
by Sheng-Liang Pan (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Hung-Te Lin, Chen-Tsung Hsieh, Lucas Chen, Yidi Lin. Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73469 ) Change subject: mb/google/kukui: Add sdram configs for RAM code 0x33 and 0x34 ...................................................................... Patch Set 7: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/73469/comment/1018ae7d_5a1f7068 PS6, Line 10: > Line break here. Done https://review.coreboot.org/c/coreboot/+/73469/comment/1ed76897_0c6b4d84 PS6, Line 11: > Line break here. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/73469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5b484b5324ba39dbb220f12bdb8344ecb5c4da5 Gerrit-Change-Number: 73469 Gerrit-PatchSet: 7 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Attention: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 18 Apr 2023 07:32:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/kukui: Add sdram configs for RAM code 0x33 and 0x34
by Sheng-Liang Pan (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Hung-Te Lin, Chen-Tsung Hsieh, Lucas Chen, Sheng-Liang Pan, Yidi Lin. Hello Hung-Te Lin, build bot (Jenkins), Chen-Tsung Hsieh, Lucas Chen, Yu-Ping Wu, Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73469 to look at the new patch set (#7). Change subject: mb/google/kukui: Add sdram configs for RAM code 0x33 and 0x34 ...................................................................... mb/google/kukui: Add sdram configs for RAM code 0x33 and 0x34 Add sdram configs: - RAM code 0x33: sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB SPD for K4UBE3D4AB-MGCL 4GB - RAM code 0x34: sdram-lpddr4x-H9HCNNNFAMMLXR-NEE-8GB for H54G68CYRBX248 8GB BUG=b:278644249 BRANCH=kukui TEST=emerge-jacuzzi coreboot Signed-off-by: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Change-Id: If5b484b5324ba39dbb220f12bdb8344ecb5c4da5 --- M src/mainboard/google/kukui/sdram_configs.c 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/73469/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/73469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5b484b5324ba39dbb220f12bdb8344ecb5c4da5 Gerrit-Change-Number: 73469 Gerrit-PatchSet: 7 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Attention: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/kukui: Add sdram configs for RAM code 0x33 and 0x34
by Yu-Ping Wu (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Hung-Te Lin, Chen-Tsung Hsieh, Lucas Chen, Sheng-Liang Pan, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73469 ) Change subject: mb/google/kukui: Add sdram configs for RAM code 0x33 and 0x34 ...................................................................... Patch Set 6: Code-Review+2 (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/73469/comment/fd156543_3ee3d5dc PS5, Line 7: Samsung K3UBE3D4AB-MGCL 4GB and : Hynix H54G68CYRBX248 8GB support for Pico > thanks, done. Ack https://review.coreboot.org/c/coreboot/+/73469/comment/e669655b_c1c58714 PS5, Line 10: Add new RAM ID 0x33 and 0x34 for new memory support : leverage sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB SPD for K4UBE3D4AB-MGCL 4GB : and sdram-lpddr4x-H9HCNNNFAMMLXR-NEE-8GB for H54G68CYRBX248 8GB > thanks, done. Ack Commit Message: https://review.coreboot.org/c/coreboot/+/73469/comment/69df7777_435839ba PS6, Line 10: Line break here. https://review.coreboot.org/c/coreboot/+/73469/comment/b8e1c226_9b537db7 PS6, Line 11: Line break here. -- To view, visit https://review.coreboot.org/c/coreboot/+/73469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5b484b5324ba39dbb220f12bdb8344ecb5c4da5 Gerrit-Change-Number: 73469 Gerrit-PatchSet: 6 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Attention: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 18 Apr 2023 07:28:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/kukui: Add sdram configs for RAM code 0x33 and 0x34
by Sheng-Liang Pan (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Hung-Te Lin, Chen-Tsung Hsieh, Lucas Chen, Yu-Ping Wu, Yidi Lin. Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73469 ) Change subject: mb/google/kukui: Add sdram configs for RAM code 0x33 and 0x34 ...................................................................... Patch Set 6: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/73469/comment/717ff478_8657f9ce PS5, Line 7: Samsung K3UBE3D4AB-MGCL 4GB and : Hynix H54G68CYRBX248 8GB support for Pico > sdram configs for RAM code 0x33 and 0x34 thanks, done. https://review.coreboot.org/c/coreboot/+/73469/comment/6e376dfd_2a9641c3 PS5, Line 10: Add new RAM ID 0x33 and 0x34 for new memory support : leverage sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB SPD for K4UBE3D4AB-MGCL 4GB : and sdram-lpddr4x-H9HCNNNFAMMLXR-NEE-8GB for H54G68CYRBX248 8GB > ``` […] thanks, done. -- To view, visit https://review.coreboot.org/c/coreboot/+/73469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5b484b5324ba39dbb220f12bdb8344ecb5c4da5 Gerrit-Change-Number: 73469 Gerrit-PatchSet: 6 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Attention: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 18 Apr 2023 07:26:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/kukui: Add sdram configs for RAM code 0x33 and 0x34
by Sheng-Liang Pan (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Hung-Te Lin, Chen-Tsung Hsieh, Lucas Chen, Sheng-Liang Pan, Yidi Lin. Hello Hung-Te Lin, build bot (Jenkins), Chen-Tsung Hsieh, Lucas Chen, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73469 to look at the new patch set (#6). Change subject: mb/google/kukui: Add sdram configs for RAM code 0x33 and 0x34 ...................................................................... mb/google/kukui: Add sdram configs for RAM code 0x33 and 0x34 Add sdram configs: - RAM code 0x33: sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB SPD for K4UBE3D4AB-MGCL 4GB - RAM code 0x34: sdram-lpddr4x-H9HCNNNFAMMLXR-NEE-8GB for H54G68CYRBX248 8GB BUG=b:278644249 BRANCH=kukui TEST=emerge-jacuzzi coreboot Signed-off-by: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Change-Id: If5b484b5324ba39dbb220f12bdb8344ecb5c4da5 --- M src/mainboard/google/kukui/sdram_configs.c 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/73469/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/73469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5b484b5324ba39dbb220f12bdb8344ecb5c4da5 Gerrit-Change-Number: 73469 Gerrit-PatchSet: 6 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Attention: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023