coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[L] Change in coreboot[master]: [RFC] drivers/option: Add option list in cbtable
by Benjamin Doron (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Angel Pons, Maximilian Brune. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 ) Change subject: [RFC] drivers/option: Add option list in cbtable ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: v1 implemented as https://github.com/9elements/edk2/commit/c7f26c86130d21f3eb30fbd70cdc9aedb8… (factors into previous 9elements work with patches into 9elements-specific code) and https://github.com/benjamindoron/edk2/commit/f23c3551aaa430abae3a76156b748e… (copied base implementation) -- To view, visit https://review.coreboot.org/c/coreboot/+/74121 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772 Gerrit-Change-Number: 74121 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Maslowski <info(a)orangecms.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Fri, 21 Apr 2023 14:08:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: buildgcc: work around bug in --print-librt-file-name
by Elyes Haouas (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Stefan Reinauer. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/10815 ) Change subject: buildgcc: work around bug in --print-librt-file-name ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/10815/comment/448f5112_c6a39dd5 PS2, Line 9: --print-librt-file-name it gives this error: "clang: error: unsupported option '--print-librt-file-name'" -- To view, visit https://review.coreboot.org/c/coreboot/+/10815 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21ef5c4a690d83c326717ca55c5ace558257a0ec Gerrit-Change-Number: 10815 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Apr 2023 14:02:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: Enable AP <-> GSC communication
by Felix Held (Code Review) 21 Apr '23

21 Apr '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74111 ) ( 34 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/myst: Enable AP <-> GSC communication ...................................................................... mb/google/myst: Enable AP <-> GSC communication Configure GSC I2C and Interrupt GPIOs during the early initialization. Add devicetree configuration for GSC device and enable the required config items. BUG=b:275959717 TEST=builds Change-Id: I6e235356b252a7b68a42da128ffd3189a829f117 Signed-off-by: Jon Murphy <jpmurphy(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74111 Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/myst/Kconfig M src/mainboard/google/myst/bootblock.c M src/mainboard/google/myst/mainboard.c M src/mainboard/google/myst/variants/baseboard/devicetree.cb M src/mainboard/google/myst/variants/baseboard/gpio.c M src/mainboard/google/myst/variants/baseboard/include/baseboard/variants.h 6 files changed, 68 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/myst/Kconfig b/src/mainboard/google/myst/Kconfig index 8739506..76061fe 100644 --- a/src/mainboard/google/myst/Kconfig +++ b/src/mainboard/google/myst/Kconfig @@ -18,13 +18,24 @@ select ELOG_GSMI select FW_CONFIG select FW_CONFIG_SOURCE_CHROMEEC_CBI + select I2C_TPM select MAINBOARD_HAS_CHROMEOS + select MAINBOARD_HAS_TPM2 select SOC_AMD_COMMON_BLOCK_USE_ESPI select SOC_AMD_PHOENIX + select TPM_GOOGLE_TI50 config DEVICETREE default "variants/baseboard/devicetree.cb" +config DRIVER_TPM_I2C_BUS + hex + default 0x02 + +config DRIVER_TPM_I2C_ADDR + hex + default 0x50 + config FMDFILE default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/chromeos.fmd" @@ -52,4 +63,9 @@ select VBOOT_SEPARATE_VERSTAGE select VBOOT_STARTS_IN_BOOTBLOCK +# TODO(b/277087492): Enable GSC CBFS verification +config VBOOT_GSCVD + bool + default n + endif # BOARD_GOOGLE_BASEBOARD_MYST diff --git a/src/mainboard/google/myst/bootblock.c b/src/mainboard/google/myst/bootblock.c index 4d4d7e7..e9d69e3 100644 --- a/src/mainboard/google/myst/bootblock.c +++ b/src/mainboard/google/myst/bootblock.c @@ -18,7 +18,11 @@ void bootblock_mainboard_early_init(void) { - /* TODO(b/275959717): Perform mainboard initialization */ + size_t num_gpios; + const struct soc_amd_gpio *gpios; + + variant_tpm_gpio_table(&gpios, &num_gpios); + gpio_configure_pads(gpios, num_gpios); } void bootblock_mainboard_init(void) diff --git a/src/mainboard/google/myst/mainboard.c b/src/mainboard/google/myst/mainboard.c index 3a25e8c..44e8f67 100644 --- a/src/mainboard/google/myst/mainboard.c +++ b/src/mainboard/google/myst/mainboard.c @@ -5,6 +5,7 @@ #include <baseboard/variants.h> #include <console/console.h> #include <device/device.h> +#include <drivers/i2c/tpm/chip.h> #include <soc/acpi.h> #include <variant/ec.h> diff --git a/src/mainboard/google/myst/variants/baseboard/devicetree.cb b/src/mainboard/google/myst/variants/baseboard/devicetree.cb index 466b2dc..085e464 100644 --- a/src/mainboard/google/myst/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/myst/variants/baseboard/devicetree.cb @@ -186,6 +186,13 @@ device ref uart_0 on end # UART0 device ref i2c_0 on end device ref i2c_1 on end - device ref i2c_2 on end + device ref i2c_2 on + chip drivers/i2c/tpm + register "hid" = ""GOOG0005"" + register "desc" = ""Ti50 TPM"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_84)" + device i2c 50 alias ti50 on end + end + end device ref i2c_3 on end end # chip soc/amd/phoenix diff --git a/src/mainboard/google/myst/variants/baseboard/gpio.c b/src/mainboard/google/myst/variants/baseboard/gpio.c index b2eccff..56b8143 100644 --- a/src/mainboard/google/myst/variants/baseboard/gpio.c +++ b/src/mainboard/google/myst/variants/baseboard/gpio.c @@ -168,6 +168,15 @@ PAD_GPO(GPIO_157, HIGH), }; +static const struct soc_amd_gpio tpm_gpio_table[] = { + /* I2C2_SCL */ + PAD_NF(GPIO_113, I2C2_SCL, PULL_NONE), + /* I2C2_SDA */ + PAD_NF(GPIO_114, I2C2_SDA, PULL_NONE), + /* GSC_SOC_INT_L */ + PAD_INT(GPIO_84, PULL_NONE, EDGE_LOW, STATUS_DELIVERY), +}; + /* GPIO configuration in bootblock */ static const struct soc_amd_gpio bootblock_gpio_table[] = { /* TODO(b/275965982): Fill bootblock gpio configuration */ @@ -208,6 +217,12 @@ *gpio = espi_gpio_table; } +__weak void variant_tpm_gpio_table(const struct soc_amd_gpio **gpio, size_t *size) +{ + *size = ARRAY_SIZE(tpm_gpio_table); + *gpio = tpm_gpio_table; +} + __weak void variant_override_gpio_table(const struct soc_amd_gpio **gpio, size_t *size) { *size = 0; diff --git a/src/mainboard/google/myst/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/myst/variants/baseboard/include/baseboard/variants.h index a39d2bf..d5c2513 100644 --- a/src/mainboard/google/myst/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/myst/variants/baseboard/include/baseboard/variants.h @@ -21,4 +21,7 @@ */ void variant_override_gpio_table(const struct soc_amd_gpio **gpio, size_t *size); +/* This function provides GPIO settings for TPM i2c bus. */ +void variant_tpm_gpio_table(const struct soc_amd_gpio **gpio, size_t *size); + #endif /* __BASEBOARD_VARIANTS_H__ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/74111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e235356b252a7b68a42da128ffd3189a829f117 Gerrit-Change-Number: 74111 Gerrit-PatchSet: 36 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: acpigen: Add print-like function for debug string
by Kapil Porwal (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Lance Zhao, Hannah Williams, Cliff Huang, Paul Menzel, Tim Wawrzynczak, Angel Pons, Nick Vaccaro. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73113 ) Change subject: acpigen: Add print-like function for debug string ...................................................................... Patch Set 9: (1 comment) File src/acpi/acpigen.c: https://review.coreboot.org/c/coreboot/+/73113/comment/cfd191a6_ed8871a7 PS9, Line 1485: 255 can define a macro? -- To view, visit https://review.coreboot.org/c/coreboot/+/73113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4a42e5854516a22b7bc4559c2ed08680722c5ba Gerrit-Change-Number: 73113 Gerrit-PatchSet: 9 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Fri, 21 Apr 2023 13:35:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in blobs[master]: mb/starlabs/starbook/adl: Update EC binary to 1.12
by Sean Rhodes (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Sean Rhodes. Hello Lean Sheng Tan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/blobs/+/73683 to look at the new patch set (#6). Change subject: mb/starlabs/starbook/adl: Update EC binary to 1.12 ...................................................................... mb/starlabs/starbook/adl: Update EC binary to 1.12 1.12 Revert the charging rate to 0.5C Store the state of charging at 0xa0 1.11 Adjust the threshold for Hybrid Power to 1536MA Adjust the threshold for Hybrid Power to be disable to 5 percent RSOC 1.10 Disable Hybrid Power when the RSOC is less than 20 percent Only enable LEARN once when RSOC is greater than 50 percent Dont query unused registers on the BQ24780S 1.07 Disable PD requests when a normal USB-C device is connected Account for having two chargers connected Optimise the charging calculations 1.06 Strip PD responses to only include valid bits 1.05 Fix the charging voltage to 13.2V Only call Anx when USB-C PD chargers are connected Disable Hybrid-Power when charging current is less that 1536 1.04 Store power related variables in the EC RAM and mirror them to EC memory to avoid memory overflow to mitigate some strange behaviours when the EC memory overflows 1.03 Improved the reliability of DC Jack charging by modifying it to 800MHz, 3A Avoided charging stalling by continuously polling the SMBus after overcharge protection is active Exposed the behavior of overcharge protection to APCI Set the charge LED to purple when overcharge protection is active Modified fan curve Ensured the trackpad is in the desired state by polling its state every 10ms Set the brightness of the keyboard backlight to the maximum Streamlined the system by removing unused SMM events Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I3b08cb8b2b4e9e9836cd7e8c545fc83b2e0e3f99 --- M mainboard/starlabs/starbook/adl/ec.bin 1 file changed, 52 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/83/73683/6 -- To view, visit https://review.coreboot.org/c/blobs/+/73683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I3b08cb8b2b4e9e9836cd7e8c545fc83b2e0e3f99 Gerrit-Change-Number: 73683 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: Drop unused include <version.h>
by Nico Huber (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Jason Glenesk, Matt DeVillier, Kyösti Mälkki, Fred Reitberger, Felix Held. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74448 ) Change subject: Drop unused include <version.h> ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: +2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d0718b5d2e0dd16eb90f63dd9d33329a2d808ba Gerrit-Change-Number: 74448 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 21 Apr 2023 13:29:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/siemens/mc_ehl4: Disable PCIe device I2C4
by Jan Samek (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Mario Scheithauer, Werner Zeh. Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74629 ) Change subject: mb/siemens/mc_ehl4: Disable PCIe device I2C4 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8a5d1d27a57508d70bf30cf8e71aa1ee33bcbf13 Gerrit-Change-Number: 74629 Gerrit-PatchSet: 3 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 21 Apr 2023 13:29:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/braswell: Replace <build.h> with <version.h>
by Nico Huber (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Kyösti Mälkki. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74447 ) Change subject: soc/intel/braswell: Replace <build.h> with <version.h> ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: +2 Not very obvious that `coreboot_build_date` is supposed to be BCD. But it is :) -- To view, visit https://review.coreboot.org/c/coreboot/+/74447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd6fa2ddf8aa584b0f51ba130592f227bbdad975 Gerrit-Change-Number: 74447 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Fri, 21 Apr 2023 13:26:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/ipmi: Replace <build.h> with <version.h>
by Nico Huber (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Kyösti Mälkki. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74446 ) Change subject: drivers/ipmi: Replace <build.h> with <version.h> ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: +2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f10acabf1838deb90fde8215a32718028096852 Gerrit-Change-Number: 74446 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Fri, 21 Apr 2023 13:23:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: sb,soc/intel/common: Add common get_pmbase()
by build bot (Jenkins) (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Jeff Daly, Jonathan Zhang, Angel Pons, Arthur Heymans, Tarun Tuli, Sean Rhodes, Subrata Banik, Johnny Lin, Kapil Porwal, Christian Walter, Vanessa Eusebio, Lean Sheng Tan, Tim Chu. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70048 ) Change subject: sb,soc/intel/common: Add common get_pmbase() ...................................................................... Patch Set 9: (1 comment) File src/southbridge/intel/common/pmbase.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174731): https://review.coreboot.org/c/coreboot/+/70048/comment/340d3f54_9306ce76 PS9, Line 19: !CONFIG(SOC_INTEL_BRASWELL) please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/70048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idda34aa376caef94383699e6c17ed1f588bca37e Gerrit-Change-Number: 70048 Gerrit-PatchSet: 9 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 21 Apr 2023 13:22:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023