coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: mb/google/skyrim: Add named GPIO's
by Jon Murphy (Code Review) 22 Apr '23

22 Apr '23

Attention is currently required from: Jason Nien, Martin Roth. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74607 ) Change subject: mb/google/skyrim: Add named GPIO's ...................................................................... Patch Set 1: (3 comments) File src/mainboard/google/skyrim/port_descriptors.c: https://review.coreboot.org/c/coreboot/+/74607/comment/4823eccb_4b2ae78c PS1, Line 3: #include <variant/gpio.h> Has to be before soc/platform_descriptors.h File src/mainboard/google/skyrim/variants/markarth/port_descriptors.c: https://review.coreboot.org/c/coreboot/+/74607/comment/7e194969_3688473d PS1, Line 3: #include <variant/gpio.h> Has to be before the include of soc/platform_descriptors.h File src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c: https://review.coreboot.org/c/coreboot/+/74607/comment/b32d3640_d1e2d527 PS1, Line 3: #include <variant/gpio.h> Has to be before the include of soc/platform_descriptors -- To view, visit https://review.coreboot.org/c/coreboot/+/74607 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24a8f7e5bfa9e3e586d4189132f47551202f7d2d Gerrit-Change-Number: 74607 Gerrit-PatchSet: 1 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 21 Apr 2023 22:19:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/skyrim: rename baseboard gpios in gpio.c
by Jon Murphy (Code Review) 22 Apr '23

22 Apr '23

Attention is currently required from: Raul Rangel, Jason Nien, Martin Roth, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74592 ) Change subject: mb/google/skyrim: rename baseboard gpios in gpio.c ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74592/comment/6531b051_82dd9ca1 PS2, Line 9: Add named GPIO's to help prevent confusion in GPIO management > That link was broken for me: https://source.chromium. […] Added test to https://review.coreboot.org/c/coreboot/+/74607/1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If907478442ea7acb80b2e413926d173d188ce340 Gerrit-Change-Number: 74592 Gerrit-PatchSet: 5 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Fri, 21 Apr 2023 22:17:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com> Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/skyrim: rename baseboard gpios in gpio.c
by Jon Murphy (Code Review) 22 Apr '23

22 Apr '23

Attention is currently required from: Raul Rangel, Jason Nien, Martin Roth, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74592 ) Change subject: mb/google/skyrim: rename baseboard gpios in gpio.c ...................................................................... Patch Set 5: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74592/comment/d4dc4586_ff6f62ae PS2, Line 9: Add named GPIO's to help prevent confusion in GPIO management > BUILD_TIMELESS=1 emerge-... coreboot […] That link was broken for me: https://source.chromium.org/chromium/chromiumos/third_party/coreboot/+/chro… File src/mainboard/google/skyrim/port_descriptors.c: https://review.coreboot.org/c/coreboot/+/74592/comment/73608d9c_0c8b916a PS2, Line 38: .gpio_group_id = SSD_AUX_RST_L, > SD_AUX_RST_SOC_L Done File src/mainboard/google/skyrim/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/74592/comment/3b9e0c16_0c3659c5 PS2, Line 10: SYS_RST_ODL > > We may not be configuring the GPIOs in other places, but we are referencing them. […] Split everything except gpio.c into a separate CL File src/mainboard/google/skyrim/variants/markarth/gpio.c: https://review.coreboot.org/c/coreboot/+/74592/comment/93172267_4b03ad4f PS2, Line 10: PAD_NC(GPIO_3), > I know these are not named b/c they are not used, but it feels like another place in code we could f […] We can just delete the name from the baseboard and leave it as unused -- To view, visit https://review.coreboot.org/c/coreboot/+/74592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If907478442ea7acb80b2e413926d173d188ce340 Gerrit-Change-Number: 74592 Gerrit-PatchSet: 5 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Fri, 21 Apr 2023 22:16:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com> Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Comment-In-Reply-To: Mark Hasemeyer <markhas(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/common: Update GPIO macros
by build bot (Jenkins) (Code Review) 22 Apr '23

22 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Jon Murphy, Martin Roth, Tim Van Patten, Fred Reitberger, Karthik Ramasubramanian, Felix Held, Mark Hasemeyer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74591 ) Change subject: soc/amd/common: Update GPIO macros ...................................................................... Patch Set 4: Verified-1 (3 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174779): https://review.coreboot.org/c/coreboot/+/74591/comment/1a0fdd3f_d5c9928e PS4, Line 8: Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174779): https://review.coreboot.org/c/coreboot/+/74591/comment/0f3cff62_4cbf257a PS4, Line 11: to GPIO_NN names for use in their own development. Enabling projects to Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174779): https://review.coreboot.org/c/coreboot/+/74591/comment/49506c7b_8673df6f PS4, Line 12: rename their own GPIOs to nets will hopefully make the code more readable Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/74591 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I918d659eecf2076ed9089218177874ed2c9023b3 Gerrit-Change-Number: 74591 Gerrit-PatchSet: 4 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Fri, 21 Apr 2023 22:15:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/myst: Add mainboard chip.h
by Jon Murphy (Code Review) 22 Apr '23

22 Apr '23

Attention is currently required from: Jon Murphy. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74670 to look at the new patch set (#3). Change subject: mb/google/myst: Add mainboard chip.h ...................................................................... mb/google/myst: Add mainboard chip.h Add mainboard chip.h to allow for using additional includes and specifically net names within the devicetree. BUG=b:278969100 TEST=builds Change-Id: I52be99c168ce0fd6f08258da443eeaebdfb78d0a Signed-off-by: Jon Murphy <jpmurphy(a)google.com> --- M src/mainboard/google/myst/mainboard.c A src/mainboard/google/myst/variants/baseboard/chip.h M src/mainboard/google/myst/variants/baseboard/devicetree.cb 3 files changed, 169 insertions(+), 135 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/74670/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74670 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52be99c168ce0fd6f08258da443eeaebdfb78d0a Gerrit-Change-Number: 74670 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: mb/google/skyrim: Add mainboard chip.h
by Jon Murphy (Code Review) 22 Apr '23

22 Apr '23

Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth. Hello build bot (Jenkins), Jason Nien, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74609 to look at the new patch set (#3). Change subject: mb/google/skyrim: Add mainboard chip.h ...................................................................... mb/google/skyrim: Add mainboard chip.h Add mainboard chip.h to allow for using additional includes and specifically net names within the devicetree. BUG=b:278968729 TEST=builds Change-Id: Ic609d294135e2982064cb1c1fe6eac98dc24086f --- M src/mainboard/google/skyrim/mainboard.c A src/mainboard/google/skyrim/variants/baseboard/chip.h M src/mainboard/google/skyrim/variants/baseboard/devicetree.cb 3 files changed, 274 insertions(+), 241 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/74609/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74609 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic609d294135e2982064cb1c1fe6eac98dc24086f Gerrit-Change-Number: 74609 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/amd/common: Update GPIO macros
by build bot (Jenkins) (Code Review) 22 Apr '23

22 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Jon Murphy, Martin Roth, Tim Van Patten, Fred Reitberger, Karthik Ramasubramanian, Felix Held, Mark Hasemeyer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74591 ) Change subject: soc/amd/common: Update GPIO macros ...................................................................... Patch Set 3: Verified-1 (3 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174772): https://review.coreboot.org/c/coreboot/+/74591/comment/37e3c53c_09b1a798 PS3, Line 8: Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174772): https://review.coreboot.org/c/coreboot/+/74591/comment/9d1bb835_f209a57b PS3, Line 11: to GPIO_NN names for use in their own development. Enabling projects to Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174772): https://review.coreboot.org/c/coreboot/+/74591/comment/e48ba59d_2ad1ac6c PS3, Line 12: rename their own GPIOs to nets will hopefully make the code more readable Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/74591 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I918d659eecf2076ed9089218177874ed2c9023b3 Gerrit-Change-Number: 74591 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Fri, 21 Apr 2023 22:12:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/skyrim: Add mainboard chip.h
by build bot (Jenkins) (Code Review) 22 Apr '23

22 Apr '23

Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74609 ) Change subject: mb/google/skyrim: Add mainboard chip.h ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/skyrim/variants/baseboard/chip.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174768): https://review.coreboot.org/c/coreboot/+/74609/comment/18c0395a_94b3786d PS2, Line 10: #endif adding a line without newline at end of file -- To view, visit https://review.coreboot.org/c/coreboot/+/74609 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic609d294135e2982064cb1c1fe6eac98dc24086f Gerrit-Change-Number: 74609 Gerrit-PatchSet: 2 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 21 Apr 2023 22:12:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/myst: Add mainboard chip.h
by build bot (Jenkins) (Code Review) 22 Apr '23

22 Apr '23

Attention is currently required from: Jon Murphy. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74670 ) Change subject: mb/google/myst: Add mainboard chip.h ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/myst/variants/baseboard/chip.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174770): https://review.coreboot.org/c/coreboot/+/74670/comment/a4ad214b_5e3f6f8c PS2, Line 10: #endif adding a line without newline at end of file -- To view, visit https://review.coreboot.org/c/coreboot/+/74670 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52be99c168ce0fd6f08258da443eeaebdfb78d0a Gerrit-Change-Number: 74670 Gerrit-PatchSet: 2 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Comment-Date: Fri, 21 Apr 2023 22:12:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/myst: Update GPIO names
by Jon Murphy (Code Review) 22 Apr '23

22 Apr '23

Attention is currently required from: Raul Rangel, Jon Murphy, Martin Roth, Karthik Ramasubramanian. Hello build bot (Jenkins), Raul Rangel, Martin Roth, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74596 to look at the new patch set (#3). Change subject: mb/google/myst: Update GPIO names ...................................................................... mb/google/myst: Update GPIO names Update GPIO names in devicetree files to use the more descriptive versions in variant/gpio.h. This provides more clarity and insight into what GPIOs actually mean on the design. BUG=b:278969100 TEST=builds Signed-off-by: Jon Murphy <jpmurphy(a)google.com> Change-Id: I2ad4618eb6d897807d26c9bf8f2a090b5c9020c2 --- M src/mainboard/google/myst/variants/baseboard/devicetree.cb 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/74596/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74596 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ad4618eb6d897807d26c9bf8f2a090b5c9020c2 Gerrit-Change-Number: 74596 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023