Attention is currently required from: Lance Zhao, Tim Wawrzynczak.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73348 )
Change subject: acpi: Add warning message when timeout in write_delay_until function
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73348/comment/442fffc3_f2d7f3e5
PS1, Line 12: This timeout message won't be displayed when this function are used as delay
> Possible unwrapped commit description (prefer a maximum 72 chars per line)
Please fix.
--
To view, visit https://review.coreboot.org/c/coreboot/+/73348
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3843e51988527e99822017d1b5f653ff2eaa7958
Gerrit-Change-Number: 73348
Gerrit-PatchSet: 1
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 23:13:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Lance Zhao, Tim Wawrzynczak.
Hello Lance Zhao, build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/73348
to look at the new patch set (#2).
Change subject: acpi: Add warning message when timeout in write_delay_until function
......................................................................
acpi: Add warning message when timeout in write_delay_until function
The ACPI should print warning message to kernel when timeout during the
loop waiting for the condition to occur
This timeout message won't be displayed when this function are used as
delay loop, (ie. without checking variable condition)
To enable this print to kernel log:
echo 1 > /sys/module/acpi/parameters/aml_debug_output
ex: Waiting for variable L23E = 0; the max loop count( Local7) = 8
will generate ACPI code:
Local7 = 0x08
While ((Local7 > Zero))
{
If ((L23E == Zero))
{
Break
}
Sleep (0x10)
Local7--
If ((Local7 == Zero))
{
Debug = "WARN: Wait loop Timeout! variable = L23E"
}
}
BRANCH=firmware-brya-14505.B
TEST=Boot to OS and check that the Debug print is added to the function.
Signed-off-by: Cliff Huang <cliff.huang(a)intel.com>
Change-Id: I3843e51988527e99822017d1b5f653ff2eaa7958
---
M src/acpi/acpigen.c
1 file changed, 47 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/73348/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/73348
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3843e51988527e99822017d1b5f653ff2eaa7958
Gerrit-Change-Number: 73348
Gerrit-PatchSet: 2
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, David Hendricks, Arthur Heymans, Tim Chu.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73171 )
Change subject: soc/intel/xeon_sp: Split SKX/CPX MSRs into separate headers
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
This patchset implements a suggestion from CB:72611 to split MSR headers into different files. Some of the MSRs on SPR are laid out differently from previous generations, so it made sense to split the headers apart.
For this patch set, I went through the EDS docs for SKX, CPX, and SPR to figure out which MSRs are common or not. SKX and CPX are fairly similar, particularly fields in MSR_POWER_CTL. However there are some differences, for example in the number of MC banks implemented. SPR (CB:73172) has a lot more differences.
For now I tried to leave formatting the same (simple cut+paste from one header to another). We may want to re-formatt these files later on using the updated .clang-format from Elyes (CB:64779).
--
To view, visit https://review.coreboot.org/c/coreboot/+/73171
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ecfebdde453a48b7b0e6f21b3c4394411eed671
Gerrit-Change-Number: 73171
Gerrit-PatchSet: 4
Gerrit-Owner: David Hendricks
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 23:05:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73172 )
Change subject: soc/intel/xeon_sp: add MSR definitions for SPR-SP
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/73172
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92b433a9686734716dc7936895fb79c7751f7f9b
Gerrit-Change-Number: 73172
Gerrit-PatchSet: 5
Gerrit-Owner: David Hendricks
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 01 Mar 2023 22:55:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: David Hendricks.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73171 )
Change subject: soc/intel/xeon_sp: Split SKX/CPX MSRs into separate headers
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/73171
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ecfebdde453a48b7b0e6f21b3c4394411eed671
Gerrit-Change-Number: 73171
Gerrit-PatchSet: 4
Gerrit-Owner: David Hendricks
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: David Hendricks
Gerrit-Comment-Date: Wed, 01 Mar 2023 22:55:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Robert Zieba, Raul Rangel, Martin Roth.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69914 )
Change subject: device/xhci: Add functions to work with resource pointers
......................................................................
Patch Set 13:
(2 comments)
File src/device/xhci_resource.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171262):
https://review.coreboot.org/c/coreboot/+/69914/comment/8f5cb6e3_0c02a0d1
PS13, Line 18: enum cb_err xhci_resource_for_each_ext_cap(const struct resource *res, void *context,
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171262):
https://review.coreboot.org/c/coreboot/+/69914/comment/1e49550c_530d3bae
PS13, Line 95: enum cb_err xhci_resource_for_each_supported_usb_cap(
that open brace { should be on the previous line
--
To view, visit https://review.coreboot.org/c/coreboot/+/69914
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5a74f9529d5dc6031ec968ef5f40a9cad5ffbc4
Gerrit-Change-Number: 69914
Gerrit-PatchSet: 13
Gerrit-Owner: Robert Zieba <robertzieba(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Robert Zieba <robertzieba(a)google.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 22:35:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Robert Zieba, Raul Rangel, Martin Roth.
Hello build bot (Jenkins), Raul Rangel, Martin Roth, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69914
to look at the new patch set (#13).
Change subject: device/xhci: Add functions to work with resource pointers
......................................................................
device/xhci: Add functions to work with resource pointers
The XHCI device functions currently use functions that require a
access to the device tree. Create variant of these functions that can
operate with a resource* as an argument and refactor the existing
device*-based functions to operate by calling the resource*-based
variants. This is useful for stages like SMM that may not have access to
the device tree.
BRANCH=guybrush
BUG=b:186792595
TEST=Ran on skyrim device, verified that XHCI ACPI tables are still
generated correctly.
Change-Id: If5a74f9529d5dc6031ec968ef5f40a9cad5ffbc4
Signed-off-by: Robert Zieba <robertzieba(a)google.com>
---
M src/device/Makefile.inc
M src/device/xhci.c
A src/device/xhci_resource.c
M src/include/device/xhci.h
4 files changed, 162 insertions(+), 95 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/69914/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/69914
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5a74f9529d5dc6031ec968ef5f40a9cad5ffbc4
Gerrit-Change-Number: 69914
Gerrit-PatchSet: 13
Gerrit-Owner: Robert Zieba <robertzieba(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Robert Zieba <robertzieba(a)google.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Robert Zieba, Raul Rangel, Nico Huber, Angel Pons, Martin Roth, Felix Held.
Hello Arthur Heymans, build bot (Jenkins), Martin Roth, Karthik Ramasubramanian, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67931
to look at the new patch set (#20).
Change subject: cpu/x86/smm: Add PCI resource store functionality
......................................................................
cpu/x86/smm: Add PCI resource store functionality
In certain cases data within protected memmory areas like SMRAM could
be leaked or modified if an attacker remaps PCI BARs to point within
that area. Add support to the existing SMM runtime to allow storing
PCI resources in SMRAM and then later retrieving them.
BRANCH=guybrush
BUG=b:186792595
TEST=builds
Signed-off-by: Robert Zieba <robertzieba(a)google.com>
Change-Id: I23fb1e935dd1b89f1cc5c834cc2025f0fe5fda37
---
M src/cpu/x86/Kconfig
M src/cpu/x86/smm/Makefile.inc
A src/cpu/x86/smm/pci_resource_store.c
M src/cpu/x86/smm/smm_module_handler.c
M src/cpu/x86/smm/smm_module_loader.c
M src/include/cpu/x86/smm.h
M src/include/device/pci_def.h
7 files changed, 148 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/67931/20
--
To view, visit https://review.coreboot.org/c/coreboot/+/67931
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23fb1e935dd1b89f1cc5c834cc2025f0fe5fda37
Gerrit-Change-Number: 67931
Gerrit-PatchSet: 20
Gerrit-Owner: Robert Zieba <robertzieba(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Robert Zieba <robertzieba(a)google.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Lance Zhao, Tim Wawrzynczak.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73348 )
Change subject: acpi: Add warning message when timeout in acpigen_write_delay_until_namestr_int()
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171260):
https://review.coreboot.org/c/coreboot/+/73348/comment/4c03faf6_75fd142c
PS1, Line 12: This timeout message won't be displayed when this function are used as delay
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit https://review.coreboot.org/c/coreboot/+/73348
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3843e51988527e99822017d1b5f653ff2eaa7958
Gerrit-Change-Number: 73348
Gerrit-PatchSet: 1
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 22:32:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Cliff Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73348 )
Change subject: acpi: Add warning message when timeout in acpigen_write_delay_until_namestr_int()
......................................................................
acpi: Add warning message when timeout in acpigen_write_delay_until_namestr_int()
The ACPI should print warning message to kernel when timeout during the
loop waiting for the condition to occur
This timeout message won't be displayed when this function are used as delay
loop, (ie. without checking variable condition)
To enable this print to kernel log:
echo 1 > /sys/module/acpi/parameters/aml_debug_output
ex: Waiting for variable L23E = 0; the max loop count( Local7) = 8
will generate ACPI code:
Local7 = 0x08
While ((Local7 > Zero))
{
If ((L23E == Zero))
{
Break
}
Sleep (0x10)
Local7--
If ((Local7 == Zero))
{
Debug = "WARN: Wait loop Timeout! variable = L23E"
}
}
BRANCH=firmware-brya-14505.B
TEST=Boot to OS and check that the Debug print is added to the function.
Signed-off-by: Cliff Huang <cliff.huang(a)intel.com>
Change-Id: I3843e51988527e99822017d1b5f653ff2eaa7958
---
M src/acpi/acpigen.c
1 file changed, 47 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/73348/1
diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c
index 9d23e57..26280e2 100644
--- a/src/acpi/acpigen.c
+++ b/src/acpi/acpigen.c
@@ -2330,4 +2330,10 @@
acpigen_emit_byte(DECREMENT_OP);
acpigen_emit_byte(LOCAL7_OP);
acpigen_pop_len(); /* While */
+
+ if (name) {
+ acpigen_write_if_lequal_op_op(LOCAL7_OP, ZERO_OP);
+ acpigen_write_debug_sprintf("WARN: Wait loop Timeout! variable = %s", name);
+ acpigen_pop_len(); /* If */
+ }
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/73348
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3843e51988527e99822017d1b5f653ff2eaa7958
Gerrit-Change-Number: 73348
Gerrit-PatchSet: 1
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-MessageType: newchange