coreboot-gerrit March 2023

coreboot-gerrit@coreboot.org

1 participants
4880 discussions

[M] Change in coreboot[master]: soc/mediatek/mt8188: Add bus protection for audio/video mtcmos
by Yu-Ping Wu (Code Review) 02 Mar '23

02 Mar '23

Attention is currently required from: Hung-Te Lin, jason-ch chen, Rex-BC Chen, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73375 ) Change subject: soc/mediatek/mt8188: Add bus protection for audio/video mtcmos ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73375 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14aa63c4934073a14552cef64f40657d0197bbe1 Gerrit-Change-Number: 73375 Gerrit-PatchSet: 3 Gerrit-Owner: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 03 Mar 2023 03:16:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in blobs[master]: soc/mediatek/mt8188: Add scramble switch and fix 1RK register bit
by Yu-Ping Wu (Code Review) 02 Mar '23

02 Mar '23

Attention is currently required from: Xixi Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/73339 ) Change subject: soc/mediatek/mt8188: Add scramble switch and fix 1RK register bit ...................................................................... Patch Set 5: (1 comment) File soc/mediatek/mt8188/dram_release_notes.txt: https://review.coreboot.org/c/blobs/+/73339/comment/4aaa4c89_1225522a PS5, Line 1: # 0.1.1 Next time please use the official build. See https://review.coreboot.org/c/blobs/+/62583/2/soc/mediatek/mt8195/dram_rele… for example. -- To view, visit https://review.coreboot.org/c/blobs/+/73339 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I7bf751e19d6df32bbd40b9dacad16fb99253d2ae Gerrit-Change-Number: 73339 Gerrit-PatchSet: 5 Gerrit-Owner: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: johnson wang <johnson.wang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Fri, 03 Mar 2023 03:16:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek/mt8188: Add bus protection for audio/video mtcmos
by jason-ch chen (Code Review) 02 Mar '23

02 Mar '23

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu, Yidi Lin. jason-ch chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73375 ) Change subject: soc/mediatek/mt8188: Add bus protection for audio/video mtcmos ...................................................................... Patch Set 3: (1 comment) File src/soc/mediatek/mt8188/mtcmos.c: https://review.coreboot.org/c/coreboot/+/73375/comment/2032cd3d_9e78879c PS2, Line 25: ADSP_PROT_STEP_1_MASK = 0x00100000, : ADSP_PROT_STEP_2_MASK = 0x00001000, : AUDIO_PROT_STEP_1_MASK = 0x00000F00, : AUDIO_PROT_STEP_2_MASK = 0x00600000, > The order isn't consistent. `V*STEP_*` are sorted by decreasing steps. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/73375 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14aa63c4934073a14552cef64f40657d0197bbe1 Gerrit-Change-Number: 73375 Gerrit-PatchSet: 3 Gerrit-Owner: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 03 Mar 2023 03:11:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek/mt8188: Add bus protection for audio/video mtcmos
by jason-ch chen (Code Review) 02 Mar '23

02 Mar '23

Attention is currently required from: Hung-Te Lin, jason-ch chen, Rex-BC Chen, Yidi Lin. Hello Hung-Te Lin, build bot (Jenkins), Rex-BC Chen, Yu-Ping Wu, Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73375 to look at the new patch set (#3). Change subject: soc/mediatek/mt8188: Add bus protection for audio/video mtcmos ...................................................................... soc/mediatek/mt8188: Add bus protection for audio/video mtcmos Bus protection is a HW mechanism to avoid bus hang and incomplete bus transactions. Bus protection HW must be enabled while the receiver of the transaction is not able to respond. BUG=b:264204465 TEST=build pass Change-Id: I14aa63c4934073a14552cef64f40657d0197bbe1 Signed-off-by: garmin chang <garmin.chang(a)mediatek.corp-partner.google.com> Signed-off-by: jason-ch chen <jason-ch.chen(a)mediatek.corp-partner.google.com> --- M src/soc/mediatek/mt8188/mtcmos.c 1 file changed, 89 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/73375/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/73375 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14aa63c4934073a14552cef64f40657d0197bbe1 Gerrit-Change-Number: 73375 Gerrit-PatchSet: 3 Gerrit-Owner: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: lint/lint-stable-003-whitespace: Fix excludelist
by build bot (Jenkins) (Code Review) 02 Mar '23

02 Mar '23

Attention is currently required from: Martin L Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73396 ) Change subject: lint/lint-stable-003-whitespace: Fix excludelist ...................................................................... Patch Set 1: (1 comment) File util/lint/lint-stable-003-whitespace: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171362): https://review.coreboot.org/c/coreboot/+/73396/comment/4fd8e955_96489158 PS1, Line 14: EXCLUDELIST='^src/vendorcode/|^util/kconfig/|^util/nvidia/cbootimage|^util/goswid|__pycache__|COPYING|LICENSE|README|_shipped$|\.patch$|\.bin$|\.hex$|\.jpg$|\.gif$|\.ttf$|\.woff$|\.png$|\.eot$|\.vbt$|\.ico$|\.md$' 'README' may be misspelled - perhaps 'README'? -- To view, visit https://review.coreboot.org/c/coreboot/+/73396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I90cc2cff9a98bbd0af344156332b970bfd6430b9 Gerrit-Change-Number: 73396 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 03 Mar 2023 02:59:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: lint/lint-stable-003-whitespace: Fix excludelist
by Maximilian Brune (Code Review) 02 Mar '23

02 Mar '23

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73396 ) Change subject: lint/lint-stable-003-whitespace: Fix excludelist ...................................................................... lint/lint-stable-003-whitespace: Fix excludelist Remove the last slash '/' from directories in excludelist, so that they will be correctly filtered by grep. Fixes: grep: util/goswid: Is a directory grep: util/nvidia/cbootimage: Is a directory Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I90cc2cff9a98bbd0af344156332b970bfd6430b9 --- M util/lint/lint-stable-003-whitespace 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/73396/1 diff --git a/util/lint/lint-stable-003-whitespace b/util/lint/lint-stable-003-whitespace index 838ea93..82b46b0 100755 --- a/util/lint/lint-stable-003-whitespace +++ b/util/lint/lint-stable-003-whitespace @@ -11,7 +11,7 @@ # shellcheck source=helper_functions.sh . "${LINTDIR}/helper_functions.sh" -EXCLUDELIST='^src/vendorcode/|^util/kconfig/|^util/nvidia/cbootimage/|^util/goswid/|__pycache__|COPYING|LICENSE|README|_shipped$|\.patch$|\.bin$|\.hex$|\.jpg$|\.gif$|\.ttf$|\.woff$|\.png$|\.eot$|\.vbt$|\.ico$|\.md$' +EXCLUDELIST='^src/vendorcode/|^util/kconfig/|^util/nvidia/cbootimage|^util/goswid|__pycache__|COPYING|LICENSE|README|_shipped$|\.patch$|\.bin$|\.hex$|\.jpg$|\.gif$|\.ttf$|\.woff$|\.png$|\.eot$|\.vbt$|\.ico$|\.md$' INCLUDELIST="src util payloads Makefile* toolchain.inc tests" # shellcheck disable=SC2086,SC2046 -- To view, visit https://review.coreboot.org/c/coreboot/+/73396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I90cc2cff9a98bbd0af344156332b970bfd6430b9 Gerrit-Change-Number: 73396 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: soc/mediatek/mt8188: Add bus protection for audio/video mtcmos
by Yu-Ping Wu (Code Review) 02 Mar '23

02 Mar '23

Attention is currently required from: Hung-Te Lin, jason-ch chen, Rex-BC Chen, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73375 ) Change subject: soc/mediatek/mt8188: Add bus protection for audio/video mtcmos ...................................................................... Patch Set 2: (1 comment) File src/soc/mediatek/mt8188/mtcmos.c: https://review.coreboot.org/c/coreboot/+/73375/comment/c095067b_fcc8738d PS2, Line 25: ADSP_PROT_STEP_1_MASK = 0x00100000, : ADSP_PROT_STEP_2_MASK = 0x00001000, : AUDIO_PROT_STEP_1_MASK = 0x00000F00, : AUDIO_PROT_STEP_2_MASK = 0x00600000, The order isn't consistent. `V*STEP_*` are sorted by decreasing steps. -- To view, visit https://review.coreboot.org/c/coreboot/+/73375 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14aa63c4934073a14552cef64f40657d0197bbe1 Gerrit-Change-Number: 73375 Gerrit-PatchSet: 2 Gerrit-Owner: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 03 Mar 2023 02:59:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek/mt8188: Add bus protection for audio/video mtcmos
by jason-ch chen (Code Review) 02 Mar '23

02 Mar '23

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu. jason-ch chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73375 ) Change subject: soc/mediatek/mt8188: Add bus protection for audio/video mtcmos ...................................................................... Patch Set 2: (1 comment) File src/soc/mediatek/mt8188/mtcmos.c: https://review.coreboot.org/c/coreboot/+/73375/comment/4ce19e62_890f37eb PS1, Line 1: /* SPDX-License-Identifier: GPL-2.0-only OR MIT */ > Please correct the file mode Done -- To view, visit https://review.coreboot.org/c/coreboot/+/73375 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14aa63c4934073a14552cef64f40657d0197bbe1 Gerrit-Change-Number: 73375 Gerrit-PatchSet: 2 Gerrit-Owner: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 03 Mar 2023 02:40:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek/mt8188: Add bus protection for audio/video mtcmos
by jason-ch chen (Code Review) 02 Mar '23

02 Mar '23

Attention is currently required from: Hung-Te Lin, jason-ch chen, Rex-BC Chen, Yu-Ping Wu. Hello Hung-Te Lin, build bot (Jenkins), Rex-BC Chen, Yu-Ping Wu, Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73375 to look at the new patch set (#2). Change subject: soc/mediatek/mt8188: Add bus protection for audio/video mtcmos ...................................................................... soc/mediatek/mt8188: Add bus protection for audio/video mtcmos Bus protection is a HW mechanism to avoid bus hang and incomplete bus transactions. Bus protection HW must be enabled while the receiver of the transaction is not able to respond. BUG=b:264204465 TEST=build pass Change-Id: I14aa63c4934073a14552cef64f40657d0197bbe1 Signed-off-by: garmin chang <garmin.chang(a)mediatek.corp-partner.google.com> Signed-off-by: jason-ch chen <jason-ch.chen(a)mediatek.corp-partner.google.com> --- M src/soc/mediatek/mt8188/mtcmos.c 1 file changed, 89 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/73375/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73375 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14aa63c4934073a14552cef64f40657d0197bbe1 Gerrit-Change-Number: 73375 Gerrit-PatchSet: 2 Gerrit-Owner: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: WIP:amdfwtool: Add page
by Bao Zheng (Code Review) 02 Mar '23

02 Mar '23

Attention is currently required from: Zheng Bao. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73410 ) Change subject: WIP:amdfwtool: Add page ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > https://review.coreboot. […] Based on Arthur's comments. Need suggestion if it is worth to do. -- To view, visit https://review.coreboot.org/c/coreboot/+/73410 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9804ddc7fd2d59bc5b726de57d627cd785f1ed24 Gerrit-Change-Number: 73410 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Fri, 03 Mar 2023 02:32:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2023