Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu, Yidi Lin.
jason-ch chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73375 )
Change subject: soc/mediatek/mt8188: Add bus protection for audio/video mtcmos
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/mt8188/mtcmos.c:
https://review.coreboot.org/c/coreboot/+/73375/comment/2032cd3d_9e78879c
PS2, Line 25: ADSP_PROT_STEP_1_MASK = 0x00100000,
: ADSP_PROT_STEP_2_MASK = 0x00001000,
: AUDIO_PROT_STEP_1_MASK = 0x00000F00,
: AUDIO_PROT_STEP_2_MASK = 0x00600000,
The order isn't consistent. `V*STEP_*` are sorted by decreasing steps.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73375
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14aa63c4934073a14552cef64f40657d0197bbe1
Gerrit-Change-Number: 73375
Gerrit-PatchSet: 3
Gerrit-Owner: jason-ch chen
Jason-ch.Chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Fri, 03 Mar 2023 03:11:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment