Attention is currently required from: Sudheer Amrabadi.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/qc_blobs/+/73458 )
Change subject: sc7180/boot: Update qclib blobs binaries from 50 to 53
......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/qc_blobs/+/73458/comment/b2372b62_3909abd9
PS3, Line 8:
Please add the one change-log entry from the release notes to the commit message.
Patchset:
PS3:
Why does the version increase by three (50 → 53), when there is only one change-log entry?
File sc7180/boot/Release_Notes.txt:
https://review.coreboot.org/c/qc_blobs/+/73458/comment/e3cfe43a_aa96e04a
PS3, Line 15: at mission mode
What does mission mode mean?
https://review.coreboot.org/c/qc_blobs/+/73458/comment/5ced0e2d_c7331fab
PS3, Line 15: * Fix
Please use spaces after the bullet point.
https://review.coreboot.org/c/qc_blobs/+/73458/comment/dadb939e_58f3259d
PS3, Line 15: * Fix for QSIP Gen2 Hynix failures over Factory test at mission mode
Statement with verb (in imperative mood):
* Fix QSIP Gen2 Hynix failures over factory test at mission mode
--
To view, visit https://review.coreboot.org/c/qc_blobs/+/73458
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: qc_blobs
Gerrit-Branch: master
Gerrit-Change-Id: Id70415361d2de5a2c8e7d215f95675e93a670962
Gerrit-Change-Number: 73458
Gerrit-PatchSet: 3
Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Comment-Date: Tue, 07 Mar 2023 07:36:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kevin Keijzer, Felix Singer, Angel Pons, Fabian Groffen.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73516 )
Change subject: mb/asrock/b75m-itx: Make NIC a child device below the right PCIe port
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/73516
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1e3a757a6bd6c7dd1702ced177d13711978dcc4
Gerrit-Change-Number: 73516
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Keijzer
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Fabian Groffen <grobian(a)gentoo.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kevin Keijzer
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org>
Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl>
Gerrit-Comment-Date: Tue, 07 Mar 2023 07:34:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: John Su, Dtrain Hsu, Jason Nien, Eric Lai, Martin Roth.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73510 )
Change subject: mb/google/skyrim/var/markarth: Update RAM ID table
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/73510
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59a6a6dff249cd4fe982a4de824848f1bac0ecba
Gerrit-Change-Number: 73510
Gerrit-PatchSet: 3
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-CC: Rex Chou <rex_chou(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 07 Mar 2023 07:34:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Frank Wu, John Su, Dtrain Hsu, Eric Lai, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73489 )
Change subject: spd/lp5: Add new memory part to LP5 list
......................................................................
Patch Set 5:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73489/comment/829b2e06_a26ed6e0
PS5, Line 7: Add new memory part to LP5 list
More specific: Add 2 Micron memory parts
https://review.coreboot.org/c/coreboot/+/73489/comment/cc7572f2_f417ea1c
PS5, Line 9: MICRON
Micron
https://review.coreboot.org/c/coreboot/+/73489/comment/2f1326cf_05dc60a7
PS5, Line 10: data sheets
Please add the names and revisions.
https://review.coreboot.org/c/coreboot/+/73489/comment/7a158300_3fbec5f2
PS5, Line 11: using the newly added parts
That’s redundant.
https://review.coreboot.org/c/coreboot/+/73489/comment/65ac4123_cabf9740
PS5, Line 11: SoC
the SoC
File spd/lp5/memory_parts.json:
https://review.coreboot.org/c/coreboot/+/73489/comment/b816d0cc_f6bfd774
PS5, Line 222: {
Tabs and spaces seem to be mixed. Maybe add a commit before fixing this for the old entries too.
--
To view, visit https://review.coreboot.org/c/coreboot/+/73489
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6675a68b7a515bd6d21db3ea2da762b06dee017a
Gerrit-Change-Number: 73489
Gerrit-PatchSet: 5
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rex Chou <rex_chou(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Tue, 07 Mar 2023 06:44:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Praveen Kumar Bairi has uploaded a new patch set (#2) to the change originally created by Sudheer Amrabadi. ( https://review.coreboot.org/c/qc_blobs/+/73458 )
Change subject: sc7180/boot: Update qclib blobs binaries from 50 to 53 Analysis: The changes are pushed to address issue @ https://partnerissuetracker.corp.google.com/issues/26738786.
......................................................................
sc7180/boot: Update qclib blobs binaries from 50 to 53
Analysis: The changes are pushed to address issue @ https://partnerissuetracker.corp.google.com/issues/26738786.
TEST=Validated on qualcomm sc7180 development board
Signed-off-by: Sudheer Kumar Amrabadi <samrabad(a)codeaurora.org>
Change-Id: Id70415361d2de5a2c8e7d215f95675e93a670962
---
M sc7180/boot/QcLib.elf
M sc7180/boot/Release_Notes.txt
2 files changed, 35 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/qc_blobs refs/changes/58/73458/2
--
To view, visit https://review.coreboot.org/c/qc_blobs/+/73458
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: qc_blobs
Gerrit-Branch: master
Gerrit-Change-Id: Id70415361d2de5a2c8e7d215f95675e93a670962
Gerrit-Change-Number: 73458
Gerrit-PatchSet: 2
Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Frank Wu, Dtrain Hsu, Jason Nien, Eric Lai, Martin Roth.
Hello Frank Wu, build bot (Jenkins), Dtrain Hsu, Jason Nien, Eric Lai, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/73510
to look at the new patch set (#3).
Change subject: mb/google/skyrim/var/markarth: Update RAM ID table
......................................................................
mb/google/skyrim/var/markarth: Update RAM ID table
Add new ram_id:0011 for micron MT62F1G32D2DS-023 WT:B.
Add new ram_id:0100 for micron MT62F2G32D4DS-023 WT:B.
DRAM Part Name ID to assign
K3KL8L80CM-MGCT 0 (0000)
H58G56BK7BX068 0 (0000)
MT62F1G32D2DS-026 WT:B 0 (0000)
K3KL9L90CM-MGCT 1 (0001)
H58G66BK7BX067 1 (0001)
MT62F2G32D4DS-026 WT:B 1 (0001)
MT62F512M32D2DR-031 WT:B 2 (0010)
H58G56BK8BX068 3 (0011)
MT62F1G32D2DS-023 WT:B 3 (0011)
H58G66BK8BX067 4 (0100)
MT62F2G32D4DS-023 WT:B 4 (0100)
BUG=b:271188237
BRANCH=None
TEST=FW_NAME=markarth emerge-skyrim coreboot
Change-Id: I59a6a6dff249cd4fe982a4de824848f1bac0ecba
Signed-off-by: John Su <john_su(a)compal.corp-partner.google.com>
---
M src/mainboard/google/skyrim/variants/markarth/memory/Makefile.inc
M src/mainboard/google/skyrim/variants/markarth/memory/dram_id.generated.txt
M src/mainboard/google/skyrim/variants/markarth/memory/mem_parts_used.txt
3 files changed, 36 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/73510/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/73510
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59a6a6dff249cd4fe982a4de824848f1bac0ecba
Gerrit-Change-Number: 73510
Gerrit-PatchSet: 3
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-CC: Rex Chou <rex_chou(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Frank Wu, John Su, Dtrain Hsu, Eric Lai, Karthik Ramasubramanian.
Hello Frank Wu, build bot (Jenkins), Subrata Banik, Dtrain Hsu, Eric Lai, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/73489
to look at the new patch set (#5).
Change subject: spd/lp5: Add new memory part to LP5 list
......................................................................
spd/lp5: Add new memory part to LP5 list
Add MICRON memory part MT62F1G32D2DS-023 and MT62F2G32D4DS-023 to LP5
global list. Attributes are derived from data sheets. Also, regenerate
the SPD files for SoC using the newly added parts.
BUG=b:271188237
TEST=util/spd_tools/bin/spd_gen spd/lp5/memory_parts.json lp5
Change-Id: I6675a68b7a515bd6d21db3ea2da762b06dee017a
Signed-off-by: John Su <john_su(a)compal.corp-partner.google.com>
---
M spd/lp5/memory_parts.json
M spd/lp5/set-0/parts_spd_manifest.generated.txt
M spd/lp5/set-1/parts_spd_manifest.generated.txt
3 files changed, 43 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/73489/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/73489
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6675a68b7a515bd6d21db3ea2da762b06dee017a
Gerrit-Change-Number: 73489
Gerrit-PatchSet: 5
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-CC: Rex Chou <rex_chou(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset