coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[S] Change in coreboot[master]: arch/x86/include/cpu: introduce CPUID_FROM_FMS macro
by Fred Reitberger (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72856 ) Change subject: arch/x86/include/cpu: introduce CPUID_FROM_FMS macro ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idab77453712b14983b1d02ca365f7924239fc2bf Gerrit-Change-Number: 72856 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 07 Feb 2023 15:28:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Remove unsupported hybrid_storage_mode config
by Sridhar Siricilla (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Tarun Tuli, Paul Menzel. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72871 ) Change subject: soc/intel/meteorlake: Remove unsupported hybrid_storage_mode config ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/72871/comment/2285d0a7_ec76713f PS1, Line 7: soc/intel/meteorlake: Update soc_intel_meteorlake_config structure > Ack Done https://review.coreboot.org/c/coreboot/+/72871/comment/71baecdb_4505c6c0 PS1, Line 10: since hybrid storage is no longer : supported on Meteor Lake platform > Please refer Intel announcement @ https://www.intel. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/72871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40ec3775b827ab6e1ebd4778c6c8e13eac1944e5 Gerrit-Change-Number: 72871 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 07 Feb 2023 15:23:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Remove unsupported hybrid_storage_mode config
by Sridhar Siricilla (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Tarun Tuli, Paul Menzel. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72871 to look at the new patch set (#2). Change subject: soc/intel/meteorlake: Remove unsupported hybrid_storage_mode config ...................................................................... soc/intel/meteorlake: Remove unsupported hybrid_storage_mode config The patch removes hybrid_storage_mode variable from soc_intel_meteorlake_config struct since hybrid storage is no longer supported on Meteor Lake platform. TEST=Verify the build for Rex board Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: I40ec3775b827ab6e1ebd4778c6c8e13eac1944e5 --- M src/soc/intel/meteorlake/chip.h 1 file changed, 16 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/72871/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40ec3775b827ab6e1ebd4778c6c8e13eac1944e5 Gerrit-Change-Number: 72871 Gerrit-PatchSet: 2 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Update soc_intel_meteorlake_config structure
by Sridhar Siricilla (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Tarun Tuli, Paul Menzel. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72871 ) Change subject: soc/intel/meteorlake: Update soc_intel_meteorlake_config structure ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/72871/comment/4e455e65_17b6e673 PS1, Line 7: soc/intel/meteorlake: Update soc_intel_meteorlake_config structure > Please be more specific. Maybe: […] Ack https://review.coreboot.org/c/coreboot/+/72871/comment/85ce2d86_1ac90356 PS1, Line 10: since hybrid storage is no longer : supported on Meteor Lake platform > What is the source for that statement? Please refer Intel announcement @ https://www.intel.in/content/www/in/en/support/articles/000057951/memory-an… -- To view, visit https://review.coreboot.org/c/coreboot/+/72871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40ec3775b827ab6e1ebd4778c6c8e13eac1944e5 Gerrit-Change-Number: 72871 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 07 Feb 2023 15:18:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/stoneyridge/cpu: use CPUID_ALL_STEPPINGS_MASK
by Fred Reitberger (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Matt DeVillier, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72855 ) Change subject: soc/amd/stoneyridge/cpu: use CPUID_ALL_STEPPINGS_MASK ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72855 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id05f849d59c04efa9f38dd66892f3cb99d94e3ff Gerrit-Change-Number: 72855 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 07 Feb 2023 15:13:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/intel/model_206ax/model_206ax_init: use CPUID_ALL_STEPPINGS_MASK
by Fred Reitberger (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72854 ) Change subject: cpu/intel/model_206ax/model_206ax_init: use CPUID_ALL_STEPPINGS_MASK ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46020d5b1b1fba8449c3823fac1369e5670d91c0 Gerrit-Change-Number: 72854 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 07 Feb 2023 15:10:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/x86/include/cpu: retype device field in cpu_device_id
by Fred Reitberger (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72846 ) Change subject: arch/x86/include/cpu: retype device field in cpu_device_id ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72846 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic54f73dcd3496a5ad85291b9b9586bc740b734d5 Gerrit-Change-Number: 72846 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 07 Feb 2023 15:05:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/x86/include/cpu: retype device field in cpu_device_id
by Felix Held (Code Review) 07 Feb '23

07 Feb '23

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72846 to look at the new patch set (#3). Change subject: arch/x86/include/cpu: retype device field in cpu_device_id ...................................................................... arch/x86/include/cpu: retype device field in cpu_device_id Use a more specific type in preparation for using bit masks on this field in the next patch. Since uint32_t is a typedef of unsigned int, this won't change behavior. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ic54f73dcd3496a5ad85291b9b9586bc740b734d5 --- M src/arch/x86/include/arch/cpu.h 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/72846/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/72846 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic54f73dcd3496a5ad85291b9b9586bc740b734d5 Gerrit-Change-Number: 72846 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/amd/phoenix/include/cpu: add Phoenix CPUID
by Fred Reitberger (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Jason Glenesk, Matt DeVillier, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72853 ) Change subject: soc/amd/phoenix/include/cpu: add Phoenix CPUID ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72853 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4eb3502dec5ebdfdbba263b15b34621952d0554 Gerrit-Change-Number: 72853 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 07 Feb 2023 15:04:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/glinda/cpu: use CPUID_ALL_STEPPINGS_MASK
by Fred Reitberger (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72852 ) Change subject: soc/amd/glinda/cpu: use CPUID_ALL_STEPPINGS_MASK ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72852 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9b8cbb2dc925a8258db6a4eb0d1b00b2745637f Gerrit-Change-Number: 72852 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 07 Feb 2023 15:03:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023