Attention is currently required from: Mike Banon, Patrick Georgi.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79264?usp=email )
Change subject: util/kconfig: Import some more of Linux's build infra
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79264?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie16ef31a8e0137f3fd4129fb73ca6ef4669173cc
Gerrit-Change-Number: 79264
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Comment-Date: Sun, 26 Nov 2023 23:47:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79232?usp=email )
Change subject: doc/releases/4.22: Replace unicode chars with ASCII
......................................................................
doc/releases/4.22: Replace unicode chars with ASCII
Change-Id: I0b8419a8ad01d711362733e02ace89c48d2893b2
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79232
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M Documentation/releases/coreboot-4.22-relnotes.md
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
build bot (Jenkins): Verified
Nicholas Chin: Looks good to me, approved
diff --git a/Documentation/releases/coreboot-4.22-relnotes.md b/Documentation/releases/coreboot-4.22-relnotes.md
index ff978c2..4cd0991 100644
--- a/Documentation/releases/coreboot-4.22-relnotes.md
+++ b/Documentation/releases/coreboot-4.22-relnotes.md
@@ -29,14 +29,14 @@
Year.Month.Sub-version naming scheme. As such, the next release,
scheduled for February of 2024 will be numbered 24.02, with the
sub-version of 00 implied. If we need to do a fix or future release of
-the 24.02 release, we’ll append the values .01, .02 and so on to the
+the 24.02 release, we'll append the values .01, .02 and so on to the
initial release value.
### coreboot default branch update
Immediately after the 4.21 release, the coreboot project changed the
-default git branch from ‘master’ to ‘main’. For the first couple of
+default git branch from 'master' to 'main'. For the first couple of
months after the change, The master branch was synced with the main
branch several times a day, allowing people time to update any scripts.
As of 2023-11-01, the sync rate has slowed to once a week. This will
@@ -166,7 +166,7 @@
Additional coreboot changes
---------------------------
-* Move all ‘select’ statements from Kconfig.name files to Kconfig
+* Move all 'select' statements from Kconfig.name files to Kconfig
* acpigen now generates variable-length PkgLength fields instead of a
fixed 3-byte size to improve compatibility and to bring it in line
with IASL
--
To view, visit https://review.coreboot.org/c/coreboot/+/79232?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0b8419a8ad01d711362733e02ace89c48d2893b2
Gerrit-Change-Number: 79232
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Mike Banon, Patrick Georgi.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79264?usp=email )
Change subject: util/kconfig: Import some more of Linux's build infra
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79264?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie16ef31a8e0137f3fd4129fb73ca6ef4669173cc
Gerrit-Change-Number: 79264
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Comment-Date: Sun, 26 Nov 2023 20:38:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Mike Banon, Patrick Georgi.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79264?usp=email )
Change subject: util/kconfig: Import some more of Linux's build infra
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79264?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie16ef31a8e0137f3fd4129fb73ca6ef4669173cc
Gerrit-Change-Number: 79264
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Sun, 26 Nov 2023 20:04:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Balázs Vinarz, HacX Scedix, Kyösti Mälkki, Martin L Roth, Paul Menzel, Vlado Ilic, awokd(a)danwin1210.me.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76832?usp=email )
Change subject: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
Behold: new restore_agesa.sh delivers coreboot 4.22.01 to Lenovo G505S - boots fine! - and to other AMD AGESA boards which I didn't have the opportunity to test yet ;-)
https://review.coreboot.org/c/coreboot/+/76832
--
To view, visit https://review.coreboot.org/c/coreboot/+/76832?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4658dcaf4ff6fbac36070529284f2c982ed73c3
Gerrit-Change-Number: 76832
Gerrit-PatchSet: 7
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Reviewer: HacX Scedix <oblongs.figure-0z(a)icloud.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Vlado Ilic <kakonema(a)gmail.com>
Gerrit-Reviewer: awokd(a)danwin1210.me
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: HacX Scedix <oblongs.figure-0z(a)icloud.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: awokd(a)danwin1210.me
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Attention: Vlado Ilic <kakonema(a)gmail.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Sun, 26 Nov 2023 19:45:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Balázs Vinarz, HacX Scedix, Kyösti Mälkki, Martin L Roth, Mike Banon, Paul Menzel, Vlado Ilic, awokd(a)danwin1210.me.
Hello Balázs Vinarz, HacX Scedix, Martin L Roth, Paul Menzel, Vlado Ilic, awokd(a)danwin1210.me, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76832?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
......................................................................
util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
restore_agesa.sh reverts the opensource AGESA AMD boards removal that happened
after 5e8e911b7caee021faff96c4e82a77a42544ea62 (0 point of history, or 0 PoH)
- by git-reverting:
1) the "bad commits" (marked as "CBF" = coreboot build failure)
- that either remove or break a code needed for our boards
2) the "unlucky commits" (marked as "GRF" = git revert failure)
- that are a roadblock for git-reverting the "bad commits"
Right now at 786292a0fca78405d56afb3f97a88f17f1c4bd32 (5166 PoH), it takes
41 CBF git reverts - just 1% of 5166 commits since the OSS AGESA removal! -
- making this removal look questionable and the idea of restoration viable.
SUCCESSFUL TESTS for the opensource AGESA boards which I own (Lenovo G505S -
- fam15 laptop, ASUS A88XM-E - fam15 desktop, ASUS AM1I-A - fam16 desktop):
1) only build:
69ffebf5ccf123bc0b3fb28b485985af0597761d (3698 PoH) for AM1I-A,
most likely boot works too but I didn't have the time to test
2) build & boot:
786292a0fca78405d56afb3f97a88f17f1c4bd32 (5166 PoH) for G505S test only,
11ba8ebbcc662ebd1dc8e14372a020eb32f26561 (3741 PoH) for G505S test only,
69ffebf5ccf123bc0b3fb28b485985af0597761d (3698 PoH) for G505S and A88XM-E
Change-Id: Ib4658dcaf4ff6fbac36070529284f2c982ed73c3
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
---
A util/scripts/restore_agesa.sh
1 file changed, 234 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/76832/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/76832?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4658dcaf4ff6fbac36070529284f2c982ed73c3
Gerrit-Change-Number: 76832
Gerrit-PatchSet: 7
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Reviewer: HacX Scedix <oblongs.figure-0z(a)icloud.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Vlado Ilic <kakonema(a)gmail.com>
Gerrit-Reviewer: awokd(a)danwin1210.me
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: HacX Scedix <oblongs.figure-0z(a)icloud.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: awokd(a)danwin1210.me
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Vlado Ilic <kakonema(a)gmail.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth, Mike Banon, Patrick Georgi.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79264?usp=email )
Change subject: util/kconfig: Import some more of Linux's build infra
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/79264?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie16ef31a8e0137f3fd4129fb73ca6ef4669173cc
Gerrit-Change-Number: 79264
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Sun, 26 Nov 2023 19:27:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Mike Banon, Patrick Georgi.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79264?usp=email )
Change subject: util/kconfig: Import some more of Linux's build infra
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
This change successfully fixes the error mentioned at [1] for menuconfig (nconfig works too), didn't check the code to be honest - but it seems to work...
[1] https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/GRPW…
( /usr/bin/ld: build/util/kconfig/lxdialog/yesno.o: warning: relocation
against `acs_map' in read-only section `.text'
/usr/bin/ld: build/util/kconfig/mconf.o: in function `show_help':
mconf.c:(.text+0x1770): undefined reference to `stdscr'
/usr/bin/ld: mconf.c:(.text+0x177c): undefined reference to `stdscr'
/usr/bin/ld: build/util/kconfig/lxdialog/checklist.o: in function `print_item':
checklist.c:(.text+0x82): undefined reference to `wattrset'
/usr/bin/ld: checklist.c:(.text+0x98): undefined reference to `wmove'
/usr/bin/ld: checklist.c:(.text+0xb2): undefined reference to `waddch'
/usr/bin/ld: checklist.c:(.text+0xd8): undefined reference to `wmove'
/usr/bin/ld: checklist.c:(.text+0xfe): undefined reference to `wattrset'
... )
--
To view, visit https://review.coreboot.org/c/coreboot/+/79264?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie16ef31a8e0137f3fd4129fb73ca6ef4669173cc
Gerrit-Change-Number: 79264
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Sun, 26 Nov 2023 18:48:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79264?usp=email )
Change subject: util/kconfig: Import some more of Linux's build infra
......................................................................
util/kconfig: Import some more of Linux's build infra
cmd and cmd_conf_cfg are necessary for `make menuconfig`
and `make nconfig`.
Change-Id: Ie16ef31a8e0137f3fd4129fb73ca6ef4669173cc
Signed-off-by: Patrick Georgi <patrick(a)georgi.software>
---
M util/kconfig/Makefile.inc
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/79264/1
diff --git a/util/kconfig/Makefile.inc b/util/kconfig/Makefile.inc
index 0614bb0..3a9f353 100644
--- a/util/kconfig/Makefile.inc
+++ b/util/kconfig/Makefile.inc
@@ -25,6 +25,9 @@
kecho := echo
+cmd = $(cmd_$(1))
+cmd_conf_cfg = $< $(addprefix $(obj)/$*conf-, cflags libs bin); touch $(obj)/$*conf-bin
+
###
# Read a file, replacing newlines with spaces
#
--
To view, visit https://review.coreboot.org/c/coreboot/+/79264?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie16ef31a8e0137f3fd4129fb73ca6ef4669173cc
Gerrit-Change-Number: 79264
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-MessageType: newchange