coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[XS] Change in coreboot[main]: configs: Rename UART_DEBUG to INTEL_LPSS_UART_FOR_CONSOLE
by Patrick Georgi (Code Review) 25 Nov '23

25 Nov '23

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79256?usp=email ) Change subject: configs: Rename UART_DEBUG to INTEL_LPSS_UART_FOR_CONSOLE ...................................................................... configs: Rename UART_DEBUG to INTEL_LPSS_UART_FOR_CONSOLE This follows commit a96e66a76f2 which did the rename across the tree except here. Since Kconfig is going to become more strict about unknown symbols, fix it. Change-Id: I3b855085d4be13622e8f38ff651d576e719b682c Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79256 Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M configs/config.google_meep_cros 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Arthur Heymans: Looks good to me, approved build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/configs/config.google_meep_cros b/configs/config.google_meep_cros index c8e3227..5dfd8e3 100644 --- a/configs/config.google_meep_cros +++ b/configs/config.google_meep_cros @@ -33,5 +33,5 @@ CONFIG_CONSOLE_SERIAL_115200=y # CONFIG_DRIVERS_UART_8250IO is not set # GLK specific setting to auto select all the correct settings. -CONFIG_UART_DEBUG=y +CONFIG_INTEL_LPSS_UART_FOR_CONSOLE=y CONFIG_NO_BOOTBLOCK_CONSOLE=y -- To view, visit https://review.coreboot.org/c/coreboot/+/79256?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3b855085d4be13622e8f38ff651d576e719b682c Gerrit-Change-Number: 79256 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: configs: Drop references to MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN
by Patrick Georgi (Code Review) 25 Nov '23

25 Nov '23

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79255?usp=email ) Change subject: configs: Drop references to MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN ...................................................................... configs: Drop references to MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN This follows commit 6615c6eaf79 which removed the symbol. Since Kconfig is going to become more strict about unknown symbols, fix it. Change-Id: I7b7f2e4c0774919a55083f7c5348f2b5031c8287 Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79255 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M configs/config.google_meep_cros 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Felix Singer: Looks good to me, approved diff --git a/configs/config.google_meep_cros b/configs/config.google_meep_cros index 97e23fd..c8e3227 100644 --- a/configs/config.google_meep_cros +++ b/configs/config.google_meep_cros @@ -10,7 +10,6 @@ # ChromeOS CONFIG_CHROMEOS=y CONFIG_HAS_RECOVERY_MRC_CACHE=y -CONFIG_MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN=y # Event Logging CONFIG_CMOS_POST=y -- To view, visit https://review.coreboot.org/c/coreboot/+/79255?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7b7f2e4c0774919a55083f7c5348f2b5031c8287 Gerrit-Change-Number: 79255 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: configs: Drop references to CPU_QEMU_X86_SMMLOADERV2
by Patrick Georgi (Code Review) 25 Nov '23

25 Nov '23

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79254?usp=email ) Change subject: configs: Drop references to CPU_QEMU_X86_SMMLOADERV2 ...................................................................... configs: Drop references to CPU_QEMU_X86_SMMLOADERV2 This follows commit 88407bcd which removed the symbol. Since Kconfig is going to become more strict about unknown symbols, fix it. Change-Id: I19d26de8003c51437ea62e04083a14c3587a4665 Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79254 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M configs/config.emulation_qemu_x86_q35_smm_tseg 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Arthur Heymans: Looks good to me, approved diff --git a/configs/config.emulation_qemu_x86_q35_smm_tseg b/configs/config.emulation_qemu_x86_q35_smm_tseg index 4b3e6e5..0ec233b 100644 --- a/configs/config.emulation_qemu_x86_q35_smm_tseg +++ b/configs/config.emulation_qemu_x86_q35_smm_tseg @@ -1,4 +1,3 @@ CONFIG_VENDOR_EMULATION=y CONFIG_BOARD_EMULATION_QEMU_X86_Q35=y CONFIG_CPU_QEMU_X86_TSEG_SMM=y -CONFIG_CPU_QEMU_X86_SMMLOADERV2=y -- To view, visit https://review.coreboot.org/c/coreboot/+/79254?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I19d26de8003c51437ea62e04083a14c3587a4665 Gerrit-Change-Number: 79254 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: configs: Drop references to CPU_QEMU_X86_PARALLEL_MP
by Patrick Georgi (Code Review) 25 Nov '23

25 Nov '23

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79253?usp=email ) Change subject: configs: Drop references to CPU_QEMU_X86_PARALLEL_MP ...................................................................... configs: Drop references to CPU_QEMU_X86_PARALLEL_MP This follows commit e2d291b5 which removed the symbol. Since Kconfig is going to become more strict about unknown symbols, fix it. Change-Id: I838f98d07fc0448dda6c02b58d7c5639992c77a2 Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79253 Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M configs/config.emulation_qemu_x86_i440fx_debug M configs/config.emulation_qemu_x86_q35_smm_tseg 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: Arthur Heymans: Looks good to me, approved build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/configs/config.emulation_qemu_x86_i440fx_debug b/configs/config.emulation_qemu_x86_i440fx_debug index 3cff033..85f5499 100644 --- a/configs/config.emulation_qemu_x86_i440fx_debug +++ b/configs/config.emulation_qemu_x86_i440fx_debug @@ -8,4 +8,3 @@ CONFIG_DEBUG_MALLOC=y CONFIG_DEBUG_BOOT_STATE=y CONFIG_DEBUG_ADA_CODE=y -CONFIG_CPU_QEMU_X86_PARALLEL_MP=y diff --git a/configs/config.emulation_qemu_x86_q35_smm_tseg b/configs/config.emulation_qemu_x86_q35_smm_tseg index 6d64715..4b3e6e5 100644 --- a/configs/config.emulation_qemu_x86_q35_smm_tseg +++ b/configs/config.emulation_qemu_x86_q35_smm_tseg @@ -1,5 +1,4 @@ CONFIG_VENDOR_EMULATION=y CONFIG_BOARD_EMULATION_QEMU_X86_Q35=y -CONFIG_CPU_QEMU_X86_PARALLEL_MP=y CONFIG_CPU_QEMU_X86_TSEG_SMM=y CONFIG_CPU_QEMU_X86_SMMLOADERV2=y -- To view, visit https://review.coreboot.org/c/coreboot/+/79253?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I838f98d07fc0448dda6c02b58d7c5639992c77a2 Gerrit-Change-Number: 79253 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: configs: Rename PXE_SERIAL_CONSOLE to IPXE_SERIAL_CONSOLE
by Patrick Georgi (Code Review) 25 Nov '23

25 Nov '23

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79252?usp=email ) Change subject: configs: Rename PXE_SERIAL_CONSOLE to IPXE_SERIAL_CONSOLE ...................................................................... configs: Rename PXE_SERIAL_CONSOLE to IPXE_SERIAL_CONSOLE This follows commit 238ff1e9c which did the rename across the tree except here. Since Kconfig is going to become more strict about unknown symbols, fix it. Change-Id: Ic31b8ae353ec07e8b8adab46b604365be4be44d9 Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79252 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M configs/config.pcengines_apu1 M configs/config.pcengines_apu2 M configs/config.pcengines_apu3 M configs/config.pcengines_apu4 M configs/config.pcengines_apu5 5 files changed, 5 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Felix Singer: Looks good to me, approved diff --git a/configs/config.pcengines_apu1 b/configs/config.pcengines_apu1 index e511d65..a3e34b8 100644 --- a/configs/config.pcengines_apu1 +++ b/configs/config.pcengines_apu1 @@ -6,5 +6,5 @@ CONFIG_PXE=y CONFIG_BUILD_IPXE=y CONFIG_PXE_ROM_ID="10ec,8168" -# CONFIG_PXE_SERIAL_CONSOLE is not set +# CONFIG_IPXE_SERIAL_CONSOLE is not set CONFIG_MEMTEST_SECONDARY_PAYLOAD=y diff --git a/configs/config.pcengines_apu2 b/configs/config.pcengines_apu2 index 08d4d4e..fe0a9d7 100644 --- a/configs/config.pcengines_apu2 +++ b/configs/config.pcengines_apu2 @@ -8,5 +8,5 @@ CONFIG_PXE=y CONFIG_BUILD_IPXE=y CONFIG_PXE_ROM_ID="8086,157b" -# CONFIG_PXE_SERIAL_CONSOLE is not set +# CONFIG_IPXE_SERIAL_CONSOLE is not set CONFIG_MEMTEST_SECONDARY_PAYLOAD=y diff --git a/configs/config.pcengines_apu3 b/configs/config.pcengines_apu3 index 7acf014..bf37715 100644 --- a/configs/config.pcengines_apu3 +++ b/configs/config.pcengines_apu3 @@ -8,5 +8,5 @@ CONFIG_PXE=y CONFIG_BUILD_IPXE=y CONFIG_PXE_ROM_ID="8086,1539" -# CONFIG_PXE_SERIAL_CONSOLE is not set +# CONFIG_IPXE_SERIAL_CONSOLE is not set CONFIG_MEMTEST_SECONDARY_PAYLOAD=y diff --git a/configs/config.pcengines_apu4 b/configs/config.pcengines_apu4 index 9e7ca5a..17db794 100644 --- a/configs/config.pcengines_apu4 +++ b/configs/config.pcengines_apu4 @@ -8,5 +8,5 @@ CONFIG_PXE=y CONFIG_BUILD_IPXE=y CONFIG_PXE_ROM_ID="8086,1539" -# CONFIG_PXE_SERIAL_CONSOLE is not set +# CONFIG_IPXE_SERIAL_CONSOLE is not set CONFIG_MEMTEST_SECONDARY_PAYLOAD=y diff --git a/configs/config.pcengines_apu5 b/configs/config.pcengines_apu5 index e5ddcee..b004e89 100644 --- a/configs/config.pcengines_apu5 +++ b/configs/config.pcengines_apu5 @@ -8,5 +8,5 @@ CONFIG_PXE=y CONFIG_BUILD_IPXE=y CONFIG_PXE_ROM_ID="8086,1539" -# CONFIG_PXE_SERIAL_CONSOLE is not set +# CONFIG_IPXE_SERIAL_CONSOLE is not set CONFIG_MEMTEST_SECONDARY_PAYLOAD=y -- To view, visit https://review.coreboot.org/c/coreboot/+/79252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic31b8ae353ec07e8b8adab46b604365be4be44d9 Gerrit-Change-Number: 79252 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: Docs/releases: Finalize 4.22/4.22.01 release notes
by Martin L Roth (Code Review) 25 Nov '23

25 Nov '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79147?usp=email ) Change subject: Docs/releases: Finalize 4.22/4.22.01 release notes ...................................................................... Docs/releases: Finalize 4.22/4.22.01 release notes Now that the 4.22 release tag has been added to git, update the release notes with the final statistics and wording. We also decided to add a fix submitted immediately after the 4.22 release was tagged into the release package and do a point release. This also adds an expected date for the next release Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Iae9653a275fcc1d11efbb88e12676f332be0a5dc Reviewed-on: https://review.coreboot.org/c/coreboot/+/79147 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M Documentation/releases/coreboot-4.22-relnotes.md 1 file changed, 22 insertions(+), 11 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/Documentation/releases/coreboot-4.22-relnotes.md b/Documentation/releases/coreboot-4.22-relnotes.md index e32607a..ff978c2 100644 --- a/Documentation/releases/coreboot-4.22-relnotes.md +++ b/Documentation/releases/coreboot-4.22-relnotes.md @@ -1,7 +1,7 @@ -Upcoming release - coreboot 4.22 +coreboot 4.22 & 4.22.01 releases ======================================================================== -The next release is planned for mid-February, 2024 +The next release is planned for the 19th of February, 2024 These notes cover the latest updates and improvements to coreboot over the past three months. A big thank you to the returning contributors as @@ -11,6 +11,17 @@ security enhancements, and expanding hardware support. +### 4.22.01 release + +The week between tagging a release and announcing it publicly is used +to test the tagged version and make sure everything is working as we +expect. This is done instead of freezing the tree and doing release +candidates before the release. + +For the 4.22 release cycle we found an uninitialized variable error on +the sandybridge/ivybridge platforms and rolled that into the 4.22.01 +release package. + ### coreboot version naming update This release is the last release to use the incrementing 4.xx release @@ -235,15 +246,15 @@ Statistics from the 4.21 to the 4.22 release -------------------------------------------- -* Total Commits: 885 -* Average Commits per day: 10.72 -* Total lines added: 58276 -* Average lines added per commit: 65.85 -* Number of patches adding more than 100 lines: 54 -* Average lines added per small commit: 37.77 -* Total lines removed: 27790 -* Average lines removed per commit: 31.40 -* Total difference between added and removed: 30486 +* Total Commits: 977 +* Average Commits per day: 10.98 +* Total lines added: 62993 +* Average lines added per commit: 64.48 +* Number of patches adding more than 100 lines: 60 +* Average lines added per small commit: 37.55 +* Total lines removed: 30042 +* Average lines removed per commit: 30.75 +* Total difference between added and removed: 32951 * Total authors: 135 * New authors: 14 -- To view, visit https://review.coreboot.org/c/coreboot/+/79147?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae9653a275fcc1d11efbb88e12676f332be0a5dc Gerrit-Change-Number: 79147 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XL] Change in coreboot[main]: Revert "util/crossgcc: Update gcc to 11.2"
by Martin L Roth (Code Review) 25 Nov '23

25 Nov '23

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/59636?usp=email ) Change subject: Revert "util/crossgcc: Update gcc to 11.2" ...................................................................... Abandoned These patches aren't for merge, so move them to an abandoned state. They can always be brought back to be rebased on the main branch. -- To view, visit https://review.coreboot.org/c/coreboot/+/59636?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I09a789f9ccb284ac7cad32b12bbf60ecb82efb44 Gerrit-Change-Number: 59636 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: Revert "crossgcc/buildgcc: Remove unused GCC_AUTOCONF_VERSION"
by Martin L Roth (Code Review) 25 Nov '23

25 Nov '23

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/63679?usp=email ) Change subject: Revert "crossgcc/buildgcc: Remove unused GCC_AUTOCONF_VERSION" ...................................................................... Abandoned These patches aren't for merge, so move them to an abandoned state. They can always be brought back to be rebased on the main branch. -- To view, visit https://review.coreboot.org/c/coreboot/+/63679?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0bc6772fc68ce8997c463e67ccfa8a911c076b94 Gerrit-Change-Number: 63679 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[L] Change in coreboot[main]: crossgcc: Upgrade GCC from 11.4.0 to 13.2.0
by Martin L Roth (Code Review) 25 Nov '23

25 Nov '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/70771?usp=email ) Change subject: crossgcc: Upgrade GCC from 11.4.0 to 13.2.0 ...................................................................... crossgcc: Upgrade GCC from 11.4.0 to 13.2.0 Changelogs: * https://gcc.gnu.org/gcc-12/changes.html * https://gcc.gnu.org/gcc-13/changes.html Porting guides: * https://gcc.gnu.org/gcc-12/porting_to.html * https://gcc.gnu.org/gcc-13/porting_to.html Change-Id: I4f2ed4de4811abaa13528906de71eee29a8f2910 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Signed-off-by: Nico Huber <nico.h(a)gmx.de> Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/70771 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-11.4.0_ada-musl_workaround.patch D util/crossgcc/patches/gcc-11.4.0_gnat.patch R util/crossgcc/patches/gcc-13.2.0_asan_shadow_offset_callback.patch A util/crossgcc/patches/gcc-13.2.0_gnat.patch R util/crossgcc/patches/gcc-13.2.0_libcpp.patch R util/crossgcc/patches/gcc-13.2.0_libgcc.patch A util/crossgcc/patches/gcc-13.2.0_musl_poisoned_calloc.patch R util/crossgcc/patches/gcc-13.2.0_rv32iafc.patch D util/crossgcc/sum/gcc-11.4.0.tar.xz.cksum A util/crossgcc/sum/gcc-13.2.0.tar.xz.cksum 11 files changed, 238 insertions(+), 169 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 8de6d69..23a5caf 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -38,7 +38,7 @@ GMP_VERSION=6.3.0 MPFR_VERSION=4.2.1 MPC_VERSION=1.3.1 -GCC_VERSION=11.4.0 +GCC_VERSION=13.2.0 BINUTILS_VERSION=2.41 IASL_VERSION="R06_28_23" # CLANG version number diff --git a/util/crossgcc/patches/gcc-11.4.0_ada-musl_workaround.patch b/util/crossgcc/patches/gcc-11.4.0_ada-musl_workaround.patch deleted file mode 100644 index 1f504a4..0000000 --- a/util/crossgcc/patches/gcc-11.4.0_ada-musl_workaround.patch +++ /dev/null @@ -1,120 +0,0 @@ -diff --git a/gcc/ada/adaint.c b/gcc/ada/adaint.c -index 3b0aea92c05..998f2c66289 100644 ---- a/gcc/ada/adaint.c -+++ b/gcc/ada/adaint.c -@@ -107,6 +107,15 @@ - #define xmalloc(S) malloc (S) - #define xrealloc(V,S) realloc (V,S) - #else -+#if !defined(__ANDROID__) && defined(__linux__) -+#ifdef __cplusplus -+extern "C" { -+#endif -+#include <sched.h> -+#ifdef __cplusplus -+} -+#endif -+#endif - #include "config.h" - #include "system.h" - #include "version.h" -@@ -3265,7 +3274,7 @@ __gnat_lwp_self (void) - - /* Dynamic cpu sets */ - --cpu_set_t * -+void * - __gnat_cpu_alloc (size_t count) - { - return CPU_ALLOC (count); -@@ -3278,33 +3287,33 @@ __gnat_cpu_alloc_size (size_t count) - } - - void --__gnat_cpu_free (cpu_set_t *set) -+__gnat_cpu_free (void *set) - { -- CPU_FREE (set); -+ CPU_FREE ((cpu_set_t *)set); - } - - void --__gnat_cpu_zero (size_t count, cpu_set_t *set) -+__gnat_cpu_zero (size_t count, void *set) - { - CPU_ZERO_S (count, set); - } - - void --__gnat_cpu_set (int cpu, size_t count, cpu_set_t *set) -+__gnat_cpu_set (int cpu, size_t count, void *set) - { - /* Ada handles CPU numbers starting from 1, while C identifies the first - CPU by a 0, so we need to adjust. */ -- CPU_SET_S (cpu - 1, count, set); -+ CPU_SET_S (cpu - 1, count, (cpu_set_t *)set); - } - - #else /* !CPU_ALLOC */ - - /* Static cpu sets */ - --cpu_set_t * -+void * - __gnat_cpu_alloc (size_t count ATTRIBUTE_UNUSED) - { -- return (cpu_set_t *) xmalloc (sizeof (cpu_set_t)); -+ return xmalloc (sizeof (cpu_set_t)); - } - - size_t -@@ -3314,23 +3323,23 @@ __gnat_cpu_alloc_size (size_t count ATTRIBUTE_UNUSED) - } - - void --__gnat_cpu_free (cpu_set_t *set) -+__gnat_cpu_free (void *set) - { - free (set); - } - - void --__gnat_cpu_zero (size_t count ATTRIBUTE_UNUSED, cpu_set_t *set) -+__gnat_cpu_zero (size_t count ATTRIBUTE_UNUSED, void *set) - { - CPU_ZERO (set); - } - - void --__gnat_cpu_set (int cpu, size_t count ATTRIBUTE_UNUSED, cpu_set_t *set) -+__gnat_cpu_set (int cpu, size_t count ATTRIBUTE_UNUSED, void *set) - { - /* Ada handles CPU numbers starting from 1, while C identifies the first - CPU by a 0, so we need to adjust. */ -- CPU_SET (cpu - 1, set); -+ CPU_SET (cpu - 1, (cpu_set_t *)set); - } - #endif /* !CPU_ALLOC */ - #endif /* __linux__ */ -diff --git a/gcc/ada/adaint.h b/gcc/ada/adaint.h -index 0d12f7e9020..7b3def03fb0 100644 ---- a/gcc/ada/adaint.h -+++ b/gcc/ada/adaint.h -@@ -316,13 +316,11 @@ extern void *__gnat_lwp_self (void); - - /* Routines for interface to required CPU set primitives */ - --#include <sched.h> -- --extern cpu_set_t *__gnat_cpu_alloc (size_t); -+extern void *__gnat_cpu_alloc (size_t); - extern size_t __gnat_cpu_alloc_size (size_t); --extern void __gnat_cpu_free (cpu_set_t *); --extern void __gnat_cpu_zero (size_t, cpu_set_t *); --extern void __gnat_cpu_set (int, size_t, cpu_set_t *); -+extern void __gnat_cpu_free (void *); -+extern void __gnat_cpu_zero (size_t, void *); -+extern void __gnat_cpu_set (int, size_t, void *); - #endif - - #if defined (_WIN32) diff --git a/util/crossgcc/patches/gcc-11.4.0_gnat.patch b/util/crossgcc/patches/gcc-11.4.0_gnat.patch deleted file mode 100644 index c22cec4..0000000 --- a/util/crossgcc/patches/gcc-11.4.0_gnat.patch +++ /dev/null @@ -1,41 +0,0 @@ ---- gcc-6.1.0/gcc/ada/gcc-interface/Make-lang.in.bak 2015-08-24 16:23:25.004493665 +0200 -+++ gcc-6.1.0/gcc/ada/gcc-interface/Make-lang.in 2015-08-24 17:53:52.496636113 +0200 -@@ -45,7 +45,7 @@ - - - # Extra flags to pass to recursive makes. --COMMON_ADAFLAGS= -gnatpg -+COMMON_ADAFLAGS= -gnatpg -gnatwn - ifeq ($(TREECHECKING),) - CHECKING_ADAFLAGS= - else -diff -Nurp gcc-11.2.0/gcc/ada/gcc-interface/Make-lang.in gcc-11.2.0.new/gcc/ada/gcc-interface/Make-lang.in ---- gcc-11.2.0/gcc/ada/gcc-interface/Make-lang.in 2022-06-03 00:31:57.993273717 +0200 -+++ gcc-11.2.0.new/gcc/ada/gcc-interface/Make-lang.in 2022-06-03 00:30:50.214166847 +0200 -@@ -334,6 +334,7 @@ GNAT_ADA_OBJS = \ - ada/hostparm.o \ - ada/impunit.o \ - ada/inline.o \ -+ ada/libgnat/i-c.o \ - ada/libgnat/interfac.o \ - ada/itypes.o \ - ada/krunch.o \ -@@ -364,7 +365,10 @@ GNAT_ADA_OBJS = \ - ada/rtsfind.o \ - ada/libgnat/s-addope.o \ - ada/libgnat/s-addima.o \ -+ ada/libgnat/s-aotase.o \ - ada/libgnat/s-assert.o \ -+ ada/libgnat/s-atoope.o \ -+ ada/libgnat/s-atopri.o \ - ada/libgnat/s-bitops.o \ - ada/libgnat/s-carun8.o \ - ada/libgnat/s-casuti.o \ -@@ -548,6 +552,7 @@ GNATBIND_OBJS = \ - ada/hostparm.o \ - ada/init.o \ - ada/initialize.o \ -+ ada/libgnat/i-c.o \ - ada/libgnat/interfac.o \ - ada/krunch.o \ - ada/lib.o \ diff --git a/util/crossgcc/patches/gcc-11.4.0_asan_shadow_offset_callback.patch b/util/crossgcc/patches/gcc-13.2.0_asan_shadow_offset_callback.patch similarity index 99% rename from util/crossgcc/patches/gcc-11.4.0_asan_shadow_offset_callback.patch rename to util/crossgcc/patches/gcc-13.2.0_asan_shadow_offset_callback.patch index 25963b3..d446025 100644 --- a/util/crossgcc/patches/gcc-11.4.0_asan_shadow_offset_callback.patch +++ b/util/crossgcc/patches/gcc-13.2.0_asan_shadow_offset_callback.patch @@ -35,8 +35,8 @@ diff --git a/gcc/asan.c b/gcc/asan.c index 235e21947..713bf994d 100644 ---- a/gcc/asan.c -+++ b/gcc/asan.c +--- a/gcc/asan.cc ++++ b/gcc/asan.cc @@ -1389,13 +1389,28 @@ asan_emit_stack_protection (rtx base, rtx pbase, unsigned int alignb, TREE_ASM_WRITTEN (decl) = 1; TREE_ASM_WRITTEN (id) = 1; diff --git a/util/crossgcc/patches/gcc-13.2.0_gnat.patch b/util/crossgcc/patches/gcc-13.2.0_gnat.patch new file mode 100644 index 0000000..2a37b15 --- /dev/null +++ b/util/crossgcc/patches/gcc-13.2.0_gnat.patch @@ -0,0 +1,108 @@ +From b1b16478729aea709e7ef81224995b6d26b38a87 Mon Sep 17 00:00:00 2001 +From: Nico Huber <nico.h(a)gmx.de> +Date: Sun, 16 Jul 2023 00:30:03 +0200 +Subject: [PATCH] GNAT: Build cross compilers with host runtime + +When building with an older host toolchain, the shipped libgnat +sources may not be compatible. So rely on the host runtime just +like we do for a stage1 build. + +Signed-off-by: Nico Huber <nico.h(a)gmx.de> +--- + gcc/ada/gcc-interface/Make-lang.in | 16 +++++++++++++--- + gcc/ada/init.c | 4 ++++ + 2 files changed, 17 insertions(+), 3 deletions(-) + +diff --git a/gcc/ada/gcc-interface/Make-lang.in b/gcc/ada/gcc-interface/Make-lang.in +index 9507f2f09203..cf7ec4cc1662 100644 +--- a/gcc/ada/gcc-interface/Make-lang.in ++++ b/gcc/ada/gcc-interface/Make-lang.in +@@ -57,18 +57,21 @@ WARN_ADAFLAGS= -W -Wall + # checks fully active. + + STAGE1=False ++HOST_RT=False + GNATBIND_FLAGS= + GNATLIB= + ++ADAFLAGS=$(COMMON_ADAFLAGS) -gnatwns + ifeq ($(CROSS),) +- ADAFLAGS=$(COMMON_ADAFLAGS) -gnatwns + + ifeq ($(if $(wildcard ../stage_current),$(shell cat ../stage_current),stage1),stage1) + STAGE1=True + GNATBIND_FLAGS=-t ++ HOST_RT=True + endif + else +- ADAFLAGS=$(COMMON_ADAFLAGS) ++ GNATBIND_FLAGS=-t ++ HOST_RT=True + endif + + ALL_ADAFLAGS = \ +@@ -87,7 +89,7 @@ ifeq ($(strip $(filter-out hpux%,$(host_os))),) + STAGE1_LIBS=/usr/lib/libcl.a + endif + +-ifeq ($(STAGE1),True) ++ifeq ($(HOST_RT),True) + ADA_INCLUDES=$(COMMON_ADA_INCLUDES) + adalib=$(dir $(shell $(CC) -print-libgcc-file-name))adalib + GNATLIB=$(adalib)/$(if $(wildcard $(adalib)/libgnat.a),libgnat.a,libgnat.so) $(STAGE1_LIBS) +@@ -485,6 +487,7 @@ GNAT1_C_OBJS+= \ + ada/rtinit.o \ + ada/seh_init.o + ++ifeq ($(HOST_RT),False) + GNAT_ADA_OBJS+= \ + ada/gcc-interface/system.o \ + ada/libgnat/a-assert.o \ +@@ -555,6 +558,7 @@ GNAT_ADA_OBJS+= \ + ada/libgnat/s-wchstw.o \ + ada/libgnat/s-widuns.o + endif ++endif + + # Object files for gnat executables + GNAT1_ADA_OBJS = $(GNAT_ADA_OBJS) ada/back_end.o ada/gnat1drv.o +@@ -656,6 +660,9 @@ GNATBIND_OBJS += \ + ada/rtfinal.o \ + ada/rtinit.o \ + ada/seh_init.o \ ++ ++ifeq ($(HOST_RT),False) ++GNATBIND_OBJS += \ + ada/gcc-interface/system.o \ + ada/libgnat/a-assert.o \ + ada/libgnat/a-elchha.o \ +@@ -707,6 +714,9 @@ GNATBIND_OBJS += \ + ada/libgnat/s-wchjis.o \ + ada/libgnat/s-wchstw.o \ + ada/libgnat/s-widuns.o \ ++ ++endif ++GNATBIND_OBJS += \ + ada/adaint.o \ + ada/argv.o \ + ada/cio.o \ +diff --git a/gcc/ada/init.c b/gcc/ada/init.c +index 5212a38490d3..5ae2efd32ef3 100644 +--- a/gcc/ada/init.c ++++ b/gcc/ada/init.c +@@ -93,8 +93,12 @@ extern struct Exception_Data storage_error; + #ifdef CERT + #define Raise_From_Signal_Handler __gnat_raise_exception + #else ++#if __GNUC__ < 12 ++#define Raise_From_Signal_Handler ada__exceptions__raise_from_signal_handler ++#else + #define Raise_From_Signal_Handler __gnat_raise_from_signal_handler + #endif ++#endif + + extern void Raise_From_Signal_Handler (struct Exception_Data *, const void *) + ATTRIBUTE_NORETURN; +-- +2.39.0 + diff --git a/util/crossgcc/patches/gcc-11.4.0_libcpp.patch b/util/crossgcc/patches/gcc-13.2.0_libcpp.patch similarity index 85% rename from util/crossgcc/patches/gcc-11.4.0_libcpp.patch rename to util/crossgcc/patches/gcc-13.2.0_libcpp.patch index df28c01..2b0c953 100644 --- a/util/crossgcc/patches/gcc-11.4.0_libcpp.patch +++ b/util/crossgcc/patches/gcc-13.2.0_libcpp.patch @@ -1,8 +1,8 @@ GCC with `-Wformat-security -Werror=format-security` hardening options enabled by default rejects some codes in libcpp. This patch fixes them. ---- gcc-8.3.0/libcpp/expr.c.bak 2020-09-11 15:44:45.770000000 +0900 -+++ gcc-8.3.0/libcpp/expr.c 2020-09-11 15:46:22.370000000 +0900 +--- gcc-8.3.0/libcpp/expr.cc.bak 2020-09-11 15:44:45.770000000 +0900 ++++ gcc-8.3.0/libcpp/expr.cc 2020-09-11 15:46:22.370000000 +0900 @@ -794,10 +794,10 @@ if (CPP_OPTION (pfile, c99)) @@ -16,8 +16,8 @@ } result |= CPP_N_INTEGER; ---- gcc-8.3.0/libcpp/macro.c.bak 2020-09-11 16:01:42.550000000 +0900 -+++ gcc-8.3.0/libcpp/macro.c 2020-09-11 16:03:47.850000000 +0900 +--- gcc-8.3.0/libcpp/macro.cc.bak 2020-09-11 16:01:42.550000000 +0900 ++++ gcc-8.3.0/libcpp/macro.cc 2020-09-11 16:03:47.850000000 +0900 @@ -160,7 +160,7 @@ if (m_state == 2 && token->type == CPP_PASTE) { diff --git a/util/crossgcc/patches/gcc-11.4.0_libgcc.patch b/util/crossgcc/patches/gcc-13.2.0_libgcc.patch similarity index 100% rename from util/crossgcc/patches/gcc-11.4.0_libgcc.patch rename to util/crossgcc/patches/gcc-13.2.0_libgcc.patch diff --git a/util/crossgcc/patches/gcc-13.2.0_musl_poisoned_calloc.patch b/util/crossgcc/patches/gcc-13.2.0_musl_poisoned_calloc.patch new file mode 100644 index 0000000..552a7e7 --- /dev/null +++ b/util/crossgcc/patches/gcc-13.2.0_musl_poisoned_calloc.patch @@ -0,0 +1,122 @@ +Musl's <sched.h> uses calloc() which is marked as poisoned by GCC's +"system.h". Work around that by making sure that <sched.h> gets +included first. + +--- gcc-13.2.0/gcc/ada/adaint.c ++++ gcc-13.2.0.musl/gcc/ada/adaint.c +@@ -101,6 +101,10 @@ + #include <sys/time.h> + #endif + ++#if defined (__linux__) ++#include <sched.h> ++#endif ++ + #ifdef IN_RTS + + #ifdef STANDALONE +@@ -3441,7 +3445,6 @@ + #endif + + #if defined (__linux__) +-#include <sched.h> + + /* glibc versions earlier than 2.7 do not define the routines to handle + dynamically allocated CPU sets. For these targets, we use the static +--- gcc-13.2.0/gcc/ada/argv.c ++++ gcc-13.2.0.musl/gcc/ada/argv.c +@@ -42,6 +42,8 @@ + main program, and these routines are accessed from the + Ada.Command_Line.Environment package. */ + ++#include "adaint.h" ++ + #ifdef IN_RTS + #include "runtime.h" + #include <stdlib.h> +@@ -50,8 +52,6 @@ + #include "config.h" + #include "system.h" + #endif +- +-#include "adaint.h" + + #ifdef __cplusplus + extern "C" { +--- gcc-13.2.0/gcc/ada/cio.c ++++ gcc-13.2.0.musl/gcc/ada/cio.c +@@ -29,6 +29,8 @@ + * * + ****************************************************************************/ + ++#include "adaint.h" ++ + #ifdef IN_RTS + #include "runtime.h" + #include <sys/stat.h> +@@ -36,8 +38,6 @@ + #include "config.h" + #include "system.h" + #endif +- +-#include "adaint.h" + + /* We need L_tmpnam definition */ + #include <stdio.h> +--- gcc-13.2.0/gcc/ada/cstreams.c ++++ gcc-13.2.0.musl/gcc/ada/cstreams.c +@@ -58,14 +58,14 @@ + #include "vxWorks.h" + #endif + ++#include "adaint.h" ++ + #ifdef IN_RTS + #include <string.h> + #else + #include "config.h" + #include "system.h" + #endif +- +-#include "adaint.h" + + #ifdef __cplusplus + extern "C" { +--- gcc-13.2.0/gcc/ada/init.c ++++ gcc-13.2.0.musl/gcc/ada/init.c +@@ -53,6 +53,8 @@ + #undef __linux__ + #endif + ++#include "adaint.h" ++ + #ifdef IN_RTS + + #ifdef STANDALONE +@@ -71,7 +73,6 @@ + #include "system.h" + #endif + +-#include "adaint.h" + #include "raise.h" + + #ifdef __cplusplus +--- gcc-13.2.0/gcc/ada/raise.c ++++ gcc-13.2.0.musl/gcc/ada/raise.c +@@ -32,6 +32,8 @@ + /* Shared routines to support exception handling. __gnat_unhandled_terminate + is shared between all exception handling mechanisms. */ + ++#include "adaint.h" ++ + #ifdef IN_RTS + #include "runtime.h" + #else +@@ -39,7 +41,6 @@ + #include "system.h" + #endif + +-#include "adaint.h" + #include "raise.h" + + #ifdef __cplusplus diff --git a/util/crossgcc/patches/gcc-11.4.0_rv32iafc.patch b/util/crossgcc/patches/gcc-13.2.0_rv32iafc.patch similarity index 100% rename from util/crossgcc/patches/gcc-11.4.0_rv32iafc.patch rename to util/crossgcc/patches/gcc-13.2.0_rv32iafc.patch diff --git a/util/crossgcc/sum/gcc-11.4.0.tar.xz.cksum b/util/crossgcc/sum/gcc-11.4.0.tar.xz.cksum deleted file mode 100644 index c9469c3..0000000 --- a/util/crossgcc/sum/gcc-11.4.0.tar.xz.cksum +++ /dev/null @@ -1 +0,0 @@ -03f21dce9edf9092e38b4e23dd27b29f6ab56f63 tarballs/gcc-11.4.0.tar.xz diff --git a/util/crossgcc/sum/gcc-13.2.0.tar.xz.cksum b/util/crossgcc/sum/gcc-13.2.0.tar.xz.cksum new file mode 100644 index 0000000..dcf9d41 --- /dev/null +++ b/util/crossgcc/sum/gcc-13.2.0.tar.xz.cksum @@ -0,0 +1 @@ +5f95b6d042fb37d45c6cbebfc91decfbc4fb493c tarballs/gcc-13.2.0.tar.xz -- To view, visit https://review.coreboot.org/c/coreboot/+/70771?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4f2ed4de4811abaa13528906de71eee29a8f2910 Gerrit-Change-Number: 70771 Gerrit-PatchSet: 33 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: merged

1 0

[L] Change in coreboot[main]: crossgcc: Upgrade GCC from 11.4.0 to 13.2.0
by Martin L Roth (Code Review) 25 Nov '23

25 Nov '23

Attention is currently required from: Elyes Haouas, Felix Singer, Julius Werner, Nico Huber, Patrick Georgi. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70771?usp=email ) Change subject: crossgcc: Upgrade GCC from 11.4.0 to 13.2.0 ...................................................................... Patch Set 32: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70771?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4f2ed4de4811abaa13528906de71eee29a8f2910 Gerrit-Change-Number: 70771 Gerrit-PatchSet: 32 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 24 Nov 2023 23:30:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023