coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3353 discussions

[L] Change in coreboot[main]: [RFC] drivers/option: Add forms in cbtables
by Martin L Roth (Code Review) 31 Oct '23

31 Oct '23

Attention is currently required from: Angel Pons, Benjamin Doron, Lean Sheng Tan, Maximilian Brune, Nico Huber, Patrick Rudolph, Sean Rhodes. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121?usp=email ) Change subject: [RFC] drivers/option: Add forms in cbtables ...................................................................... Patch Set 18: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74121/comment/44bb257b_6e0dc683 : PS18, Line 15: The system currently lacks a way : to describe where to find option values. Right - I think that's a critical piece that needs to be added before we implement this. It can be as simple as an enum for different storage medias. I'd also like to make sure that different options can be stored in different media, not just assuming a single media for every option. https://review.coreboot.org/c/coreboot/+/74121/comment/64612936_4b09a606 : PS18, Line 20: cursed forms representation Config Option Data - COD? "Forms representation" is awful. https://review.coreboot.org/c/coreboot/+/74121/comment/474f353d_b33ec38a : PS18, Line 31: which is undesired Agreed! Patchset: PS18: I like the concept, but have some quibbles. It seems that all of this is to support a setup engine. The setup engine should not be a part of coreboot itself though. I don't understand why anything needs to be parsed at runtime in coreboot to generate all of these structures. This seems like a table of values that could be created at build time and just populated into a cbfs region. Looking at the data that's included in the table, the fields all seem static: Name, display name, help text, flags, and default value. None of that needs to be modified at runtime. Why does any of this need to go into coreboot? All coreboot cares about is the name and the current value of the setting, which isn't even defined yet. Maybe move all of this into a separate tool that parses everything at build time and generates the final structures? coreboot can then just copy the data from cbfs into cbmem, or better still, just leave it in cbfs. -- To view, visit https://review.coreboot.org/c/coreboot/+/74121?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772 Gerrit-Change-Number: 74121 Gerrit-PatchSet: 18 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Maslowski <info(a)orangecms.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 18:31:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: mb/emulation: Add SIMICS QSP support
by Nico Huber (Code Review) 31 Oct '23

31 Oct '23

Attention is currently required from: Angel Pons, Benjamin Doron, Christian Walter, Lean Sheng Tan, Leon Groß, Patrick Rudolph. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77905?usp=email ) Change subject: mb/emulation: Add SIMICS QSP support ...................................................................... Patch Set 13: (1 comment) Patchset: PS4: > > I'm not sure if I follow. You expect current users of Simics to adopt this? > > Currently, with QEMU it's as simple as running `make qemu`. Are there plans > > to make Simics as easy to use? if not, wouldn't it be better to teach people > > about QEMU? > I guess we can start from here :) > > > i mean it is no harm to add more support to the platform for coreboot i guess? > > > > Every addition also adds at least some maintenance overhead. I've often > > seen redundant additions to be abandoned and bit rot. > > This sounds pretty discouraging to be honest. If every time someone spend some time to implement a nice additional feature or implement new board support (in this case it actually takes 2 months for the engineer to work on this), and we shoot it down with the reason "oh please dont do it it just add more maintainance", that is not very welcoming to the new coreboot leaner who try to work on something isn't it? 😊 That's why we usually ask if something is a good idea for upstream in advance. It only takes about 1 hour to write an email, explaining what Simics QSP is and how to use it and how it would look like with coreboot. That can easily safe 2 months of potentially unnecessary work. I'm not saying it's been done in vain. But use cases need to be explained when requesting to maintain things upstream. This is a very important part of review and IMO should come first. Even if there is no definite use case and this is just part of some strategy, that can be explained and discussed, too ofc. What harm does it do to explain things? > And also we have maintainer list for this purpose - so I personally dont see it is a big issue here. The maintainers list is mostly listing people who *might* reply to requests. What we need is people who proactively maintain things. Anyway, digressing, this has nothing to do with the patch. > > > > It is a nice addition as well. As it does have specific use cases (although quite limited): as Intel or silicon vendors usually use Simics for the RTL simulation before the actual silicon is available, actively used by the internal engineers for that. > > > > Do they use QSP? > I guess so, as you can see Intel engineers actively update it in edk2 tree. So my work is that i am also in discussion with the Simics guy to also include coreboot binary as default binary (together with current UEFI edk2 binary), and that could also help to promote coreboot to more people 😊 This sounds really nice. Why not start with that? If the binary is accepted, let's maintain it upstream? -- To view, visit https://review.coreboot.org/c/coreboot/+/77905?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I175b20bb4746608e4d868aa96492fc06c149bd36 Gerrit-Change-Number: 77905 Gerrit-PatchSet: 13 Gerrit-Owner: Leon Groß <leon.gross(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Leon Groß <leon.gross(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 18:16:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: include/commonlib/coreboot_tables: Add CFR structs
by Martin L Roth (Code Review) 31 Oct '23

31 Oct '23

Attention is currently required from: Patrick Rudolph, Sean Rhodes. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77882?usp=email ) Change subject: include/commonlib/coreboot_tables: Add CFR structs ...................................................................... Patch Set 9: (16 comments) File Documentation/drivers/cfr.md: https://review.coreboot.org/c/coreboot/+/77882/comment/4ca3736d_062680c5 : PS9, Line 9: S change to lowercase. https://review.coreboot.org/c/coreboot/+/77882/comment/452accf7_495c72c1 : PS9, Line 18: ## Design Proposal After it's accepted, it's no longer a design proposal, so let's just write it as documentation for the design. https://review.coreboot.org/c/coreboot/+/77882/comment/10c954db_1bd635d8 : PS9, Line 21: The coreboot table is generated from coreboot ramstage : code. : This sentence leads to questions that you might want to address here. - Is the data only available in ramstage? (I doubt it, but I wouldn't think that works well for many of the values that want to be stored.) https://review.coreboot.org/c/coreboot/+/77882/comment/48d20d4f_f55af1df : PS9, Line 24: name Can we use an enum instead? https://review.coreboot.org/c/coreboot/+/77882/comment/6f5b6593_973fd4eb : PS9, Line 24: it's its https://review.coreboot.org/c/coreboot/+/77882/comment/302f9944_bc908027 : PS9, Line 25: tatus flags. Where is the current value stored? I assume that the minimum we need to use this are the name, flags, and current value. https://review.coreboot.org/c/coreboot/+/77882/comment/f31b2bf0_77c36916 : PS9, Line 24: user : visible name, a help text, Maybe these could be stored separately? They are only needed for display, not for use. https://review.coreboot.org/c/coreboot/+/77882/comment/2e1d8d41_ad296d15 : PS9, Line 25: default value Is there any thought of the default value needing to be calculated? If we change memory speeds, for example, we'd want to change the default value for timing. https://review.coreboot.org/c/coreboot/+/77882/comment/06b90597_5843164c : PS9, Line 29: ore or https://review.coreboot.org/c/coreboot/+/77882/comment/e3d85a94_0b648a48 : PS9, Line 30: and are never reachable should be marked as hidden Why not remove them? https://review.coreboot.org/c/coreboot/+/77882/comment/8c803332_a5c63cb3 : PS9, Line 36: number can we differentiate between hex & decimal? Maybe with a flag? https://review.coreboot.org/c/coreboot/+/77882/comment/5108f2f7_5facbf1a : PS9, Line 44: form generate? https://review.coreboot.org/c/coreboot/+/77882/comment/f54b065b_0dc89776 : PS9, Line 69: immideatly immediately File src/commonlib/include/commonlib/cfr.h: https://review.coreboot.org/c/coreboot/+/77882/comment/64de19c1_7dcda42c : PS9, Line 102: I think we need a version number of the structures to be stored along with the structures somewhere. That should at least allow for backward compatibility when the structures change. This is not needed as much for a payload, though I can see it catching issues there as well, but for an OS-based tool, I'd think it would be critical. https://review.coreboot.org/c/coreboot/+/77882/comment/fe650dd1_375ea9bc : PS9, Line 128: Uniqueue Unique? https://review.coreboot.org/c/coreboot/+/77882/comment/53d4835f_6d2fed90 : PS9, Line 145: Uniqueue Unique? -- To view, visit https://review.coreboot.org/c/coreboot/+/77882?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I44f006318a15556f97da286dc032c58ccb7993e4 Gerrit-Change-Number: 77882 Gerrit-PatchSet: 9 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 18:10:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/guybrush: Set PS2K_IRQ to level/low
by Raul Rangel (Code Review) 31 Oct '23

31 Oct '23

Attention is currently required from: Jason Nien, Karthik Ramasubramanian, Mark Hasemeyer, Martin L Roth. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78137?usp=email ) Change subject: mb/google/guybrush: Set PS2K_IRQ to level/low ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78137?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7d093d94a666263684645ef724e945069c68c806 Gerrit-Change-Number: 78137 Gerrit-PatchSet: 3 Gerrit-Owner: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 18:02:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: mb/emulation: Add SIMICS QSP support
by Lean Sheng Tan (Code Review) 31 Oct '23

31 Oct '23

Attention is currently required from: Angel Pons, Benjamin Doron, Christian Walter, Leon Groß, Nico Huber, Patrick Rudolph. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77905?usp=email ) Change subject: mb/emulation: Add SIMICS QSP support ...................................................................... Patch Set 13: (1 comment) Patchset: PS4: > I'm not sure if I follow. You expect current users of Simics to adopt this? > Currently, with QEMU it's as simple as running `make qemu`. Are there plans > to make Simics as easy to use? if not, wouldn't it be better to teach people > about QEMU? I guess we can start from here :) > i mean it is no harm to add more support to the platform for coreboot i guess? > > Every addition also adds at least some maintenance overhead. I've often > seen redundant additions to be abandoned and bit rot. This sounds pretty discouraging to be honest. If every time someone spend some time to implement a nice additional feature or implement new board support (in this case it actually takes 2 months for the engineer to work on this), and we shoot it down with the reason "oh please dont do it it just add more maintainance", that is not very welcoming to the new coreboot leaner who try to work on something isn't it? 😊 And also we have maintainer list for this purpose - so I personally dont see it is a big issue here. > > It is a nice addition as well. As it does have specific use cases (although quite limited): as Intel or silicon vendors usually use Simics for the RTL simulation before the actual silicon is available, actively used by the internal engineers for that. > > Do they use QSP? I guess so, as you can see Intel engineers actively update it in edk2 tree. So my work is that i am also in discussion with the Simics guy to also include coreboot binary as default binary (together with current UEFI edk2 binary), and that could also help to promote coreboot to more people 😊 > > EDK2 and Slimbootloader already have nice support for Simics: > > https://slimbootloader.github.io/supported-hardware/qsp.html > > https://github.com/tianocore/edk2-platforms/tree/master/Platform/Intel/Simi… > > And others have support for other open-source emulators, e.g. Bochs. > Still we don't add those, why? Sure, we should welcome everyone who wants to contribute it, as long as there is volunteer who wants to port coreboot for other emulators, e.g. Bochs. -- To view, visit https://review.coreboot.org/c/coreboot/+/77905?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I175b20bb4746608e4d868aa96492fc06c149bd36 Gerrit-Change-Number: 77905 Gerrit-PatchSet: 13 Gerrit-Owner: Leon Groß <leon.gross(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Leon Groß <leon.gross(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 17:37:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/amd/*: Ensure PSP soft fuse bitmask set properly
by Felix Held (Code Review) 31 Oct '23

31 Oct '23

Attention is currently required from: Eric Lai, Fred Reitberger, Jason Glenesk, Karthik Ramasubramanian, Matt DeVillier. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78823?usp=email ) Change subject: soc/amd/*: Ensure PSP soft fuse bitmask set properly ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78823?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2e207e20132d44016fbcb986bdfd8e935d8fead5 Gerrit-Change-Number: 78823 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 17:34:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/rex/variants/deku: Generate RAM IDs
by Eran Mitrani (Code Review) 31 Oct '23

31 Oct '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun. Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78445?usp=email ) Change subject: mb/google/rex/variants/deku: Generate RAM IDs ...................................................................... Patch Set 9: (2 comments) Patchset: PS7: > http://go/cros-deku-mapping Done File src/mainboard/google/rex/variants/deku/memory/mem_parts_used.txt: https://review.coreboot.org/c/coreboot/+/78445/comment/d6cf45e0_fa077d05 : PS7, Line 12: MT62F2G32D4DS-026 WT:B > I based that on the email exchange with HW eng. confirmed on Platform mapping doc as well -- To view, visit https://review.coreboot.org/c/coreboot/+/78445?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If2ed2bdcee44f6dbbda51a3ff484edaf3df4830d Gerrit-Change-Number: 78445 Gerrit-PatchSet: 9 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 17:28:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eran Mitrani <mitrani(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jakub Czapiga <czapiga(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/x86/memcpy.c: Optimize code for 64bit
by Felix Held (Code Review) 31 Oct '23

31 Oct '23

Attention is currently required from: Arthur Heymans, Martin L Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78646?usp=email ) Change subject: arch/x86/memcpy.c: Optimize code for 64bit ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78646?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I65f178d2ed3aae54b0c1ce739c2b4af8738b9fcc Gerrit-Change-Number: 78646 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 31 Oct 2023 17:27:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/rex/variants/deku: Generate RAM IDs
by Eran Mitrani (Code Review) 31 Oct '23

31 Oct '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun. Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78445?usp=email ) Change subject: mb/google/rex/variants/deku: Generate RAM IDs ...................................................................... Patch Set 9: (1 comment) Patchset: PS7: > It's not ready yet, hopefully next week. http://go/cros-deku-mapping -- To view, visit https://review.coreboot.org/c/coreboot/+/78445?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If2ed2bdcee44f6dbbda51a3ff484edaf3df4830d Gerrit-Change-Number: 78445 Gerrit-PatchSet: 9 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 17:24:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eran Mitrani <mitrani(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Makefile.inc: Add filter_dupes macro
by Matt DeVillier (Code Review) 31 Oct '23

31 Oct '23

Attention is currently required from: Martin L Roth. Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78831?usp=email ) Change subject: Makefile.inc: Add filter_dupes macro ...................................................................... Makefile.inc: Add filter_dupes macro Add a macro to sort and filter out duplicate tokens from a string variable. This will be used in a subsequent patch to correct the calculation of the soft fuse bitmask value passed to amdfwtool. TEST=tested with follow-on patch Change-Id: Ic947b445efe44af9fcbaef52f6c5a5d949878bc9 Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> --- M Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/78831/1 diff --git a/Makefile.inc b/Makefile.inc index 22a4646..49e1657 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -147,6 +147,7 @@ # toupper: returns the value in all uppercase # ws_to_under: returns the value with any whitespace changed to underscores # get_fmap_value returns the value of a given FMAP field from fmap_config.h +# remove_dupes sorts and filters out duplicate tokens from a whitespace-separated string _toint=$(shell printf "%d" $1) _tohex=$(shell printf 0x"%x" $1) _int-add2=$(shell expr $(call _toint,$1) + $(call _toint,$2)) @@ -167,6 +168,7 @@ toupper=$(shell echo '$1' | tr '[:lower:]' '[:upper:]') ws_to_under=$(shell echo '$1' | tr ' \t' '_') get_fmap_value=$(shell awk '$$2 == "$1" {print $$3}' $(obj)/fmap_config.h) +remove_dupes=$(shell echo $1 | tr ' ' '\n' | sort | uniq | tr '\n' ' ') ####################################################################### # Helper functions for ramstage postprocess -- To view, visit https://review.coreboot.org/c/coreboot/+/78831?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic947b445efe44af9fcbaef52f6c5a5d949878bc9 Gerrit-Change-Number: 78831 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
336
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023