coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[S] Change in coreboot[main]: Documentation: Make real time chats look less "official"
by Patrick Georgi (Code Review) 06 Oct '23

06 Oct '23

Attention is currently required from: Felix Singer, Martin L Roth, Nico Huber, Stefan Reinauer. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78022?usp=email ) Change subject: Documentation: Make real time chats look less "official" ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > I guess it's fine to demote them to inofficial. But not listing them at all […] They're back, and I hope it's sufficiently clear now that they're inofficial. -- To view, visit https://review.coreboot.org/c/coreboot/+/78022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If51ab9b9abc87772ce7584bb1976a1fbbc37854b Gerrit-Change-Number: 78022 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 06 Oct 2023 19:28:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: Documentation: Make real time chats look less "official"
by Patrick Georgi (Code Review) 06 Oct '23

06 Oct '23

Attention is currently required from: Felix Singer, Martin L Roth, Stefan Reinauer. Hello Felix Singer, Martin L Roth, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78022?usp=email to look at the new patch set (#3). Change subject: Documentation: Make real time chats look less "official" ...................................................................... Documentation: Make real time chats look less "official" Instead of sending people to four different services where they might or might not get an answer, refer to the most reliable venue, our mailing list. It follows that GSoC students also won't need to be present on IRC (although they can, of course.) The real time chat options are still listed, but with a focus on helping people find coreboot folks on whatever service they're already using. Change-Id: If51ab9b9abc87772ce7584bb1976a1fbbc37854b Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> --- M Documentation/community/forums.md M Documentation/contributing/gsoc.md 2 files changed, 11 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/78022/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/78022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If51ab9b9abc87772ce7584bb1976a1fbbc37854b Gerrit-Change-Number: 78022 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: Documentation: Drop mention of real time chats as "official"
by Patrick Georgi (Code Review) 06 Oct '23

06 Oct '23

Attention is currently required from: Felix Singer, Martin L Roth, Stefan Reinauer. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78022?usp=email ) Change subject: Documentation: Drop mention of real time chats as "official" ...................................................................... Patch Set 1: (1 comment) File Documentation/community/forums.md: https://review.coreboot.org/c/coreboot/+/78022/comment/67803081_1a5ec870 : PS1, Line 13: > Maybe: […] I started from that, but went for a different angle: We have a somewhat fragmented community in real-time chats right now because people use whatever platform to talk about coreboot they already use for other purposes. As such these places exist, but I hope my newest revision makes it sufficiently clear that none of them is more important than another. -- To view, visit https://review.coreboot.org/c/coreboot/+/78022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If51ab9b9abc87772ce7584bb1976a1fbbc37854b Gerrit-Change-Number: 78022 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 06 Oct 2023 19:26:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: Documentation: Drop mention of real time chats as "official"
by Patrick Georgi (Code Review) 06 Oct '23

06 Oct '23

Attention is currently required from: Felix Singer, Patrick Georgi, Stefan Reinauer. Hello Felix Singer, Martin L Roth, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78022?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Stefan Reinauer, Verified+1 by build bot (Jenkins) Change subject: Documentation: Drop mention of real time chats as "official" ...................................................................... Documentation: Drop mention of real time chats as "official" Instead of sending people to four different services where they might or might not get an answer, only refer to the most reliable venue, our mailing list. It follows that GSoC students also won't need to be present on IRC (although they can, of course.) Change-Id: If51ab9b9abc87772ce7584bb1976a1fbbc37854b Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> --- M Documentation/community/forums.md M Documentation/contributing/gsoc.md 2 files changed, 11 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/78022/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If51ab9b9abc87772ce7584bb1976a1fbbc37854b Gerrit-Change-Number: 78022 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: doc/forums: Add a section for local groups and meetups
by Patrick Georgi (Code Review) 06 Oct '23

06 Oct '23

Attention is currently required from: David Hendricks, Felix Singer, Martin L Roth, Paul Menzel. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76937?usp=email ) Change subject: doc/forums: Add a section for local groups and meetups ...................................................................... Patch Set 1: (1 comment) File Documentation/community/forums.md: https://review.coreboot.org/c/coreboot/+/76937/comment/f175f824_cba6f845 : PS1, Line 43: Local groups and meetups are not organized by the coreboot project but : by affiliated individuals from the community. The purpose of this disclaimer is to point out that these events aren't necessarily run by whoever could be considered "coreboot admin/owner/boss/you-name-it", but by their own event-specific organizers. So for any feedback (be that praise, criticism, lawsuits), reach out to the point of contact listed with the event, not with "the coreboot project". Maybe it could be stated more clearly, maybe something like the following? > The events below take place on a regular basis. They're organized by individuals from the community for the benefit of the community but they're not official "coreboot project events." For details on any event please reach out to the point of contact given in the list below. -- To view, visit https://review.coreboot.org/c/coreboot/+/76937?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib814ce34b24cd199e5a0a623bffde4b7d93deff0 Gerrit-Change-Number: 76937 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Fri, 06 Oct 2023 19:21:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: Kconfig: Bring HEAP_SIZE to a common, large value
by Subrata Banik (Code Review) 06 Oct '23

06 Oct '23

1 0

[M] Change in coreboot[main]: Kconfig: Bring HEAP_SIZE to a common, large value
by Patrick Georgi (Code Review) 06 Oct '23

06 Oct '23

Attention is currently required from: Arthur Heymans, Christian Walter, Eran Mitrani, Felix Held, Fred Reitberger, Jakub Czapiga, Jason Glenesk, Johnny Lin, Jonathan Zhang, Kapil Porwal, Lean Sheng Tan, Matt DeVillier, Nick Vaccaro, Philipp Hug, Sean Rhodes, Subrata Banik, Tarun, Tim Chu, Werner Zeh, ron minnich. Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78270?usp=email ) Change subject: Kconfig: Bring HEAP_SIZE to a common, large value ...................................................................... Kconfig: Bring HEAP_SIZE to a common, large value We have a tiny HEAP_SIZE by default, except when we don't, and mainboards that override it, or not. Since memory isn't exactly at a premium these days, and unused heap doesn't cost anything extra, just crank it up to the highest value we have in the tree by default and remove all overrides. Change-Id: I918a6c58c02496e8074e5fba06e38d9cfd691020 Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> --- M src/Kconfig M src/cpu/qemu-x86/Kconfig M src/mainboard/sifive/hifive-unleashed/Kconfig M src/northbridge/amd/pi/Kconfig M src/soc/amd/picasso/Kconfig M src/soc/amd/stoneyridge/Kconfig M src/soc/cavium/cn81xx/Kconfig M src/soc/intel/alderlake/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/cannonlake/Kconfig M src/soc/intel/elkhartlake/Kconfig M src/soc/intel/jasperlake/Kconfig M src/soc/intel/meteorlake/Kconfig M src/soc/intel/skylake/Kconfig M src/soc/intel/tigerlake/Kconfig M src/soc/intel/xeon_sp/Kconfig M src/soc/intel/xeon_sp/cpx/Kconfig M src/soc/intel/xeon_sp/skx/Kconfig M src/soc/intel/xeon_sp/spr/Kconfig M src/soc/qualcomm/ipq40xx/Kconfig 20 files changed, 1 insertion(+), 77 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/78270/1 diff --git a/src/Kconfig b/src/Kconfig index 1549719..ae80240 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -751,8 +751,7 @@ config HEAP_SIZE hex - default 0x100000 if FLATTENED_DEVICE_TREE - default 0x4000 + default 0x100000 config STACK_SIZE hex diff --git a/src/cpu/qemu-x86/Kconfig b/src/cpu/qemu-x86/Kconfig index f3e2c4c..0fa999e 100644 --- a/src/cpu/qemu-x86/Kconfig +++ b/src/cpu/qemu-x86/Kconfig @@ -35,7 +35,4 @@ default 32 if SMM_TSEG default 4 -config HEAP_SIZE - default 0x8000 - endif diff --git a/src/mainboard/sifive/hifive-unleashed/Kconfig b/src/mainboard/sifive/hifive-unleashed/Kconfig index 7f9300f..7bc3b0b 100644 --- a/src/mainboard/sifive/hifive-unleashed/Kconfig +++ b/src/mainboard/sifive/hifive-unleashed/Kconfig @@ -10,9 +10,6 @@ select FLATTENED_DEVICE_TREE select SPI_SDCARD -config HEAP_SIZE - default 0x10000 - config MAINBOARD_DIR default "sifive/hifive-unleashed" diff --git a/src/northbridge/amd/pi/Kconfig b/src/northbridge/amd/pi/Kconfig index 4518db1..4ffe82a 100644 --- a/src/northbridge/amd/pi/Kconfig +++ b/src/northbridge/amd/pi/Kconfig @@ -29,8 +29,4 @@ hex default 0x200000 -config HEAP_SIZE - hex - default 0xc0000 - endif # NORTHBRIDGE_AMD_PI diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index 796fe4e..c33f287 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -264,10 +264,6 @@ bool default n -config HEAP_SIZE - hex - default 0xc0000 - config SERIRQ_CONTINUOUS_MODE bool default n diff --git a/src/soc/amd/stoneyridge/Kconfig b/src/soc/amd/stoneyridge/Kconfig index 9af7455..6ff135e 100644 --- a/src/soc/amd/stoneyridge/Kconfig +++ b/src/soc/amd/stoneyridge/Kconfig @@ -152,10 +152,6 @@ bool default n -config HEAP_SIZE - hex - default 0xc0000 - config EHCI_BAR hex default 0xfef00000 diff --git a/src/soc/cavium/cn81xx/Kconfig b/src/soc/cavium/cn81xx/Kconfig index 368581f..77ca972 100644 --- a/src/soc/cavium/cn81xx/Kconfig +++ b/src/soc/cavium/cn81xx/Kconfig @@ -30,9 +30,6 @@ int default 1 -config HEAP_SIZE - default 0x10000 - config STACK_SIZE default 0x2000 diff --git a/src/soc/intel/alderlake/Kconfig b/src/soc/intel/alderlake/Kconfig index 82ec8f2..4b960c1 100644 --- a/src/soc/intel/alderlake/Kconfig +++ b/src/soc/intel/alderlake/Kconfig @@ -215,11 +215,6 @@ hex default 0x400000 -config HEAP_SIZE - hex - default 0x80000 if BMP_LOGO - default 0x10000 - config GFX_GMA_DEFAULT_MMIO default 0xaf000000 if MAINBOARD_HAS_EARLY_LIBGFXINIT diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index bce935d..78ec298 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -252,10 +252,6 @@ help Name of file to store in the IFWI region. -config HEAP_SIZE - hex - default 0x8000 - config MAX_ROOT_PORTS int default 6 diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index 80237f9..a42a3c3 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -160,10 +160,6 @@ hex default 0x400000 -config HEAP_SIZE - hex - default 0x8000 - config NHLT_DMIC_1CH_16B bool depends on ACPI_NHLT diff --git a/src/soc/intel/elkhartlake/Kconfig b/src/soc/intel/elkhartlake/Kconfig index 7f1c767..3361c0d 100644 --- a/src/soc/intel/elkhartlake/Kconfig +++ b/src/soc/intel/elkhartlake/Kconfig @@ -104,10 +104,6 @@ hex default 0x0 -config HEAP_SIZE - hex - default 0x8000 - config MAX_ROOT_PORTS int default 7 diff --git a/src/soc/intel/jasperlake/Kconfig b/src/soc/intel/jasperlake/Kconfig index ff5def3..3d84991 100644 --- a/src/soc/intel/jasperlake/Kconfig +++ b/src/soc/intel/jasperlake/Kconfig @@ -106,10 +106,6 @@ hex default 0x400000 -config HEAP_SIZE - hex - default 0x8000 - config MAX_ROOT_PORTS int default 8 diff --git a/src/soc/intel/meteorlake/Kconfig b/src/soc/intel/meteorlake/Kconfig index 48030a1..590e8b8 100644 --- a/src/soc/intel/meteorlake/Kconfig +++ b/src/soc/intel/meteorlake/Kconfig @@ -197,11 +197,6 @@ hex default 0x400000 -config HEAP_SIZE - hex - default 0x80000 if BMP_LOGO - default 0x10000 - # Intel recommends reserving the PCIe TBT root port resources as below: # - 42 buses # - 194 MiB Non-prefetchable memory diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig index d6a11363e..e0df501 100644 --- a/src/soc/intel/skylake/Kconfig +++ b/src/soc/intel/skylake/Kconfig @@ -151,10 +151,6 @@ help If you set this option to n, will not use native SD controller. -config HEAP_SIZE - hex - default 0x80000 - config IED_REGION_SIZE hex default 0x400000 diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig index 0a4b7bf..c07a0d8 100644 --- a/src/soc/intel/tigerlake/Kconfig +++ b/src/soc/intel/tigerlake/Kconfig @@ -152,10 +152,6 @@ config INTEL_TME default n -config HEAP_SIZE - hex - default 0x10000 - config MAX_ROOT_PORTS int default 24 if SOC_INTEL_TIGERLAKE_PCH_H diff --git a/src/soc/intel/xeon_sp/Kconfig b/src/soc/intel/xeon_sp/Kconfig index 63ced01..e63bee5 100644 --- a/src/soc/intel/xeon_sp/Kconfig +++ b/src/soc/intel/xeon_sp/Kconfig @@ -91,10 +91,6 @@ config ECAM_MMCONF_BUS_NUMBER default 256 -config HEAP_SIZE - hex - default 0x80000 - config HPET_MIN_TICKS hex default 0x80 diff --git a/src/soc/intel/xeon_sp/cpx/Kconfig b/src/soc/intel/xeon_sp/cpx/Kconfig index f54f771..ac166c3 100644 --- a/src/soc/intel/xeon_sp/cpx/Kconfig +++ b/src/soc/intel/xeon_sp/cpx/Kconfig @@ -71,10 +71,6 @@ hex default 0x7C00 -config HEAP_SIZE - hex - default 0x80000 - config STACK_SIZE hex default 0x4000 diff --git a/src/soc/intel/xeon_sp/skx/Kconfig b/src/soc/intel/xeon_sp/skx/Kconfig index c2c3d4e..5d84387 100644 --- a/src/soc/intel/xeon_sp/skx/Kconfig +++ b/src/soc/intel/xeon_sp/skx/Kconfig @@ -55,10 +55,6 @@ hex default 0x7C00 -config HEAP_SIZE - hex - default 0x80000 - config IED_REGION_SIZE hex default 0x400000 diff --git a/src/soc/intel/xeon_sp/spr/Kconfig b/src/soc/intel/xeon_sp/spr/Kconfig index b1c4c78..43b87ad 100644 --- a/src/soc/intel/xeon_sp/spr/Kconfig +++ b/src/soc/intel/xeon_sp/spr/Kconfig @@ -79,10 +79,6 @@ hex default 0x8c00 -config HEAP_SIZE - hex - default 0x80000 - config STACK_SIZE hex default 0x4000 diff --git a/src/soc/qualcomm/ipq40xx/Kconfig b/src/soc/qualcomm/ipq40xx/Kconfig index 0eabb00..0ce9273 100644 --- a/src/soc/qualcomm/ipq40xx/Kconfig +++ b/src/soc/qualcomm/ipq40xx/Kconfig @@ -57,8 +57,4 @@ help Path for utils to combine SBL_ELF and bootblock -config HEAP_SIZE - hex - default 0x8000 - endif -- To view, visit https://review.coreboot.org/c/coreboot/+/78270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I918a6c58c02496e8074e5fba06e38d9cfd691020 Gerrit-Change-Number: 78270 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: include/stddef: define SIZE_MAX
by Patrick Georgi (Code Review) 06 Oct '23

06 Oct '23

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78269?usp=email ) Change subject: include/stddef: define SIZE_MAX ...................................................................... include/stddef: define SIZE_MAX It's needed for future work. Change-Id: I3419d11072bc0e3791ad08144c2a25c607550f28 Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> --- M src/include/stddef.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/78269/1 diff --git a/src/include/stddef.h b/src/include/stddef.h index 484017d..82d38c3 100644 --- a/src/include/stddef.h +++ b/src/include/stddef.h @@ -7,6 +7,7 @@ typedef __PTRDIFF_TYPE__ ptrdiff_t; typedef __SIZE_TYPE__ size_t; +#define SIZE_MAX __SIZE_MAX__ /* There is a GCC macro for a size_t type, but not * for a ssize_t type. Below construct tricks GCC * into making __SIZE_TYPE__ signed. -- To view, visit https://review.coreboot.org/c/coreboot/+/78269?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3419d11072bc0e3791ad08144c2a25c607550f28 Gerrit-Change-Number: 78269 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: drivers/pc80/rtc/option.c: Stop resetting CMOS during s3 resume
by Bill XIE (Code Review) 06 Oct '23

06 Oct '23

Bill XIE has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/78287?usp=email ) Change subject: drivers/pc80/rtc/option.c: Stop resetting CMOS during s3 resume ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/78287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I533e83f3b95f327b0e24f4d750f8812325b7770b Gerrit-Change-Number: 78287 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Add config for Client RPL FSP support
by Bora Guvendik (Code Review) 06 Oct '23

06 Oct '23

Attention is currently required from: Nick Vaccaro. Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78014?usp=email ) Change subject: soc/intel/alderlake: Add config for Client RPL FSP support ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/78014?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib3172b06b23e19be453142af764dd027bfe8043d Gerrit-Change-Number: 78014 Gerrit-PatchSet: 2 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Fri, 06 Oct 2023 18:15:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023