coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[XS] Change in coreboot[main]: util/liveiso/nixos: Bump to 23.05
by Felix Singer (Code Review) 17 Oct '23

17 Oct '23

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78399?usp=email ) Change subject: util/liveiso/nixos: Bump to 23.05 ...................................................................... Patch Set 1: (1 comment) File util/liveiso/nixos/common.nix: https://review.coreboot.org/c/coreboot/+/78399/comment/8cf19d24_cdbffce9 : PS1, Line 36: "intel-spi.writeable=1" There was an issue with that. Needs test. -- To view, visit https://review.coreboot.org/c/coreboot/+/78399?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a23466bef5c45ebb82d92038ec2595103c984d3 Gerrit-Change-Number: 78399 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 17 Oct 2023 06:38:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: util/liveiso/nixos: Drop XFS package
by Felix Singer (Code Review) 17 Oct '23

17 Oct '23

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78400?usp=email ) Change subject: util/liveiso/nixos: Drop XFS package ...................................................................... util/liveiso/nixos: Drop XFS package XFS is barely used. In order to save some space, drop it from the package list. Change-Id: Ic1cc567eb3f555bdf5567f3d036c84ce58691128 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/liveiso/nixos/common.nix 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/78400/1 diff --git a/util/liveiso/nixos/common.nix b/util/liveiso/nixos/common.nix index 4258055..f12d958 100644 --- a/util/liveiso/nixos/common.nix +++ b/util/liveiso/nixos/common.nix @@ -170,7 +170,6 @@ upterm usbutils wget - xfsprogs.bin zfs zip zstd -- To view, visit https://review.coreboot.org/c/coreboot/+/78400?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic1cc567eb3f555bdf5567f3d036c84ce58691128 Gerrit-Change-Number: 78400 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: util/liveiso/nixos: Bump to 23.05
by Felix Singer (Code Review) 17 Oct '23

17 Oct '23

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78399?usp=email ) Change subject: util/liveiso/nixos: Bump to 23.05 ...................................................................... util/liveiso/nixos: Bump to 23.05 Bump to 23.05 and also rename settings in order to compliant with newest namespaces and names. Change-Id: I4a23466bef5c45ebb82d92038ec2595103c984d3 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/liveiso/nixos/build.sh M util/liveiso/nixos/common.nix 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/78399/1 diff --git a/util/liveiso/nixos/build.sh b/util/liveiso/nixos/build.sh index e2e1d65..a10dad3 100755 --- a/util/liveiso/nixos/build.sh +++ b/util/liveiso/nixos/build.sh @@ -11,4 +11,4 @@ nix-build '<nixpkgs/nixos>' \ -A config.system.build.isoImage \ -I nixos-config=$config \ - -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/refs/heads/nixos-22.11.tar… + -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/refs/heads/nixos-23.05.tar… diff --git a/util/liveiso/nixos/common.nix b/util/liveiso/nixos/common.nix index 93a4168..4258055 100644 --- a/util/liveiso/nixos/common.nix +++ b/util/liveiso/nixos/common.nix @@ -8,7 +8,7 @@ <nixpkgs/nixos/modules/installer/cd-dvd/iso-image.nix> ]; - system.stateVersion = "22.11"; + system.stateVersion = "23.05"; isoImage = { makeEfiBootable = true; @@ -75,7 +75,7 @@ ]; openssh = { enable = true; - permitRootLogin = "yes"; + settings.PermitRootLogin = "yes"; }; }; -- To view, visit https://review.coreboot.org/c/coreboot/+/78399?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a23466bef5c45ebb82d92038ec2595103c984d3 Gerrit-Change-Number: 78399 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/rex: Enable sending EOP from payload
by Subrata Banik (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74768?usp=email ) Change subject: mb/google/rex: Enable sending EOP from payload ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74768?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5eda0a5c6d4c34cfcc2de898adde0b005d6edc1e Gerrit-Change-Number: 74768 Gerrit-PatchSet: 5 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 17 Oct 2023 05:09:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/cmn/block/cse: Support sending EOP from payload
by Subrata Banik (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Julius Werner, Kapil Porwal, Paul Menzel, Werner Zeh. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74765?usp=email ) Change subject: soc/intel/cmn/block/cse: Support sending EOP from payload ...................................................................... Patch Set 7: (2 comments) File src/soc/intel/common/block/cse/cse_eop.c: https://review.coreboot.org/c/coreboot/+/74765/comment/18ea8e12_b85b3eb0 : PS7, Line 310: #if !CONFIG(SOC_INTEL_CSE_SEND_EOP_BY_PAYLOAD) we don't need the guarding IMO https://review.coreboot.org/c/coreboot/+/74765/comment/d08ef101_e0385f92 : PS7, Line 311: send_cse_eop_with_late_finalize ``` static void send_cse_eop_with_late_finalize(void *unused) { if (CONFIG(SOC_INTEL_CSE_SEND_EOP_BY_PAYLOAD)) return; if (is_cse_eop_supported()) do_send_end_of_post(true); if (CONFIG(SOC_INTEL_CSE_SEND_EOP_LATE) || CONFIG(SOC_INTEL_CSE_SEND_EOP_ASYNC)) cse_late_finalize(); } ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/74765?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0fbb9fd0f8522eefad39960ca3167c2ba764f523 Gerrit-Change-Number: 74765 Gerrit-PatchSet: 7 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: sridhar siricilla <siricillasridhar(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 17 Oct 2023 05:05:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/wwan/fm: Wake up modem on PEWAKE# signal change
by Subrata Banik (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Kornel Dulęba, Nick Vaccaro, Paweł Anikiel. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78297?usp=email ) Change subject: drivers/wwan/fm: Wake up modem on PEWAKE# signal change ...................................................................... Patch Set 3: (2 comments) File src/drivers/wwan/fm/acpi_fm350gl.c: https://review.coreboot.org/c/coreboot/+/78297/comment/d510db5a_565391ca : PS3, Line 6: #if CONFIG(GENERIC_GPIO_LIB) : #include <gpio.h> : #endif order please. why not adding header file unconditionally ? https://review.coreboot.org/c/coreboot/+/78297/comment/f3d9a045_9e1f1964 : PS3, Line 287: #if CONFIG(GENERIC_GPIO_LIB) why preprocessing guard ? -- To view, visit https://review.coreboot.org/c/coreboot/+/78297?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I32257689da85ea71f9de781093b3ede0cfe70a0e Gerrit-Change-Number: 78297 Gerrit-PatchSet: 3 Gerrit-Owner: Paweł Anikiel <panikiel(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com> Gerrit-CC: Kornel Dulęba <korneld(a)google.com> Gerrit-Attention: Paweł Anikiel <panikiel(a)google.com> Gerrit-Attention: Kornel Dulęba <korneld(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 17 Oct 2023 04:46:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brya: Set WWAN_PCIE_WAKE_ODL as interrupt on Redrix
by Subrata Banik (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Nick Vaccaro, Paweł Anikiel. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78416?usp=email ) Change subject: mb/google/brya: Set WWAN_PCIE_WAKE_ODL as interrupt on Redrix ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78416/comment/8bf7ffe0_30ff3113 : PS2, Line 8: appreciate if you could specify the problem that you were facing and configuring the GPIO from APIC to INT is helping u to resolve the problem -- To view, visit https://review.coreboot.org/c/coreboot/+/78416?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I37f6836aefe4a374eaff3e4bc11358be274cf563 Gerrit-Change-Number: 78416 Gerrit-PatchSet: 2 Gerrit-Owner: Paweł Anikiel <panikiel(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com> Gerrit-CC: Kornel Dulęba <korneld(a)google.com> Gerrit-Attention: Paweł Anikiel <panikiel(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 17 Oct 2023 04:45:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/rex/var/karis: add hook for WiFi SAR table
by Eric Lai (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: David Wu, Eran Mitrani, Kapil Porwal, Sumeet R Pawnikar, Tarun, Tyler Wang, YH Lin. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78260?usp=email ) Change subject: mb/google/rex/var/karis: add hook for WiFi SAR table ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78260?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic989024ab9eb0fc439fc701c335a85986c4cfec5 Gerrit-Change-Number: 78260 Gerrit-PatchSet: 5 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 17 Oct 2023 03:57:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/brya/var/omnigul: Add fingerprint SPI
by Jamie Chen (Code Review) 16 Oct '23

16 Oct '23

Jamie Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78427?usp=email ) Change subject: mb/google/brya/var/omnigul: Add fingerprint SPI ...................................................................... mb/google/brya/var/omnigul: Add fingerprint SPI Add Fingerprint SPI, and power-off FPMCU during romstage. BUG=b:302085513 BRANCH=firmware-brya-14505.B TEST=emerge-brya coreboot, and measure evtest can detect Change-Id: Ic7b9e29ca3cb9352fe098156924fde2719399a79 Signed-off-by: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/variants/omnigul/gpio.c M src/mainboard/google/brya/variants/omnigul/overridetree.cb 2 files changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/78427/1 diff --git a/src/mainboard/google/brya/variants/omnigul/gpio.c b/src/mainboard/google/brya/variants/omnigul/gpio.c index d3f907d..873bbfa 100644 --- a/src/mainboard/google/brya/variants/omnigul/gpio.c +++ b/src/mainboard/google/brya/variants/omnigul/gpio.c @@ -316,12 +316,15 @@ * B4 is programmed here so that it is sequenced after EN_PP3300_SSD. */ PAD_CFG_GPO(GPP_B4, 1, DEEP), - /* Enable touchscreen, hold in reset */ /* C0 : SMBCLK ==> EN_PP3300_TCHSCR */ PAD_CFG_GPO(GPP_C0, 1, DEEP), /* C1 : SMBDATA ==> USI_RST_L */ PAD_CFG_GPO(GPP_C1, 0, DEEP), + // D1 : ISH_GP1 ==> FP_RST_ODL / + PAD_CFG_GPO(GPP_D1, 0, DEEP), + // D2 : ISH_GP2 ==> EN_FP_PWR / + PAD_CFG_GPO(GPP_D2, 0, DEEP), }; const struct pad_config *variant_gpio_override_table(size_t *num) diff --git a/src/mainboard/google/brya/variants/omnigul/overridetree.cb b/src/mainboard/google/brya/variants/omnigul/overridetree.cb index b9c6d87..53e275e 100644 --- a/src/mainboard/google/brya/variants/omnigul/overridetree.cb +++ b/src/mainboard/google/brya/variants/omnigul/overridetree.cb @@ -318,6 +318,21 @@ device i2c 2c on end end end #I2C5 + device ref gspi1 on + chip drivers/spi/acpi + register "name" = ""CRFP"" + register "hid" = "ACPI_DT_NAMESPACE_HID" + register "uid" = "1" + register "compat_string" = ""google,cros-ec-spi"" + register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_F15_IRQ)" + register "wake" = "GPE0_DW2_15" + register "has_power_resource" = "1" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D1)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D2)" + register "enable_delay_ms" = "3" + device spi 0 on end + end # FPMCU + end device ref pcie_rp8 off end device ref pcie_rp9 on # Enable NVMe PCIE 9 using clk 1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78427?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic7b9e29ca3cb9352fe098156924fde2719399a79 Gerrit-Change-Number: 78427 Gerrit-PatchSet: 1 Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: security/vboot: Add Kconfig option to clear recovery request
by Yu-Ping Wu (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Julius Werner, Michał Żygowski. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74343?usp=email ) Change subject: security/vboot: Add Kconfig option to clear recovery request ...................................................................... Patch Set 6: (1 comment) File src/security/vboot/bootmode.c: https://review.coreboot.org/c/coreboot/+/74343/comment/6ce716e8_3eaa93bf : PS4, Line 68: BS_ON_ENTRY > Julius, ping Let's proceed with your latest PS. If Julius has a different opinion, we can change it in the future. For now, could you add a comment explaining why this has to be `BS_ON_ENTRY`? ``` /* This has to be called before back_up_vbnv_cmos, so BS_ON_ENTRY is used here. */ ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/74343?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7ffaf3e8f61a28a68c9802c184961b1b9bf9d617 Gerrit-Change-Number: 74343 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 17 Oct 2023 03:12:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023