coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[S] Change in coreboot[main]: mb/google/rex: Set frequency and gears for SaGv points
by Subrata Banik (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Bora Guvendik, Eran Mitrani, Tarun. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78268?usp=email ) Change subject: mb/google/rex: Set frequency and gears for SaGv points ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78268?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie8a81c05f25b1cdab1008d09c606d1debea6e6e4 Gerrit-Change-Number: 78268 Gerrit-PatchSet: 2 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 17 Oct 2023 13:27:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/brya/variants/anraggar: Add initial GPIOs config
by Weimin Wu (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Nick Vaccaro, Subrata Banik, Weimin Wu. Hello Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78401?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: mb/google/brya/variants/anraggar: Add initial GPIOs config ...................................................................... mb/google/brya/variants/anraggar: Add initial GPIOs config Configure GPIOs according to schematics revision 20231012A. BUG=b:304920262 TEST=cros-workon-nissa start coreboot TEST=emerge-nissa coreboot Change-Id: I7be6829fc27ee20e014c372d704333ebfd4967b8 Signed-off-by: wuweimin <wuweimin(a)huaqin.corp-partner.google.com> --- A src/mainboard/google/brya/variants/anraggar/Makefile.inc A src/mainboard/google/brya/variants/anraggar/gpio.c 2 files changed, 121 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/78401/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78401?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7be6829fc27ee20e014c372d704333ebfd4967b8 Gerrit-Change-Number: 78401 Gerrit-PatchSet: 2 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/rex: Set frequency and gears for SaGv points
by Kapil Porwal (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Bora Guvendik, Eran Mitrani, Tarun. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78268?usp=email ) Change subject: mb/google/rex: Set frequency and gears for SaGv points ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Update the commit message as requested by Subrata. -- To view, visit https://review.coreboot.org/c/coreboot/+/78268?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie8a81c05f25b1cdab1008d09c606d1debea6e6e4 Gerrit-Change-Number: 78268 Gerrit-PatchSet: 2 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 17 Oct 2023 13:22:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/brya/variants/anraggar: Add initial GPIOs config
by Weimin Wu (Code Review) 17 Oct '23

17 Oct '23

Weimin Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78401?usp=email ) Change subject: mb/google/brya/variants/anraggar: Add initial GPIOs config ...................................................................... mb/google/brya/variants/anraggar: Add initial GPIOs config Configure GPIOs according to schematics revision 20231012A. BUG=b:304920262 TEST=cros-workon-nissa start coreboot TEST=emerge-nissa coreboot Change-Id: I7be6829fc27ee20e014c372d704333ebfd4967b8 Signed-off-by: wuweimin <wuweimin(a)huaqin.corp-partner.google.com> --- A src/mainboard/google/brya/variants/anraggar/Makefile.inc A src/mainboard/google/brya/variants/anraggar/gpio.c 2 files changed, 121 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/78401/1 diff --git a/src/mainboard/google/brya/variants/anraggar/Makefile.inc b/src/mainboard/google/brya/variants/anraggar/Makefile.inc new file mode 100644 index 0000000..d38141c --- /dev/null +++ b/src/mainboard/google/brya/variants/anraggar/Makefile.inc @@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +bootblock-y += gpio.c + +romstage-y += gpio.c + +ramstage-y += gpio.c diff --git a/src/mainboard/google/brya/variants/anraggar/gpio.c b/src/mainboard/google/brya/variants/anraggar/gpio.c new file mode 100644 index 0000000..0305de0 --- /dev/null +++ b/src/mainboard/google/brya/variants/anraggar/gpio.c @@ -0,0 +1,115 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> +#include <baseboard/variants.h> +#include <commonlib/helpers.h> +#include <soc/gpio.h> + +/* Pad configuration in ramstage */ +static const struct pad_config override_gpio_table[] = { + /* A7 : NC ==> LTE_Present */ + PAD_CFG_GPI(GPP_A7, NONE, DEEP), + /* A18 : NC ==> HDMI_HPD_SRC*/ + PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), + + /* A20 : DDSP_HPD2 ==> EC_SOC_HDMI_HPD ==> NC */ + PAD_NC(GPP_A20, NONE), + /* A21 : GPP_A21 ==> USB_C1_AUX_DC_P ==> NC */ + PAD_NC(GPP_A21, NONE), + /* A22 : GPP_A22 ==> USB_C1_AUX_DC_N ==> NC */ + PAD_NC(GPP_A22, NONE), + + /* B5 : I2C2_SDA ==> SOC_I2C_SUB_SDA ==> MIPI_WCAM_SDA */ + PAD_CFG_NF_LOCK(GPP_B5, NONE, NF2, LOCK_CONFIG), + /* B6 : I2C2_SCL ==> SOC_I2C_SUB_SCL ==> MIPI_WCAM_SCL */ + PAD_CFG_NF_LOCK(GPP_B6, NONE, NF2, LOCK_CONFIG), + + /* B11 : NC ==> EN_PP3300_WLAN_X*/ + PAD_CFG_GPO(GPP_B11, 0, DEEP), + + /* D8 : SRCCLKREQ3# ==> SD_CLKREQ_ODL ==> NC */ + PAD_NC(GPP_D8, NONE), + + /* E20 : DDP2_CTRLCLK ==> HDMI_DDC_SCL ==> NC */ + PAD_NC(GPP_E20, NONE), + /* E21 : DDP2_CTRLDATA ==> HDMI_DDC_SDA_STRAP ==> GPP_E21_STRAP */ + PAD_NC(GPP_E21, NONE), + + /* H22 : IMGCLKOUT3 ==> WCAM_MCLK_R */ + PAD_CFG_NF(GPP_H22, NONE, DEEP, NF1), + /* H23 : GPP_H23 ==> WWAN_SAR_DETECT_ODL */ + PAD_CFG_GPI_APIC(GPP_H23, NONE, PLTRST, LEVEL, INVERT), + + /* F11 : NC ==> WWAN_PWR_ON */ + PAD_CFG_GPO(GPP_F11, 0, DEEP), + /* F16 : NC ==> WWAN_PWR_ENABLE */ + PAD_CFG_GPO(GPP_F16, 0, DEEP), + /* F18 : THC1_SPI2_INT# ==> EC_IN_RW_OD ==> EN_PP2800_AVDD*/ + PAD_CFG_GPO(GPP_F18, 0, DEEP), + /* F23 : V1P05_CTRL ==> V1P05EXT_CTRL ==> NC*/ + PAD_NC(GPP_F23, NONE), + + + /* H12 : UART0_RTS# ==> SD_PERST_L ==> NC*/ + PAD_NC(GPP_H12, NONE), + /* H13 : UART0_CTS# ==> EN_PP3300_SD_X ==> NC */ + PAD_NC(GPP_H13, NONE), + /* H15 : DDPB_CTRLCLK ==> HDMI_DDC_SCL */ + PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), + /* H17 : DDPB_CTRLDATA ==> HDMI_DDC_SDA */ + PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), + + /* R6 : DMIC_CLK_A_1A ==> DMIC_WCAM_CLK_R ==> NC */ + PAD_NC(GPP_R6, NONE), + /* R7 : DMIC_DATA_1A ==> DMIC_WCAM_DATA ==> NC */ + PAD_NC(GPP_R7, NONE), +}; + +/* Early pad configuration in bootblock */ +static const struct pad_config early_gpio_table[] = { + /* H20 : IMGCLKOUT1 ==> WLAN_PERST_L */ + PAD_CFG_GPO(GPP_H20, 0, DEEP), + /* A13 : GPP_A13 ==> GSC_SOC_INT_ODL */ + PAD_CFG_GPI_APIC(GPP_A13, NONE, PLTRST, LEVEL, INVERT), + /* E12 : THC0_SPI1_IO1 ==> SOC_WP_OD */ + PAD_CFG_GPI_GPIO_DRIVER(GPP_E12, NONE, DEEP), + + /* H4 : I2C0_SDA ==> SOC_I2C_GSC_SDA */ + PAD_CFG_NF(GPP_H4, NONE, DEEP, NF1), + /* H5 : I2C0_SCL ==> SOC_I2C_GSC_SCL */ + PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1), + + /* H10 : UART0_RXD ==> UART_SOC_RX_DBG_TX */ + PAD_CFG_NF(GPP_H10, NONE, DEEP, NF2), + /* H11 : UART0_TXD ==> UART_SOC_TX_DBG_RX */ + PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2), +}; + +static const struct pad_config romstage_gpio_table[] = { + /* Enable touchscreen, hold in reset */ + /* C0 : SMBCLK ==> EN_PP3300_TCHSCR_X */ + PAD_CFG_GPO(GPP_C0, 1, DEEP), + /* C1 : SMBDATA ==> TCHSCR_RST_L */ + PAD_CFG_GPO(GPP_C1, 0, DEEP), + + /* H20 : IMGCLKOUT1 ==> WLAN_PERST_L */ + PAD_CFG_GPO(GPP_H20, 1, DEEP), +}; + +const struct pad_config *variant_gpio_override_table(size_t *num) +{ + *num = ARRAY_SIZE(override_gpio_table); + return override_gpio_table; +} + +const struct pad_config *variant_early_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(early_gpio_table); + return early_gpio_table; +} + +const struct pad_config *variant_romstage_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(romstage_gpio_table); + return romstage_gpio_table; +} -- To view, visit https://review.coreboot.org/c/coreboot/+/78401?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7be6829fc27ee20e014c372d704333ebfd4967b8 Gerrit-Change-Number: 78401 Gerrit-PatchSet: 1 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: drivers/wwan/fm: Wake up modem on PEWAKE# signal change
by Paweł Anikiel (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Kornel Dulęba, Nick Vaccaro, Paul Menzel, Subrata Banik. Paweł Anikiel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78297?usp=email ) Change subject: drivers/wwan/fm: Wake up modem on PEWAKE# signal change ...................................................................... Patch Set 5: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78297/comment/827f6c11_d9556a3a : PS4, Line 13: TEST=Compiled and tested on google/redrix > Tested how exactly? I included a description. File src/drivers/wwan/fm/acpi_fm350gl.c: https://review.coreboot.org/c/coreboot/+/78297/comment/ea45cb25_ad95fb15 : PS3, Line 6: #if CONFIG(GENERIC_GPIO_LIB) : #include <gpio.h> : #endif > Same as below, it's copied over from `acpi/device.c`. I took a look, and I think including the file unconditionally should work. https://review.coreboot.org/c/coreboot/+/78297/comment/ec6854d1_b069f568 : PS3, Line 287: #if CONFIG(GENERIC_GPIO_LIB) > > I needed to get the pin number and the GPIO controller's scope name from a `struct acpi_gpio`. […] I changed it to an if statement as you suggested. As for bailing out early, `acpi_device_write_gpio()` seems to just use the value it got from `pins[0]`. File src/drivers/wwan/fm/acpi_fm350gl.c: https://review.coreboot.org/c/coreboot/+/78297/comment/305d0a5c_11da4a2b : PS4, Line 293: __func__); > Please also print out pin value. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78297?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I32257689da85ea71f9de781093b3ede0cfe70a0e Gerrit-Change-Number: 78297 Gerrit-PatchSet: 5 Gerrit-Owner: Paweł Anikiel <panikiel(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com> Gerrit-CC: Kornel Dulęba <korneld(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kornel Dulęba <korneld(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 17 Oct 2023 13:16:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paweł Anikiel <panikiel(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/rex: Set frequency and gears for SaGv points
by Kapil Porwal (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Bora Guvendik, Eran Mitrani, Tarun. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78268?usp=email ) Change subject: mb/google/rex: Set frequency and gears for SaGv points ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Verified on rex. No boot time regression seen. -- To view, visit https://review.coreboot.org/c/coreboot/+/78268?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie8a81c05f25b1cdab1008d09c606d1debea6e6e4 Gerrit-Change-Number: 78268 Gerrit-PatchSet: 2 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 17 Oct 2023 12:59:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/gigabyte/ga-h77m-d3h: Add Sandy/Ivy Bridge board GA-H77M-D3H
by Fabian Groffen (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Keith Hui. Fabian Groffen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77046?usp=email ) Change subject: mb/gigabyte/ga-h77m-d3h: Add Sandy/Ivy Bridge board GA-H77M-D3H ...................................................................... Patch Set 3: (1 comment) File src/mainboard/gigabyte/ga-h77m-d3h/early_init.c: https://review.coreboot.org/c/coreboot/+/77046/comment/5b20189b_97938737 : PS1, Line 61: vo > So 800mhz does work for you. Good to know. Super off-topic here, but p8z77-m and p8h77-m both seem to do the same thing, and use 800MHz. -- To view, visit https://review.coreboot.org/c/coreboot/+/77046?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icb3e74326a0a7aaf770d1917a2a0931feadd7eab Gerrit-Change-Number: 77046 Gerrit-PatchSet: 3 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Keith Hui <buurin(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Tue, 17 Oct 2023 12:58:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Keith Hui <buurin(a)gmail.com> Comment-In-Reply-To: Fabian Groffen <grobian(a)gentoo.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brya: Set WWAN_PCIE_WAKE_ODL as interrupt on Redrix
by Paweł Anikiel (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Nick Vaccaro, Paul Menzel. Paweł Anikiel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78416?usp=email ) Change subject: mb/google/brya: Set WWAN_PCIE_WAKE_ODL as interrupt on Redrix ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78416/comment/c6d00b3e_cf575ae7 : PS3, Line 11: to setup > The verb is spelled with a space: to set up. Done https://review.coreboot.org/c/coreboot/+/78416/comment/bd795655_48ef99e0 : PS3, Line 12: > Please mention the source. […] I'm not aware of any publicly available ones, unfortunately. -- To view, visit https://review.coreboot.org/c/coreboot/+/78416?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I37f6836aefe4a374eaff3e4bc11358be274cf563 Gerrit-Change-Number: 78416 Gerrit-PatchSet: 4 Gerrit-Owner: Paweł Anikiel <panikiel(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com> Gerrit-CC: Kornel Dulęba <korneld(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 17 Oct 2023 12:57:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/wwan/fm: Wake up modem on PEWAKE# signal change
by Paweł Anikiel (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Kornel Dulęba, Nick Vaccaro, Paweł Anikiel. Hello Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78297?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: drivers/wwan/fm: Wake up modem on PEWAKE# signal change ...................................................................... drivers/wwan/fm: Wake up modem on PEWAKE# signal change Create an event handler for the PEWAKE# GPIO and notify the device driver to wake up the device. BUG=b:301150499 TEST=Compiled and tested on google/redrix: 1. Enable runtime suspend for linux mtk_t7xx driver 2. Wait for device to enter suspended state 3. Modem should be able to wake up driver, e.g. on SIM card insert/eject The interrupts should show up under /proc/interrupts as ACPI:Event Signed-off-by: Paweł Anikiel <panikiel(a)google.com> Change-Id: I32257689da85ea71f9de781093b3ede0cfe70a0e --- M src/drivers/wwan/fm/acpi_fm350gl.c 1 file changed, 55 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/78297/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/78297?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I32257689da85ea71f9de781093b3ede0cfe70a0e Gerrit-Change-Number: 78297 Gerrit-PatchSet: 5 Gerrit-Owner: Paweł Anikiel <panikiel(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com> Gerrit-CC: Kornel Dulęba <korneld(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paweł Anikiel <panikiel(a)google.com> Gerrit-Attention: Kornel Dulęba <korneld(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/brya: Set WWAN_PCIE_WAKE_ODL as interrupt on Redrix
by Paweł Anikiel (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Nick Vaccaro, Paweł Anikiel. Hello Nick Vaccaro, Paul Menzel, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78416?usp=email to look at the new patch set (#4). Change subject: mb/google/brya: Set WWAN_PCIE_WAKE_ODL as interrupt on Redrix ...................................................................... mb/google/brya: Set WWAN_PCIE_WAKE_ODL as interrupt on Redrix This signal gets deasserted by the WWAN modem to reactivate the PCIe link when in low power mode. In order to handle this efficiently, the kernel needs to set up an interrupt. BUG=b:301150499 TEST=Compiled and tested on google/redrix Signed-off-by: Paweł Anikiel <panikiel(a)google.com> Change-Id: I37f6836aefe4a374eaff3e4bc11358be274cf563 --- M src/mainboard/google/brya/variants/baseboard/brya/gpio.c M src/mainboard/google/brya/variants/redrix/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/78416/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/78416?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I37f6836aefe4a374eaff3e4bc11358be274cf563 Gerrit-Change-Number: 78416 Gerrit-PatchSet: 4 Gerrit-Owner: Paweł Anikiel <panikiel(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com> Gerrit-CC: Kornel Dulęba <korneld(a)google.com> Gerrit-Attention: Paweł Anikiel <panikiel(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023