coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[XS] Change in coreboot[main]: soc/amd/genoa: Add MAX_CPUS
by Varshit Pandya (Code Review) 17 Oct '23

17 Oct '23

Varshit Pandya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78402?usp=email ) Change subject: soc/amd/genoa: Add MAX_CPUS ...................................................................... soc/amd/genoa: Add MAX_CPUS Change-Id: I817fea7c41477f476794e9e5c16451037d01f912 Signed-off-by: Varshit Pandya <pandyavarshit(a)gmail.com> --- M src/soc/amd/genoa/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/78402/1 diff --git a/src/soc/amd/genoa/Kconfig b/src/soc/amd/genoa/Kconfig index af4056a..fc4bf57 100644 --- a/src/soc/amd/genoa/Kconfig +++ b/src/soc/amd/genoa/Kconfig @@ -44,6 +44,10 @@ hex default 0x1000 +config MAX_CPUS + int + default 384 + config PSP_APOB_DRAM_ADDRESS hex default 0x7001000 -- To view, visit https://review.coreboot.org/c/coreboot/+/78402?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I817fea7c41477f476794e9e5c16451037d01f912 Gerrit-Change-Number: 78402 Gerrit-PatchSet: 1 Gerrit-Owner: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: mb/google/rex: Set frequency and gears for SaGv points
by Bora Guvendik (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Eran Mitrani, Subrata Banik, Tarun. Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78268?usp=email ) Change subject: mb/google/rex: Set frequency and gears for SaGv points ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > can you please highlight the reason behind this new tuning values? With new values, we achieve power reduction with no significant performance degradation Partner bug is updated with more detailed information and measurement. -- To view, visit https://review.coreboot.org/c/coreboot/+/78268?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie8a81c05f25b1cdab1008d09c606d1debea6e6e4 Gerrit-Change-Number: 78268 Gerrit-PatchSet: 2 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 17 Oct 2023 16:30:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/gothrax: Supplement register settings for SX9324 ...
by Kyle Lin (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Derek Huang, Nick Vaccaro, Subrata Banik, Yunlong Jia. Kyle Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78289?usp=email ) Change subject: mb/google/nissa/var/gothrax: Supplement register settings for SX9324 P-sensor ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78289?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib15f12d754fec8b379afd702b27d0701fac78072 Gerrit-Change-Number: 78289 Gerrit-PatchSet: 4 Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 17 Oct 2023 16:17:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/amd/stoneyridge: Use common block graphics driver
by CoolStar (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Matt DeVillier, Paul Menzel. CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78428?usp=email ) Change subject: soc/amd/stoneyridge: Use common block graphics driver ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78428/comment/41d95038_78090e30 : PS2, Line 11: don't write the : ACPI device for the GPU as stoney already defines it statically. > wouldn't it be better to remove the statically defined version and just have commonality across the […] attempting to use the common version on Stoney causes an ACPI_BIOS_ERROR in windows on Stoney File src/soc/amd/common/block/graphics/graphics.c: https://review.coreboot.org/c/coreboot/+/78428/comment/14b146bb_656de48b : PS2, Line 183: #if CONFIG(RUN_FSP_GOP) > Why not keep the C version? compilation fails if it’s not changed to the pre processor version as Stoney does not use FSP (and has no FSP headers) -- To view, visit https://review.coreboot.org/c/coreboot/+/78428?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I260b964be59c1a208ff907c474243a9ace03f206 Gerrit-Change-Number: 78428 Gerrit-PatchSet: 2 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 17 Oct 2023 16:07:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/kahlee: Fix backlight settings in Windows
by CoolStar (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Jason Nien, Martin Roth, Matt DeVillier. CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78429?usp=email ) Change subject: mb/google/kahlee: Fix backlight settings in Windows ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78429/comment/4a4e5aaa_9c79149a : PS2, Line 12: Observe display turns on after 30 : minutes with brightness controls functional. > are they immediately functional with your modified driver? yes -- To view, visit https://review.coreboot.org/c/coreboot/+/78429?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6792a91f26a5f6e4dc478cdde776ff749f08946f Gerrit-Change-Number: 78429 Gerrit-PatchSet: 2 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Tue, 17 Oct 2023 16:04:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/{adl, mtl}: Avoid redundant display init by joining to MBUS
by Nick Vaccaro (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Nick Vaccaro, Paz Zcharya, Subrata Banik, Tarun. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78387?usp=email ) Change subject: soc/intel/{adl, mtl}: Avoid redundant display init by joining to MBUS ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78387?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I36af167afa902053a987602d494a8830ad9b1b1a Gerrit-Change-Number: 78387 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 17 Oct 2023 16:04:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/kahlee: Fix backlight settings in Windows
by Matt DeVillier (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: CoolStar, Jason Nien, Martin Roth. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78429?usp=email ) Change subject: mb/google/kahlee: Fix backlight settings in Windows ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78429/comment/5a978c65_3808d38b : PS2, Line 12: Observe display turns on after 30 : minutes with brightness controls functional. are they immediately functional with your modified driver? -- To view, visit https://review.coreboot.org/c/coreboot/+/78429?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6792a91f26a5f6e4dc478cdde776ff749f08946f Gerrit-Change-Number: 78429 Gerrit-PatchSet: 2 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Tue, 17 Oct 2023 14:20:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/amd/stoneyridge: Use common block graphics driver
by Matt DeVillier (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: CoolStar, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78428?usp=email ) Change subject: soc/amd/stoneyridge: Use common block graphics driver ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78428/comment/9eb2be5a_d53b21ea : PS2, Line 11: don't write the : ACPI device for the GPU as stoney already defines it statically. wouldn't it be better to remove the statically defined version and just have commonality across the board? -- To view, visit https://review.coreboot.org/c/coreboot/+/78428?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I260b964be59c1a208ff907c474243a9ace03f206 Gerrit-Change-Number: 78428 Gerrit-PatchSet: 2 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 17 Oct 2023 14:20:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brya: Set WWAN_PCIE_WAKE_ODL as interrupt on Redrix
by Jakub Czapiga (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Nick Vaccaro, Paul Menzel, Paweł Anikiel. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78416?usp=email ) Change subject: mb/google/brya: Set WWAN_PCIE_WAKE_ODL as interrupt on Redrix ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78416/comment/889a023f_4e952f1a : PS3, Line 12: > I'm not aware of any publicly available ones, unfortunately. This patch does not change the GPIO connections, just function of one of them, so schematic should not be necessary. It should have been configured this way from the beginning. -- To view, visit https://review.coreboot.org/c/coreboot/+/78416?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I37f6836aefe4a374eaff3e4bc11358be274cf563 Gerrit-Change-Number: 78416 Gerrit-PatchSet: 4 Gerrit-Owner: Paweł Anikiel <panikiel(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com> Gerrit-CC: Kornel Dulęba <korneld(a)google.com> Gerrit-Attention: Paweł Anikiel <panikiel(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 17 Oct 2023 14:12:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paweł Anikiel <panikiel(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/kahlee: Rework I2S/ACP ACPI for new Windows driver
by Matt DeVillier (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: CoolStar, Jason Nien, Martin Roth, Martin Roth, Nico Huber, Paul Menzel. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78406?usp=email ) Change subject: mb/google/kahlee: Rework I2S/ACP ACPI for new Windows driver ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78406?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I51527a1bfae3e12ce5cf1da8a3465bbc9ddfa76e Gerrit-Change-Number: 78406 Gerrit-PatchSet: 5 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Tue, 17 Oct 2023 13:59:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023