coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[M] Change in coreboot[master]: soc/intel/meteorlake: provide a list of D-states to enter LPM
by Eran Mitrani (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71644 to look at the new patch set (#6). Change subject: soc/intel/meteorlake: provide a list of D-states to enter LPM ...................................................................... soc/intel/meteorlake: provide a list of D-states to enter LPM Provide D-states to enter LPM (S0ix) for MTL Values were copied over from corresponding ADL file (as MTL data sheet is not yet available). TEST=Built and tested on Rex by verifying SSDT contents Change-Id: If367511a29726669fe25ad2124e2f9b877a31ee8 Signed-off-by: Eran Mitrani <mitrani(a)google.com> --- M src/soc/intel/meteorlake/acpi.c 1 file changed, 88 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/71644/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/71644 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If367511a29726669fe25ad2124e2f9b877a31ee8 Gerrit-Change-Number: 71644 Gerrit-PatchSet: 6 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/meteorlake: provide a list of D-states to enter LPM
by Eran Mitrani (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71644 to look at the new patch set (#5). Change subject: soc/intel/meteorlake: provide a list of D-states to enter LPM ...................................................................... soc/intel/meteorlake: provide a list of D-states to enter LPM Provide D-states to enter LPM (S0ix) for MTL Values were copied over from coresponding ADL file (as MTL data sheet is not yet available). TEST=Built and tested on Rex by verifying SSDT contents Change-Id: If367511a29726669fe25ad2124e2f9b877a31ee8 Signed-off-by: Eran Mitrani <mitrani(a)google.com> --- M src/soc/intel/meteorlake/acpi.c 1 file changed, 88 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/71644/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/71644 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If367511a29726669fe25ad2124e2f9b877a31ee8 Gerrit-Change-Number: 71644 Gerrit-PatchSet: 5 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/meteorlake: provide a list of D-states to enter LPM
by build bot (Jenkins) (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71644 ) Change subject: soc/intel/meteorlake: provide a list of D-states to enter LPM ...................................................................... Patch Set 4: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167673): https://review.coreboot.org/c/coreboot/+/71644/comment/b6447606_cf7ea2d4 PS4, Line 10: 'coresponding' may be misspelled - perhaps 'corresponding'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167673): https://review.coreboot.org/c/coreboot/+/71644/comment/cdc3b1ea_818f9835 PS4, Line 17: Change-Id: If367511a29726669fe25ad2124e2f9b877a31ee8 Duplicate signature -- To view, visit https://review.coreboot.org/c/coreboot/+/71644 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If367511a29726669fe25ad2124e2f9b877a31ee8 Gerrit-Change-Number: 71644 Gerrit-PatchSet: 4 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 21:04:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/meteorlake: provide a list of D-states to enter LPM
by Eran Mitrani (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71644 to look at the new patch set (#4). Change subject: soc/intel/meteorlake: provide a list of D-states to enter LPM ...................................................................... soc/intel/meteorlake: provide a list of D-states to enter LPM Provide D-states to enter LPM (S0ix) for MTL Values were copied over from coresponding ADL file (as MTL data sheet is not yet available). TEST=Built and tested on Rex by verifying SSDT contents Signed-off-by: Eran Mitrani <mitrani(a)google.com> Change-Id: If367511a29726669fe25ad2124e2f9b877a31ee8 Signed-off-by: Eran Mitrani <mitrani(a)google.com> --- M src/soc/intel/meteorlake/acpi.c 1 file changed, 89 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/71644/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/71644 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If367511a29726669fe25ad2124e2f9b877a31ee8 Gerrit-Change-Number: 71644 Gerrit-PatchSet: 4 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/meteorlake: provide a list of D-states to enter LPM
by Eran Mitrani (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71644 ) Change subject: soc/intel/meteorlake: provide a list of D-states to enter LPM ...................................................................... Patch Set 3: (1 comment) File src/soc/intel/meteorlake/acpi.c: https://review.coreboot.org/c/coreboot/+/71644/comment/6fe4c6ff_110c4b5d PS1, Line 172: // { SA_DEVFN_CPU_PCIE1_0, ACPI_DEVICE_SLEEP_D3 }, > u can refer to the doc:640228 for adding lists of PCI devices. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/71644 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If367511a29726669fe25ad2124e2f9b877a31ee8 Gerrit-Change-Number: 71644 Gerrit-PatchSet: 3 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 20:51:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/meteorlake: provide a list of D-states to enter LPM
by build bot (Jenkins) (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71644 ) Change subject: soc/intel/meteorlake: provide a list of D-states to enter LPM ...................................................................... Patch Set 3: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167672): https://review.coreboot.org/c/coreboot/+/71644/comment/a639cba4_c7fb6932 PS3, Line 10: 'coresponding' may be misspelled - perhaps 'corresponding'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167672): https://review.coreboot.org/c/coreboot/+/71644/comment/39dbc92e_1c956402 PS3, Line 17: Change-Id: If367511a29726669fe25ad2124e2f9b877a31ee8 Duplicate signature -- To view, visit https://review.coreboot.org/c/coreboot/+/71644 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If367511a29726669fe25ad2124e2f9b877a31ee8 Gerrit-Change-Number: 71644 Gerrit-PatchSet: 3 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 20:50:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/meteorlake: provide a list of D-states to enter LPM
by Eran Mitrani (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71644 ) Change subject: soc/intel/meteorlake: provide a list of D-states to enter LPM ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/71644 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If367511a29726669fe25ad2124e2f9b877a31ee8 Gerrit-Change-Number: 71644 Gerrit-PatchSet: 3 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 20:50:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Revert "mb/google/brya: Add romstage early graphics for brya"
by Jakub Czapiga (Code Review) 04 Jan '23

04 Jan '23

Jakub Czapiga has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71280 ) Change subject: Revert "mb/google/brya: Add romstage early graphics for brya" ...................................................................... Revert "mb/google/brya: Add romstage early graphics for brya" This reverts commit 96d9b756690839c17b307a93b8a1898bd1c02ff5. Reason for revert: Merged out of order, broke tree Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: Iac2d78f2d6c687f52dc720e8d8dcb5cf7a171c9d Reviewed-on: https://review.coreboot.org/c/coreboot/+/71280 Reviewed-by: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/brya/Makefile.inc D src/mainboard/google/brya/gma-mainboard.ads M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb 3 files changed, 18 insertions(+), 45 deletions(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/mainboard/google/brya/Makefile.inc b/src/mainboard/google/brya/Makefile.inc index ab80e32..c40f21c 100644 --- a/src/mainboard/google/brya/Makefile.inc +++ b/src/mainboard/google/brya/Makefile.inc @@ -4,7 +4,6 @@ romstage-$(CONFIG_CHROMEOS) += chromeos.c romstage-y += romstage.c -romstage-$(CONFIG_MAINBOARD_USE_EARLY_LIBGFXINIT) += gma-mainboard.ads ramstage-$(CONFIG_CHROMEOS) += chromeos.c ramstage-y += mainboard.c diff --git a/src/mainboard/google/brya/gma-mainboard.ads b/src/mainboard/google/brya/gma-mainboard.ads deleted file mode 100644 index 3b02f14..0000000 --- a/src/mainboard/google/brya/gma-mainboard.ads +++ /dev/null @@ -1,13 +0,0 @@ --- SPDX-License-Identifier: GPL-2.0-or-later - -with HW.GFX.GMA; -with HW.GFX.GMA.Display_Probing; - -use HW.GFX.GMA; -use HW.GFX.GMA.Display_Probing; - -private package GMA.Mainboard is - ports : constant Port_List := - (eDP, - others => Disabled); -end GMA.Mainboard; diff --git a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb index efc2fcb..70e7779 100644 --- a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb +++ b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb @@ -123,37 +123,7 @@ }" device domain 0 on - # The timing values can be derived from datasheet of display panel - # You can use EDID string to identify the type of display on the board - # use below command to get display info from EDID - # strings /sys/devices/pci0000:00/0000:00:02.0/drm/card0/card0-eDP-1/edid - - # refer to display PRM document (Volume 2b: Command Reference: Registers) - # for more info on display control registers - # https://01.org/linuxgraphics/documentation/hardware-specification-prms - #+-----------------------------+---------------------------------------+-----+ - #| Intel docs | devicetree.cb | eDP | - #+-----------------------------+---------------------------------------+-----+ - #| Power up delay | `gpu_panel_power_up_delay` | T3 | - #+-----------------------------+---------------------------------------+-----+ - #| Power on to backlight on | `gpu_panel_power_backlight_on_delay` | T7 | - #+-----------------------------+---------------------------------------+-----+ - #| Power Down delay | `gpu_panel_power_down_delay` | T10 | - #+-----------------------------+---------------------------------------+-----+ - #| Backlight off to power down | `gpu_panel_power_backlight_off_delay` | T9 | - #+-----------------------------+---------------------------------------+-----+ - #| Power Cycle Delay | `gpu_panel_power_cycle_delay` | T12 | - #+-----------------------------+---------------------------------------+-----+ - device ref igpu on - register "panel_cfg" = "{ - .up_delay_ms = 200, - .down_delay_ms = 50, - .cycle_delay_ms = 500, - .backlight_on_delay_ms = 1, - .backlight_off_delay_ms = 200, - .backlight_pwm_hz = 200, - }" - end + device ref igpu on end device ref dtt on end device ref tbt_pcie_rp0 on end device ref tbt_pcie_rp1 on end -- To view, visit https://review.coreboot.org/c/coreboot/+/71280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac2d78f2d6c687f52dc720e8d8dcb5cf7a171c9d Gerrit-Change-Number: 71280 Gerrit-PatchSet: 3 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-MessageType: merged

1 0

[XL] Change in coreboot[master]: mb/system76/adl-p: Add Oryx Pro 9 as a variant
by Tim Crawford (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Jeremy Soller. Hello build bot (Jenkins), Jeremy Soller, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/65610 to look at the new patch set (#12). Change subject: mb/system76/adl-p: Add Oryx Pro 9 as a variant ...................................................................... mb/system76/adl-p: Add Oryx Pro 9 as a variant The Oryx Pro 9 (oryp9) is an Alder Lake-P board. Tested with a custom TianoCore UefiPayloadPkg. Working: - PS/2 keyboard, touchpad - Both DIMM slots (with NMSO480E82-3200EA00) - Both M.2 NVME SSD slots (with MZVL2500HCJQ) - All USB ports - SD card reader - Webcam - Ethernet - WiFi/Bluetooth - Integrated graphics using Intel GOP driver - Internal microphone - Internal speakers - Combined headphone + mic 3.5mm audio - 3.5mm microphone input - S0ix suspend/resume - Booting Pop!_OS Linux 22.04 with kernel 6.0.6 - Internal flashing with flashrom v1.2-703-g76118a7c10ed Not working: - Discrete/Hybrid graphics - HDMI output (requires NVIDIA GPU) - Mini DisplayPort output (requires NVIDIA GPU) - Detection of devices in TBT slot on boot Change-Id: I8aac3e83f4423f444cb9ce8aa562ba465eb718c1 Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M Documentation/mainboard/index.md A Documentation/mainboard/system76/oryp9.md M src/mainboard/system76/adl-p/Kconfig M src/mainboard/system76/adl-p/Kconfig.name M src/mainboard/system76/adl-p/Makefile.inc A src/mainboard/system76/adl-p/variants/oryp9/board_info.txt A src/mainboard/system76/adl-p/variants/oryp9/data.vbt A src/mainboard/system76/adl-p/variants/oryp9/gpio.c A src/mainboard/system76/adl-p/variants/oryp9/gpio_early.c A src/mainboard/system76/adl-p/variants/oryp9/hda_verb.c A src/mainboard/system76/adl-p/variants/oryp9/overridetree.cb A src/mainboard/system76/adl-p/variants/oryp9/romstage.c A src/mainboard/system76/adl-p/variants/oryp9/tas5825m.c 13 files changed, 1,850 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/65610/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/65610 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8aac3e83f4423f444cb9ce8aa562ba465eb718c1 Gerrit-Change-Number: 65610 Gerrit-PatchSet: 12 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/system76/tgl-u: Leave TBT LSX0 as FSP configured
by Tim Crawford (Code Review) 04 Jan '23

04 Jan '23

Tim Crawford has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71666 ) Change subject: mb/system76/tgl-u: Leave TBT LSX0 as FSP configured ...................................................................... mb/system76/tgl-u: Leave TBT LSX0 as FSP configured Do not reconfigured LSX0 so that the FSP values are used. Change-Id: I7ef4af2cde4f3260f2bc2efdbf85569b0eb147fb Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M src/mainboard/system76/tgl-u/variants/darp7/gpio.c M src/mainboard/system76/tgl-u/variants/galp5/gpio.c M src/mainboard/system76/tgl-u/variants/lemp10/gpio.c 3 files changed, 18 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/71666/1 diff --git a/src/mainboard/system76/tgl-u/variants/darp7/gpio.c b/src/mainboard/system76/tgl-u/variants/darp7/gpio.c index ad18ca6..3e0bc77 100644 --- a/src/mainboard/system76/tgl-u/variants/darp7/gpio.c +++ b/src/mainboard/system76/tgl-u/variants/darp7/gpio.c @@ -137,8 +137,8 @@ PAD_NC(GPP_E15, NONE), // ALERT# PAD_CFG_GPI(GPP_E16, DN_20K, DEEP), // SB_KBCRST# PAD_NC(GPP_E17, NONE), - PAD_NC(GPP_E18, NATIVE), // TBT_LSX0_TXD - programmed by FSP, see Intel document 617016 - PAD_NC(GPP_E19, NATIVE), // TBT_LSX0_RXD - programmed by FSP, see Intel document 617016 + // GPP_E18 (TBT_LSX0_TXD) configured by FSP (Ref: Intel doc 617016) + // GPP_E19 (TBT_LSX0_RXD) configured by FSP (Ref: Intel doc 617016) PAD_NC(GPP_E20, NONE), // SWI# PAD_NC(GPP_E21, NONE), // DDP2 I2C / TBT_LSX1 strap PAD_NC(GPP_E22, NONE), diff --git a/src/mainboard/system76/tgl-u/variants/galp5/gpio.c b/src/mainboard/system76/tgl-u/variants/galp5/gpio.c index 17119b3..7b8e850 100644 --- a/src/mainboard/system76/tgl-u/variants/galp5/gpio.c +++ b/src/mainboard/system76/tgl-u/variants/galp5/gpio.c @@ -131,8 +131,8 @@ PAD_NC(GPP_E15, NONE), // ALERT#_R PAD_CFG_GPI(GPP_E16, DN_20K, DEEP), // SB_KBCRST# PAD_NC(GPP_E17, NONE), - PAD_NC(GPP_E18, NONE), // TBT_LSX0_TXD - programmed by FSP, see Intel document 617016 - PAD_NC(GPP_E19, NONE), // TBT_LSX0_RXD - programmed by FSP, see Intel document 617016 + // GPP_E18 (TBT_LSX0_TXD) configured by FSP (Ref: Intel doc 617016) + // GPP_E19 (TBT_LSX0_RXD) configured by FSP (Ref: Intel doc 617016) PAD_NC(GPP_E20, NONE), PAD_NC(GPP_E21, NONE), PAD_NC(GPP_E22, NONE), diff --git a/src/mainboard/system76/tgl-u/variants/lemp10/gpio.c b/src/mainboard/system76/tgl-u/variants/lemp10/gpio.c index cca2056..cd9f833 100644 --- a/src/mainboard/system76/tgl-u/variants/lemp10/gpio.c +++ b/src/mainboard/system76/tgl-u/variants/lemp10/gpio.c @@ -131,8 +131,8 @@ PAD_CFG_GPI(GPP_E15, DN_20K, DEEP), // SCI# _PAD_CFG_STRUCT(GPP_E16, 0x82840100, 0x0000), // SMI# PAD_NC(GPP_E17, NONE), - PAD_NC(GPP_E18, NONE), // TBT_LSX0_TXD - programmed by FSP, see Intel document 617016 - PAD_NC(GPP_E19, NONE), // TBT_LSX0_RXD - programmed by FSP, see Intel document 617016 + // GPP_E18 (TBT_LSX0_TXD) configured by FSP (Ref: Intel doc 617016) + // GPP_E19 (TBT_LSX0_RXD) configured by FSP (Ref: Intel doc 617016) _PAD_CFG_STRUCT(GPP_E20, 0x40880100, 0x0000), // SWI# PAD_NC(GPP_E21, NONE), // GPP_E21 - DDP2 I2C / TBT_LSX1 pin voltage (L=1.8V, H=3.3V) PAD_NC(GPP_E22, NONE), -- To view, visit https://review.coreboot.org/c/coreboot/+/71666 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ef4af2cde4f3260f2bc2efdbf85569b0eb147fb Gerrit-Change-Number: 71666 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023