coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[M] Change in coreboot[master]: cpu/x86/smm: Enable setting SMM console log level from mainboard
by Jonathan Zhang (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Marc Jones, Martin L Roth, Patrick Rudolph, Johnny Lin, Rocky Phagura, Jingle Hsu, Angel Pons, Arthur Heymans, Morgan Jang, Kyösti Mälkki. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49460 ) Change subject: cpu/x86/smm: Enable setting SMM console log level from mainboard ...................................................................... Patch Set 27: (1 comment) Patchset: PS27: There is a merge conflict. -- To view, visit https://review.coreboot.org/c/coreboot/+/49460 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81722a4f1bf75ec942cc06e403ad702dfe938e71 Gerrit-Change-Number: 49460 Gerrit-PatchSet: 27 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Rocky Phagura Gerrit-Reviewer: Rocky Phagura <rphagura(a)fb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Rocky Phagura <rphagura(a)fb.com> Gerrit-Attention: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 23:00:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Add retimer flag for mux device
by Prashant Malani (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Caveh Jalali, Boris Mittelberg. Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71663 ) Change subject: ec/google/chromeec: Add retimer flag for mux device ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/71663/comment/a4ef0bfb_b5e62a2e PS1, Line 10: instead of assuming that all ports have retimers > is there any code which depends on the original definition […] TimW had me add modifications to brya0, just to ensure things are build tested, but those should still build fine even with this patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/71663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754323236d2912777b63cede0fce2ccf7882cfea Gerrit-Change-Number: 71663 Gerrit-PatchSet: 1 Gerrit-Owner: Prashant Malani <pmalani(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 22:52:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Caveh Jalali <caveh(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: utils/inteltool: Add support to print Key Locker status
by Pratikkumar V Prajapati (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Stefan Reinauer. Hello Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71657 to look at the new patch set (#2). Change subject: utils/inteltool: Add support to print Key Locker status ...................................................................... utils/inteltool: Add support to print Key Locker status Add commandline option "-k" to print status. Sample output: $ inteltool -k ============= Dumping INTEL Key Locker status ============= Key Locker supported : YES AESKL instructions enabled : NO =========================================================== Change-Id: Icb1b08619b1dbc535640127f7ab5f6b49d70a6fe Signed-off-by: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.com> --- M util/inteltool/cpu.c M util/inteltool/inteltool.c M util/inteltool/inteltool.h 3 files changed, 90 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/71657/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb1b08619b1dbc535640127f7ab5f6b49d70a6fe Gerrit-Change-Number: 71657 Gerrit-PatchSet: 2 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: utils/inteltool: Add support to print Key Locker status
by Pratikkumar V Prajapati (Code Review) 04 Jan '23

04 Jan '23

Pratikkumar V Prajapati has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71657 ) Change subject: utils/inteltool: Add support to print Key Locker status ...................................................................... utils/inteltool: Add support to print Key Locker status Add commandline option "-k" to print status. Sample output: $ inteltool -k ============= Dumping INTEL Key Locker status ============= Key Locker supported : YES AESKL instructions enabled : NO =========================================================== Change-Id: Icb1b08619b1dbc535640127f7ab5f6b49d70a6fe Signed-off-by: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.com> --- M util/inteltool/cpu.c M util/inteltool/inteltool.c M util/inteltool/inteltool.h 3 files changed, 90 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/71657/1 diff --git a/util/inteltool/cpu.c b/util/inteltool/cpu.c index 7425229..b6c7ebf 100644 --- a/util/inteltool/cpu.c +++ b/util/inteltool/cpu.c @@ -17,16 +17,21 @@ # define BREG "%%ebx" #endif -#define IA32_FEATURE_CONTROL 0x3a -#define SGX_GLOBAL_ENABLED (1 << 18) -#define FEATURE_CONTROL_LOCKED (1) -#define MTRR_CAP_MSR 0xfe -#define PRMRR_SUPPORTED (1 << 12) -#define SGX_SUPPORTED (1 << 2) -#define IA32_TME_ACTIVATE 0x982 -#define TME_SUPPORTED (1 << 13) -#define TME_LOCKED (1) -#define TME_ENABLED (1 << 1) + +#define CPUID_STRUCT_EXTENDED_FEATURE_FLAGS 0x7 +#define IA32_FEATURE_CONTROL 0x3a +#define SGX_GLOBAL_ENABLED (1 << 18) +#define FEATURE_CONTROL_LOCKED (1) +#define MTRR_CAP_MSR 0xfe +#define PRMRR_SUPPORTED (1 << 12) +#define SGX_SUPPORTED (1 << 2) +#define IA32_TME_ACTIVATE 0x982 +#define TME_SUPPORTED (1 << 13) +#define TME_LOCKED (1) +#define TME_ENABLED (1 << 1) +#define CPUID_KEYLOCKER_FEATURE_FLAGS 0x19 +#define KEYLOCKER_SUPPORTED (1<<23) +#define KEYLOCKER_AESKL (1) int fd_msr; @@ -266,6 +271,49 @@ #endif } +static int is_keylocker_supported() +{ + cpuid_result_t cpuid_regs; + msr_t msr; + + /* + * CPUID leaf 0x7 subleaf 0x0 to detect Intel Key Locker support. + * The specification of Key Locker can be found at: https://www.intel.com/ + * content/www/us/en/develop/download/intel-key-locker-specification.html + * The spec can also be found via document #343965 on Intel's site. + */ + cpuid_regs = cpuid_ext(CPUID_STRUCT_EXTENDED_FEATURE_FLAGS, 0x0); + msr = rdmsr_from_cpu(0, MTRR_CAP_MSR); + return ((cpuid_regs.ecx & KEYLOCKER_SUPPORTED) && (msr.lo & PRMRR_SUPPORTED)); +} + +static int is_aeskl_enabled() +{ + cpuid_result_t cpuid_regs; + + /* CPUID leaf 0x19 subleaf 0x0 to detect details of Intel Key Locker feature */ + cpuid_regs = cpuid_ext(CPUID_KEYLOCKER_FEATURE_FLAGS, 0x0); + return (cpuid_regs.ebx & KEYLOCKER_AESKL); +} + +void print_keylocker(void) +{ +#ifndef __DARWIN__ + int keylocker_supported = is_keylocker_supported(); + + printf("\n============= Dumping INTEL Key Locker status =============\n"); + + printf("Key Locker supported : %s\n", keylocker_supported ? "YES" : "NO"); + + if (keylocker_supported) { + printf("AESKL instructions enabled : %s\n", is_aeskl_enabled() ? "YES" : "NO"); + } + printf("====================================================\n"); +#else + printf("Not Implemented\n"); +#endif +} + int print_intel_msrs(unsigned int range_start, unsigned int range_end) { unsigned int i, core, id; diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index f4dbc1d..92a981a 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -628,6 +628,7 @@ " -A | --ambs: dump AMB registers\n" " -x | --sgx: dump SGX status\n" " -t | --tme: dump TME status\n" + " -k | --keylocker: dump Key Locker status\n" " -a | --all: dump all known (safe) registers\n" " --pcr=PORT_ID: dump all registers of a PCR port\n" " (may be specified max %d times)\n" @@ -689,7 +690,7 @@ int dump_pmbase = 0, dump_epbar = 0, dump_dmibar = 0; int dump_pciexbar = 0, dump_coremsrs = 0, dump_ambs = 0; int dump_spi = 0, dump_gfx = 0, dump_ahci = 0, dump_sgx = 0, dump_tme = 0; - int dump_lpc = 0; + int dump_lpc = 0, dump_keylocker = 0; int show_gpio_diffs = 0; size_t pcr_count = 0; uint8_t dump_pcr[MAX_PCR_PORTS]; @@ -719,10 +720,11 @@ {"sgx", 0, 0, 'x'}, {"pcr", required_argument, 0, LONG_OPT_PCR}, {"tme", 0, 0, 't'}, + {"keylocker", 0, 0, 'k'}, {0, 0, 0, 0} }; - while ((opt = getopt_long(argc, argv, "vh?gGrplmedPMaAsfRS:xt", + while ((opt = getopt_long(argc, argv, "vh?gGrplmedPMaAsfRS:xtk", long_options, &option_index)) != EOF) { switch (opt) { case 'v': @@ -803,6 +805,7 @@ dump_ahci = 1; dump_sgx = 1; dump_tme = 1; + dump_keylocker = 1; break; case 'A': dump_ambs = 1; @@ -816,6 +819,9 @@ case 't': dump_tme = 1; break; + case 'k': + dump_keylocker = 1; + break; case LONG_OPT_PCR: if (pcr_count < MAX_PCR_PORTS) { errno = 0; @@ -1011,6 +1017,9 @@ if (dump_tme) print_tme(); + if (dump_keylocker) + print_keylocker(); + if (pcr_count) print_pcr_ports(sb, dump_pcr, pcr_count); diff --git a/util/inteltool/inteltool.h b/util/inteltool/inteltool.h index 5b40721..130e63c 100644 --- a/util/inteltool/inteltool.h +++ b/util/inteltool/inteltool.h @@ -498,6 +498,7 @@ int print_ahci(struct pci_dev *ahci); int print_sgx(void); void print_tme(void); +void print_keylocker(void); void ivybridge_dump_timings(const char *dump_spd_file); #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/71657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb1b08619b1dbc535640127f7ab5f6b49d70a6fe Gerrit-Change-Number: 71657 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Add retimer flag for mux device
by Caveh Jalali (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Prashant Malani, Boris Mittelberg. Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71663 ) Change subject: ec/google/chromeec: Add retimer flag for mux device ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/71663/comment/63def3c3_c7baa49e PS1, Line 10: instead of assuming that all ports have retimers is there any code which depends on the original definition that needs to be updated? -- To view, visit https://review.coreboot.org/c/coreboot/+/71663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754323236d2912777b63cede0fce2ccf7882cfea Gerrit-Change-Number: 71663 Gerrit-PatchSet: 1 Gerrit-Owner: Prashant Malani <pmalani(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Prashant Malani <pmalani(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 22:47:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Revert "mb/google/brya: Define a more suitable MRC training text mess...
by Martin Roth (Code Review) 04 Jan '23

04 Jan '23

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71279 ) Change subject: Revert "mb/google/brya: Define a more suitable MRC training text message" ...................................................................... Revert "mb/google/brya: Define a more suitable MRC training text message" This reverts commit e45f70423e5da8509bae83aba84b08f8fc0f624e. Reason for revert: Merged out of order, broke tree Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: I38a7be6b94199d3a23e78114fb6708c535f241cc Reviewed-on: https://review.coreboot.org/c/coreboot/+/71279 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martin.roth(a)amd.corp-partner.google.com> --- M src/mainboard/google/brya/Kconfig 1 file changed, 17 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index a267946..bc754be 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -332,7 +332,4 @@ int default 32 -config MEMORY_TRAINING_TEXT - default "Your device is finishing an update. This may take 1-2 minutes.\\Please do not turn off your device." - endif # BOARD_GOOGLE_BRYA_COMMON -- To view, visit https://review.coreboot.org/c/coreboot/+/71279 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38a7be6b94199d3a23e78114fb6708c535f241cc Gerrit-Change-Number: 71279 Gerrit-PatchSet: 7 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: Revert "mb/google/brya: Define a more suitable MRC training text mess...
by Martin Roth (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Anil Kumar K, Tarun Tuli, Jakub Czapiga, Angel Pons, Nick Vaccaro. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71279 ) Change subject: Revert "mb/google/brya: Define a more suitable MRC training text message" ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71279 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38a7be6b94199d3a23e78114fb6708c535f241cc Gerrit-Change-Number: 71279 Gerrit-PatchSet: 6 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 22:26:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Modify GPIOs for NVMe
by Reka Norman (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: David Wu, Tarun Tuli, Martin L Roth, Dtrain Hsu, Ren Kuo, Eric Lai. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71170 ) Change subject: mb/google/nissa/var/craask: Modify GPIOs for NVMe ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If45c1a87144d5370b1ca2525295fb7947639362f Gerrit-Change-Number: 71170 Gerrit-PatchSet: 10 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 21:54:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Revert "mb/google/brya: Define a more suitable MRC training text mess...
by Jakub Czapiga (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Anil Kumar K, Tarun Tuli, Jakub Czapiga, Angel Pons, Nick Vaccaro. Hello build bot (Jenkins), Anil Kumar K, Tarun Tuli, Jérémy Compostella, Angel Pons, Nick Vaccaro, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71279 to look at the new patch set (#6). Change subject: Revert "mb/google/brya: Define a more suitable MRC training text message" ...................................................................... Revert "mb/google/brya: Define a more suitable MRC training text message" This reverts commit e45f70423e5da8509bae83aba84b08f8fc0f624e. Reason for revert: Merged out of order, broke tree Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: I38a7be6b94199d3a23e78114fb6708c535f241cc --- M src/mainboard/google/brya/Kconfig 1 file changed, 14 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/71279/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/71279 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38a7be6b94199d3a23e78114fb6708c535f241cc Gerrit-Change-Number: 71279 Gerrit-PatchSet: 6 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Add retimer flag for mux device
by Prashant Malani (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Caveh Jalali, Boris Mittelberg. Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71663 ) Change subject: ec/google/chromeec: Add retimer flag for mux device ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Build failure seems unrelated to the patch: ``` #!!!!! Error: No type defined for symbol MEMORY_TRAINING_TEXT defined at src/mainboard/google/brya/Kconfig:335. # 1 errors ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/71663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754323236d2912777b63cede0fce2ccf7882cfea Gerrit-Change-Number: 71663 Gerrit-PatchSet: 1 Gerrit-Owner: Prashant Malani <pmalani(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 21:20:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023