coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[M] Change in coreboot[master]: post_codes: Add an optional "Prefix" to post codes sent to IO
by Martin L Roth (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Martin Roth. Hello Martin Roth, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/71712 to review the following change. Change subject: post_codes: Add an optional "Prefix" to post codes sent to IO ...................................................................... post_codes: Add an optional "Prefix" to post codes sent to IO I wrote this patch for a debug effort I was doing to be able to tell which code came from coreboot. If anyone thinks it's useful I can look at getting it merged. Change-Id: Ie8a518b8ecd2a00b7a7e2109036bc9b7ea8de0cf Signed-off-by: Martin Roth <martin.roth(a)amd.corp-partner.google.com> --- M src/arch/x86/post.c M src/console/Kconfig M src/include/cpu/x86/post_code.h M src/soc/amd/common/psp_verstage/post.c 4 files changed, 48 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/71712/1 diff --git a/src/arch/x86/post.c b/src/arch/x86/post.c index 908cc3b..b56f890 100644 --- a/src/arch/x86/post.c +++ b/src/arch/x86/post.c @@ -7,8 +7,11 @@ void arch_post_code(uint8_t value) { - if (CONFIG(POST_IO)) + if (CONFIG(POST_IO)) { + if (CONFIG(ADD_POST_CODE_IDENTIFIER)) + outb(CONFIG_POST_CODE_IDENTIFIER_VALUE, CONFIG_POST_IO_PORT); outb(value, CONFIG_POST_IO_PORT); + } if (CONFIG(CMOS_POST) && !ENV_SMM) cmos_post_code(value); diff --git a/src/console/Kconfig b/src/console/Kconfig index c6aec18..5569366 100644 --- a/src/console/Kconfig +++ b/src/console/Kconfig @@ -526,6 +526,23 @@ depending on the presence of coprocessors/microcontrollers or if the platform does not support IO in the conventional x86 manner. +config ADD_POST_CODE_IDENTIFIER + bool "Add a prefix to each POST code" + depends on POST_IO + help + Because many IP blocks can write to the POST code address, it can + be difficult to differentiate between them. This allows for the + code to be prefixed with a value when sending it out to a hardware + port. + +config POST_CODE_IDENTIFIER_VALUE + hex "POST code identifer value" + depends on ADD_POST_CODE_IDENTIFIER + default 0xcb + help + Set the value to send to the POST code port along with the coreboot + POST code. + config NO_EARLY_BOOTBLOCK_POSTCODES def_bool n help diff --git a/src/include/cpu/x86/post_code.h b/src/include/cpu/x86/post_code.h index db8f90d..a0acfc6 100644 --- a/src/include/cpu/x86/post_code.h +++ b/src/include/cpu/x86/post_code.h @@ -6,10 +6,17 @@ #include <commonlib/console/post_codes.h> #if CONFIG(POST_IO) && !(ENV_BOOTBLOCK && CONFIG(NO_EARLY_BOOTBLOCK_POSTCODES)) +#if CONFIG(ADD_POST_CODE_IDENTIFIER) +#define post_code(value) \ + movb $CONFIG_POST_CODE_IDENTIFIER_VALUE, %al; \ + outb %al, $CONFIG_POST_IO_PORT; \ + movb $value, %al; \ + outb %al, $CONFIG_POST_IO_PORT +#else #define post_code(value) \ movb $value, %al; \ outb %al, $CONFIG_POST_IO_PORT - +#endif #else #define post_code(value) #endif diff --git a/src/soc/amd/common/psp_verstage/post.c b/src/soc/amd/common/psp_verstage/post.c index 5b429c9..ff4486c 100644 --- a/src/soc/amd/common/psp_verstage/post.c +++ b/src/soc/amd/common/psp_verstage/post.c @@ -6,6 +6,9 @@ void arch_post_code(u8 value) { - if (CONFIG(POST_IO) && CONFIG_POST_IO_PORT == 0x80) + if (CONFIG(POST_IO) && CONFIG_POST_IO_PORT == 0x80) { + if (CONFIG(ADD_POST_CODE_IDENTIFIER)) + svc_write_postcode(CONFIG_POST_CODE_IDENTIFIER_VALUE); svc_write_postcode(value); + } } -- To view, visit https://review.coreboot.org/c/coreboot/+/71712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8a518b8ecd2a00b7a7e2109036bc9b7ea8de0cf Gerrit-Change-Number: 71712 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/hp/z220_series: Drop VBOOT support
by Elyes Haouas (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Patrick Rudolph, Julius Werner, Yu-Ping Wu. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70295 ) Change subject: mb/hp/z220_series: Drop VBOOT support ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dcabda5e8ee3a0084736d3674dca31d1f5a641f Gerrit-Change-Number: 70295 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 06 Jan 2023 06:47:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/xivu: Update DPTF parameters
by Sumeet R Pawnikar (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Tarun Tuli, Ian Feng, Kangheui Won, Vidya Gopalakrishnan. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71658 ) Change subject: mb/google/nissa/var/xivu: Update DPTF parameters ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/71658 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1fcaee15a8b58b755ce0a48a1978e795b66efd7 Gerrit-Change-Number: 71658 Gerrit-PatchSet: 2 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 06:46:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Enable VBOOT_VBNV_FLASH for 2065X and 206AX
by Elyes Haouas (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Stefan Ott, Angel Pons, Alexander Couzens, Yu-Ping Wu. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70296 ) Change subject: Enable VBOOT_VBNV_FLASH for 2065X and 206AX ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I833edd4f7a328b21e81c971ba8a9aec0aad7d3d3 Gerrit-Change-Number: 70296 Gerrit-PatchSet: 4 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 06:46:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/intel/mtlrvp: Configure USB devices for MTL-RVP
by Sridhar Siricilla (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Jamie Ryu, Subrata Banik, Harsha B R, Eric Lai, Usha P. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71168 ) Change subject: mb/intel/mtlrvp: Configure USB devices for MTL-RVP ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1a0c31b7bf0f3fc06f039ad76b0cdd41f7cdd90 Gerrit-Change-Number: 71168 Gerrit-PatchSet: 5 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 06:42:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation: Update coding_style.md with refactoring section
by Elyes Haouas (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Felix Singer, Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71067 ) Change subject: Documentation: Update coding_style.md with refactoring section ...................................................................... Patch Set 1: (1 comment) File Documentation/contributing/coding_style.md: https://review.coreboot.org/c/coreboot/+/71067/comment/da1673d2_bd37eb3f PS1, Line 811: This should not be the norm > I'm note sure to understand. […] (it sounds to me as it allows to break the rules...)* -- To view, visit https://review.coreboot.org/c/coreboot/+/71067 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3508529f639ea0609d2ea2032cc52407e9543e5 Gerrit-Change-Number: 71067 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 06:31:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: treewide: Remove unused <cpu/amd/msr.h>
by Elyes Haouas (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64939 to look at the new patch set (#6). Change subject: treewide: Remove unused <cpu/amd/msr.h> ...................................................................... treewide: Remove unused <cpu/amd/msr.h> Change-Id: Id24a7c7db24f49672df9d5ceefec5b7596f23e09 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/cpu/amd/pi/00730F01/fixme.c M src/drivers/amd/agesa/bootblock.c M src/soc/amd/cezanne/root_complex.c M src/soc/amd/common/block/acpi/ivrs.c M src/soc/amd/common/block/acpi/tables.c M src/soc/amd/common/block/cpu/noncar/memmap.c M src/soc/amd/common/block/cpu/smm/finalize.c M src/soc/amd/common/block/psp/psb.c M src/soc/amd/glinda/root_complex.c M src/soc/amd/mendocino/root_complex.c M src/soc/amd/morgana/root_complex.c M src/soc/amd/picasso/agesa_acpi.c M src/soc/amd/picasso/fch.c M src/soc/amd/picasso/root_complex.c M src/soc/amd/stoneyridge/bootblock.c M src/soc/amd/stoneyridge/memmap.c M src/soc/amd/stoneyridge/northbridge.c 17 files changed, 10 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/64939/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/64939 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id24a7c7db24f49672df9d5ceefec5b7596f23e09 Gerrit-Change-Number: 64939 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: treewide: Remove unused <cpu/amd/msr.h>
by Elyes Haouas (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Felix Held. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64939 ) Change subject: treewide: Remove unused <cpu/amd/msr.h> ...................................................................... Patch Set 5: (5 comments) Patchset: PS5: > Status? If still active can you rebase on top of https://review.coreboot. […] Ack File src/cpu/amd/smm/smm_init.c: https://review.coreboot.org/c/coreboot/+/64939/comment/e4052d2f_1bdd567b PS4, Line 16: SYSCFG_MSR > defined in cpu/amd/msr. […] "cat src/include/cpu/amd/msr.h |grep SYSCFG_MSR" gives nothing File src/soc/amd/common/block/acpi/tables.c: https://review.coreboot.org/c/coreboot/+/64939/comment/ac77f946_25fa21fa PS4, Line 52: TOP_MEM > defined in cpu/amd/mtrr. […] cat src/include/cpu/amd/msr.h |grep TOP_MEM File src/soc/amd/stoneyridge/memmap.c: https://review.coreboot.org/c/coreboot/+/64939/comment/aa2d085e_d581cfbb PS4, Line 16: TOP_MEM > defined in cpu/amd/msr. […] cat src/include/cpu/amd/msr.h |grep TOP_MEM File src/soc/amd/stoneyridge/northbridge.c: https://review.coreboot.org/c/coreboot/+/64939/comment/874598be_01a206fa PS4, Line 195: TOP_MEM > same here cat src/include/cpu/amd/msr.h |grep TOP_MEM -- To view, visit https://review.coreboot.org/c/coreboot/+/64939 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id24a7c7db24f49672df9d5ceefec5b7596f23e09 Gerrit-Change-Number: 64939 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 06 Jan 2023 06:19:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: treewide: Remove unused <cpu/amd/msr.h>
by Elyes Haouas (Code Review) 06 Jan '23

06 Jan '23

Elyes Haouas has restored this change. ( https://review.coreboot.org/c/coreboot/+/64939 ) Change subject: treewide: Remove unused <cpu/amd/msr.h> ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/64939 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id24a7c7db24f49672df9d5ceefec5b7596f23e09 Gerrit-Change-Number: 64939 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: restore

1 0

[M] Change in coreboot[master]: mb/google/nissa: Disable stage cache
by Sridhar Siricilla (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Tarun Tuli, Kangheui Won, Reka Norman. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71677 ) Change subject: mb/google/nissa: Disable stage cache ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/71677/comment/3239af4c_94c6a94a PS3, Line 10: don't care about > Done Thanks Reka for the CL update! -- To view, visit https://review.coreboot.org/c/coreboot/+/71677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8015dc0808ee19cac67c2a6573d52781c6120e8c Gerrit-Change-Number: 71677 Gerrit-PatchSet: 4 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Comment-Date: Fri, 06 Jan 2023 05:50:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org> Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023