coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[S] Change in coreboot[master]: [WIP] mb/google/brya/var/skolas: Control fan based on TSR0 sensor
by Sumeet R Pawnikar (Code Review) 06 Jan '23

06 Jan '23

Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71692 ) Change subject: [WIP] mb/google/brya/var/skolas: Control fan based on TSR0 sensor ...................................................................... [WIP] mb/google/brya/var/skolas: Control fan based on TSR0 sensor Control fan based on TSR0 sensor which is placed near DDR/SoC, not based on CPU sensor temperature which changes too fast. This change is based on the discussion on bug:235311241 comment#7. BRANCH=None BUG=b:235311241, b:261749371 TEST=Built and tested on Skolas system Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com> Change-Id: Ibeddce61b0d73d82a85f486e7cb5cbfa9568953c --- M src/mainboard/google/brya/variants/skolas/overridetree.cb 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/71692/1 diff --git a/src/mainboard/google/brya/variants/skolas/overridetree.cb b/src/mainboard/google/brya/variants/skolas/overridetree.cb index 0cecd14..4bad48d 100644 --- a/src/mainboard/google/brya/variants/skolas/overridetree.cb +++ b/src/mainboard/google/brya/variants/skolas/overridetree.cb @@ -124,7 +124,7 @@ ## Active Policy register "policies.active" = "{ [0] = { - .target = DPTF_CPU, + .target = DPTF_TEMP_SENSOR_0, .thresholds = { TEMP_PCT(85, 90), TEMP_PCT(80, 80), -- To view, visit https://review.coreboot.org/c/coreboot/+/71692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibeddce61b0d73d82a85f486e7cb5cbfa9568953c Gerrit-Change-Number: 71692 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/dibbi: Generate SPD ID for supported parts
by Sam McNally (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Liam Flaherty. Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71710 ) Change subject: mb/google/dedede/var/dibbi: Generate SPD ID for supported parts ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/dedede/variants/dibbi/memory/mem_parts_used.txt: https://review.coreboot.org/c/coreboot/+/71710/comment/44c3733c_9bab46b8 PS2, Line 1: # This is a CSV file containing a list of memory parts used by this variant. Please keep this comment. -- To view, visit https://review.coreboot.org/c/coreboot/+/71710 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c95ced79e14bb4a99aa1fa5f4fc3bc0681cc1cc Gerrit-Change-Number: 71710 Gerrit-PatchSet: 2 Gerrit-Owner: Liam Flaherty <liamflaherty(a)chromium.org> Gerrit-Reviewer: Adam Mills <adamjmills(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Liam Flaherty <liamflaherty(a)chromium.org> Gerrit-Comment-Date: Fri, 06 Jan 2023 05:43:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/dedede: Create dibbi variant
by Sam McNally (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Liam Flaherty. Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71709 ) Change subject: mb/google/dedede: Create dibbi variant ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71709 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3b8d4e7f8a53323f56567cbbc03bab7f8804f286 Gerrit-Change-Number: 71709 Gerrit-PatchSet: 2 Gerrit-Owner: Liam Flaherty <liamflaherty(a)chromium.org> Gerrit-Reviewer: Adam Mills <adamjmills(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Liam Flaherty <liamflaherty(a)chromium.org> Gerrit-Comment-Date: Fri, 06 Jan 2023 05:43:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: sb/intel/common/spi: Fix building for 64bit
by Sridhar Siricilla (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Felix Singer, Angel Pons, Arthur Heymans. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69389 ) Change subject: sb/intel/common/spi: Fix building for 64bit ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69389 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7bcb6dbf286438115c854d618eaa2da21c81400d Gerrit-Change-Number: 69389 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 06 Jan 2023 05:36:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/craask: remove SAR UNUSED fw_config
by Eric Lai (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Tarun Tuli, Kangheui Won. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71690 ) Change subject: mb/google/nissa/var/craask: remove SAR UNUSED fw_config ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/71690/comment/ae4845a1_ba921aca PS1, Line 10: > `BUG=b:251287101`? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/71690 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4298376899f881dd2265aef5a0bbc5bcc46728a1 Gerrit-Change-Number: 71690 Gerrit-PatchSet: 2 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Comment-Date: Fri, 06 Jan 2023 05:16:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/craask: remove SAR UNUSED fw_config
by Eric Lai (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Tarun Tuli, Kangheui Won, Eric Lai. Hello build bot (Jenkins), Tarun Tuli, Kangheui Won, Reka Norman, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71690 to look at the new patch set (#2). Change subject: mb/google/nissa/var/craask: remove SAR UNUSED fw_config ...................................................................... mb/google/nissa/var/craask: remove SAR UNUSED fw_config This bit is dropped in factory. All skus can use table ID_0. BUG=b:251287101 TEST=build passed. Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Change-Id: I4298376899f881dd2265aef5a0bbc5bcc46728a1 --- M src/mainboard/google/brya/variants/craask/overridetree.cb 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/71690/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71690 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4298376899f881dd2265aef5a0bbc5bcc46728a1 Gerrit-Change-Number: 71690 Gerrit-PatchSet: 2 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/dibbi: Generate SPD ID for supported parts
by Adam Mills (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Sam McNally, Liam Flaherty. Adam Mills has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71710 ) Change subject: mb/google/dedede/var/dibbi: Generate SPD ID for supported parts ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/71710 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c95ced79e14bb4a99aa1fa5f4fc3bc0681cc1cc Gerrit-Change-Number: 71710 Gerrit-PatchSet: 2 Gerrit-Owner: Liam Flaherty <liamflaherty(a)chromium.org> Gerrit-Reviewer: Adam Mills <adamjmills(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Liam Flaherty <liamflaherty(a)chromium.org> Gerrit-Comment-Date: Fri, 06 Jan 2023 05:00:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/dedede: Create dibbi variant
by Adam Mills (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Sam McNally, Liam Flaherty. Adam Mills has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71709 ) Change subject: mb/google/dedede: Create dibbi variant ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/71709 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3b8d4e7f8a53323f56567cbbc03bab7f8804f286 Gerrit-Change-Number: 71709 Gerrit-PatchSet: 2 Gerrit-Owner: Liam Flaherty <liamflaherty(a)chromium.org> Gerrit-Reviewer: Adam Mills <adamjmills(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Liam Flaherty <liamflaherty(a)chromium.org> Gerrit-Comment-Date: Fri, 06 Jan 2023 04:58:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation: Update coding_style.md with refactoring section
by Elyes Haouas (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71067 ) Change subject: Documentation: Update coding_style.md with refactoring section ...................................................................... Patch Set 1: (1 comment) File Documentation/contributing/coding_style.md: https://review.coreboot.org/c/coreboot/+/71067/comment/a7182650_c456ca98 PS1, Line 811: This should not be the norm I'm note sure to understand. Current document is the guide and is supposed to be the norm. Here, "This should not be the norm" is related to what exactly? (it sounds to me as it allows as to break the rules...) -- To view, visit https://review.coreboot.org/c/coreboot/+/71067 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3508529f639ea0609d2ea2032cc52407e9543e5 Gerrit-Change-Number: 71067 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 04:50:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/dibbi: Generate SPD ID for supported parts
by Liam Flaherty (Code Review) 06 Jan '23

06 Jan '23

Liam Flaherty has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/71710 ) Change subject: mb/google/dedede/var/dibbi: Generate SPD ID for supported parts ...................................................................... mb/google/dedede/var/dibbi: Generate SPD ID for supported parts Add supported memory parts in the mem_parts_used.txt and generate the SPD ID for the parts. BUG=b:260934724, b:255447299 BRANCH=dedede TEST=build Change-Id: I8c95ced79e14bb4a99aa1fa5f4fc3bc0681cc1cc Signed-off-by: Liam Flaherty <liamflaherty(a)chromium.org> --- M src/mainboard/google/dedede/variants/dibbi/memory/Makefile.inc M src/mainboard/google/dedede/variants/dibbi/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/dibbi/memory/mem_parts_used.txt 3 files changed, 28 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/71710/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71710 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c95ced79e14bb4a99aa1fa5f4fc3bc0681cc1cc Gerrit-Change-Number: 71710 Gerrit-PatchSet: 2 Gerrit-Owner: Liam Flaherty <liamflaherty(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023