Attention is currently required from: Jason Glenesk, Martin L Roth, Matt DeVillier, Angel Pons.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71530 )
Change subject: Docs/releases: Update board support doc for 4.17 & 4.18 branches
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/71530
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id90a84eb9a417836a7d3fdd9b6f2f3ae34c95fc4
Gerrit-Change-Number: 71530
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 09 Jan 2023 02:33:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Piotr Król, Maciej Pijanowski, Michał Żygowski, Kacper Stojek, Michal Zygowski.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70852 )
Change subject: Documentation/distributions.md: update Dasharo description
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70852/comment/b9504e79_9bc3df92
PS2, Line 7: update
Write uppercase
https://review.coreboot.org/c/coreboot/+/70852/comment/fda94a60_53605c04
PS2, Line 9: Add info on where to contribute to Dasharo
Missing point at the end.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70852
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b7e7aa05a0cabc990bddfaf957873402ebe183f
Gerrit-Change-Number: 70852
Gerrit-PatchSet: 2
Gerrit-Owner: Kacper Stojek
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michal Zygowski <miczyg94(a)gmail.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Piotr Król <3mdeb.training(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Piotr Król <3mdeb.training(a)gmail.com>
Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Kacper Stojek
Gerrit-Attention: Michal Zygowski <miczyg94(a)gmail.com>
Gerrit-Comment-Date: Mon, 09 Jan 2023 02:31:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Piotr Król, Maciej Pijanowski, Michał Żygowski, Kacper Stojek, Michal Zygowski.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70852 )
Change subject: Documentation/distributions.md: update Dasharo description
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File Documentation/distributions.md:
https://review.coreboot.org/c/coreboot/+/70852/comment/a2d051d7_ed52c8dd
PS2, Line 74: ,
I think it sounds better when the sentence ends here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70852
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b7e7aa05a0cabc990bddfaf957873402ebe183f
Gerrit-Change-Number: 70852
Gerrit-PatchSet: 2
Gerrit-Owner: Kacper Stojek
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michal Zygowski <miczyg94(a)gmail.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Piotr Król <3mdeb.training(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Piotr Król <3mdeb.training(a)gmail.com>
Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Kacper Stojek
Gerrit-Attention: Michal Zygowski <miczyg94(a)gmail.com>
Gerrit-Comment-Date: Mon, 09 Jan 2023 02:29:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Derek Huang, Caveh Jalali, Christian Walter, Nick Vaccaro, Daisuke Nojiri, Boris Mittelberg.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70773 )
Change subject: chromeos/cr50_enable_update.c: Clear EC AP_IDLE flag
......................................................................
Patch Set 16: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/70773
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b
Gerrit-Change-Number: 70773
Gerrit-PatchSet: 16
Gerrit-Owner: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Comment-Date: Mon, 09 Jan 2023 02:24:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Derek Huang, Caveh Jalali, Christian Walter, Nick Vaccaro, Daisuke Nojiri, Eric Lai, Boris Mittelberg.
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70773 )
Change subject: chromeos/cr50_enable_update.c: Clear EC AP_IDLE flag
......................................................................
Patch Set 16: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/70773
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b
Gerrit-Change-Number: 70773
Gerrit-PatchSet: 16
Gerrit-Owner: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Comment-Date: Mon, 09 Jan 2023 02:23:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Maximilian Brune.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71665 )
Change subject: Documentation/acronyms: Add several acronyms
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Patchset:
PS3:
Just fixed some nits, typos and such. Thanks Maximilian.
--
To view, visit https://review.coreboot.org/c/coreboot/+/71665
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d925516e48231b15d9aa78c5ef05b6de1ef42ca
Gerrit-Change-Number: 71665
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Comment-Date: Mon, 09 Jan 2023 02:22:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Felix Singer has uploaded a new patch set (#3) to the change originally created by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/71665 )
Change subject: Documentation/acronyms: Add several acronyms
......................................................................
Documentation/acronyms: Add several acronyms
Change-Id: I3d925516e48231b15d9aa78c5ef05b6de1ef42ca
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
---
M Documentation/acronyms.md
1 file changed, 25 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/71665/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/71665
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d925516e48231b15d9aa78c5ef05b6de1ef42ca
Gerrit-Change-Number: 71665
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tarun Tuli, Caveh Jalali, Christian Walter, Nick Vaccaro, Daisuke Nojiri, Eric Lai, Boris Mittelberg.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70773 )
Change subject: chromeos/cr50_enable_update.c: Clear EC AP_IDLE flag
......................................................................
Patch Set 16:
(2 comments)
File src/ec/google/chromeec/ec_commands.h:
PS16:
> we should really have a separate patch to refresh ec_commands.h from […]
Agree, I will submit a separate patch to refresh ec_commands.h from EC repo.
File src/vendorcode/google/chromeos/cr50_enable_update.c:
https://review.coreboot.org/c/coreboot/+/70773/comment/91f42c0e_c63ff6bc
PS16, Line 79: printk(BIOS_INFO, "Successfully clear AP_IDLE flag");
> do we need success msg always or just able to catch the failure case is fine?
I prefer to print success msg so that we can know if the function is called or no.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70773
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b
Gerrit-Change-Number: 70773
Gerrit-PatchSet: 16
Gerrit-Owner: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Comment-Date: Mon, 09 Jan 2023 02:07:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Caveh Jalali <caveh(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Kangheui Won, Ren Kuo.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71726 )
Change subject: mb/google/nissa/var/craask: Disable storage devices based on fw_config
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71726/comment/2166a83b_7e7439ab
PS1, Line 15: TEST=Boot to OS on craask eMMC and NVMe SKUs with both unprovisioned
: fw_config and fw_config set correctly.
I've tested eMMC. Ren, could you please test NVMe?
--
To view, visit https://review.coreboot.org/c/coreboot/+/71726
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4167ee4d00b9ae8fe074c6f5e7a2d5a7382bfe6d
Gerrit-Change-Number: 71726
Gerrit-PatchSet: 1
Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Reka Norman <rekanorman(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 09 Jan 2023 02:05:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment