Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47451 )
Change subject: sb/intel/common: Move xHCI SMI callback after mainboard
......................................................................
sb/intel/common: Move xHCI SMI callback after mainboard
The only platform with xHCI is bd82x6x, and the callback merely toggles
some bits and accounts for workarounds (although the code is wrong). In
preparation for having Lynxpoint use the common SMI handler code, place
the xHCI callback after the mainboard's, which seems to be safe to do.
Change-Id: I85305ef588747bddfd414c4344c207a00a5aa8d0
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/southbridge/intel/common/smihandler.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/47451/1
diff --git a/src/southbridge/intel/common/smihandler.c b/src/southbridge/intel/common/smihandler.c
index 7610aa1..5312285 100644
--- a/src/southbridge/intel/common/smihandler.c
+++ b/src/southbridge/intel/common/smihandler.c
@@ -118,11 +118,11 @@
printk(BIOS_SPEW, "SMI#: SLP = 0x%08x\n", reg32);
slp_typ = acpi_sleep_from_pm1(reg32);
- southbridge_smm_xhci_sleep(slp_typ);
-
/* Do any mainboard sleep handling */
mainboard_smi_sleep(slp_typ);
+ southbridge_smm_xhci_sleep(slp_typ);
+
/* Log S3, S4, and S5 entry */
if (slp_typ >= ACPI_S3)
elog_gsmi_add_event_byte(ELOG_TYPE_ACPI_ENTER, slp_typ);
--
To view, visit https://review.coreboot.org/c/coreboot/+/47451
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85305ef588747bddfd414c4344c207a00a5aa8d0
Gerrit-Change-Number: 47451
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange
Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46558 )
Change subject: mb/amd/mandolin: cereme: Use 64K instead of 0x1000 for size notation
......................................................................
mb/amd/mandolin: cereme: Use 64K instead of 0x1000 for size notation
Use the more readable size notation, which also unifies it with
Mandolin’s FMD.
Change-Id: I95c22d8d775104dc046601418bd402317dd8e676
Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de>
---
M src/mainboard/amd/mandolin/variants/cereme/board.fmd
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/46558/1
diff --git a/src/mainboard/amd/mandolin/variants/cereme/board.fmd b/src/mainboard/amd/mandolin/variants/cereme/board.fmd
index b55b8b5..31a0b2a 100644
--- a/src/mainboard/amd/mandolin/variants/cereme/board.fmd
+++ b/src/mainboard/amd/mandolin/variants/cereme/board.fmd
@@ -1,7 +1,7 @@
FLASH@0xFF000000 16M {
BIOS {
EC 0x20000
- RW_MRC_CACHE 0x10000
+ RW_MRC_CACHE 64K
FMAP 0x1000
COREBOOT(CBFS)
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/46558
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95c22d8d775104dc046601418bd402317dd8e676
Gerrit-Change-Number: 46558
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newchange