coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: mb/intel/adlrvp: Enable UFS for ADL-N RVP
by Meera Ravindranath (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Subrata Banik, Wonkyu Kim, Rizwan Qureshi, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, Gwendal Grignou. Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62662 ) Change subject: mb/intel/adlrvp: Enable UFS for ADL-N RVP ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62662/comment/f12d97cb_5975b81d PS4, Line 10: also needs to be enabled. Hence, enable ISH as well. > How about: […] Ack File src/mainboard/intel/adlrvp/devicetree_n.cb: https://review.coreboot.org/c/coreboot/+/62662/comment/7b2a7707_79b963bf PS3, Line 283: on > See the code in pcie_rp.c, the `struct pcie_rp_group` arrays in particular. […] This is right, but I think Subrata was hinting at why the same logic doesn't apply for PCI devices too. @Subrata - There is no remapping logic in case of PCI devices in fsp unlike pcie and tbt RPs. Also, CB is not disabling the device 12.7 even if 12.0 is not enabled. We are able to enumerate UFS in Depthcharge CLI even without 12.0 enabled. But we see, the kernel fails enumerate 12.7 after this and enumerates only if the parent device 12.0 is enabled. Trying to check on this internally with the kernel folks and will get back. -- To view, visit https://review.coreboot.org/c/coreboot/+/62662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If15bcaffc8fd3bbbe4b181820993ab2d882bbbe1 Gerrit-Change-Number: 62662 Gerrit-PatchSet: 4 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniil Lunev <dlunev(a)chromium.org> Gerrit-CC: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Reka Norman <rekanorman(a)chromium.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Comment-Date: Mon, 04 Apr 2022 15:31:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Add support for UFS controller
by Meera Ravindranath (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Wonkyu Kim, Subrata Banik, Kangheui Won, Paul Menzel, Rizwan Qureshi, Tim Wawrzynczak, Angel Pons, Lean Sheng Tan. Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62856 ) Change subject: soc/intel/alderlake: Add support for UFS controller ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/alderlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/62856/comment/7155b2cd_158dbe27 PS2, Line 620: /* UFS */ > For reference, I got the device/function numbers from a header in slimbootloader: https://github. […] This is right, UFS controller 0 is unused in case of ADL-N/P/M. And hence we are enabling index 1. -- To view, visit https://review.coreboot.org/c/coreboot/+/62856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92f024ded64e1eaef41a7807133361d74b5009d4 Gerrit-Change-Number: 62856 Gerrit-PatchSet: 2 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniil Lunev <dlunev(a)chromium.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Mon, 04 Apr 2022 15:25:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wonkyu Kim <wonkyu.kim(a)intel.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/acpi/acpigen_usb.c: Fix False Memory leak error
by vaibhav (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Felix Singer, Nico Huber, Tim Wawrzynczak, Paul Menzel, Angel Pons. vaibhav has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62968 ) Change subject: src/acpi/acpigen_usb.c: Fix False Memory leak error ...................................................................... Patch Set 2: (1 comment) File src/acpi/acpigen_usb.c: https://review.coreboot.org/c/coreboot/+/62968/comment/0ceefa09_126adb5d PS2, Line 92: #ifdef __clang_analyzer__ : free(fresh); : #endif > I think scan-build is just stupid. […] If i am able to understand correctly, you are proposing to edit the function defintion of `acpi_dp_add_reference()` If so, to achieve this we would need to add an extra parameter `path` (so that strdup() may be called inside it) in addition to `free`ing the leak inside the definition ? -- To view, visit https://review.coreboot.org/c/coreboot/+/62968 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifed611bd0b9c1da3678386bff33bca3eac0311b4 Gerrit-Change-Number: 62968 Gerrit-PatchSet: 2 Gerrit-Owner: vaibhav <vrockz747(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 04 Apr 2022 15:21:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/ti/beaglebone/board.fmd: USe 'FLASH' for device name
by Paul Menzel (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63349 ) Change subject: mb/ti/beaglebone/board.fmd: USe 'FLASH' for device name ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63349/comment/c679c07d_e15948d1 PS1, Line 7: USe Use -- To view, visit https://review.coreboot.org/c/coreboot/+/63349 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibba938c72d42ac74dcea8e8e6478ddae510d8c03 Gerrit-Change-Number: 63349 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 04 Apr 2022 14:54:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/external/LinuxBoot: Modify Kconfig file and remove olders ve...
by Paul Menzel (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Martin Roth, Christian Walter, Stefan Reinauer, Name of user not set #1004172. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63351 ) Change subject: payloads/external/LinuxBoot: Modify Kconfig file and remove olders versions ...................................................................... Patch Set 2: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63351/comment/923630d0_43aa5675 PS2, Line 2: RatatouilleDummie I think, we cannot accept contributions without the real name of people. Better check the documentation. https://review.coreboot.org/c/coreboot/+/63351/comment/b515da13_f6dbc589 PS2, Line 7: olders older https://review.coreboot.org/c/coreboot/+/63351/comment/df001bfd_ccf40cc6 PS2, Line 9: U-Root u-root https://review.coreboot.org/c/coreboot/+/63351/comment/5a630a20_5a910bdd PS2, Line 9: The U-Root repo have modified the name of "master" branch to "main" branch : this patch remove olders versions of u-root and use the new versions Please use 72 characters per line, and add a dot/period to the end of sentences. https://review.coreboot.org/c/coreboot/+/63351/comment/886a0104_1e1845d7 PS2, Line 10: remove removes -- To view, visit https://review.coreboot.org/c/coreboot/+/63351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70c4d064b534b28ea0be987b91a30650debc6ffe Gerrit-Change-Number: 63351 Gerrit-PatchSet: 2 Gerrit-Owner: Name of user not set #1004172 Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Name of user not set #1004172 Gerrit-Comment-Date: Mon, 04 Apr 2022 14:53:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ehl/fsp_params.c: setting for intel speed step from device tree
by Paul Menzel (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Uwe Poeche, Werner Zeh. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63352 ) Change subject: ehl/fsp_params.c: setting for intel speed step from device tree ...................................................................... Patch Set 1: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63352/comment/11762012_415de973 PS1, Line 7: ehl/fsp_params.c soc/intel/ehl/fsp_params https://review.coreboot.org/c/coreboot/+/63352/comment/ec3a69f1_acd90664 PS1, Line 7: setting for intel speed step from device tree Set Intel Speed Step (Eist) from devicetree https://review.coreboot.org/c/coreboot/+/63352/comment/e06d2773_471642c4 PS1, Line 9: device tree devicetree https://review.coreboot.org/c/coreboot/+/63352/comment/75d93d54_ae14ec18 PS1, Line 10: fsps FSPS https://review.coreboot.org/c/coreboot/+/63352/comment/1a6cc9a0_cd6567f8 PS1, Line 11: fsp FSP https://review.coreboot.org/c/coreboot/+/63352/comment/94f1e115_9e729786 PS1, Line 13: / Remove File src/soc/intel/elkhartlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/63352/comment/d4955246_7aa2e4c7 PS1, Line 267: setting for intel speed step from device tree Just use: Intel Speed Step? -- To view, visit https://review.coreboot.org/c/coreboot/+/63352 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0a5ef4968a27978116c21ce35b3818c6b36e086f Gerrit-Change-Number: 63352 Gerrit-PatchSet: 1 Gerrit-Owner: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Mon, 04 Apr 2022 14:48:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util: Add amdfwread utility
by Felix Held (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Robert Zieba, Bao Zheng, Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62795 ) Change subject: util: Add amdfwread utility ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: without having looked at any of the code: there's already CB:54901 which might do a similar thing -- To view, visit https://review.coreboot.org/c/coreboot/+/62795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850 Gerrit-Change-Number: 62795 Gerrit-PatchSet: 7 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Comment-Date: Mon, 04 Apr 2022 14:09:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Override SPD file for Samsung parts
by Rob Barnes (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Robert Zieba, Karthik Ramasubramanian. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63282 ) Change subject: mb/google/guybrush/var/dewatt: Override SPD file for Samsung parts ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63282 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd08f109765933640ea3d0ad442873c30fa14bc4 Gerrit-Change-Number: 63282 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 04 Apr 2022 14:00:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/spd_tools: Add ability to override SPD file for parts
by Rob Barnes (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Robert Zieba, Reka Norman, Karthik Ramasubramanian. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63281 ) Change subject: util/spd_tools: Add ability to override SPD file for parts ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63281 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I078dd04fead2bf19f53bc6ca8295187d439adc20 Gerrit-Change-Number: 63281 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 04 Apr 2022 14:00:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util: Add amdfwread utility
by Rob Barnes (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Bao Zheng, Marshall Dawson, Felix Held. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62795 ) Change subject: util: Add amdfwread utility ...................................................................... Patch Set 7: Code-Review+1 (1 comment) Patchset: PS7: LGTM. It'd be good to get an AMD +2. -- To view, visit https://review.coreboot.org/c/coreboot/+/62795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850 Gerrit-Change-Number: 62795 Gerrit-PatchSet: 7 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 04 Apr 2022 13:57:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022