coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: drivers/lenovo/hybrid: Add GPIO settings for DDC mux
by Swift Geek (Sebastian Grzywna) (Code Review) 10 Apr '22

10 Apr '22

Attention is currently required from: Nico Huber. Swift Geek (Sebastian Grzywna) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63529 ) Change subject: drivers/lenovo/hybrid: Add GPIO settings for DDC mux ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib92d07a07e895d325bcd1106184f71106f2ea515 Gerrit-Change-Number: 63529 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sun, 10 Apr 2022 13:52:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [TESTME] mb/lenovo/t410: Complete and fix hybrid-graphics config
by Swift Geek (Sebastian Grzywna) (Code Review) 10 Apr '22

10 Apr '22

Attention is currently required from: Nico Huber, Paul Menzel, Alexander Couzens. Swift Geek (Sebastian Grzywna) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63530 ) Change subject: [TESTME] mb/lenovo/t410: Complete and fix hybrid-graphics config ...................................................................... Patch Set 1: (1 comment) File src/mainboard/lenovo/t410/devicetree.cb: https://review.coreboot.org/c/coreboot/+/63530/comment/c1bfe939_f0cb9571 PS1, Line 138: # -DISCRETE_PRESENCE > What does the - in the beginning denote? Same as /SIGNAL or ~SIGNAL or overbar - means "Active Low" -- To view, visit https://review.coreboot.org/c/coreboot/+/63530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia42416b7d2aeebe193747f88bc168a9e0838e449 Gerrit-Change-Number: 63530 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 10 Apr 2022 13:04:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Add support to control CSE firmware update
by Paul Menzel (Code Review) 10 Apr '22

10 Apr '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Rizwan Qureshi, Sridhar Siricilla, Arthur Heymans, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62715 ) Change subject: soc/intel/common: Add support to control CSE firmware update ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62715/comment/38cb70f2_67a88ac6 PS4, Line 9: The patch adds support to control CSE Lite firmware update dynamically. Please elaborate, what “dynamically” means. -- To view, visit https://review.coreboot.org/c/coreboot/+/62715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f234b142191eb83137d5d83f21e890e1cb828ba Gerrit-Change-Number: 62715 Gerrit-PatchSet: 4 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)gmail.com> Gerrit-Comment-Date: Sun, 10 Apr 2022 12:26:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [TESTME] mb/lenovo/t410: Complete and fix hybrid-graphics config
by Paul Menzel (Code Review) 10 Apr '22

10 Apr '22

Attention is currently required from: Nico Huber, Alexander Couzens. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63530 ) Change subject: [TESTME] mb/lenovo/t410: Complete and fix hybrid-graphics config ...................................................................... Patch Set 1: (2 comments) File src/mainboard/lenovo/t410/devicetree.cb: https://review.coreboot.org/c/coreboot/+/63530/comment/bb65de59_9978dd25 PS1, Line 138: # -DISCRETE_PRESENCE What does the - in the beginning denote? https://review.coreboot.org/c/coreboot/+/63530/comment/c75b5f13_06242180 PS1, Line 143: register "ddc_mux_gpio" = "54" Can’t `has_ddc_mux_gpio` be derived from having `ddc_mux_gpio` set? -- To view, visit https://review.coreboot.org/c/coreboot/+/63530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia42416b7d2aeebe193747f88bc168a9e0838e449 Gerrit-Change-Number: 63530 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 10 Apr 2022 11:21:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: intel/common/block: Add gpmr common driver
by Subrata Banik (Code Review) 10 Apr '22

10 Apr '22

Attention is currently required from: Jamie Ryu, Wonkyu Kim, Ethan Tsao, Ravishankar Sarawadi, Angel Pons, Nick Vaccaro, Michael Niewöhner, Tim Wawrzynczak. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63170 ) Change subject: intel/common/block: Add gpmr common driver ...................................................................... Patch Set 14: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63170/comment/938da2aa_09a25d07 PS14, Line 9: Move GPMR(General Purpose Memory Range) APIs to gpmr driver from dmi.c : For this, 3 patches are used. : 1. Add GPMR common driver in IA common code(CB:63170) : 2. Migrate all DMI API usage to GPMR(CB:63471) : 3. Drop DMI driver (CB:63472) : > hmm, it seems the newly added code for the gpmr driver is ~90% identical to the dmi driver. Why not rename the dmi driver, then refactor/clean it up, instead of adding a modified copy and delete the origin? This would make it easier to keep track of the changes. I guess I'm the one who suggested to add a new GPMR common driver and clear up the SoC code in two separate CL, the reason that I have in mind is better code readability, otherwise same Cl is renaming APIs, changing Kconfig depex across SoC and rest of the IA common code. Hence, ideally I thought we could add a new driver (in commit msg, we could mention that it's derived from DMI common code) and next CL is to touch only SoC code to utilise the GPMR common code instead DMI. And finally drop the unused DMI driver (after SoC starts referring to GPMR). -- To view, visit https://review.coreboot.org/c/coreboot/+/63170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d57f4b8bd06e0cf6c9afa4baf4a7bed64ecb56b Gerrit-Change-Number: 63170 Gerrit-PatchSet: 14 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Ethan Tsao <ethan.tsao(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ethan Tsao <ethan.tsao(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Sun, 10 Apr 2022 11:13:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/kontron/986lcd-m: Drop `_PRS` and `_DIS` from static devices
by Nico Huber (Code Review) 10 Apr '22

10 Apr '22

Attention is currently required from: Angel Pons, Arthur Heymans. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63524 ) Change subject: mb/kontron/986lcd-m: Drop `_PRS` and `_DIS` from static devices ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I71275f2581b999d606f36773578b36dbdccf6452 Gerrit-Change-Number: 63524 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 10 Apr 2022 10:45:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [TESTME] mb/lenovo/t410: Complete and fix hybrid-graphics config
by Nico Huber (Code Review) 10 Apr '22

10 Apr '22

Attention is currently required from: Alexander Couzens. Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63530 ) Change subject: [TESTME] mb/lenovo/t410: Complete and fix hybrid-graphics config ...................................................................... [TESTME] mb/lenovo/t410: Complete and fix hybrid-graphics config The T410 (Nozomi-1) has another GPIO to control DDC muxes. Configure this one and also correct `panel_integrated_lvl`, DISCRETE_ENABLE is active high. Also add some comments what settings refers to what on the board. Change-Id: Ia42416b7d2aeebe193747f88bc168a9e0838e449 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/mainboard/lenovo/t410/devicetree.cb 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/63530/1 diff --git a/src/mainboard/lenovo/t410/devicetree.cb b/src/mainboard/lenovo/t410/devicetree.cb index e3456f2..24d4075 100644 --- a/src/mainboard/lenovo/t410/devicetree.cb +++ b/src/mainboard/lenovo/t410/devicetree.cb @@ -135,16 +135,25 @@ chip drivers/lenovo/hybrid_graphics device pnp ff.f on end # dummy + # -DISCRETE_PRESENCE register "detect_gpio" = "21" + # DDC_MUX_SEL + register "has_ddc_mux_gpio" = "1" + register "ddc_mux_gpio" = "54" + register "ddc_integrated_lvl" = "1" + + # DISCRETE_ENABLE register "has_panel_hybrid_gpio" = "1" register "panel_hybrid_gpio" = "52" - register "panel_integrated_lvl" = "1" + register "panel_integrated_lvl" = "0" + # BKLT_CTRL_SEL register "has_backlight_gpio" = "1" register "backlight_gpio" = "50" register "backlight_integrated_lvl" = "0" + # GFX_PWR_EN_D register "has_dgpu_power_gpio" = "1" register "dgpu_power_gpio" = "49" register "dgpu_power_off_lvl" = "0" -- To view, visit https://review.coreboot.org/c/coreboot/+/63530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia42416b7d2aeebe193747f88bc168a9e0838e449 Gerrit-Change-Number: 63530 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/lenovo/hybrid: Add GPIO settings for DDC mux
by Nico Huber (Code Review) 10 Apr '22

10 Apr '22

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63529 ) Change subject: drivers/lenovo/hybrid: Add GPIO settings for DDC mux ...................................................................... drivers/lenovo/hybrid: Add GPIO settings for DDC mux T410 (Nozomi-1) has another GPIO to control DDC muxes independently. Change-Id: Ib92d07a07e895d325bcd1106184f71106f2ea515 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/drivers/lenovo/hybrid_graphics/chip.h M src/drivers/lenovo/hybrid_graphics/hybrid_graphics.c 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/63529/1 diff --git a/src/drivers/lenovo/hybrid_graphics/chip.h b/src/drivers/lenovo/hybrid_graphics/chip.h index b3ea2b6..32922f0 100644 --- a/src/drivers/lenovo/hybrid_graphics/chip.h +++ b/src/drivers/lenovo/hybrid_graphics/chip.h @@ -23,6 +23,10 @@ struct drivers_lenovo_hybrid_graphics_config { unsigned int detect_gpio; + unsigned int has_ddc_mux_gpio; + unsigned int ddc_mux_gpio; + unsigned int ddc_integrated_lvl; + unsigned int has_panel_hybrid_gpio; unsigned int panel_hybrid_gpio; unsigned int panel_integrated_lvl; diff --git a/src/drivers/lenovo/hybrid_graphics/hybrid_graphics.c b/src/drivers/lenovo/hybrid_graphics/hybrid_graphics.c index 7a5e20d..f71d2ad 100644 --- a/src/drivers/lenovo/hybrid_graphics/hybrid_graphics.c +++ b/src/drivers/lenovo/hybrid_graphics/hybrid_graphics.c @@ -31,6 +31,10 @@ printk(BIOS_DEBUG, "Hybrid graphics:" " Switching panel to discrete GPU.\n"); + if (config->has_ddc_mux_gpio) + set_gpio(config->ddc_mux_gpio, + !config->ddc_integrated_lvl); + if (config->has_panel_hybrid_gpio) set_gpio(config->panel_hybrid_gpio, !config->panel_integrated_lvl); @@ -42,6 +46,10 @@ printk(BIOS_DEBUG, "Hybrid graphics:" " Switching panel to integrated GPU.\n"); + if (config->has_ddc_mux_gpio) + set_gpio(config->ddc_mux_gpio, + config->ddc_integrated_lvl); + if (config->has_panel_hybrid_gpio) set_gpio(config->panel_hybrid_gpio, config->panel_integrated_lvl); -- To view, visit https://review.coreboot.org/c/coreboot/+/63529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib92d07a07e895d325bcd1106184f71106f2ea515 Gerrit-Change-Number: 63529 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/prodrive/atlas: Update KConfig
by Paul Menzel (Code Review) 10 Apr '22

10 Apr '22

Attention is currently required from: Christian Walter, Lean Sheng Tan. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63464 ) Change subject: mb/prodrive/atlas: Update KConfig ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63464/comment/68f3fe9e_7c84686f PS4, Line 7: KConfig Kconfig https://review.coreboot.org/c/coreboot/+/63464/comment/736aedd7_c71d0881 PS4, Line 9: KConfig Kconfig https://review.coreboot.org/c/coreboot/+/63464/comment/90e2da7d_c5b510f9 PS4, Line 9: Update KConfig per Atlas usages. Please summarize that usage, but maybe you could also split the patch up. -- To view, visit https://review.coreboot.org/c/coreboot/+/63464 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I970de724237bcb08899aed7a4b87a23c5cdb0b48 Gerrit-Change-Number: 63464 Gerrit-PatchSet: 4 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Sun, 10 Apr 2022 09:54:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/hp/t620: Add new board HP T620
by Paul Menzel (Code Review) 10 Apr '22

10 Apr '22

Attention is currently required from: Damien Zammit. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63520 ) Change subject: mb/hp/t620: Add new board HP T620 ...................................................................... Patch Set 1: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63520/comment/43e24e93_43c1cbd8 PS1, Line 7: mb/hp/t620: Add new board HP T620 Maybe: > Add new AMD Family 16h board https://review.coreboot.org/c/coreboot/+/63520/comment/dea821f2_df9cbc03 PS1, Line 18: Please summarize the changes: ASpeed Super I/O, … https://review.coreboot.org/c/coreboot/+/63520/comment/70062e6e_db2bfeab PS1, Line 29: on a running system. There should be a version string in there. Patchset: PS1: Seeing all the similarities, maybe it should be a variant, or at least a chipset devicetree could be created? File src/mainboard/hp/t620/Kconfig: https://review.coreboot.org/c/coreboot/+/63520/comment/3bcde395_ddbbf587 PS1, Line 1: # SPDX-License-Identifier: GPL-2.0-only Please keep the differences as small as possible. -- To view, visit https://review.coreboot.org/c/coreboot/+/63520 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieaa724f393194f762d55263a74b04c9fde93e53f Gerrit-Change-Number: 63520 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Damien Zammit Gerrit-Comment-Date: Sun, 10 Apr 2022 09:52:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022