Attention is currently required from: Wonkyu Kim, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Michael Niewöhner.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63607 )
Change subject: soc/intel/cmn/gpmr: Enhance GPMR driver
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/gpmr/gpmr.c:
https://review.coreboot.org/c/coreboot/+/63607/comment/5a0b6dff_42966554
PS1, Line 9: #define MAX_GPMR_REGS 3
those define is the same in pcr_gpmr.h. Maybe you can move into gpmr.h and include it in pcr_gpmr.h.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63607
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87dca55a068366cb9a26a5218589166c1723da7f
Gerrit-Change-Number: 63607
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wonkyu Kim
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Wonkyu Kim
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Wed, 13 Apr 2022 08:02:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Reka Norman, Eric Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63569 )
Change subject: soc/intel/common/gpio: Add PAD_CFG_GPI_SCI_LOW/HIGH_LOCK macro
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63569
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5060777cc09af6cb3144ad799154e77167521de3
Gerrit-Change-Number: 63569
Gerrit-PatchSet: 2
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 13 Apr 2022 08:00:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63560 )
Change subject: [VERY WIP]tests/cpu/x86/smm: Add unit tests
......................................................................
Patch Set 6:
(3 comments)
File tests/cpu/x86/smm/smm_loader.c:
https://review.coreboot.org/c/coreboot/+/63560/comment/b1982277_ce19c9ec
PS6, Line 12: 0x10000
nit: 64 * KiB
https://review.coreboot.org/c/coreboot/+/63560/comment/1702006f_03087e2b
PS6, Line 45: 0x4000
nit: 16 * KiB
https://review.coreboot.org/c/coreboot/+/63560/comment/51dac127_388563fc
PS6, Line 54: #define setup_rmodule(mod , c)
Can it be a function?
--
To view, visit https://review.coreboot.org/c/coreboot/+/63560
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7462fa6155b8f8085256a027692cbead0ca3f08e
Gerrit-Change-Number: 63560
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 13 Apr 2022 07:57:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: YH Lin, Tim Wawrzynczak, Raihow Shi, Felix Held.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63604 )
Change subject: mb/google/brask/variants/moli: use specific VBT files for moli
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63604
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc8fbef1467605505459fce264697f670591c81e
Gerrit-Change-Number: 63604
Gerrit-PatchSet: 2
Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com>
Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 13 Apr 2022 07:50:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jamie Ryu, Wonkyu Kim, Subrata Banik, Ethan Tsao, Ravishankar Sarawadi, Paul Menzel, Tim Wawrzynczak, Angel Pons, Nick Vaccaro.
Subrata Banik has uploaded a new patch set (#16) to the change originally created by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/63198 )
Change subject: soc/intel/common: Implement IOC driver
......................................................................
soc/intel/common: Implement IOC driver
Starting with Meteor Lake SoC, the PCR/DMI interface to program GPMR
is replaced with IOC (I/O Cache), hence, this patch implements IOC
driver to support that migration.
Reference: 643504 MTL FAS section 7.5.2
TEST=Build and boot to OS for TGL RVP and MTL PSS
Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com>
Change-Id: I768027c2ca78310c03845f70f17df19dc8cd0982
---
M src/soc/intel/common/block/gpmr/gpmr.c
M src/soc/intel/common/block/include/intelblocks/gpmr.h
A src/soc/intel/common/block/include/intelblocks/ioc.h
A src/soc/intel/common/block/include/intelblocks/ioc_gpmr.h
A src/soc/intel/common/block/ioc/Kconfig
A src/soc/intel/common/block/ioc/Makefile.inc
A src/soc/intel/common/block/ioc/ioc.c
M src/soc/intel/common/pch/lockdown/lockdown.c
8 files changed, 112 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/63198/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/63198
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I768027c2ca78310c03845f70f17df19dc8cd0982
Gerrit-Change-Number: 63198
Gerrit-PatchSet: 16
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Ethan Tsao <ethan.tsao(a)intel.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Ethan Tsao <ethan.tsao(a)intel.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Anjaneya "Reddy" Chagam, Subrata Banik, Jonathan Zhang, Ravishankar Sarawadi, Johnny Lin, Paul Menzel, Christian Walter, Tim Wawrzynczak, Arthur Heymans, Michael Niewöhner, Tim Chu.
Subrata Banik has uploaded a new patch set (#19) to the change originally created by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/63472 )
Change subject: soc/intel: clean up dmi driver code
......................................................................
soc/intel: clean up dmi driver code
1. Remove dmi.h as it's migrated as gpmr.header
2. Remove unused gpmr definitions
3. For old platforms, define DMI defintions in c code
for less code changes.
TEST=Build
Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com>
Change-Id: Ib340ff1ab7fd88b1e7b3860ffec055a75e562de7
---
M src/mainboard/ocp/deltalake/bootblock.c
M src/soc/intel/alderlake/bootblock/pch.c
M src/soc/intel/cannonlake/bootblock/pch.c
D src/soc/intel/common/block/include/intelblocks/dmi.h
M src/soc/intel/common/block/include/intelblocks/lpc_lib.h
M src/soc/intel/elkhartlake/bootblock/pch.c
M src/soc/intel/icelake/bootblock/pch.c
M src/soc/intel/jasperlake/bootblock/pch.c
M src/soc/intel/skylake/bootblock/pch.c
M src/soc/intel/tigerlake/bootblock/pch.c
M src/soc/intel/xeon_sp/pch.c
11 files changed, 4 insertions(+), 65 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/63472/19
--
To view, visit https://review.coreboot.org/c/coreboot/+/63472
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib340ff1ab7fd88b1e7b3860ffec055a75e562de7
Gerrit-Change-Number: 63472
Gerrit-PatchSet: 19
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Wonkyu Kim, Ravishankar Sarawadi, Angel Pons, Nick Vaccaro, Tim Wawrzynczak.
Subrata Banik has uploaded a new patch set (#13) to the change originally created by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/63471 )
Change subject: soc/intel/cmn/{block, pch}: Migrate GPMR driver
......................................................................
soc/intel/cmn/{block, pch}: Migrate GPMR driver
This patch migrates GPMR driver over DMI to accommodate future SOCs
with different interface (other than PCR/DMI).
TEST=Able to build and boot google/redrix.
Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com>
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
Change-Id: I00ac667e8d3f2ccefd8d51a8150a989fc8e5c7e2
---
M src/soc/intel/common/block/fast_spi/fast_spi.c
M src/soc/intel/common/block/gpmr/gpmr.c
M src/soc/intel/common/block/lpc/lpc_lib.c
M src/soc/intel/common/block/smbus/tco.c
M src/soc/intel/common/pch/lockdown/lockdown.c
5 files changed, 23 insertions(+), 38 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/63471/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/63471
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00ac667e8d3f2ccefd8d51a8150a989fc8e5c7e2
Gerrit-Change-Number: 63471
Gerrit-PatchSet: 13
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Wonkyu Kim, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Eric Lai, Michael Niewöhner.
Hello build bot (Jenkins), Wonkyu Kim, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Eric Lai, Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63608
to look at the new patch set (#2).
Change subject: soc/intel/cmn/{block, pch}: Rename configs from `DMI` to `GPMR`
......................................................................
soc/intel/cmn/{block, pch}: Rename configs from `DMI` to `GPMR`
This patch renames all required IA common code blocks and PCH configs
from DMI to GPMR.
TEST=Able to build and boot google/redrix.
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
Change-Id: Ic6e576dd7f207eb16d90c5cc2892d919980d91c4
---
M src/soc/intel/common/block/gpmr/Kconfig
M src/soc/intel/common/block/gpmr/Makefile.inc
M src/soc/intel/common/block/lpc/Kconfig
M src/soc/intel/common/block/lpc/lpc_lib.c
M src/soc/intel/common/pch/Kconfig
5 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/63608/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63608
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6e576dd7f207eb16d90c5cc2892d919980d91c4
Gerrit-Change-Number: 63608
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wonkyu Kim
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Wonkyu Kim
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: newpatchset