coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: cpu/x86/smm: Use struct region to check overlapping sections
by Arthur Heymans (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Arthur Heymans. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63602 to look at the new patch set (#5). Change subject: cpu/x86/smm: Use struct region to check overlapping sections ...................................................................... cpu/x86/smm: Use struct region to check overlapping sections This allows for some runtime checks on all SMM elements and removes the need for manual checks. Change-Id: Ib7e2e3ae16c223ecfd8d5bce6ff6c17c53496925 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 171 insertions(+), 79 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/63602/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/63602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7e2e3ae16c223ecfd8d5bce6ff6c17c53496925 Gerrit-Change-Number: 63602 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/kano: Configure Acoustic noise mitigation
by David Wu (Code Review) 13 Apr '22

13 Apr '22

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63610 ) Change subject: mb/google/brya/var/kano: Configure Acoustic noise mitigation ...................................................................... mb/google/brya/var/kano: Configure Acoustic noise mitigation Enable Acoustic noise mitigation for kano and set slew rate to 1/8 BUG=b:229046516 TEST=build and verified by power team Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> Change-Id: Ifb5700391e33818878994f205acae7ee3b1b96d9 --- M src/mainboard/google/brya/variants/kano/overridetree.cb 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/63610/1 diff --git a/src/mainboard/google/brya/variants/kano/overridetree.cb b/src/mainboard/google/brya/variants/kano/overridetree.cb index 7b36d3b..5962fd1 100644 --- a/src/mainboard/google/brya/variants/kano/overridetree.cb +++ b/src/mainboard/google/brya/variants/kano/overridetree.cb @@ -22,6 +22,13 @@ # GPE configuration register "pmc_gpe0_dw1" = "GPP_D" + # Acoustic settings + register "acoustic_noise_mitigation" = "1" + register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" + register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" + register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" + register "fast_pkg_c_ramp_disable[VR_DOMAIN_GT]" = "1" + register "usb2_ports[1]" = "USB2_PORT_EMPTY" # Disable USB2_C1 register "usb2_ports[3]" = "USB2_PORT_EMPTY" # Disable M.2 WWAN -- To view, visit https://review.coreboot.org/c/coreboot/+/63610 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb5700391e33818878994f205acae7ee3b1b96d9 Gerrit-Change-Number: 63610 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in libgfxinit[master]: README: Fix hyphenations in markdown
by Angel Pons (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Jack Rosenthal. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/63588 ) Change subject: README: Fix hyphenations in markdown ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Oh, signed-off-by is missing. Oops, I missed that. Thanks for spotting it! -- To view, visit https://review.coreboot.org/c/libgfxinit/+/63588 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ie44b3d4c14215be6cc50692f0063139066751cbf Gerrit-Change-Number: 63588 Gerrit-PatchSet: 1 Gerrit-Owner: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Comment-Date: Wed, 13 Apr 2022 08:47:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in libgfxinit[master]: README: Fix hyphenations in markdown
by Nico Huber (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Jack Rosenthal. Nico Huber has removed a vote from this change. ( https://review.coreboot.org/c/libgfxinit/+/63588 ) Change subject: README: Fix hyphenations in markdown ...................................................................... Removed Verified+1 by Angel Pons <th3fanbus(a)gmail.com> -- To view, visit https://review.coreboot.org/c/libgfxinit/+/63588 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ie44b3d4c14215be6cc50692f0063139066751cbf Gerrit-Change-Number: 63588 Gerrit-PatchSet: 1 Gerrit-Owner: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-MessageType: deleteVote

1 0

Change in libgfxinit[master]: README: Fix hyphenations in markdown
by Nico Huber (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Jack Rosenthal. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/63588 ) Change subject: README: Fix hyphenations in markdown ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Oh, signed-off-by is missing. -- To view, visit https://review.coreboot.org/c/libgfxinit/+/63588 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ie44b3d4c14215be6cc50692f0063139066751cbf Gerrit-Change-Number: 63588 Gerrit-PatchSet: 1 Gerrit-Owner: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Comment-Date: Wed, 13 Apr 2022 08:36:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libgfxinit[master]: README: Fix hyphenations in markdown
by Nico Huber (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Jack Rosenthal. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/63588 ) Change subject: README: Fix hyphenations in markdown ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Thanks :) -- To view, visit https://review.coreboot.org/c/libgfxinit/+/63588 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ie44b3d4c14215be6cc50692f0063139066751cbf Gerrit-Change-Number: 63588 Gerrit-PatchSet: 1 Gerrit-Owner: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Comment-Date: Wed, 13 Apr 2022 08:35:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: apple/macbook21: configure the clockgen and add C3 CPU state
by Ferass EL HAFIDI (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Evgeny Zinoviev. Ferass EL HAFIDI has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63587 ) Change subject: apple/macbook21: configure the clockgen and add C3 CPU state ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: This patch has been tested on my MacBook2,1 for almost a year and it hasn't caused any problems whatsoever, so it should work nicely. -- To view, visit https://review.coreboot.org/c/coreboot/+/63587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib97f95599fbdf66aa55e936bdcb9cc0cd69b3824 Gerrit-Change-Number: 63587 Gerrit-PatchSet: 2 Gerrit-Owner: Ferass EL HAFIDI <vitali64pmemail(a)protonmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Comment-Date: Wed, 13 Apr 2022 08:35:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm: Use struct region to check overlapping sections
by Arthur Heymans (Code Review) 13 Apr '22

13 Apr '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63602 to look at the new patch set (#4). Change subject: cpu/x86/smm: Use struct region to check overlapping sections ...................................................................... cpu/x86/smm: Use struct region to check overlapping sections This allows for some runtime checks on all SMM elements and removes the need for manual checks. Change-Id: Ib7e2e3ae16c223ecfd8d5bce6ff6c17c53496925 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 162 insertions(+), 79 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/63602/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/63602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7e2e3ae16c223ecfd8d5bce6ff6c17c53496925 Gerrit-Change-Number: 63602 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/x86/smm: Use struct region to check overlapping sections
by Arthur Heymans (Code Review) 13 Apr '22

13 Apr '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63602 to look at the new patch set (#3). Change subject: cpu/x86/smm: Use struct region to check overlapping sections ...................................................................... cpu/x86/smm: Use struct region to check overlapping sections This allows for some runtime checks on all SMM elements and removes the need for manually checks. Change-Id: Ib7e2e3ae16c223ecfd8d5bce6ff6c17c53496925 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 161 insertions(+), 79 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/63602/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7e2e3ae16c223ecfd8d5bce6ff6c17c53496925 Gerrit-Change-Number: 63602 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: apple/macbook21: configure the clockgen and add C3 CPU state
by Ferass EL HAFIDI (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Evgeny Zinoviev. Ferass EL HAFIDI has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63587 ) Change subject: apple/macbook21: configure the clockgen and add C3 CPU state ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Please tell me if I'm doing something wrong, I never used Gerrit before so I'm not quite used to it. -- To view, visit https://review.coreboot.org/c/coreboot/+/63587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib97f95599fbdf66aa55e936bdcb9cc0cd69b3824 Gerrit-Change-Number: 63587 Gerrit-PatchSet: 2 Gerrit-Owner: Ferass EL HAFIDI <vitali64pmemail(a)protonmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Comment-Date: Wed, 13 Apr 2022 08:31:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022