coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: cpu/x86/smm: Use struct region to check overlapping sections
by Arthur Heymans (Code Review) 13 Apr '22

13 Apr '22

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63602 ) Change subject: cpu/x86/smm: Use struct region to check overlapping sections ...................................................................... Patch Set 1: (2 comments) File src/cpu/x86/smm/smm_module_loader.c: https://review.coreboot.org/c/coreboot/+/63602/comment/e84fe27e_efd252fc PS1, Line 364: static struct region_list *list; : : static int check_region(const struct region smram, : const struct region new_region, : const char *region_name) : { : if (!region_is_subregion(&smram, &new_region)) { : printk(BIOS_ERR, "%s not in SMM\n", region_name); : return 1; : } : : struct region_list *test; : for (test = list; test != NULL; test = test->next) { : if (region_overlap(&test->region, &new_region)) { : printk(BIOS_ERR, "%s overlaps with a previous region\n", region_name); : return 1; : } : } : /* All is fine. Add the new region to the linked list */ : struct region_list *new_entry = malloc(sizeof(struct region_list)); : if (new_entry == NULL) { : printk(BIOS_ERR, "Out of memory\n"); : return 1; : } : : test->next = new_entry; : new_entry->region = new_region; : new_entry->next = NULL; : printk(BIOS_DEBUG, "%-12s [0x%lx-0x%lx]\n", region_name, region_offset(&new_region), : region_end(&new_region)); : return 0; > really messing up linked lists here... Done https://review.coreboot.org/c/coreboot/+/63602/comment/130bf3cc_45f2cac1 PS1, Line 399: struct region_list *entry = list; : struct region_list *next_entry; : while (1) { : if (entry == NULL) : return; : next_entry = entry->next; : free(entry); : entry = next_entry; : } > won't work. Only the last allocated element is freed. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7e2e3ae16c223ecfd8d5bce6ff6c17c53496925 Gerrit-Change-Number: 63602 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 13 Apr 2022 08:30:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm: Use struct region to check overlapping sections
by Arthur Heymans (Code Review) 13 Apr '22

13 Apr '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63602 to look at the new patch set (#2). Change subject: cpu/x86/smm: Use struct region to check overlapping sections ...................................................................... cpu/x86/smm: Use struct region to check overlapping sections This allows for some runtime checks on all SMM elements and removes the need for manually checks. Change-Id: Ib7e2e3ae16c223ecfd8d5bce6ff6c17c53496925 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 161 insertions(+), 79 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/63602/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7e2e3ae16c223ecfd8d5bce6ff6c17c53496925 Gerrit-Change-Number: 63602 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: apple/macbook21/cstates.c: add missing '}'
by Ferass EL HAFIDI (Code Review) 13 Apr '22

13 Apr '22

Ferass EL HAFIDI has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63609 ) Change subject: apple/macbook21/cstates.c: add missing '}' ...................................................................... apple/macbook21/cstates.c: add missing '}' Change-Id: I7bc632b03b13c08b19fc1ed55ca2a00e03488ea4 Signed-off-by: Ferass 'Vitali64' EL HAFIDI <vitali64pmemail(a)protonmail.com> --- M src/mainboard/apple/macbook21/cstates.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/63609/1 diff --git a/src/mainboard/apple/macbook21/cstates.c b/src/mainboard/apple/macbook21/cstates.c index 076a096..f07dcf3 100644 --- a/src/mainboard/apple/macbook21/cstates.c +++ b/src/mainboard/apple/macbook21/cstates.c @@ -40,7 +40,8 @@ .access_size = ACPI_ACCESS_SIZE_UNDEFINED, .addrl = 0x20, .addrh = 0, - } + }, + } }; int get_cst_entries(const acpi_cstate_t **entries) -- To view, visit https://review.coreboot.org/c/coreboot/+/63609 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7bc632b03b13c08b19fc1ed55ca2a00e03488ea4 Gerrit-Change-Number: 63609 Gerrit-PatchSet: 1 Gerrit-Owner: Ferass EL HAFIDI <vitali64pmemail(a)protonmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Documentation: Add Dasharo to after-market firmware list
by Michał Żygowski (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Patrick Georgi, Paul Menzel, Igor Bagnucki, Piotr Król. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63396 ) Change subject: Documentation: Add Dasharo to after-market firmware list ...................................................................... Patch Set 3: (1 comment) File Documentation/distributions.md: https://review.coreboot.org/c/coreboot/+/63396/comment/4e479aeb_035248fc PS3, Line 60: [Dasharo](https://dasharo.com/) is an open source firmware distribution focusing on Not wrapped at 80 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/63396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19dbf70bc9ceec1408944c4029db6eabd5e2254d Gerrit-Change-Number: 63396 Gerrit-PatchSet: 3 Gerrit-Owner: Igor Bagnucki Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Igor Bagnucki <igor.bagnucki(a)3mdeb.com> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Igor Bagnucki Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 08:24:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Add NovaCustom laptops to ships-with-coreboot hw list
by Michał Żygowski (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Patrick Georgi, Igor Bagnucki, Paul Menzel, Piotr Król. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63389 ) Change subject: Documentation: Add NovaCustom laptops to ships-with-coreboot hw list ...................................................................... Patch Set 1: (1 comment) File Documentation/distributions.md: https://review.coreboot.org/c/coreboot/+/63389/comment/b51a467b_ed977c23 PS1, Line 16: compatibility. NovaCustom provides security updates via fwupd for 5 years Same comment as in https://review.coreboot.org/c/homepage/+/63401 -- To view, visit https://review.coreboot.org/c/coreboot/+/63389 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0fc521d13362b2f3047eb91af8d5b3ac74eaa1d Gerrit-Change-Number: 63389 Gerrit-PatchSet: 1 Gerrit-Owner: Igor Bagnucki Gerrit-Reviewer: Igor Bagnucki <igor.bagnucki(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Igor Bagnucki <igor.bagnucki(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Igor Bagnucki Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 08:23:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Add variant_init and variant_finalize callbacks
by Angel Pons (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62382 ) Change subject: mb/google/brya: Add variant_init and variant_finalize callbacks ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iede6dc5a5b9a7385fedd59d4eeaaba118eff0e20 Gerrit-Change-Number: 62382 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 08:21:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brask/variants/moli: use specific VBT files for moli
by Paul Menzel (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: YH Lin, Tim Wawrzynczak, Raihow Shi, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63604 ) Change subject: mb/google/brask/variants/moli: use specific VBT files for moli ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63604/comment/18faafd4_ade4a08e PS2, Line 7: for moli Remove as already in prefix. https://review.coreboot.org/c/coreboot/+/63604/comment/02308804_e1f85e81 PS2, Line 10: and return different vbt.bin Maybe: > Use specific VBTs for HDMI, DP, and ABSENT according to FW_CONFIG. File src/mainboard/google/brya/variants/moli/ramstage.c: https://review.coreboot.org/c/coreboot/+/63604/comment/013279cc_543e9cd7 PS2, Line 38: return "vbt-moli_HDMI.bin"; Where are these VBTs? https://review.coreboot.org/c/coreboot/+/63604/comment/1328dbb6_c1ca3604 PS2, Line 39: else if (fw_config_probe(FW_CONFIG(DB_OPT, OPT_HDMI))) Same condition? Should be DP? -- To view, visit https://review.coreboot.org/c/coreboot/+/63604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc8fbef1467605505459fce264697f670591c81e Gerrit-Change-Number: 63604 Gerrit-PatchSet: 2 Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 13 Apr 2022 08:20:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/agah: Add GPU power sequencing
by Angel Pons (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62384 ) Change subject: mb/google/brya/var/agah: Add GPU power sequencing ...................................................................... Patch Set 3: Code-Review+1 (12 comments) File src/mainboard/google/brya/variants/agah/variant.c: https://review.coreboot.org/c/coreboot/+/62384/comment/81e5899d_4cc6bfb0 PS3, Line 34: gpio_t pg_gpio; AIUI, `pwr_en_gpio` is an output (wired to the VR's "enable" pin) and `pg_gpio` is an input (wired from the VR's "power good" pin), right? https://review.coreboot.org/c/coreboot/+/62384/comment/f41e2c35_b42e3102 PS3, Line 56: timeout_us Shouldn't this be `seq->timeout_us`? The `timeout_us` parameter is always `DEFAULT_PG_TIMEOUT_US`, and could be dropped. https://review.coreboot.org/c/coreboot/+/62384/comment/5310caef_5f90d4e4 PS3, Line 65: gpio_output(GPU_ALLRAILS_PG, 0); Unlike the other power-good signals, this one is an output. I imagine it's wired to the dGPU's "power good" input pin, right? https://review.coreboot.org/c/coreboot/+/62384/comment/6369112e_0c666020 PS3, Line 77: a nit: capitalize `A` https://review.coreboot.org/c/coreboot/+/62384/comment/4ac137f7_b74a0ed6 PS3, Line 85: the series What does this mean? https://review.coreboot.org/c/coreboot/+/62384/comment/cb38a6db_6010b72a PS3, Line 126: void variant_fill_ssdt(const struct device *dev) Does this need to be skipped if `gpu_powered_on` is false? https://review.coreboot.org/c/coreboot/+/62384/comment/d5e5d61d_8896027f PS3, Line 126: dev I'm pretty sure this `dev` is unused, as it's the mainboard device. So, I'd strongly recommend renaming it to something like `unused` to avoid accidentally using it (e.g. writing `dev` because of treacherous muscle memory). https://review.coreboot.org/c/coreboot/+/62384/comment/84e17094_6f042538 PS3, Line 145: 4 nit: sizeof(uint32_t) https://review.coreboot.org/c/coreboot/+/62384/comment/a7bc7b93_699ec541 PS3, Line 149: res = probe_resource(dgpu, idx); Does this work for 64-bit resources? https://review.coreboot.org/c/coreboot/+/62384/comment/7183338a_ae874a9f PS3, Line 154: PCI_BASE_ADDRESS_0 - : VGAB_BYTE_OFFSET + sizeof(uint32_t) * i Isn't this equivalent to `idx - VGAB_BYTE_OFFSET`? https://review.coreboot.org/c/coreboot/+/62384/comment/fc83e063_fd9b6cea PS3, Line 160: */ nit: space before comment end https://review.coreboot.org/c/coreboot/+/62384/comment/763bf670_2bc01f53 PS3, Line 164: 0x100 What is this magic number? I presume it's the size of the PCI config space? -- To view, visit https://review.coreboot.org/c/coreboot/+/62384 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1072be12ef58af5859e2a2d19c4a9c1adc0b0f88 Gerrit-Change-Number: 62384 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 08:20:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/cmn/gpmr: Enhance GPMR driver
by Eric Lai (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Wonkyu Kim, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Michael Niewöhner. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63607 ) Change subject: soc/intel/cmn/gpmr: Enhance GPMR driver ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63607 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87dca55a068366cb9a26a5218589166c1723da7f Gerrit-Change-Number: 63607 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wonkyu Kim Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Wonkyu Kim Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Wed, 13 Apr 2022 08:19:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/cmn/gpmr: Enhance GPMR driver
by Eric Lai (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Wonkyu Kim, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Michael Niewöhner. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63607 ) Change subject: soc/intel/cmn/gpmr: Enhance GPMR driver ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/common/block/gpmr/gpmr.c: https://review.coreboot.org/c/coreboot/+/63607/comment/8f5f68f2_75a66b30 PS1, Line 9: #define MAX_GPMR_REGS 3 > > those define is the same in pcr_gpmr.h. Maybe you can move into gpmr.h and include it in pcr_gpmr. […] yes, I saw the following patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/63607 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87dca55a068366cb9a26a5218589166c1723da7f Gerrit-Change-Number: 63607 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wonkyu Kim Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Wonkyu Kim Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Wed, 13 Apr 2022 08:19:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022