coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: drivers/usb/acpi: acpi_power_res_params: Add use_gpio_for_status
by Tim Van Patten (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Lance Zhao, Tim Van Patten. Hello Lance Zhao, build bot (Jenkins), Raul Rangel, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63558 to look at the new patch set (#3). Change subject: drivers/usb/acpi: acpi_power_res_params: Add use_gpio_for_status ...................................................................... drivers/usb/acpi: acpi_power_res_params: Add use_gpio_for_status Add the member `use_gpio_for_status` to the structure `drivers_usb_acpi_config`, so the `devicetree.cb` can specify it. This field is then used to initialize the corresponding field in the structure `acpi_power_res_params` in `usb_acpi_fill_ssdt_generator()`. The member `acpi_power_res_params::use_gpio_for_status()` is already being used by `acpi_device_add_power_res()` to determine which version of the `_STA()` method to output. BRANCH=None Signed-off-by: Tim Van Patten <timvp(a)google.com> BUG=b:225022810 TEST=Dump SSDT table for guybrush Change-Id: I69eb5f1ad79f3b2980f43dcf4a36585fca198ec9 --- M src/drivers/usb/acpi/chip.h M src/drivers/usb/acpi/usb_acpi.c 2 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/63558/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63558 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69eb5f1ad79f3b2980f43dcf4a36585fca198ec9 Gerrit-Change-Number: 63558 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/denverton_ns: enable Denverton to use common SoC XHCI code
by Mariusz Szafrański (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Felix Singer, Jeff Daly, Suresh Bellampalli, Patrick Rudolph, Elyes Haouas. Mariusz Szafrański has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60992 ) Change subject: soc/intel/denverton_ns: enable Denverton to use common SoC XHCI code ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: > a new patch series is being prepared to address this (and the remaining patch series issues, if any) OK. Ping me when it will be ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/60992 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I505b3a7761cb3719697626e1f272d0928fdd29f1 Gerrit-Change-Number: 60992 Gerrit-PatchSet: 11 Gerrit-Owner: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 13 Apr 2022 18:01:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/lint/checkpatch.pl: Update lines related to max_line_length
by Martin Roth (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Elyes Haouas. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63439 ) Change subject: util/lint/checkpatch.pl: Update lines related to max_line_length ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9927bfa98e20d4b621bf7abecec234b4754ee9c Gerrit-Change-Number: 63439 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 13 Apr 2022 17:56:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/lint/checkpatch.pl: Update lines related to tabsize
by Martin Roth (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Elyes Haouas. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63438 ) Change subject: util/lint/checkpatch.pl: Update lines related to tabsize ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6651a3f8e79beca2e1235fe8de3217875f81ba2b Gerrit-Change-Number: 63438 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 13 Apr 2022 17:55:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/lint/checkpatch.pl: Update to v5.18-2 lines related to verbosity
by Martin Roth (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Elyes Haouas. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63437 ) Change subject: util/lint/checkpatch.pl: Update to v5.18-2 lines related to verbosity ...................................................................... Patch Set 4: (1 comment) File util/lint/checkpatch.pl: https://review.coreboot.org/c/coreboot/+/63437/comment/3f06733f_473ab3c9 PS4, Line 68: $D/../Documentation/dev-tools/checkpatch.rst Sorry, I thought I had already commented, but I don't see anything, so I guess not. This file doesn't exist at coreboot. We might want to grab that file and adapt it for our fork, but until we do, this should probably be left blank, i think. -- To view, visit https://review.coreboot.org/c/coreboot/+/63437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66f38cb01e58ee241bf58c4db83693029ddebcfa Gerrit-Change-Number: 63437 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 13 Apr 2022 17:55:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/kano: Configure Acoustic noise mitigation
by David Wu (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Ren Kuo, Nick Vaccaro, Peter Ou. David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63610 ) Change subject: mb/google/brya/var/kano: Configure Acoustic noise mitigation ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63610/comment/df34e95e_9f633c8f PS1, Line 9: Enable Acoustic noise mitigation for kano and set slew rate to 1/8 > suggestion: […] Done. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/63610 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb5700391e33818878994f205acae7ee3b1b96d9 Gerrit-Change-Number: 63610 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 17:17:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/kano: Configure Acoustic noise mitigation
by David Wu (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: David Wu, Ren Kuo, Nick Vaccaro, Peter Ou. Hello build bot (Jenkins), Tim Wawrzynczak, Ren Kuo, Nick Vaccaro, Nick Vaccaro, Peter Ou, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63610 to look at the new patch set (#2). Change subject: mb/google/brya/var/kano: Configure Acoustic noise mitigation ...................................................................... mb/google/brya/var/kano: Configure Acoustic noise mitigation Setup the following acoustic noise mitigation features: 1) Slew rate for both IA and GT domains to 1/8 2) Disable Fast package C ramp BUG=b:229046516 TEST=build and verified by power team Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> Change-Id: Ifb5700391e33818878994f205acae7ee3b1b96d9 --- M src/mainboard/google/brya/variants/kano/overridetree.cb 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/63610/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63610 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb5700391e33818878994f205acae7ee3b1b96d9 Gerrit-Change-Number: 63610 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/x86/smm: Refactor creating a stub/save state map
by Tim Wawrzynczak (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Arthur Heymans. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63474 ) Change subject: cpu/x86/smm: Refactor creating a stub/save state map ...................................................................... Patch Set 7: (1 comment) File src/cpu/x86/smm/smm_module_loader.c: https://review.coreboot.org/c/coreboot/+/63474/comment/e0d251ce_3155b668 PS7, Line 121: cpus[i].entry = smbase - SMM_CODE_SEGMENT_SIZE * segment_number : - needed_ss_size * (i % cpus_per_segment) + SMM_ENTRY_OFFSET; : cpus[i].smbase = cpus[i].entry - SMM_ENTRY_OFFSET; suggestion: to avoid using SMM_ENTRY_OFFSET twice ``` cpus[i].smbase = smbase - SMM_CODE_SEGMENT_SIZE * segment_number - needed_ss_size * (i % cpus_per_segment); cpus[i].entry = cpus[i].smbase + SMM_ENTRY_OFFSET; ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/63474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a455ba45a1c92533a8ecfd1aeecf34b4a63e409 Gerrit-Change-Number: 63474 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 13 Apr 2022 16:54:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/kano: Configure Acoustic noise mitigation
by Tim Wawrzynczak (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: David Wu, Ren Kuo, Nick Vaccaro, Peter Ou. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63610 ) Change subject: mb/google/brya/var/kano: Configure Acoustic noise mitigation ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63610/comment/ce8a46c9_f6cf03d6 PS1, Line 9: Enable Acoustic noise mitigation for kano and set slew rate to 1/8 suggestion: ``` Setup the following acoustic noise mitigation features: 1) Slew rate for both IA and GT domains to 1/8 2) Disable Fast package C ramp ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/63610 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb5700391e33818878994f205acae7ee3b1b96d9 Gerrit-Change-Number: 63610 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 16:52:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brask/variants/moli: use specific VBT files
by Tim Wawrzynczak (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: YH Lin, Paul Menzel, Raihow Shi, Felix Held. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63604 ) Change subject: mb/google/brask/variants/moli: use specific VBT files ...................................................................... Patch Set 8: Code-Review+2 (1 comment) File src/mainboard/google/brya/variants/moli/ramstage.c: https://review.coreboot.org/c/coreboot/+/63604/comment/9e2a33e3_1359f2ca PS2, Line 38: return "vbt-moli_HDMI.bin"; > Ok, it can reference by this […] They are currently added to the coreboot image in a private build step. That reminds me, I need to clarify when we can publish these in public with Intel. I am trying to push for us to be able to publish these in the open sooner in a program rather than afterwards. -- To view, visit https://review.coreboot.org/c/coreboot/+/63604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc8fbef1467605505459fce264697f670591c81e Gerrit-Change-Number: 63604 Gerrit-PatchSet: 8 Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 13 Apr 2022 16:49:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022