coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: coreboot_tables: Replace 'struct lb_uint64' with lb_uint64_t
by Julius Werner (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Hung-Te Lin, Jakub Czapiga, Arthur Heymans, Yu-Ping Wu, Jianjun Wang. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63494 ) Change subject: coreboot_tables: Replace 'struct lb_uint64' with lb_uint64_t ...................................................................... Patch Set 8: Code-Review+2 (1 comment) Patchset: PS5: > We could, but due to licensing issue, we can't just copy the comment to the bsd header file. […] I think we absolutely should combine those two files under commonlib/bsd (now that we can, thanks to Jakub's recent work), to eliminate the constant duplication between them. To steer clear of licensing issues that should be done by taking the libpayload file as basis -- for stuff like comments that we want to preserve, just rewrite them in your own words or something (everything else should already be the same anyway). I don't want to force you to do that as part of this patch though, since it's getting pretty far away from what you came here to do. It would be good if someone could find the time to do that eventually, though. -- To view, visit https://review.coreboot.org/c/coreboot/+/63494 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If6b037e4403a8000625f4a5fb8d20311fe76200a Gerrit-Change-Number: 63494 Gerrit-PatchSet: 8 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 20:29:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-MessageType: comment

1 0

Change in qc_blobs[master]: sc7280/qtiseclib blob update
by Saurabh Gorecha (Code Review) 13 Apr '22

13 Apr '22

Saurabh Gorecha has abandoned this change. ( https://review.coreboot.org/c/qc_blobs/+/61435 ) Change subject: sc7280/qtiseclib blob update ...................................................................... Abandoned uploaded latest -- To view, visit https://review.coreboot.org/c/qc_blobs/+/61435 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: qc_blobs Gerrit-Branch: master Gerrit-Change-Id: I91a04242ab7bdeb2e1f6c112a49d00f05b6a36e2 Gerrit-Change-Number: 61435 Gerrit-PatchSet: 1 Gerrit-Owner: Saurabh Gorecha <quic_sgorecha(a)quicinc.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-CC: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-MessageType: abandon

1 0

Change in qc_blobs[master]: sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes
by Saurabh Gorecha (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Saurabh Gorecha, Ravi Kumar Bokka, Julius Werner, mturney mturney. Hello Shelley Chen, Ravi Kumar Bokka, Julius Werner, mturney mturney, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/qc_blobs/+/63614 to look at the new patch set (#3). Change subject: sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes ...................................................................... sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes Signed-off-by: Saurabh Gorecha <quic_sgorecha(a)quicinc.com> Change-Id: I6c60c3642b272fbc57c90ad857044bf69b01fef0 --- D sc7280/qtiseclib/ReleaseNotes.txt A sc7280/qtiseclib/Release_Notes.txt M sc7280/qtiseclib/libqtisec.a 3 files changed, 66 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/qc_blobs refs/changes/14/63614/3 -- To view, visit https://review.coreboot.org/c/qc_blobs/+/63614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: qc_blobs Gerrit-Branch: master Gerrit-Change-Id: I6c60c3642b272fbc57c90ad857044bf69b01fef0 Gerrit-Change-Number: 63614 Gerrit-PatchSet: 3 Gerrit-Owner: Saurabh Gorecha <quic_sgorecha(a)quicinc.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Attention: Saurabh Gorecha <quic_sgorecha(a)quicinc.com> Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-MessageType: newpatchset

1 0

Change in qc_blobs[master]: sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes
by Shelley Chen (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Saurabh Gorecha, Ravi Kumar Bokka, Julius Werner, mturney mturney. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/qc_blobs/+/63614 ) Change subject: sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Julius can you help V+1? -- To view, visit https://review.coreboot.org/c/qc_blobs/+/63614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: qc_blobs Gerrit-Branch: master Gerrit-Change-Id: I6c60c3642b272fbc57c90ad857044bf69b01fef0 Gerrit-Change-Number: 63614 Gerrit-PatchSet: 2 Gerrit-Owner: Saurabh Gorecha <quic_sgorecha(a)quicinc.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Attention: Saurabh Gorecha <quic_sgorecha(a)quicinc.com> Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 20:26:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in qc_blobs[master]: sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes
by Shelley Chen (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Saurabh Gorecha, Ravi Kumar Bokka, Julius Werner, mturney mturney. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/qc_blobs/+/63614 ) Change subject: sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/qc_blobs/+/63614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: qc_blobs Gerrit-Branch: master Gerrit-Change-Id: I6c60c3642b272fbc57c90ad857044bf69b01fef0 Gerrit-Change-Number: 63614 Gerrit-PatchSet: 2 Gerrit-Owner: Saurabh Gorecha <quic_sgorecha(a)quicinc.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Attention: Saurabh Gorecha <quic_sgorecha(a)quicinc.com> Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 20:26:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in qc_blobs[master]: sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes
by Saurabh Gorecha (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Shelley Chen, Ravi Kumar Bokka, Julius Werner, mturney mturney. Hello Shelley Chen, Ravi Kumar Bokka, Julius Werner, mturney mturney, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/qc_blobs/+/63614 to look at the new patch set (#2). Change subject: sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes ...................................................................... sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes Signed-off-by: Saurabh Gorecha <quic_sgorecha(a)quicinc.com> Change-Id: I6c60c3642b272fbc57c90ad857044bf69b01fef0 --- M sc7280/qtiseclib/ReleaseNotes.txt M sc7280/qtiseclib/libqtisec.a 2 files changed, 44 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/qc_blobs refs/changes/14/63614/2 -- To view, visit https://review.coreboot.org/c/qc_blobs/+/63614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: qc_blobs Gerrit-Branch: master Gerrit-Change-Id: I6c60c3642b272fbc57c90ad857044bf69b01fef0 Gerrit-Change-Number: 63614 Gerrit-PatchSet: 2 Gerrit-Owner: Saurabh Gorecha <quic_sgorecha(a)quicinc.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-MessageType: newpatchset

1 0

Change in qc_blobs[master]: sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes v...
by Saurabh Gorecha (Code Review) 13 Apr '22

13 Apr '22

Saurabh Gorecha has uploaded this change for review. ( https://review.coreboot.org/c/qc_blobs/+/63614 ) Change subject: sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes version ...................................................................... sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes version Signed-off-by: Saurabh Gorecha <quic_sgorecha(a)quicinc.com> Change-Id: I6c60c3642b272fbc57c90ad857044bf69b01fef0 --- M sc7280/qtiseclib/ReleaseNotes.txt M sc7280/qtiseclib/libqtisec.a 2 files changed, 44 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/qc_blobs refs/changes/14/63614/1 diff --git a/sc7280/qtiseclib/ReleaseNotes.txt b/sc7280/qtiseclib/ReleaseNotes.txt index 4bf9a52..b5309f4 100644 --- a/sc7280/qtiseclib/ReleaseNotes.txt +++ b/sc7280/qtiseclib/ReleaseNotes.txt @@ -1,3 +1,47 @@ +=================== Release 00056 ================================ +This Release Notes file covers these blobs: + * libqtisec.a + +Version : 00061 + +Release Date : Apr 14, 2022 + +Changes since last version : + * Modem Sand box change + * Static analysis fixes +=================== Release 00056 ================================ +This Release Notes file covers these blobs: + * libqtisec.a + +Version : 00056 + +Release Date : Feb 28, 2022 + +Changes since last version : + * NOC MaxDIV DCD enablement + * ac update +=================== Release 00050 ================================ +This Release Notes file covers these blobs: + * libqtisec.a + +Version : 00050 + +Release Date : Nov 24, 2021 + +Changes since last version : + * disabling L3 voting register for perf + * sysini update +=================== Release 00047 ================================ +This Release Notes file covers these blobs: + * libqtisec.a + +Version : 00047 + +Release Date : Sep 28, 2021 + +Changes since last version : + * WLAN Sandboxing + * Noc debug Improvement =================== Release 00044 ================================ This Release Notes file covers these blobs: * libqtisec.a @@ -20,4 +64,3 @@ * PSCI Initialization * Interrupt registrartion and handling Errata : Nothing to report - diff --git a/sc7280/qtiseclib/libqtisec.a b/sc7280/qtiseclib/libqtisec.a index 3ba99b8..71a3b91 100644 --- a/sc7280/qtiseclib/libqtisec.a +++ b/sc7280/qtiseclib/libqtisec.a Binary files differ -- To view, visit https://review.coreboot.org/c/qc_blobs/+/63614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: qc_blobs Gerrit-Branch: master Gerrit-Change-Id: I6c60c3642b272fbc57c90ad857044bf69b01fef0 Gerrit-Change-Number: 63614 Gerrit-PatchSet: 1 Gerrit-Owner: Saurabh Gorecha <quic_sgorecha(a)quicinc.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/apcb/apcb_v3_edit.py: Edit APCB based on different SPD magic
by Rob Barnes (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Karthik Ramasubramanian. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63598 ) Change subject: util/apcb/apcb_v3_edit.py: Edit APCB based on different SPD magic ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e96c89e4e5ce8e0567a17bf7685b69080fa1708 Gerrit-Change-Number: 63598 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 20:17:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Set BT USB to use GPIO for status
by Raul Rangel (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Tim Van Patten. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63559 ) Change subject: mb/google/guybrush: Set BT USB to use GPIO for status ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/guybrush/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/63559/comment/6c4b47f6_3ad3d227 PS4, Line 325: register Move this up one line so it's above the `device`. -- To view, visit https://review.coreboot.org/c/coreboot/+/63559 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72f6b28671efddfbef53f328d904a05f73f39efa Gerrit-Change-Number: 63559 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 20:03:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/acpi/device.c: Early return in _ON if device already enabled
by Raul Rangel (Code Review) 13 Apr '22

13 Apr '22

Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Tim Van Patten. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63613 ) Change subject: src/acpi/device.c: Early return in _ON if device already enabled ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63613/comment/e32726df_a38cf066 PS2, Line 7: .c nit: you can drop the `.c` File src/acpi/device.c: https://review.coreboot.org/c/coreboot/+/63613/comment/9a2a014b_c8792b4a PS2, Line 674: Add: This avoids unnecessary delays while booting. https://review.coreboot.org/c/coreboot/+/63613/comment/162ccfdf_8d9cbc34 PS2, Line 675: Indent using 8 character width tabs. -- To view, visit https://review.coreboot.org/c/coreboot/+/63613 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13aa41766555953b86eded4c72e3b317fe6db5c8 Gerrit-Change-Number: 63613 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 20:02:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022