coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: cezanne: Update CPPC value
by Paul Menzel (Code Review) 14 Apr '22

14 Apr '22

Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao, Fred Reitberger. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63632 ) Change subject: cezanne: Update CPPC value ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63632/comment/6361c7ea_08119c1f PS1, Line 7: cezanne soc/amd/cezanne https://review.coreboot.org/c/coreboot/+/63632/comment/833a2968_57b408b0 PS1, Line 8: What is updated? -- To view, visit https://review.coreboot.org/c/coreboot/+/63632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I091ab3bbc5f94961f8b366a3fa00f50f5c9fa182 Gerrit-Change-Number: 63632 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Thu, 14 Apr 2022 20:28:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Add SBOM (Software Bill of Materials) Generation
by Paul Menzel (Code Review) 14 Apr '22

14 Apr '22

Attention is currently required from: Martin Roth, Maximilian Brune. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63639 ) Change subject: Add SBOM (Software Bill of Materials) Generation ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63639/comment/d1f28e65_c228fa92 PS2, Line 8: Please add the motivation. -- To view, visit https://review.coreboot.org/c/coreboot/+/63639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb7481d4903f95d200eddbfed7728fbec51819d0 Gerrit-Change-Number: 63639 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Christian Walter <christian.walter(a)9elements.com> Gerrit-CC: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 14 Apr 2022 20:28:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Reorder PSP Directory Table Types | Update PSP Firmware Integration G...
by Paul Menzel (Code Review) 14 Apr '22

14 Apr '22

Attention is currently required from: Marshall Dawson, Al Hirani, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62966 ) Change subject: Reorder PSP Directory Table Types | Update PSP Firmware Integration Guide Documentation ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62966/comment/b85f7e52_40bd2ebc PS1, Line 7: Reorder PSP Directory Table Types | Update PSP Firmware Integration Guide Documentation Please look through `git log` how to write commit messages. -- To view, visit https://review.coreboot.org/c/coreboot/+/62966 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5fb893a769fe0d870e14e68183fc7e49421605bd Gerrit-Change-Number: 62966 Gerrit-PatchSet: 1 Gerrit-Owner: Al Hirani <al.hirani13(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Al Hirani <al.hirani13(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 20:27:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Extend BIOS Directory Table Entries | Update PSP Firmware Integration...
by Paul Menzel (Code Review) 14 Apr '22

14 Apr '22

Attention is currently required from: Felix Singer, Marshall Dawson, Al Hirani, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62910 ) Change subject: Extend BIOS Directory Table Entries | Update PSP Firmware Integration Guide Documentation ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62910/comment/ab966fc6_3e879b37 PS5, Line 8: Guide Documentation Please look through `git log` how to write commit messages. -- To view, visit https://review.coreboot.org/c/coreboot/+/62910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I677f86614b0fdc6377fb2e27932ed3a8ded27102 Gerrit-Change-Number: 62910 Gerrit-PatchSet: 5 Gerrit-Owner: Al Hirani <al.hirani13(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Al Hirani <al.hirani13(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 20:26:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Allow for the tool to support additional PSP entries
by Paul Menzel (Code Review) 14 Apr '22

14 Apr '22

Attention is currently required from: Bao Zheng, Jason Nien, Al Hirani. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62911 ) Change subject: amdfwtool: Allow for the tool to support additional PSP entries ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62911/comment/d4793776_3dd899b2 PS2, Line 8: What PSP entries are not supported right now? Please start with a description of the problem. https://review.coreboot.org/c/coreboot/+/62911/comment/1e5db0e0_c65ede38 PS2, Line 9: Consolidate the MAX_BIOS_ENTRIES and MAX_PSP_ENTRIES definitions into one file Please wrap lines after 72 characters, and add a dot/period to the end of sentences. -- To view, visit https://review.coreboot.org/c/coreboot/+/62911 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie3c64a1875010e7fb368967283df6baf1cc7ba8d Gerrit-Change-Number: 62911 Gerrit-PatchSet: 2 Gerrit-Owner: Al Hirani <al.hirani13(a)gmail.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Al Hirani <al.hirani13(a)gmail.com> Gerrit-Comment-Date: Thu, 14 Apr 2022 20:26:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/usb/pci_xhci: Add Sabrina xhci pci devce id
by Paul Menzel (Code Review) 14 Apr '22

14 Apr '22

Attention is currently required from: Jon Murphy, Karthik Ramasubramanian, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63641 ) Change subject: drivers/usb/pci_xhci: Add Sabrina xhci pci devce id ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63641/comment/4ea7f23f_cd5d539e PS1, Line 7: devce device -- To view, visit https://review.coreboot.org/c/coreboot/+/63641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ad4555212ed38ea0f9029275345e4945855a8c3 Gerrit-Change-Number: 63641 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 20:23:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/usb/pci_xhci: Add Sabrina xhci pci devce id
by Raul Rangel (Code Review) 14 Apr '22

14 Apr '22

Attention is currently required from: Jon Murphy, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63641 ) Change subject: drivers/usb/pci_xhci: Add Sabrina xhci pci devce id ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/drivers/usb/pci_xhci/pci_xhci.c: https://review.coreboot.org/c/coreboot/+/63641/comment/c4c73f90_174cc0fc PS1, Line 262: PCI_DID_AMD_FAM17H_MODELA0H_XHCI2 Ugh, I really hate maintaining this list. This driver is generic and will work for any PCI xCHI compliant controller. I wonder if it would be more clear to have this as a chip driver in the device tree? -- To view, visit https://review.coreboot.org/c/coreboot/+/63641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ad4555212ed38ea0f9029275345e4945855a8c3 Gerrit-Change-Number: 63641 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 19:52:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/usb/pci_xhci: Add Sabrina xhci pci devce id
by Karthik Ramasubramanian (Code Review) 14 Apr '22

14 Apr '22

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63641 ) Change subject: drivers/usb/pci_xhci: Add Sabrina xhci pci devce id ...................................................................... drivers/usb/pci_xhci: Add Sabrina xhci pci devce id BUG=None TEST=Build and boot to OS in Skyrim. Ensure that the XHCI controllers are enumerated successfully and ACPI device objects are added in SSDT. Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> Change-Id: I7ad4555212ed38ea0f9029275345e4945855a8c3 --- M src/drivers/usb/pci_xhci/pci_xhci.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/63641/1 diff --git a/src/drivers/usb/pci_xhci/pci_xhci.c b/src/drivers/usb/pci_xhci/pci_xhci.c index 1952130..63a98c7 100644 --- a/src/drivers/usb/pci_xhci/pci_xhci.c +++ b/src/drivers/usb/pci_xhci/pci_xhci.c @@ -257,6 +257,9 @@ PCI_DID_AMD_FAM17H_MODEL18H_XHCI1, PCI_DID_AMD_FAM17H_MODEL20H_XHCI0, PCI_DID_AMD_FAM17H_MODEL60H_XHCI, + PCI_DID_AMD_FAM17H_MODELA0H_XHCI0, + PCI_DID_AMD_FAM17H_MODELA0H_XHCI1, + PCI_DID_AMD_FAM17H_MODELA0H_XHCI2, 0 }; -- To view, visit https://review.coreboot.org/c/coreboot/+/63641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ad4555212ed38ea0f9029275345e4945855a8c3 Gerrit-Change-Number: 63641 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/i2c/dw_i2c: Adjust to handle 0-byte transfers
by Matt DeVillier (Code Review) 14 Apr '22

14 Apr '22

Attention is currently required from: Tim Wawrzynczak. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63561 ) Change subject: drivers/i2c/dw_i2c: Adjust to handle 0-byte transfers ...................................................................... Patch Set 1: (1 comment) File src/drivers/i2c/designware/dw_i2c.c: https://review.coreboot.org/c/coreboot/+/63561/comment/fa5a3715_c6f271e8 PS1, Line 431: if (segments->len != 0) > I think it's OK to still print the message in the 0-byte write case I did that so that there weren't a bunch of spurious TX aborted msgs in cbmem. Some boards have 3-4 options each for touchpad/screen, so there can be up to 6 of them surrounding the output for the devices which are actually present -- To view, visit https://review.coreboot.org/c/coreboot/+/63561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I518e849f4c476c264a1464886b1853af66c0b29d Gerrit-Change-Number: 63561 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 14 Apr 2022 19:10:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/nipperkin: Disable PSPP for WLAN
by 9elements QA (Code Review) 14 Apr '22

14 Apr '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63593 ) Change subject: mb/google/nipperkin: Disable PSPP for WLAN ...................................................................... Patch Set 4: Automatic boot test returned (PASS/FAIL/TOTAL): 7 / 1 / 8 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/101013 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/101012 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/101011 FAIL: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/101010 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/101009 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/101008 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/101007 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/101006 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/63593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38f05b92ace4aba61163194a6a638915882b8871 Gerrit-Change-Number: 63593 Gerrit-PatchSet: 4 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Comment-Date: Thu, 14 Apr 2022 18:44:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022