coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: cpu/x86/mp_init.c: Add wait_finished_mp_run_on_all_cpus
by Tim Wawrzynczak (Code Review) 15 Apr '22

15 Apr '22

Attention is currently required from: Subrata Banik, Kane Chen, Arthur Heymans. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63566 ) Change subject: cpu/x86/mp_init.c: Add wait_finished_mp_run_on_all_cpus ...................................................................... Patch Set 2: (1 comment) File src/cpu/x86/mp_init.c: https://review.coreboot.org/c/coreboot/+/63566/comment/fa425b17_cb608c43 PS2, Line 984: mp_run_on_aps_and_wait_for_complete > i haven't yet tried `mp_run_on_all_aps` passing `false` […] The `mp_` functions are all "asynchronous" effectively; they ensure that all of the requested APs accept the task before returning, but it does not wait for the APs to finish. The MP init framework has provisions for that when it is required during mp initialization. -- To view, visit https://review.coreboot.org/c/coreboot/+/63566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d1d49bca410c821a3ad0347548afc42eb860594 Gerrit-Change-Number: 63566 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 15 Apr 2022 18:14:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/external: Add support for coreDOOM payload
by Nicholas Chin (Code Review) 15 Apr '22

15 Apr '22

Attention is currently required from: Martin L Roth, Stefan Reinauer, Nicholas Chin. Hello Felix Singer, build bot (Jenkins), Martin L Roth, Paul Menzel, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57222 to look at the new patch set (#5). Change subject: payloads/external: Add support for coreDOOM payload ...................................................................... payloads/external: Add support for coreDOOM payload coreDOOM is a port of DOOM to libpayload, based on the doomgeneric source port. It renders the game to the coreboot linear framebuffer, and loads WAD files from CBFS. Tested with QEMU i440fx/q35 and a Dell Latitude E6400 using the libgfxinit provided linear framebuffer. Project page: https://github.com/nic3-14159/coreDOOM Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> Change-Id: Ice0403b003a4b2717afee585f28303c2f5abea5d --- M payloads/Kconfig M payloads/Makefile.inc M payloads/external/Makefile.inc M payloads/external/SeaBIOS/Kconfig A payloads/external/coreDOOM/Kconfig.secondary A payloads/external/coreDOOM/Makefile A payloads/external/coreDOOM/libpayload-config M src/device/Kconfig 8 files changed, 101 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/57222/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/57222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice0403b003a4b2717afee585f28303c2f5abea5d Gerrit-Change-Number: 57222 Gerrit-PatchSet: 5 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dewatt: Enable tablet mode switch
by Rob Barnes (Code Review) 15 Apr '22

15 Apr '22

Attention is currently required from: Diana Zigterman, Kenneth Chan, Karthik Ramasubramanian. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63649 ) Change subject: mb/google/dewatt: Enable tablet mode switch ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h: https://review.coreboot.org/c/coreboot/+/63649/comment/b7c0d41a_70e1476c PS3, Line 65: #define EC_ENABLE_TBMC_DEVICE > This should be moved to dewatt/include/variant/ec. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ae31f314ee42474a1252be458ab383ec6036d85 Gerrit-Change-Number: 63649 Gerrit-PatchSet: 4 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Diana Zigterman <dzigterman(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Diana Zigterman <dzigterman(a)google.com> Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 15 Apr 2022 17:59:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/nipperkin: Remove EC_ENABLE_MKBP_DEVICE
by Rob Barnes (Code Review) 15 Apr '22

15 Apr '22

Rob Barnes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63659 ) Change subject: mb/google/nipperkin: Remove EC_ENABLE_MKBP_DEVICE ...................................................................... mb/google/nipperkin: Remove EC_ENABLE_MKBP_DEVICE Remove EC_ENABLE_MKBP_DEVICE on Nipperkin because it is not needed. Move EC_ENABLE_MKBP_DEVICE to be enabled on dewatt only. Add EC_ENABLE_LID_SWITCH to nipperkin because MKBP will no longer provide lid events. CONFIG_MKBP_INPUT_DEVICES must also be disabled on nipperkin EC, otherwise power button will not function. BUG=b:228259884 BRANCH=guybrush TEST=Power button, lid and keyboard tested on Nipperkin Cq-Depend: chromium:3587973 Change-Id: Idd508fe93f15d5d752945208a0d2a07a64d2635f Signed-off-by: Rob Barnes <robbarnes(a)google.com> --- M src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h M src/mainboard/google/guybrush/variants/dewatt/include/variant/ec.h M src/mainboard/google/guybrush/variants/nipperkin/include/variant/ec.h 3 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/63659/1 diff --git a/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h index 34e2edd..f057cca 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h @@ -54,9 +54,6 @@ /* Set GPI for SCI */ #define EC_SCI_GPI GEVENT_24 /* eSPI system event -> GPE 24 */ -/* Enable MKBP for buttons and switches */ -#define EC_ENABLE_MKBP_DEVICE - /* Provide wake pin for EC */ #define EC_ENABLE_WAKE_PIN GEVENT_3 /* AGPIO 22 -> GPE 3 */ diff --git a/src/mainboard/google/guybrush/variants/dewatt/include/variant/ec.h b/src/mainboard/google/guybrush/variants/dewatt/include/variant/ec.h index 3b4950b..7eaf4d5 100644 --- a/src/mainboard/google/guybrush/variants/dewatt/include/variant/ec.h +++ b/src/mainboard/google/guybrush/variants/dewatt/include/variant/ec.h @@ -2,5 +2,8 @@ #include <baseboard/ec.h> +/* Enable MKBP for buttons and switches */ +#define EC_ENABLE_MKBP_DEVICE + /* Enable Tablet switch */ #define EC_ENABLE_TBMC_DEVICE diff --git a/src/mainboard/google/guybrush/variants/nipperkin/include/variant/ec.h b/src/mainboard/google/guybrush/variants/nipperkin/include/variant/ec.h index 9e61a44..8fd54e6 100644 --- a/src/mainboard/google/guybrush/variants/nipperkin/include/variant/ec.h +++ b/src/mainboard/google/guybrush/variants/nipperkin/include/variant/ec.h @@ -1,3 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <baseboard/ec.h> + +/* Enable LID switch for EC */ +#define EC_ENABLE_LID_SWITCH -- To view, visit https://review.coreboot.org/c/coreboot/+/63659 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd508fe93f15d5d752945208a0d2a07a64d2635f Gerrit-Change-Number: 63659 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/guybrush: Remove EC_ENABLE_LID_SWITCH
by Rob Barnes (Code Review) 15 Apr '22

15 Apr '22

Rob Barnes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63658 ) Change subject: mb/google/guybrush: Remove EC_ENABLE_LID_SWITCH ...................................................................... mb/google/guybrush: Remove EC_ENABLE_LID_SWITCH Remove EC_ENABLE_LID_SWITCH since this causes a duplicate SW_LID entries. The other SW_LID entry is generated by MKBP. BUG=b:228907256 BRANCH=guybrush TEST=Lid open close triggers events on Nipperkin Change-Id: I5c1cf7aeac8405bce7bfc77110eceaf3e5383fe7 Signed-off-by: Rob Barnes <robbarnes(a)google.com> --- M src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/63658/1 diff --git a/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h index 5695a8e..34e2edd 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h @@ -57,8 +57,7 @@ /* Enable MKBP for buttons and switches */ #define EC_ENABLE_MKBP_DEVICE -/* Enable LID switch and provide wake pin for EC */ -#define EC_ENABLE_LID_SWITCH +/* Provide wake pin for EC */ #define EC_ENABLE_WAKE_PIN GEVENT_3 /* AGPIO 22 -> GPE 3 */ #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ -- To view, visit https://review.coreboot.org/c/coreboot/+/63658 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c1cf7aeac8405bce7bfc77110eceaf3e5383fe7 Gerrit-Change-Number: 63658 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/dewatt: Enable tablet mode switch
by Rob Barnes (Code Review) 15 Apr '22

15 Apr '22

Attention is currently required from: Diana Zigterman, Kenneth Chan, Karthik Ramasubramanian. Rob Barnes has uploaded a new patch set (#4) to the change originally created by Kenneth Chan. ( https://review.coreboot.org/c/coreboot/+/63649 ) Change subject: mb/google/dewatt: Enable tablet mode switch ...................................................................... mb/google/dewatt: Enable tablet mode switch Enable tablet mode switch to fix can't switch to tablet mode issue. BUG=b:228868883 BRANCH=guybrush TEST=local build test on Dewatt: testing tablet mode switch Change-Id: I0ae31f314ee42474a1252be458ab383ec6036d85 Signed-off-by: Rob Barnes <robbarnes(a)google.com> --- M src/mainboard/google/guybrush/variants/dewatt/include/variant/ec.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/63649/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/63649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ae31f314ee42474a1252be458ab383ec6036d85 Gerrit-Change-Number: 63649 Gerrit-PatchSet: 4 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Diana Zigterman <dzigterman(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Diana Zigterman <dzigterman(a)google.com> Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: arch/x86: Add support for catching null deferences through debug regs
by Robert Zieba (Code Review) 15 Apr '22

15 Apr '22

Attention is currently required from: Robert Zieba. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63657 to look at the new patch set (#5). Change subject: arch/x86: Add support for catching null deferences through debug regs ...................................................................... arch/x86: Add support for catching null deferences through debug regs This commit adds support for catching null deferences and execution through x86's debug registers. This is particularly useful when running 32-bit coreboot as paging is not enabled to catch these through page faults. To support this feature three new configs have been added: DEBUG_HW_BREAKPOINTS, DEBUG_NULL_DEREF_BREAKPOINTS and DEBUG_NULL_DEREF_HALT. BUG=b:223902046 TEST=Ran on nipperkin device, verifying that HW breakpoints work as expected Change-Id: I113590689046a13c2a552741bbfe7668a834354a Signed-off-by: Robert Zieba <robertzieba(a)google.com> --- M src/arch/x86/Kconfig M src/arch/x86/Makefile.inc A src/arch/x86/breakpoint.c M src/arch/x86/exception.c A src/arch/x86/include/arch/breakpoint.h A src/arch/x86/include/arch/null_breakpoint.h A src/arch/x86/null_breakpoint.c 7 files changed, 422 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/63657/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/63657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I113590689046a13c2a552741bbfe7668a834354a Gerrit-Change-Number: 63657 Gerrit-PatchSet: 5 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: amdfwtool: Allow for the tool to support additional PSP entries.
by Paul Menzel (Code Review) 15 Apr '22

15 Apr '22

Attention is currently required from: Bao Zheng, Jason Nien, Al Hirani. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62911 ) Change subject: amdfwtool: Allow for the tool to support additional PSP entries. ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62911/comment/81103a1b_cf555ece PS2, Line 8: > The tool has a limit to the number of PSP entries it can take as an input, so I can't specify which […] Yes please make that clear by being specific. For example: Allow 16 more additional PSP entries https://review.coreboot.org/c/coreboot/+/62911/comment/825720e3_9f45d1e4 PS2, Line 9: Consolidate the MAX_BIOS_ENTRIES and MAX_PSP_ENTRIES definitions into one file > Done The dot is still there. -- To view, visit https://review.coreboot.org/c/coreboot/+/62911 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie3c64a1875010e7fb368967283df6baf1cc7ba8d Gerrit-Change-Number: 62911 Gerrit-PatchSet: 3 Gerrit-Owner: Al Hirani <al.hirani13(a)gmail.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Al Hirani <al.hirani13(a)gmail.com> Gerrit-Comment-Date: Fri, 15 Apr 2022 17:54:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Al Hirani <al.hirani13(a)gmail.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Reset XHCI controller while preparing for S5
by Subrata Banik (Code Review) 15 Apr '22

15 Apr '22

Attention is currently required from: Maulik V Vaghela, Sridhar Siricilla, Nick Vaccaro, Eric Lai, Felix Held. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63552 ) Change subject: mb/google/brya: Reset XHCI controller while preparing for S5 ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > My concern I guess would be adding a new weak SoC smihandler_sleep function(), when this should hopefully be reverted soon-ish, and then it is no longer needed. I guess earlier, SMI handler resides inside SoC layer hence, only one mainboard callback serves well. But after we migrated the SMI handler into common code, I agree with Felix that we should have provided 2 callback (one for SOC and one for mainboard) to W/A such issue at SoC layer rather touching every mainboard. -- To view, visit https://review.coreboot.org/c/coreboot/+/63552 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf06a64f055a0cee3659b410652082f31e18e149 Gerrit-Change-Number: 63552 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 15 Apr 2022 17:49:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: Add support for catching null deferences through debug regs
by Robert Zieba (Code Review) 15 Apr '22

15 Apr '22

Attention is currently required from: Robert Zieba. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63657 to look at the new patch set (#4). Change subject: arch/x86: Add support for catching null deferences through debug regs ...................................................................... arch/x86: Add support for catching null deferences through debug regs This commit adds support for catching null deferences and execution through x86's debug registers. This is particularly useful when running 32-bit coreboot as paging is not enabled to catch these through page faults. To support this feature three new configs have been added: DEBUG_HW_BREAKPOINTS, DEBUG_NULL_DEREF_BREAKPOINTS and DEBUG_NULL_DEREF_HALT. BUG=b:223902046 TEST=Ran on nipperkin device, verifying that HW breakpoints work as expected Change-Id: I113590689046a13c2a552741bbfe7668a834354a Signed-off-by: Robert Zieba <robertzieba(a)google.com> --- M src/arch/x86/Kconfig M src/arch/x86/Makefile.inc A src/arch/x86/breakpoint.c M src/arch/x86/exception.c A src/arch/x86/include/arch/breakpoint.h A src/arch/x86/include/arch/null_breakpoint.h A src/arch/x86/null_breakpoint.c 7 files changed, 422 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/63657/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/63657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I113590689046a13c2a552741bbfe7668a834354a Gerrit-Change-Number: 63657 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022