coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: mb/ibase/mb899: Drop `_PRS` and `_DIS` from static devices
by Felix Held (Code Review) 20 Apr '22

20 Apr '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63527 ) Change subject: mb/ibase/mb899: Drop `_PRS` and `_DIS` from static devices ...................................................................... mb/ibase/mb899: Drop `_PRS` and `_DIS` from static devices The `_PRS` ACPI object is not needed for static (non-configurable) devices. For devices where `_CRS` always provides the same set of resource settings, drop the `_PRS` object. Note that every dropped `_PRS` object only provides one set of resource settings, which is identical to the resource settings provided by the `_CRS` object. The no-op `_DIS` methods can also be removed for the same reason. Also, drop `IGNORE_IASL_MISSING_DEPENDENCY` as it's no longer needed. Change-Id: I7e702e9318fbf68dbd883a145111e6beb6815b8b Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/63527 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/mainboard/ibase/mb899/Kconfig M src/mainboard/ibase/mb899/acpi/superio.asl 2 files changed, 0 insertions(+), 21 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved diff --git a/src/mainboard/ibase/mb899/Kconfig b/src/mainboard/ibase/mb899/Kconfig index fdfe541..05b0a09 100644 --- a/src/mainboard/ibase/mb899/Kconfig +++ b/src/mainboard/ibase/mb899/Kconfig @@ -1,8 +1,5 @@ if BOARD_IBASE_MB899 -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select CPU_INTEL_SOCKET_M diff --git a/src/mainboard/ibase/mb899/acpi/superio.asl b/src/mainboard/ibase/mb899/acpi/superio.asl index 488bf18..1932eab 100644 --- a/src/mainboard/ibase/mb899/acpi/superio.asl +++ b/src/mainboard/ibase/mb899/acpi/superio.asl @@ -18,15 +18,6 @@ Return (0x0f) } - Method (_DIS, 0) { /* NOOP */ } - - Name (_PRS, ResourceTemplate() { - StartDependentFn(0, 1) { - IO(Decode16, 0x3f8, 0x3f8, 0x8, 0x8) - IRQNoFlags() { 4 } - } EndDependentFn() - }) - Method (_CRS, 0) { Return(ResourceTemplate() { @@ -51,15 +42,6 @@ Return (0x0f) } - Method (_DIS, 0) { /* NOOP */ } - - Name (_PRS, ResourceTemplate() { - StartDependentFn(0, 1) { - IO(Decode16, 0x2f8, 0x2f8, 0x8, 0x8) - IRQNoFlags() { 3 } - } EndDependentFn() - }) - Method (_CRS, 0) { Return(ResourceTemplate() { -- To view, visit https://review.coreboot.org/c/coreboot/+/63527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e702e9318fbf68dbd883a145111e6beb6815b8b Gerrit-Change-Number: 63527 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/ibase/mb899: Drop `_PRS` and `_DIS` from static devices
by Felix Held (Code Review) 20 Apr '22

20 Apr '22

Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63527 ) Change subject: mb/ibase/mb899: Drop `_PRS` and `_DIS` from static devices ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e702e9318fbf68dbd883a145111e6beb6815b8b Gerrit-Change-Number: 63527 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 20 Apr 2022 10:05:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/protectli/vault_bsw: Drop `_PRS` from static devices
by Felix Held (Code Review) 20 Apr '22

20 Apr '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63526 ) Change subject: mb/protectli/vault_bsw: Drop `_PRS` from static devices ...................................................................... mb/protectli/vault_bsw: Drop `_PRS` from static devices The `_PRS` ACPI object is not needed for static (non-configurable) devices. For devices where `_CRS` always provides the same set of resource settings, drop the `_PRS` object. Note that every dropped `_PRS` object only provides one set of resource settings, which is identical to the resource settings provided by the `_CRS` object. Also, drop `IGNORE_IASL_MISSING_DEPENDENCY` as it's no longer needed. Change-Id: Ic37608ac9622b37cae6d81045740a033e9aa9d4f Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/63526 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/mainboard/protectli/vault_bsw/Kconfig M src/mainboard/protectli/vault_bsw/acpi/superio.asl 2 files changed, 0 insertions(+), 12 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved diff --git a/src/mainboard/protectli/vault_bsw/Kconfig b/src/mainboard/protectli/vault_bsw/Kconfig index 5877f84..e169392 100644 --- a/src/mainboard/protectli/vault_bsw/Kconfig +++ b/src/mainboard/protectli/vault_bsw/Kconfig @@ -1,8 +1,5 @@ if BOARD_PROTECTLI_FW2B || BOARD_PROTECTLI_FW4B -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 diff --git a/src/mainboard/protectli/vault_bsw/acpi/superio.asl b/src/mainboard/protectli/vault_bsw/acpi/superio.asl index e51eb00..40303e1 100644 --- a/src/mainboard/protectli/vault_bsw/acpi/superio.asl +++ b/src/mainboard/protectli/vault_bsw/acpi/superio.asl @@ -14,13 +14,4 @@ FixedIO (0x03F8, 0x08) IRQNoFlags () {4} }) - - Name (_PRS, ResourceTemplate () - { - StartDependentFn (0, 0) { - FixedIO (0x03F8, 0x08) - IRQNoFlags () {4} - } - EndDependentFn () - }) } -- To view, visit https://review.coreboot.org/c/coreboot/+/63526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic37608ac9622b37cae6d81045740a033e9aa9d4f Gerrit-Change-Number: 63526 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/protectli/vault_bsw: Drop `_PRS` from static devices
by Felix Held (Code Review) 20 Apr '22

20 Apr '22

Attention is currently required from: Michał Żygowski, Angel Pons, Piotr Król. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63526 ) Change subject: mb/protectli/vault_bsw: Drop `_PRS` from static devices ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic37608ac9622b37cae6d81045740a033e9aa9d4f Gerrit-Change-Number: 63526 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 20 Apr 2022 10:05:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ChromeEC boards: Drop `IGNORE_IASL_MISSING_DEPENDENCY`
by Felix Held (Code Review) 20 Apr '22

20 Apr '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63525 ) Change subject: ChromeEC boards: Drop `IGNORE_IASL_MISSING_DEPENDENCY` ...................................................................... ChromeEC boards: Drop `IGNORE_IASL_MISSING_DEPENDENCY` This should no longer be needed because the ASL has been fixed. Change-Id: I4d1500217bef54fa3d2be397e5e2a155da3f965d Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/63525 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/mainboard/google/auron/Kconfig M src/mainboard/google/beltino/Kconfig M src/mainboard/google/brya/Kconfig M src/mainboard/google/butterfly/Kconfig M src/mainboard/google/cyan/Kconfig M src/mainboard/google/dedede/Kconfig M src/mainboard/google/deltaur/Kconfig M src/mainboard/google/drallion/Kconfig M src/mainboard/google/eve/Kconfig M src/mainboard/google/fizz/Kconfig M src/mainboard/google/glados/Kconfig M src/mainboard/google/guybrush/Kconfig M src/mainboard/google/hatch/Kconfig M src/mainboard/google/jecht/Kconfig M src/mainboard/google/kahlee/Kconfig M src/mainboard/google/link/Kconfig M src/mainboard/google/octopus/Kconfig M src/mainboard/google/poppy/Kconfig M src/mainboard/google/rambi/Kconfig M src/mainboard/google/reef/Kconfig M src/mainboard/google/sarien/Kconfig M src/mainboard/google/skyrim/Kconfig M src/mainboard/google/slippy/Kconfig M src/mainboard/google/stout/Kconfig M src/mainboard/google/volteer/Kconfig M src/mainboard/google/zork/Kconfig M src/mainboard/intel/adlrvp/Kconfig M src/mainboard/intel/baskingridge/Kconfig M src/mainboard/intel/glkrvp/Kconfig M src/mainboard/intel/jasperlake_rvp/Kconfig M src/mainboard/intel/kblrvp/Kconfig M src/mainboard/intel/kunimitsu/Kconfig M src/mainboard/intel/shadowmountain/Kconfig M src/mainboard/intel/strago/Kconfig M src/mainboard/intel/tglrvp/Kconfig 35 files changed, 0 insertions(+), 105 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig index ead4c3b..7c9b864 100644 --- a/src/mainboard/google/auron/Kconfig +++ b/src/mainboard/google/auron/Kconfig @@ -44,9 +44,6 @@ if BOARD_GOOGLE_BASEBOARD_AURON -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_LID_SWITCH diff --git a/src/mainboard/google/beltino/Kconfig b/src/mainboard/google/beltino/Kconfig index d6da71c..74caad2 100644 --- a/src/mainboard/google/beltino/Kconfig +++ b/src/mainboard/google/beltino/Kconfig @@ -31,9 +31,6 @@ if BOARD_GOOGLE_BASEBOARD_BELTINO -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config VBOOT select VBOOT_VBNV_CMOS diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 331041f..24a606c 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -69,9 +69,6 @@ if BOARD_GOOGLE_BRYA_COMMON -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BASEBOARD_DIR string default "brya" if BOARD_GOOGLE_BASEBOARD_BRYA diff --git a/src/mainboard/google/butterfly/Kconfig b/src/mainboard/google/butterfly/Kconfig index ebb5233..f8897ac 100644 --- a/src/mainboard/google/butterfly/Kconfig +++ b/src/mainboard/google/butterfly/Kconfig @@ -1,8 +1,5 @@ if BOARD_GOOGLE_BUTTERFLY -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig index 5feecf6..c303266 100644 --- a/src/mainboard/google/cyan/Kconfig +++ b/src/mainboard/google/cyan/Kconfig @@ -54,9 +54,6 @@ if BOARD_GOOGLE_BASEBOARD_CYAN -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_LID_SWITCH diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 07b7bf1..458dfc7 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -47,9 +47,6 @@ if BOARD_GOOGLE_BASEBOARD_DEDEDE -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BASEBOARD_DEDEDE_LAPTOP def_bool n select SYSTEM_TYPE_LAPTOP diff --git a/src/mainboard/google/deltaur/Kconfig b/src/mainboard/google/deltaur/Kconfig index eb27796..7dc4286 100644 --- a/src/mainboard/google/deltaur/Kconfig +++ b/src/mainboard/google/deltaur/Kconfig @@ -27,9 +27,6 @@ if BOARD_GOOGLE_BASEBOARD_DELTAUR -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config CHROMEOS select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC select GBB_FLAG_FORCE_DEV_BOOT_ALTFW diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index 60a07eb..a26e70e 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -28,9 +28,6 @@ if BOARD_GOOGLE_BASEBOARD_DRALLION -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config DISABLE_HECI1_AT_PRE_BOOT default y diff --git a/src/mainboard/google/eve/Kconfig b/src/mainboard/google/eve/Kconfig index ec86185..5e1b2f7 100644 --- a/src/mainboard/google/eve/Kconfig +++ b/src/mainboard/google/eve/Kconfig @@ -1,8 +1,5 @@ if BOARD_GOOGLE_EVE -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig index 3e2b8c1..01d838a 100644 --- a/src/mainboard/google/fizz/Kconfig +++ b/src/mainboard/google/fizz/Kconfig @@ -40,9 +40,6 @@ config DISABLE_HECI1_AT_PRE_BOOT default y -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config DEVICETREE default "variants/baseboard/devicetree.cb" diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig index 3a1f38b..59ea8ed 100644 --- a/src/mainboard/google/glados/Kconfig +++ b/src/mainboard/google/glados/Kconfig @@ -78,9 +78,6 @@ config DISABLE_HECI1_AT_PRE_BOOT default y -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_LID_SWITCH diff --git a/src/mainboard/google/guybrush/Kconfig b/src/mainboard/google/guybrush/Kconfig index 069da6c..a49f586 100644 --- a/src/mainboard/google/guybrush/Kconfig +++ b/src/mainboard/google/guybrush/Kconfig @@ -5,9 +5,6 @@ if BOARD_GOOGLE_BASEBOARD_GUYBRUSH -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select AMD_SOC_CONSOLE_UART diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 2ddc403..ad23f05 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -150,9 +150,6 @@ if BOARD_GOOGLE_HATCH_COMMON -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config DISABLE_HECI1_AT_PRE_BOOT default y if BOARD_GOOGLE_BASEBOARD_HATCH diff --git a/src/mainboard/google/jecht/Kconfig b/src/mainboard/google/jecht/Kconfig index 0724466..836cbdf 100644 --- a/src/mainboard/google/jecht/Kconfig +++ b/src/mainboard/google/jecht/Kconfig @@ -26,9 +26,6 @@ if BOARD_GOOGLE_BASEBOARD_JECHT -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config VBOOT select VBOOT_VBNV_CMOS diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index 0f536b4..c82a20e 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -37,9 +37,6 @@ if BOARD_GOOGLE_BASEBOARD_KAHLEE -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config MAINBOARD_DIR default "google/kahlee" diff --git a/src/mainboard/google/link/Kconfig b/src/mainboard/google/link/Kconfig index ba38cb7..e08ced9 100644 --- a/src/mainboard/google/link/Kconfig +++ b/src/mainboard/google/link/Kconfig @@ -1,8 +1,5 @@ if BOARD_GOOGLE_LINK -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index 840ce8e..8bcd826 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -97,9 +97,6 @@ if BOARD_GOOGLE_BASEBOARD_OCTOPUS -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config CHROMEOS_WIFI_SAR bool default y if CHROMEOS diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index e650628..4032f57 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -98,9 +98,6 @@ if BOARD_GOOGLE_BASEBOARD_POPPY -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config DISABLE_HECI1_AT_PRE_BOOT default y diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index dfd66c0..ad113f5 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -92,9 +92,6 @@ if BOARD_GOOGLE_BASEBOARD_RAMBI -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_LID_SWITCH diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index 0073e09..0ab463e 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -39,9 +39,6 @@ if BOARD_GOOGLE_BASEBOARD_REEF -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config DRIVER_TPM_I2C_BUS hex default 0x2 diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index 9381ac9..32a253e 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -36,9 +36,6 @@ if BOARD_GOOGLE_BASEBOARD_SARIEN -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config DISABLE_HECI1_AT_PRE_BOOT default y diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig index 37091ab..3c2eab2 100644 --- a/src/mainboard/google/skyrim/Kconfig +++ b/src/mainboard/google/skyrim/Kconfig @@ -5,9 +5,6 @@ if BOARD_GOOGLE_BASEBOARD_SKYRIM -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config AMD_FWM_POSITION_INDEX int default 3 diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig index 0d0902c..0148093 100644 --- a/src/mainboard/google/slippy/Kconfig +++ b/src/mainboard/google/slippy/Kconfig @@ -33,9 +33,6 @@ if BOARD_GOOGLE_BASEBOARD_SLIPPY -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_LID_SWITCH diff --git a/src/mainboard/google/stout/Kconfig b/src/mainboard/google/stout/Kconfig index b2cd295..d26d5b9 100644 --- a/src/mainboard/google/stout/Kconfig +++ b/src/mainboard/google/stout/Kconfig @@ -1,8 +1,5 @@ if BOARD_GOOGLE_STOUT -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 4f83d1c..28d3457 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -121,9 +121,6 @@ if BOARD_GOOGLE_BASEBOARD_VOLTEER -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config CHROMEOS select CHROMEOS_CSE_BOARD_RESET_OVERRIDE select CHROMEOS_DRAM_PART_NUMBER_IN_CBI diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index dfc87bf..6d66b1a 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -8,9 +8,6 @@ if BOARD_GOOGLE_BASEBOARD_TREMBYLE || BOARD_GOOGLE_BASEBOARD_DALBOZ -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select SOC_AMD_COMMON_BLOCK_USE_ESPI diff --git a/src/mainboard/intel/adlrvp/Kconfig b/src/mainboard/intel/adlrvp/Kconfig index 82ba5e4..0e9f4fb 100644 --- a/src/mainboard/intel/adlrvp/Kconfig +++ b/src/mainboard/intel/adlrvp/Kconfig @@ -74,9 +74,6 @@ if BOARD_INTEL_ADLRVP_COMMON -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config CHROMEOS select GBB_FLAG_FORCE_DEV_SWITCH_ON select GBB_FLAG_FORCE_DEV_BOOT_USB diff --git a/src/mainboard/intel/baskingridge/Kconfig b/src/mainboard/intel/baskingridge/Kconfig index a22c339..6d7bc8c 100644 --- a/src/mainboard/intel/baskingridge/Kconfig +++ b/src/mainboard/intel/baskingridge/Kconfig @@ -1,8 +1,5 @@ if BOARD_INTEL_BASKING_RIDGE -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select NORTHBRIDGE_INTEL_HASWELL diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig index a7a262f..d9b61ca 100644 --- a/src/mainboard/intel/glkrvp/Kconfig +++ b/src/mainboard/intel/glkrvp/Kconfig @@ -15,9 +15,6 @@ if BOARD_INTEL_BASEBOARD_GLKRVP -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BASEBOARD_GLKRVP_LAPTOP def_bool n select SYSTEM_TYPE_LAPTOP diff --git a/src/mainboard/intel/jasperlake_rvp/Kconfig b/src/mainboard/intel/jasperlake_rvp/Kconfig index 6ae3566..2d72f95 100644 --- a/src/mainboard/intel/jasperlake_rvp/Kconfig +++ b/src/mainboard/intel/jasperlake_rvp/Kconfig @@ -33,9 +33,6 @@ if BOARD_INTEL_JASPERLAKE_RVP_COMMON -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config DISABLE_HECI1_AT_PRE_BOOT default y diff --git a/src/mainboard/intel/kblrvp/Kconfig b/src/mainboard/intel/kblrvp/Kconfig index 11d1319..6b60ac4 100644 --- a/src/mainboard/intel/kblrvp/Kconfig +++ b/src/mainboard/intel/kblrvp/Kconfig @@ -31,9 +31,6 @@ if BOARD_INTEL_KBLRVP_COMMON -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config DISABLE_HECI1_AT_PRE_BOOT default y diff --git a/src/mainboard/intel/kunimitsu/Kconfig b/src/mainboard/intel/kunimitsu/Kconfig index dc456b6..22fffb0 100644 --- a/src/mainboard/intel/kunimitsu/Kconfig +++ b/src/mainboard/intel/kunimitsu/Kconfig @@ -1,8 +1,5 @@ if BOARD_INTEL_KUNIMITSU -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 diff --git a/src/mainboard/intel/shadowmountain/Kconfig b/src/mainboard/intel/shadowmountain/Kconfig index f6d8a58..9294857 100644 --- a/src/mainboard/intel/shadowmountain/Kconfig +++ b/src/mainboard/intel/shadowmountain/Kconfig @@ -1,8 +1,5 @@ if BOARD_INTEL_SHADOWMOUNTAIN -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_32768 diff --git a/src/mainboard/intel/strago/Kconfig b/src/mainboard/intel/strago/Kconfig index 725ee9f..64d5dfc 100644 --- a/src/mainboard/intel/strago/Kconfig +++ b/src/mainboard/intel/strago/Kconfig @@ -1,8 +1,5 @@ if BOARD_INTEL_STRAGO -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 diff --git a/src/mainboard/intel/tglrvp/Kconfig b/src/mainboard/intel/tglrvp/Kconfig index 8a4c9ad..77a8afd 100644 --- a/src/mainboard/intel/tglrvp/Kconfig +++ b/src/mainboard/intel/tglrvp/Kconfig @@ -1,8 +1,5 @@ if BOARD_INTEL_TGLRVP_UP3 || BOARD_INTEL_TGLRVP_UP4 -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_32768 -- To view, visit https://review.coreboot.org/c/coreboot/+/63525 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d1500217bef54fa3d2be397e5e2a155da3f965d Gerrit-Change-Number: 63525 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ChromeEC boards: Drop `IGNORE_IASL_MISSING_DEPENDENCY`
by Felix Held (Code Review) 20 Apr '22

20 Apr '22

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Angel Pons. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63525 ) Change subject: ChromeEC boards: Drop `IGNORE_IASL_MISSING_DEPENDENCY` ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63525 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d1500217bef54fa3d2be397e5e2a155da3f965d Gerrit-Change-Number: 63525 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 20 Apr 2022 10:04:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/google/chromeec: Drop `_PRS` from static devices
by Felix Held (Code Review) 20 Apr '22

20 Apr '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63521 ) Change subject: ec/google/chromeec: Drop `_PRS` from static devices ...................................................................... ec/google/chromeec: Drop `_PRS` from static devices The `_PRS` ACPI object is not needed for static (non-configurable) devices. For devices where `_CRS` always provides the same set of resource settings, drop the `_PRS` object. Note that every dropped `_PRS` object only provides one set of resource settings, which is identical to the resource settings provided by the `_CRS` object. Change-Id: Ief40e790fdee336fd6c786e18cd01c41fa658c2c Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/63521 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> --- M src/ec/google/chromeec/acpi/superio.asl 1 file changed, 0 insertions(+), 46 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved diff --git a/src/ec/google/chromeec/acpi/superio.asl b/src/ec/google/chromeec/acpi/superio.asl index 05310be..0620e09 100644 --- a/src/ec/google/chromeec/acpi/superio.asl +++ b/src/ec/google/chromeec/acpi/superio.asl @@ -37,12 +37,6 @@ IO (Decode16, EC_LPC_ADDR_MEMMAP, EC_LPC_ADDR_MEMMAP, 0x08, EC_MEMMAP_SIZE) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, EC_LPC_ADDR_MEMMAP, EC_LPC_ADDR_MEMMAP, - 0x08, EC_MEMMAP_SIZE) - }) } #endif @@ -70,23 +64,6 @@ EC_HOST_CMD_REGION1, EC_HOST_CMD_REGION1, 0x08, EC_HOST_CMD_REGION_SIZE) }) - - Name (_PRS, ResourceTemplate () - { - StartDependentFn (0, 0) { - IO (Decode16, EC_LPC_ADDR_HOST_DATA, - EC_LPC_ADDR_HOST_DATA, 0x01, 0x01) - IO (Decode16, EC_LPC_ADDR_HOST_CMD, - EC_LPC_ADDR_HOST_CMD, 0x01, 0x01) - IO (Decode16, - EC_HOST_CMD_REGION0, EC_HOST_CMD_REGION0, - 0x08, EC_HOST_CMD_REGION_SIZE) - IO (Decode16, - EC_HOST_CMD_REGION1, EC_HOST_CMD_REGION1, - 0x08, EC_HOST_CMD_REGION_SIZE) - } - EndDependentFn () - }) } #endif @@ -104,15 +81,6 @@ IO (Decode16, 0x03F8, 0x3F8, 0x08, 0x08) IRQNoFlags () {4} }) - - Name (_PRS, ResourceTemplate () - { - StartDependentFn (0, 0) { - IO (Decode16, 0x03F8, 0x3F8, 0x08, 0x08) - IRQNoFlags () {4} - } - EndDependentFn () - }) } #endif } @@ -140,20 +108,6 @@ IRQ (Edge, ActiveHigh, Exclusive) {1} #endif }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) -#ifdef SIO_EC_PS2K_IRQ - SIO_EC_PS2K_IRQ -#else - IRQ (Edge, ActiveHigh, Exclusive) {1} -#endif - } - EndDependentFn () - }) } } #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/63521 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief40e790fdee336fd6c786e18cd01c41fa658c2c Gerrit-Change-Number: 63521 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Override SPI fast speed
by 9elements QA (Code Review) 20 Apr '22

20 Apr '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63685 ) Change subject: mb/google/guybrush/var/dewatt: Override SPI fast speed ...................................................................... Patch Set 2: Automatic boot test returned (PASS/FAIL/TOTAL): 12 / 1 / 13 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/101405 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/101404 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/101403 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/101402 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/101401 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/101400 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/101399 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/101398 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/101397 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/101396 FAIL: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/101395 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/101394 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/101393 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/63685 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7301d873e36bec4ee46c9d18293f924500ea9aba Gerrit-Change-Number: 63685 Gerrit-PatchSet: 2 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Wed, 20 Apr 2022 10:04:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/google/chromeec: Drop `_PRS` from static devices
by Felix Held (Code Review) 20 Apr '22

20 Apr '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63521 ) Change subject: ec/google/chromeec: Drop `_PRS` from static devices ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63521 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief40e790fdee336fd6c786e18cd01c41fa658c2c Gerrit-Change-Number: 63521 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 20 Apr 2022 10:02:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: superio/smsc/mec1308: Drop `_PRS` from static devices
by Felix Held (Code Review) 20 Apr '22

20 Apr '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63523 ) Change subject: superio/smsc/mec1308: Drop `_PRS` from static devices ...................................................................... superio/smsc/mec1308: Drop `_PRS` from static devices The `_PRS` ACPI object is not needed for static (non-configurable) devices. For devices where `_CRS` always provides the same set of resource settings, drop the `_PRS` object. Note that every dropped `_PRS` object only provides one set of resource settings, which is identical to the resource settings provided by the `_CRS` object. In addition, drop `IGNORE_IASL_MISSING_DEPENDENCY` from the two mainboards using the MEC1308 code, `samsung/{lumpy, stumpy}`. Change-Id: I5d5cdc28c2cfaa5dfcffd656060b931208977386 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/63523 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/mainboard/samsung/lumpy/Kconfig M src/mainboard/samsung/stumpy/Kconfig M src/superio/smsc/mec1308/acpi/superio.asl 3 files changed, 0 insertions(+), 44 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved diff --git a/src/mainboard/samsung/lumpy/Kconfig b/src/mainboard/samsung/lumpy/Kconfig index f9710e5..d0574bb 100644 --- a/src/mainboard/samsung/lumpy/Kconfig +++ b/src/mainboard/samsung/lumpy/Kconfig @@ -1,8 +1,5 @@ if BOARD_SAMSUNG_LUMPY -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select SYSTEM_TYPE_LAPTOP diff --git a/src/mainboard/samsung/stumpy/Kconfig b/src/mainboard/samsung/stumpy/Kconfig index 13b0eacbf..2a706b9 100644 --- a/src/mainboard/samsung/stumpy/Kconfig +++ b/src/mainboard/samsung/stumpy/Kconfig @@ -1,8 +1,5 @@ if BOARD_SAMSUNG_STUMPY -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 diff --git a/src/superio/smsc/mec1308/acpi/superio.asl b/src/superio/smsc/mec1308/acpi/superio.asl index f692323..117de96 100644 --- a/src/superio/smsc/mec1308/acpi/superio.asl +++ b/src/superio/smsc/mec1308/acpi/superio.asl @@ -101,11 +101,6 @@ { IO (Decode16, SIO_SPM1_IO0, SIO_SPM1_IO0, 0x08, 0x08) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_SPM1_IO0, SIO_SPM1_IO0, 0x08, 0x08) - }) } #endif @@ -122,11 +117,6 @@ { IO (Decode16, SIO_SEC1_IO0, SIO_SEC1_IO0, 0x04, 0x04) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_SEC1_IO0, SIO_SEC1_IO0, 0x04, 0x04) - }) } #endif @@ -143,11 +133,6 @@ { IO (Decode16, SIO_SEC2_IO0, SIO_SEC2_IO0, 0x04, 0x04) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_SEC2_IO0, SIO_SEC2_IO0, 0x04, 0x04) - }) } #endif @@ -165,12 +150,6 @@ IO (Decode16, SIO_SSP1_IO0, SIO_SSP1_IO0, 0x08, 0x08) IRQNoFlags () {SIO_SSP1_IRQ} }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_SSP1_IO0, SIO_SSP1_IO0, 0x08, 0x08) - IRQNoFlags () {SIO_SSP1_IRQ} - }) } #endif @@ -190,13 +169,6 @@ IO (Decode16, 0x64, 0x64, 0x01, 0x01) IRQNoFlags () {1} }) - - Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) - IRQNoFlags () {1} - }) } #endif @@ -213,11 +185,6 @@ { IO (Decode16, SIO_SEC0_IO0, SIO_SEC0_IO0, 0x04, 0x04) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_SEC0_IO0, SIO_SEC0_IO0, 0x04, 0x04) - }) } #endif @@ -235,11 +202,6 @@ { IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0, 0x01, 0x34) }) - - Name (_PRS, ResourceTemplate() - { - IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0, 0x01, 0x34) - }) } #endif } -- To view, visit https://review.coreboot.org/c/coreboot/+/63523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d5cdc28c2cfaa5dfcffd656060b931208977386 Gerrit-Change-Number: 63523 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022