Attention is currently required from: Julius Werner.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60621 )
Change subject: lib: Remove unused <stdlib.h> and use <types.h> when appropriate
......................................................................
Patch Set 13:
(1 comment)
Patchset:
PS13:
Thx
--
To view, visit https://review.coreboot.org/c/coreboot/+/60621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ad171679cbfa67d522bd1105fb58e0f84b9cb89
Gerrit-Change-Number: 60621
Gerrit-PatchSet: 13
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Sat, 23 Apr 2022 06:43:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63797 )
Change subject: Documentation: Add list of boards maintained on each branch
......................................................................
Patch Set 1:
(4 comments)
Patchset:
PS1:
Looks good !
File Documentation/releases/boards_supported_on_branches.md:
https://review.coreboot.org/c/coreboot/+/63797/comment/496e78a9_01e2e696
PS1, Line 99: PARALLEL_INIT
AMD_AMDFAM10
https://review.coreboot.org/c/coreboot/+/63797/comment/952d0397_463403c7
PS1, Line 109: lenovo/z61t
This one is a variant now.
https://review.coreboot.org/c/coreboot/+/63797/comment/60927769_e7f3025b
PS1, Line 265:
spaces
--
To view, visit https://review.coreboot.org/c/coreboot/+/63797
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee25db13e2c1b0b9131fd2032a26ece45aba4f42
Gerrit-Change-Number: 63797
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Martin L Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Sat, 23 Apr 2022 06:26:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63764 )
Change subject: RFC: Kconfig: Show current test run from board-status
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Does this not mean that you periodically need to run that script to update the Kconfig?
--
To view, visit https://review.coreboot.org/c/coreboot/+/63764
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I248e2d4ba59cc63f9b21c27ab32432b24216d3ca
Gerrit-Change-Number: 63764
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Martin L Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Sat, 23 Apr 2022 06:19:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Julius Werner, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63754 )
Change subject: RFC: Kconfig - show boards supported on 4.11 branch (POC)
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
It feels weird to me to have code to not use the latest code, but that could just be me ^^.
If people want this or even if it reduces the churn when discussing to move boards of the master branch I'm fine with it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63754
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fe1c508e97b52a6b70b33107c6e17cc7d7faeb2
Gerrit-Change-Number: 63754
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <martinroth(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <martinroth(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 23 Apr 2022 06:14:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Martin L Roth, Paul Menzel, Christian Walter, Maximilian Brune, Krystian Hebel.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63639 )
Change subject: Add SBOM (Software Bill of Materials) Generation
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS2:
> Isn't all the information already reflected by the version info + config?
Not all the information. For instance not the version of blobs.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63639
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb7481d4903f95d200eddbfed7728fbec51819d0
Gerrit-Change-Number: 63639
Gerrit-PatchSet: 6
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Christian Walter <christian.walter(a)9elements.com>
Gerrit-CC: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Comment-Date: Sat, 23 Apr 2022 06:06:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner, Felix Held.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63754 )
Change subject: RFC: Kconfig - show boards supported on 4.11 branch (POC)
......................................................................
Patch Set 2:
(2 comments)
File Makefile:
https://review.coreboot.org/c/coreboot/+/63754/comment/abb67e2a_d0531238
PS2, Line 183: ifeq ($(CONFIG_MAINBOARD_SUPPORTED_ON_BRANCH),y)
> nit: I feel like this would better fit in Makefile.inc, with the other Git stuff (e.g. […]
It really needs to go at this spot, otherwise toolchaain.inc will fail the make because there's no architecture declared for any of the stages.
It could go directly into toolchain.inc if you'd prefer.
File src/mainboard/adi/Kconfig:
PS2:
> Can we stuff these vendors that have only branch mainboards in some separate directory (e.g. […]
Unfortunately, we can't if we want to keep the list in alphabetical order. The Kconfig source command just reads the Kconfig files from the filesystem in alphabetical order. I agree with you, I don't like creating the directories this way.
What if we added a suffix to the newly created mainboard directories to at least indicate ones that don't contain any actual boards?
So this file would be src/mainboard/adi__/Kconfig.
It's not a great solution, but it's something.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63754
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fe1c508e97b52a6b70b33107c6e17cc7d7faeb2
Gerrit-Change-Number: 63754
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <martinroth(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 23 Apr 2022 03:29:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Kangheui Won, Tim Wawrzynczak, Reka Norman, Ivy Jian.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63774 )
Change subject: lib/spd: Change log prefix for ddr4 params
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This log actually added by myself when I refactor this file. And since we can boot with LPDDR5 so is't not an error. If someone can guarantee LPDDR5 is total compatible to DDR4 parameter. I am fine with the change. But now, no document can prove this point.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63774
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55f0968b78baaa2fc9a6bbebf6712fb8bfd349f6
Gerrit-Change-Number: 63774
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Sat, 23 Apr 2022 02:49:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Felix Held.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63791 )
Change subject: include/device/i2c_simple: add i2c_read_eeprom_bytes function
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
No objections but I feel that the name `eeprom` is a bit overly specific here. All this is is a version of read_bytes() that uses a 16-bit register address. Can we find a more systematic name for that? Maybe i2c_readw_bytes() or i2c_read16_bytes()?
--
To view, visit https://review.coreboot.org/c/coreboot/+/63791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I224e434bb2654aabef6302c1525112e44c4b21fa
Gerrit-Change-Number: 63791
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 23 Apr 2022 00:39:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment