coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: Documentation: Add mdl style file
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Felix Singer, Patrick Georgi, Angel Pons. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63805 ) Change subject: Documentation: Add mdl style file ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This is a tool I found when I was trying to figure out why some of my tables were broken. It actually didn't catch that, but did seem like a useful tool overall. Let me know what you think. I can probably add it to the checkpatch build to add comments if it seems useful. -- To view, visit https://review.coreboot.org/c/coreboot/+/63805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98289492ae3e920d440f0e5c308a3590fb89d9fd Gerrit-Change-Number: 63805 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 24 Apr 2022 17:24:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Rename infrastructure section
by Felix Singer (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Paul Menzel. Hello build bot (Jenkins), Martin L Roth, Thomas Heijligen, Paul Menzel, Angel Pons, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62441 to look at the new patch set (#14). Change subject: Documentation: Rename infrastructure section ...................................................................... Documentation: Rename infrastructure section In preparation for CB:62442, rename the section for infrastructure related things to "Project infrastructure & services". Change-Id: I1ba8a2e2070a79d8c9e955133203f9bb9f58cb8e Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/index.md M Documentation/infrastructure/index.md 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/62441/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/62441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ba8a2e2070a79d8c9e955133203f9bb9f58cb8e Gerrit-Change-Number: 62441 Gerrit-PatchSet: 14 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Documentation/releases: Deprecate Intel Quark SoC
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Felix Singer, Paul Menzel, Angel Pons. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63283 ) Change subject: Documentation/releases: Deprecate Intel Quark SoC ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63283/comment/e4598bb4_75f0a4a1 PS1, Line 9: Intel Quark SoC is unmaintained for a long time now. Thus, deprecate it. > Done https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot. […] This has been discussed extensively on both the mailing list and in a couple of leadership meetings, but I don't think we have a firm decision about it yet. It was decided though, that being unmaintained is not a reason in itself for being removed from the master branch. The below is a statement of the existing discussions, and ***is not advocating for removal.*** Though I'm not sure, It sounds like there may still be a reason for removal, because of issues in the code required by the Quark. The Quark platforms are going to be tested shortly to see if they still work. If they don't work anymore, and nobody steps up to do the work, that could be another reason to remove the platforms from the master branch. On the other side, having a good diversity of platforms in coreboot is good for the project. Additionally, the FSP for Quark is open source, so it's likely that the platform can be used with little if any proprietary blobs. -- To view, visit https://review.coreboot.org/c/coreboot/+/63283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e437d363c90c5155d6723a4377dc6052e80ebe7 Gerrit-Change-Number: 63283 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 24 Apr 2022 17:18:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Update document about jenkins builders
by Felix Singer (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Martin L Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62439 ) Change subject: Documentation: Update document about jenkins builders ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa094a6d0450da4ab58e23d7b56e65e6101ee931 Gerrit-Change-Number: 62439 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <martinroth(a)google.com> Gerrit-Comment-Date: Sun, 24 Apr 2022 17:14:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Rename infrastructure section
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Paul Menzel. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62441 ) Change subject: Documentation: Rename infrastructure section ...................................................................... Patch Set 13: Code-Review+2 (2 comments) Patchset: PS13: Please update Michael's comment in the commit message, then I believe this is ready to go. File Documentation/infrastructure/index.md: https://review.coreboot.org/c/coreboot/+/62441/comment/10652c4f_ff41b511 PS12, Line 3: This section contains documentation about our infrastructure > What's about services here? That's in the following commit. -- To view, visit https://review.coreboot.org/c/coreboot/+/62441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ba8a2e2070a79d8c9e955133203f9bb9f58cb8e Gerrit-Change-Number: 62441 Gerrit-PatchSet: 13 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 24 Apr 2022 17:06:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Move services page to infrastructure section
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Felix Singer, Paul Menzel. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62442 ) Change subject: Documentation: Move services page to infrastructure section ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ca2aba8ae817cf874367fa17e567065aec99a93 Gerrit-Change-Number: 62442 Gerrit-PatchSet: 14 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 24 Apr 2022 17:04:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Add mdl style file
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63805 ) Change subject: Documentation: Add mdl style file ...................................................................... Documentation: Add mdl style file This adds a style file for the markdown linter mdl. The tool can be found on archive.org at the URL: https://web.archive.org/web/20220407032312/https://github.com/markdownlint/… This does 2 things: - Sets that line length limit to 72 characters as requested in the docs about writing the documentation. - Excludes several rules that were added for a particular markdown parser. My opinion is that these rules make the text versions of the markdown harder to read. To use this style file, run: $ mdl -s Documentation/.mdl_style.rb Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I98289492ae3e920d440f0e5c308a3590fb89d9fd --- A Documentation/.mdl_style.rb 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/63805/1 diff --git a/Documentation/.mdl_style.rb b/Documentation/.mdl_style.rb new file mode 100644 index 0000000..a02a64c --- /dev/null +++ b/Documentation/.mdl_style.rb @@ -0,0 +1,9 @@ +# See one of the following URLs for explanations of all the rules +# https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md +# https://web.archive.org/web/20220424164542/https://github.com/markdownlint/… + +all +exclude_rule 'no-multiple-blanks' +exclude_rule 'blanks-around-headers' +exclude_rule 'blanks-around-lists' +rule 'line-length', :line_length => 72 -- To view, visit https://review.coreboot.org/c/coreboot/+/63805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98289492ae3e920d440f0e5c308a3590fb89d9fd Gerrit-Change-Number: 63805 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Documentation/infra/builders.md: Fix markdown inssues
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63804 ) Change subject: Documentation/infra/builders.md: Fix markdown inssues ...................................................................... Documentation/infra/builders.md: Fix markdown inssues This fixes the following issues found by the markdown lint tool, mdl: MD014 Dollar signs used before commands without showing output MD026 Trailing punctuation in header MD030 Spaces after list markers MD031 Fenced code blocks should be surrounded by blank lines MD040 Fenced code blocks should have a language specified Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I82317f51c003b2c23d64c3cbbcecbf9a39d5d509 --- M Documentation/infrastructure/builders.md 1 file changed, 58 insertions(+), 57 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/63804/1 diff --git a/Documentation/infrastructure/builders.md b/Documentation/infrastructure/builders.md index 0c3e99c..eeb48f4 100644 --- a/Documentation/infrastructure/builders.md +++ b/Documentation/infrastructure/builders.md @@ -45,21 +45,21 @@ These times are taken from the week of Feb 21 - Feb 28, 2022 -* Congenialbuilder - 128 threads, 256GiB RAM - * Fastest Passing coreboot gerrit build: 6 min, 47 sec - * Slowest Passing coreboot gerrit build: 14 min +*Congenialbuilder - 128 threads, 256GiB RAM + Fastest Passing coreboot gerrit build: 6 min, 47 sec + Slowest Passing coreboot gerrit build: 14 min -* Gleefulbuilder - 64 thread, 64GiB RAM - * Fastest Passing coreboot gerrit build: 10 min - * Slowest Passing coreboot gerrit build: 46 min + Gleefulbuilder - 64 thread, 64GiB RAM + Fastest Passing coreboot gerrit build: 10 min + Slowest Passing coreboot gerrit build: 46 min -* Fabulousbuilder - 64 threads, 64GiB RAM - * Fastest Passing coreboot gerrit build: 7 min, 56 sec - * Slowest Passing coreboot gerrit build: 56 min (No ccache) +*Fabulousbuilder - 64 threads, 64GiB RAM + Fastest Passing coreboot gerrit build: 7 min, 56 sec + Slowest Passing coreboot gerrit build: 56 min (No ccache) -* Ultron (9elements) - 48 threads, 128GiB RAM - * Fastest Passing coreboot gerrit build: 12 - * Slowest Passing coreboot gerrit build: 58 min +*Ultron (9elements) - 48 threads, 128GiB RAM + Fastest Passing coreboot gerrit build: 12 + Slowest Passing coreboot gerrit build: 58 min ### Jenkins Builds @@ -75,11 +75,11 @@ Most of the time on the builders is taken up by the coreboot master and coreboot gerrit builds. -* [coreboot gerrit build](https://qa.coreboot.org/job/coreboot-gerrit/) +*[coreboot gerrit build](https://qa.coreboot.org/job/coreboot-gerrit/) ([Time trend](https://qa.coreboot.org/job/coreboot-gerrit/buildTimeTrend)) -* [coreboot master build](https://qa.coreboot.org/job/coreboot/) +*[coreboot master build](https://qa.coreboot.org/job/coreboot/) ([Time trend](https://qa.coreboot.org/job/coreboot/buildTimeTrend)) @@ -91,8 +91,8 @@ On a system with 32 cores, it was tested with this command: -``` -$ stress-ng --cpu 20 --io 6 --vm 6 --vm-bytes 1G --verify --metrics-brief -t 60m +```sh +stress-ng --cpu 20 --io 6 --vm 6 --vm-bytes 1G --verify --metrics-brief -t 60m ``` You can watch the temperature with the sensors package or with ‘acpi -t’ @@ -102,8 +102,8 @@ if the values go down on any of the cores after it's been running for a while. -``` -$ while [ true ]; do clear; cat /proc/cpuinfo | grep 'cpu MHz' ; sleep 1; done +```sh +while [ true ]; do clear; cat /proc/cpuinfo | grep 'cpu MHz' ; sleep 1; done ``` If the machine throttles or resets, you probably need to upgrade the @@ -142,7 +142,7 @@ As a regular user - *Not root*, run: -``` +```sh sudo mkdir -p ${COREBOOT_JENKINS_CACHE_DIR} sudo mkdir -p ${COREBOOT_JENKINS_CCACHE_DIR} sudo chown $(whoami):$(whoami) ${COREBOOT_JENKINS_CCACHE_DIR} @@ -158,7 +158,7 @@ your shell's .rc file. Note that you only need to set them if you're using something other than the default. -``` +```sh # Set the port used on your machine to connect to jenkins. export COREBOOT_JENKINS_PORT=49151 @@ -180,13 +180,13 @@ From the coreboot directory, run -``` +```sh make -C util/docker help ``` This will show you the available targets and variables needed: -``` +```text Commands for working with docker images: coreboot-sdk - Build coreboot-sdk container upload-coreboot-sdk - Upload coreboot-sdk to hub.docker.com @@ -221,7 +221,7 @@ ### Install the coreboot jenkins builder -``` +```sh make -C util/docker docker-jenkins-server ``` @@ -252,11 +252,12 @@ ### How to log in to the docker instance for debugging -``` - $ make -C util/docker docker-jenkins-attach - $ su coreboot - $ cd ~/slave-root/workspace - $ bash + +```sh +make -C util/docker docker-jenkins-attach +su coreboot +cd ~/slave-root/workspace +bash ``` @@ -273,18 +274,18 @@ To delete the old containers & images: -``` -$ docker stop $COREBOOT_JENKINS_CONTAINER -$ docker rm $COREBOOT_JENKINS_CONTAINER -$ docker images # lists all existing images -$ docker rmi XXXX # Use the image ID found in the above command. +```sh +docker stop $COREBOOT_JENKINS_CONTAINER +docker rm $COREBOOT_JENKINS_CONTAINER +docker images # lists all existing images +docker rmi XXXX # Use the image ID found in the above command. ``` To get and run the new coreboot-jenkins image, change the value in the `DOCKER_COMMIT` variable to the new image value. -``` -$ make -C util/docker docker-jenkins-server +```sh +make -C util/docker docker-jenkins-server ``` #### Getting ready to push the docker images @@ -298,15 +299,15 @@ Make sure your credentials are configured on your host machine by running -``` -$ docker login +```sh +docker login ``` This will prompt you for your docker username, password, and your email address, and write out to ~/.docker/config.json. Without this file, you won’t be able to push the images. -#### Updating the Dockerfiles: +#### Updating the Dockerfiles The coreboot-sdk Dockerfile will need to be updated when any additional dependencies are added. Both the coreboot-sdk and the @@ -317,15 +318,15 @@ Read the [dockerfile best practices](https://docs.docker.com/v1.8/articles/dockerfile_best-practices/) page before updating the files. -#### Rebuilding the coreboot-sdk docker image to update the toolchain: +#### Rebuilding the coreboot-sdk docker image to update the toolchain -``` -$ make -C util/docker coreboot-sdk +```sh +make -C util/docker coreboot-sdk ``` This takes a relatively long time. -#### Test the coreboot-sdk docker image: +#### Test the coreboot-sdk docker image There are two methods of running the docker image - interactively as a shell, or doing the build directly. Running interactively as a shell is @@ -333,44 +334,44 @@ (without any changes getting saved) and re-test builds. This saves the time of having to rebuild the image for every issue you find. -#### Running the docker image interactively: +#### Running the docker image interactively Run: -``` -$ make -C util/docker docker-jenkins-server -$ make -C util/docker docker-jenkins-attach +```sh +make -C util/docker docker-jenkins-server +make -C util/docker docker-jenkins-attach ``` -#### Running the build directly: +#### Running the build directly From the coreboot directory: -``` -$ make -C util/docker docker-build-coreboot +```sh +make -C util/docker docker-build-coreboot ``` You’ll also want to test building the other projects and payloads: ChromeEC, flashrom, memtest86+, em100, Grub2, SeaBIOS, iPXE, coreinfo, nvramcui, tint... -#### Pushing the coreboot-sdk image to hub.docker.com for use: +#### Pushing the coreboot-sdk image to hub.docker.com for use When you’re satisfied with the testing, push the coreboot-sdk image to the hub.docker.com -``` -$ make -C util/docker upload-coreboot-sdk +```sh +make -C util/docker upload-coreboot-sdk ``` -#### Building and pushing the coreboot-jenkins-node docker image: +#### Building and pushing the coreboot-jenkins-node docker image This docker image is pretty simple, so there’s not really any testing that needs to be done. -``` -$ make -C util/docker coreboot-jenkins-node -$ make -C util/docker upload-coreboot-jenkins-node +```sh +make -C util/docker coreboot-jenkins-node +make -C util/docker upload-coreboot-jenkins-node ``` ### Coverity Setup @@ -391,7 +392,7 @@ (cov-analysis-linux64-7.7.0.4) to ‘coverity’, or better, create a symlink: -``` +```sh ln -s cov-analysis-linux64-7.7.0.4 coverity ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/63804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82317f51c003b2c23d64c3cbbcecbf9a39d5d509 Gerrit-Change-Number: 63804 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Documentation: Update document about jenkins builders
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Martin L Roth. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62439 to look at the new patch set (#3). Change subject: Documentation: Update document about jenkins builders ...................................................................... Documentation: Update document about jenkins builders Although we're looking at updating the build system, we don't have a strict timeframe that this will happen. Until it does, we'll be using the current Jenkins configuration. This commit give some minor updates to the instructions and current state of the builders. Signed-off-by: Martin Roth <martin(a)coreboot.org> Change-Id: Ifa094a6d0450da4ab58e23d7b56e65e6101ee931 --- M Documentation/infrastructure/builders.md 1 file changed, 51 insertions(+), 43 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/62439/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa094a6d0450da4ab58e23d7b56e65e6101ee931 Gerrit-Change-Number: 62439 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <martinroth(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/kontron/986lcd-m: Add Firewire chip in device tree
by Arthur Heymans (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Petr Cvek. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63801 ) Change subject: mb/kontron/986lcd-m: Add Firewire chip in device tree ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa702b1efc15818ade2b1cd15aa6d415c3850e4b Gerrit-Change-Number: 63801 Gerrit-PatchSet: 1 Gerrit-Owner: Petr Cvek <petrcvekcz(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Petr Cvek <petrcvekcz(a)gmail.com> Gerrit-Comment-Date: Sun, 24 Apr 2022 16:08:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022