coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: mainboard/intel: Remove unused <acpi/acpi.h>
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60624 ) Change subject: mainboard/intel: Remove unused <acpi/acpi.h> ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I591062541ea9ad51aef2dfaf902a4b5f1a5bd8e0 Gerrit-Change-Number: 60624 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 24 Apr 2022 17:36:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/qualcomm: Remove unused <timer.h>
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60611 ) Change subject: soc/qualcomm: Remove unused <timer.h> ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60611 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc08ea20263623159c78b634d34899ac7da0d3c6 Gerrit-Change-Number: 60611 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 24 Apr 2022 17:35:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard/google: Remove unused <boardid.h>
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Paul Menzel, Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60748 ) Change subject: mainboard/google: Remove unused <boardid.h> ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2611be41e8730a9b189b1b0aa3fe62be0757b371 Gerrit-Change-Number: 60748 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 24 Apr 2022 17:32:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers: Remove unused <acpi/acpi.h>
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Lee Leahy, Huang Jin, Patrick Rudolph, Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60632 ) Change subject: drivers: Remove unused <acpi/acpi.h> ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic890dc7c0ed02891d3144210016cd96f01c344d5 Gerrit-Change-Number: 60632 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Huang Jin Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Attention: Huang Jin Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 24 Apr 2022 17:31:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Update document about jenkins builders
by Felix Singer (Code Review) 24 Apr '22

24 Apr '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62439 ) Change subject: Documentation: Update document about jenkins builders ...................................................................... Documentation: Update document about jenkins builders Although we're looking at updating the build system, we don't have a strict timeframe that this will happen. Until it does, we'll be using the current Jenkins configuration. This commit give some minor updates to the instructions and current state of the builders. Signed-off-by: Martin Roth <martin(a)coreboot.org> Change-Id: Ifa094a6d0450da4ab58e23d7b56e65e6101ee931 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62439 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/infrastructure/builders.md 1 file changed, 51 insertions(+), 43 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/Documentation/infrastructure/builders.md b/Documentation/infrastructure/builders.md index 77d7525..0c3e99c 100644 --- a/Documentation/infrastructure/builders.md +++ b/Documentation/infrastructure/builders.md @@ -8,8 +8,8 @@ build system. For a permanent build system, this should generally be a dedicated -machine that is not generally being used for other purposes. The -coreboot builds are very intensive. +machine workstation or server class machine that is not generally being +used for other purposes. The coreboot builds are very intensive. It's also best to be aware that although we don't know of any security issues, the jenkins-node image is run with the privileged flag which @@ -26,34 +26,40 @@ * Patrick Georgi: * Email: [patrick@georgi-clan.de](mailto:patrick@georgi-clan.de) * IRC: pgeorgi - +* Martin Roth: + * Email: [gaumless@gmail.com](mailto:gaumless@gmail.com) + * IRC: martinr ### Build Machine requirements -For a builder, we need a fast system with lots of threads and plenty of -RAM. The builder builds and stores the git repos and output in tmpfs -along with the ccache save area, so if there isn't enough memory, the -builds will slow down because of smaller ccache areas and can run into -"out of storage space" errors. +For a builder, we need a very fast system with lots of threads and +plenty of RAM. The builder builds and stores the git repos and output +in tmpfs along with the ccache save area, so if there isn't enough +memory, the builds will slow down because of smaller ccache areas and +can run into "out of storage space" errors. #### Current Build Machines To give an idea of what a suitable build machine might be, currently the -coreboot project has 3 active jenkins build machines. +coreboot project has 4 active jenkins build machines. + +These times are taken from the week of Feb 21 - Feb 28, 2022 * Congenialbuilder - 128 threads, 256GiB RAM - * Fastest Passing coreboot gerrit build: 4 min, 30 sec - * Slowest Passing coreboot gerrit build: 9 min, 56 sec + * Fastest Passing coreboot gerrit build: 6 min, 47 sec + * Slowest Passing coreboot gerrit build: 14 min +* Gleefulbuilder - 64 thread, 64GiB RAM + * Fastest Passing coreboot gerrit build: 10 min + * Slowest Passing coreboot gerrit build: 46 min -* Gleeful builder - 64 thread, 64GiB RAM - * Fastest Passing coreboot gerrit build: 6 min, 6 sec - * Slowest Passing coreboot gerrit build, 34 min - +* Fabulousbuilder - 64 threads, 64GiB RAM + * Fastest Passing coreboot gerrit build: 7 min, 56 sec + * Slowest Passing coreboot gerrit build: 56 min (No ccache) * Ultron (9elements) - 48 threads, 128GiB RAM - * Fastest Passing coreboot gerrit build: 6 min, 32 sec - * Slowest Passing coreboot gerrit build: 44 min + * Fastest Passing coreboot gerrit build: 12 + * Slowest Passing coreboot gerrit build: 58 min ### Jenkins Builds @@ -67,7 +73,7 @@ [https://qa.coreboot.org/](https://qa.coreboot.org/) Most of the time on the builders is taken up by the coreboot master and -gerrit builds. +coreboot gerrit builds. * [coreboot gerrit build](https://qa.coreboot.org/job/coreboot-gerrit/) ([Time trend](https://qa.coreboot.org/job/coreboot-gerrit/buildTimeTrend)) @@ -127,10 +133,23 @@ ### Install and set up docker -Install docker by following the -[directions](https://docs.docker.com/engine/install/) on the docker -site. These instructions keep changing, so just check the latest -information. +Install docker by following [the +directions](https://docs.docker.com/engine/install/) on the docker site. +These instructions keep changing, so just check the latest information. + + +### Set up the system for the jenkins builder + +As a regular user - *Not root*, run: + +``` +sudo mkdir -p ${COREBOOT_JENKINS_CACHE_DIR} +sudo mkdir -p ${COREBOOT_JENKINS_CCACHE_DIR} +sudo chown $(whoami):$(whoami) ${COREBOOT_JENKINS_CCACHE_DIR} +sudo chown $(whoami):$(whoami) ${COREBOOT_JENKINS_CACHE_DIR} +wget http://www.dediprog.com/save/78.rar/to/EM100Pro.rar +mv EM100Pro.rar ${COREBOOT_JENKINS_CACHE_DIR} +``` #### Set up environment variables @@ -143,8 +162,8 @@ # Set the port used on your machine to connect to jenkins. export COREBOOT_JENKINS_PORT=49151 -# Set the revision of the container from docker hub -export DOCKER_COMMIT=65718760fa +# Set the revision of the container from [docker hub](https://hub.docker.com/repository/docker/coreboot/coreboot-sdk) +export DOCKER_COMMIT=2021-09-23_b0d87f753c # Set the location of where the jenkins cache directory will be. export COREBOOT_JENKINS_CACHE_DIR="/srv/docker/coreboot-builder/cache" @@ -199,18 +218,6 @@ DOCKER_COMMIT=65718760fa ``` -### Set up the system for the jenkins builder - -As a regular user - *Not root*, run: - -``` -sudo mkdir -p ${COREBOOT_JENKINS_CACHE_DIR} -sudo mkdir -p ${COREBOOT_JENKINS_CCACHE_DIR} -sudo chown $(whoami):$(whoami) ${COREBOOT_JENKINS_CCACHE_DIR} -sudo chown $(whoami):$(whoami) ${COREBOOT_JENKINS_CACHE_DIR} -wget http://www.dediprog.com/save/78.rar/to/EM100Pro.rar -mv EM100Pro.rar ${COREBOOT_JENKINS_CACHE_DIR} -``` ### Install the coreboot jenkins builder @@ -226,17 +233,17 @@ They need to know: * Your external IP address or domain name. If you don’t have a static -IP, make sure you have a dynamic dns hostname configured. + IP, make sure you have a dynamic dns hostname configured. * The port on your machine and firewall that’s exposed for jenkins: -`$COREBOOT_JENKINS_PORT` + `$COREBOOT_JENKINS_PORT` * The core count of the machine. * How much memory is available on the machine. This helps determine -the amount of memory used for ccache. + the amount of memory used for ccache. ### First build On the first build after a machine is reset, it will frequently take -20-25 minutes to do the entire what-jenkins-does build while the ccache +an hour to do the entire what-jenkins-does build while the ccache is getting filled up and the entire coreboot repo gets downloaded. As the ccache gets populated, the build time will drop. @@ -254,12 +261,12 @@ WARNING: This should not be used to make changes to the build system, -but just to debug issues. Changes to the build system are highly +but just to debug issues. Changes to the build system image are highly discouraged as it leads to situations where patches can pass the build testing on one builder and fail on another builder. Any changes that are made in the image will be lost on the next update, so if you -accidentally change something, you can remove the containers and images -and update to get a fresh installation. +accidentally change something, you can remove the containers and images, +then update to get a fresh installation. ### How to download containers/images for a fresh installation and remove old containers @@ -376,6 +383,7 @@ Download the Linux-64 coverity build tool and decompress it into your cache directory as defined by the `$COREBOOT_JENKINS_CACHE_DIR` variable +on the jenkins server. [https://scan.coverity.com/download](https://scan.coverity.com/download) -- To view, visit https://review.coreboot.org/c/coreboot/+/62439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa094a6d0450da4ab58e23d7b56e65e6101ee931 Gerrit-Change-Number: 62439 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: Documentation: Update document about jenkins builders
by Felix Singer (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Martin L Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62439 ) Change subject: Documentation: Update document about jenkins builders ...................................................................... Patch Set 3: (2 comments) File Documentation/infrastructure/builders.md: https://review.coreboot.org/c/coreboot/+/62439/comment/e32756db_f34a3e6f PS2, Line 268: images > Missing comma? Done https://review.coreboot.org/c/coreboot/+/62439/comment/a79349e9_08b8c0a3 PS2, Line 386: on the jenkins server > Missing dot at the end. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa094a6d0450da4ab58e23d7b56e65e6101ee931 Gerrit-Change-Number: 62439 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <martinroth(a)google.com> Gerrit-Comment-Date: Sun, 24 Apr 2022 17:30:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel: Remove unused <acpi/acpi.h>
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Patrick Rudolph, Elyes Haouas, Tim Chu. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60631 ) Change subject: soc/intel: Remove unused <acpi/acpi.h> ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc5d5883d9ec6ee55797bd36178af622d08e4f9b Gerrit-Change-Number: 60631 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Sun, 24 Apr 2022 17:30:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib/edid_fill_fb.c: Remove unused <bootsplash.h>
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61057 ) Change subject: lib/edid_fill_fb.c: Remove unused <bootsplash.h> ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fb22ff647f824872dc35648bb4b5078f0cbde96 Gerrit-Change-Number: 61057 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 24 Apr 2022 17:27:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib: Remove unused <stdlib.h> and use <types.h> when appropriate
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Julius Werner, Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60621 ) Change subject: lib: Remove unused <stdlib.h> and use <types.h> when appropriate ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60621 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ad171679cbfa67d522bd1105fb58e0f84b9cb89 Gerrit-Change-Number: 60621 Gerrit-PatchSet: 13 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 24 Apr 2022 17:27:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Rename infrastructure section
by Felix Singer (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Martin L Roth, Thomas Heijligen, Paul Menzel, Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62441 ) Change subject: Documentation: Rename infrastructure section ...................................................................... Patch Set 14: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62441/comment/e77b6945_7d7742da PS13, Line 9: to > for Done Patchset: PS13: > Please update Michael's comment in the commit message, then I believe this is ready to go. oops, sorry. I missed that. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ba8a2e2070a79d8c9e955133203f9bb9f58cb8e Gerrit-Change-Number: 62441 Gerrit-PatchSet: 14 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <martinroth(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Sun, 24 Apr 2022 17:24:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <martinroth(a)google.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022