coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: mb/kontron/986lcd-m: Improve device tree description
by Arthur Heymans (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Petr Cvek. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63800 ) Change subject: mb/kontron/986lcd-m: Improve device tree description ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I479f41d71342104e74f862cf37b967963bc54877 Gerrit-Change-Number: 63800 Gerrit-PatchSet: 1 Gerrit-Owner: Petr Cvek <petrcvekcz(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Petr Cvek <petrcvekcz(a)gmail.com> Gerrit-Comment-Date: Sun, 24 Apr 2022 16:08:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Update opensbi submodule to upstream master
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/60823 ) Change subject: Update opensbi submodule to upstream master ...................................................................... Abandoned out of date -- To view, visit https://review.coreboot.org/c/coreboot/+/60823 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e7d7f465407a3a8dd4e431db82bc755fd41b017 Gerrit-Change-Number: 60823 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Update blobs submodule to upstream master
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/60819 ) Change subject: Update blobs submodule to upstream master ...................................................................... Abandoned out of date -- To view, visit https://review.coreboot.org/c/coreboot/+/60819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieff9a5d9ba5ad9abcb9eb3e8117995235ffab1e9 Gerrit-Change-Number: 60819 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Update chromeec submodule to upstream master
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/60827 ) Change subject: Update chromeec submodule to upstream master ...................................................................... Abandoned out of date. -- To view, visit https://review.coreboot.org/c/coreboot/+/60827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia84ed1da618e649b4546b033b55159f6f2d5b8a4 Gerrit-Change-Number: 60827 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mb/kontron/986lcd-m: Add Firewire chip in device tree
by Elyes Haouas (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Petr Cvek. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63801 ) Change subject: mb/kontron/986lcd-m: Add Firewire chip in device tree ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa702b1efc15818ade2b1cd15aa6d415c3850e4b Gerrit-Change-Number: 63801 Gerrit-PatchSet: 1 Gerrit-Owner: Petr Cvek <petrcvekcz(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Petr Cvek <petrcvekcz(a)gmail.com> Gerrit-Comment-Date: Sun, 24 Apr 2022 09:02:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/kontron/986lcd-m: Improve device tree description
by Elyes Haouas (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Petr Cvek. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63800 ) Change subject: mb/kontron/986lcd-m: Improve device tree description ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I479f41d71342104e74f862cf37b967963bc54877 Gerrit-Change-Number: 63800 Gerrit-PatchSet: 1 Gerrit-Owner: Petr Cvek <petrcvekcz(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Petr Cvek <petrcvekcz(a)gmail.com> Gerrit-Comment-Date: Sun, 24 Apr 2022 09:02:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: include/device/i2c_simple: add i2c_read_eeprom_bytes function
by Felix Held (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Raul Rangel, Julius Werner. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63791 ) Change subject: include/device/i2c_simple: add i2c_read_eeprom_bytes function ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > No objections but I feel that the name `eeprom` is a bit overly specific here. […] yes, the name is probably overly specific, but i didn't have a much better name. most i2c devices will only use a 1 byte index/offset and the only devices that use 2 byte index/offset that i could think of were the eeproms, but there are likely other i2c devices that use 2 bytes of index/offset. from the name i2c_read16_bytes i'd expect that it does 16 bit reads, so at least for me that makes things a bit more confusing. what do you think about i2c_1ba_read and i2c_2ba_read as function names? maybe with some comment that has the acronym expanded to 1/2 byte address -- To view, visit https://review.coreboot.org/c/coreboot/+/63791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I224e434bb2654aabef6302c1525112e44c4b21fa Gerrit-Change-Number: 63791 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sat, 23 Apr 2022 22:13:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/scripts: Add script to show platforms, CPU, type, and date added
by Martin L Roth (Code Review) 23 Apr '22

23 Apr '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63799 ) Change subject: util/scripts: Add script to show platforms, CPU, type, and date added ...................................................................... util/scripts: Add script to show platforms, CPU, type, and date added This is the script used to generate the list of platforms that were removed from the master branch at each release. Generate a list for the old branch, another for the new, and compare the two. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I4f7265d95df31f3a74aa2aa164f6a094c1139750 --- M util/scripts/description.md A util/scripts/show_platforms.sh 2 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/63799/1 diff --git a/util/scripts/description.md b/util/scripts/description.md index a08771d..7c996f5 100644 --- a/util/scripts/description.md +++ b/util/scripts/description.md @@ -23,5 +23,8 @@ headers `Shell` * _parse-maintainers.pl_ - Script to alphabetize MAINTAINERS file `Perl` + * _show_platforms.sh_ - Makes a list of platforms in the tree. Does + not show variants. + `Shell` * _ucode_h_to_bin.sh_ - Microcode conversion tool `Bash` * _update_submodules_ - Check all submodules for updates `Bash` diff --git a/util/scripts/show_platforms.sh b/util/scripts/show_platforms.sh new file mode 100755 index 0000000..e8f0fae --- /dev/null +++ b/util/scripts/show_platforms.sh @@ -0,0 +1,40 @@ +#!/bin/bash +# +# SPDX-License-Identifier: GPL-2.0-only +# +# This script finds all of the top-level mainboards, then goes through +# and finds the date the directory was added, the processor type, and +# the board type. +# +# This could be improved by finding all of the variants, then figuring +# out when those veriants were added. + +platforms="$(find src/mainboard -name 'Kconfig' | + grep -v '\./Kconfig\|\./[^/]\+/Kconfig' | + sed 's|^\./||' | + sort)" + +echo "| Vendor/Board | Processor | Date added | Brd type |" +echo "|-----------------------------|------------------------|------------|----------|" + + +for file in ${platforms}; do + platformname="$(echo "${file}" | sed 's|.*/mainboard/||' | sed 's|/Kconfig.*||')" + if [[ ! -f ${file/Kconfig/board_info.txt} ]]; then + continue + fi + chips=$(grep "CPU_\|SOC_\|NORTHBRIDGE" "${file}" | + grep -v "SUBTYPE\|COMMON\|SOCKET\|ENABLE\|CONSOLE\|SMU\|depends on\|ESPI\|INTEL_CSE\|NORTHBRIDGE_AMD_AGESA\|INTEL_SLOT\|REBOOT" | + sed 's|\s\+select\s\+||; s|\s\+if.*||; s|SKYLAKE_SOC_PCH|INTEL_SKYLAKE|; s|CPU_AMD_AGESA|AMD|; s|SOC_INTEL_ALDERLAKE_PCH_|INTEL_ALDERLAKE|; s|QC_|QUALCOMM_|; s/SOC_\|NORTHBRIDGE_\|PCH_\|CPU_//g' | + sort | uniq) + if [[ ! -f ${file/Kconfig/board_info.txt} ]]; then + continue + fi + create_date="$(git log --format="format:%cs" -- "${file}" | tail -n1)" + platform_type="$(grep "Category: " "${file/Kconfig/board_info.txt}" 2>/dev/null | sed 's/Category: //')" + for chip in ${chips}; do + + printf "| %-27s | %-22s | %-10s | %-8s |\n" "${platformname}" "${chip}" "${create_date}" "${platform_type}" + done + +done -- To view, visit https://review.coreboot.org/c/coreboot/+/63799 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f7265d95df31f3a74aa2aa164f6a094c1139750 Gerrit-Change-Number: 63799 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: lib/spd: Change log prefix for ddr4 params
by Eric Lai (Code Review) 23 Apr '22

23 Apr '22

Attention is currently required from: Kangheui Won, Tim Wawrzynczak, Reka Norman, Ivy Jian, Julius Werner. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63774 ) Change subject: lib/spd: Change log prefix for ddr4 params ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I agree with Tim, I'm not very familiar with this matter but it looks like you're taking the wrong a […] I must admit I wasn't think this properly in CB:39366 , I don't know it will cause trouble back then. Let me explain the thoughts of this section. Back to 2020 when I refactor this code, we don't have DDR5/LPDDR5 SPD spec and still now. I don't use die and ASSERT and trying to use DDR4 parameter for the future generation memory. Because if it doesn't work, the MRC training will ASSERT or die. So I don't have to use die or ASSERT here. Thus, I think the warning level is legit here. Can you guys accept my explanation? -- To view, visit https://review.coreboot.org/c/coreboot/+/63774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55f0968b78baaa2fc9a6bbebf6712fb8bfd349f6 Gerrit-Change-Number: 63774 Gerrit-PatchSet: 1 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sat, 23 Apr 2022 21:09:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Add list of boards maintained on each branch
by Martin L Roth (Code Review) 23 Apr '22

23 Apr '22

Attention is currently required from: Arthur Heymans. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63797 to look at the new patch set (#2). Change subject: Documentation: Add list of boards maintained on each branch ...................................................................... Documentation: Add list of boards maintained on each branch This documents the boards that have been removed from the master branch, and which branch to check out to build or work on them. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Iee25db13e2c1b0b9131fd2032a26ece45aba4f42 --- A Documentation/releases/boards_supported_on_branches.md 1 file changed, 321 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/63797/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee25db13e2c1b0b9131fd2032a26ece45aba4f42 Gerrit-Change-Number: 63797 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022