coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: nb/amd/{agesa,pi}: Clean up some math expressions
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55930 ) Change subject: nb/amd/{agesa,pi}: Clean up some math expressions ...................................................................... nb/amd/{agesa,pi}: Clean up some math expressions Change-Id: Id6a1a6123dc0e2afd04213ece13363eed29f92c0 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/55930 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-by: Martin L Roth <martinroth(a)google.com> --- M src/northbridge/amd/agesa/family14/northbridge.c M src/northbridge/amd/agesa/family15tn/northbridge.c M src/northbridge/amd/agesa/family16kb/northbridge.c M src/northbridge/amd/pi/00730F01/northbridge.c 4 files changed, 13 insertions(+), 13 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved Elyes Haouas: Looks good to me, approved diff --git a/src/northbridge/amd/agesa/family14/northbridge.c b/src/northbridge/amd/agesa/family14/northbridge.c index e102252..cf67d93 100644 --- a/src/northbridge/amd/agesa/family14/northbridge.c +++ b/src/northbridge/amd/agesa/family14/northbridge.c @@ -552,12 +552,12 @@ basek, limitk, sizek); /* See if we need a hole from 0xa0000 (640K) to 0xbffff (768K) */ - if ((basek < 640) && (sizek > 768)) { + if (basek < 640 && sizek > 768) { printk(BIOS_DEBUG,"adsr - 0xa0000 to 0xbffff resource.\n"); ram_resource(dev, (idx | 0), basek, 640 - basek); idx += 0x10; basek = 768; - sizek = limitk - 768; + sizek = limitk - basek; } printk(BIOS_DEBUG, diff --git a/src/northbridge/amd/agesa/family15tn/northbridge.c b/src/northbridge/amd/agesa/family15tn/northbridge.c index 8c010ee..046f875 100644 --- a/src/northbridge/amd/agesa/family15tn/northbridge.c +++ b/src/northbridge/amd/agesa/family15tn/northbridge.c @@ -710,11 +710,11 @@ sizek = limitk - basek; /* See if we need a hole from 0xa0000 (640K) to 0xbffff (768K) */ - if ((basek < ((8*64)+(8*16))) && (sizek > ((8*64)+(16*16)))) { - ram_resource(dev, (idx | i), basek, ((8*64)+(8*16)) - basek); + if (basek < 640 && sizek > 768) { + ram_resource(dev, (idx | i), basek, 640 - basek); idx += 0x10; - basek = (8*64)+(16*16); - sizek = limitk - ((8*64)+(16*16)); + basek = 768; + sizek = limitk - basek; } diff --git a/src/northbridge/amd/agesa/family16kb/northbridge.c b/src/northbridge/amd/agesa/family16kb/northbridge.c index a343321..0dc3d0b 100644 --- a/src/northbridge/amd/agesa/family16kb/northbridge.c +++ b/src/northbridge/amd/agesa/family16kb/northbridge.c @@ -722,11 +722,11 @@ sizek = limitk - basek; /* See if we need a hole from 0xa0000 (640K) to 0xbffff (768K) */ - if ((basek < ((8*64)+(8*16))) && (sizek > ((8*64)+(16*16)))) { - ram_resource(dev, (idx | i), basek, ((8*64)+(8*16)) - basek); + if (basek < 640 && sizek > 768) { + ram_resource(dev, (idx | i), basek, 640 - basek); idx += 0x10; - basek = (8*64)+(16*16); - sizek = limitk - ((8*64)+(16*16)); + basek = 768; + sizek = limitk - basek; } //printk(BIOS_DEBUG, "node %d : mmio_basek=%08lx, basek=%08llx, limitk=%08llx\n", i, mmio_basek, basek, limitk); diff --git a/src/northbridge/amd/pi/00730F01/northbridge.c b/src/northbridge/amd/pi/00730F01/northbridge.c index 9889275..52364a2 100644 --- a/src/northbridge/amd/pi/00730F01/northbridge.c +++ b/src/northbridge/amd/pi/00730F01/northbridge.c @@ -811,10 +811,10 @@ i, basek, limitk, sizek); /* See if we need a hole from 0xa0000 (640K) to 0xfffff (1024K) */ - if ((basek < (0xa0000 >> 10) && (sizek > (0x100000 >> 10)))) { - ram_resource(dev, (idx | i), basek, (0xa0000 >> 10) - basek); + if (basek < 640 && sizek > 1024) { + ram_resource(dev, (idx | i), basek, 640 - basek); idx += 0x10; - basek = 0x100000 >> 10; + basek = 1024; sizek = limitk - basek; } -- To view, visit https://review.coreboot.org/c/coreboot/+/55930 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6a1a6123dc0e2afd04213ece13363eed29f92c0 Gerrit-Change-Number: 55930 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: nb/amd/{agesa,pi}: Clean up some math expressions
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Kyösti Mälkki, Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55930 ) Change subject: nb/amd/{agesa,pi}: Clean up some math expressions ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55930 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6a1a6123dc0e2afd04213ece13363eed29f92c0 Gerrit-Change-Number: 55930 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 24 Apr 2022 21:35:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/amd/*/*/northbridge.c: Change the comment 'hole from 0xa0000..' to...
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62378 ) Change subject: nb/amd/*/*/northbridge.c: Change the comment 'hole from 0xa0000..' to reflect the code ...................................................................... nb/amd/*/*/northbridge.c: Change the comment 'hole from 0xa0000..' to reflect the code Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I4acc895be00cfdef3ff0eef440f4b85fdb75edf8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62378 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <martinroth(a)google.com> --- M src/northbridge/amd/agesa/family14/northbridge.c M src/northbridge/amd/agesa/family15tn/northbridge.c M src/northbridge/amd/agesa/family16kb/northbridge.c M src/northbridge/amd/pi/00730F01/northbridge.c 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/src/northbridge/amd/agesa/family14/northbridge.c b/src/northbridge/amd/agesa/family14/northbridge.c index 3507ff7..e102252 100644 --- a/src/northbridge/amd/agesa/family14/northbridge.c +++ b/src/northbridge/amd/agesa/family14/northbridge.c @@ -551,7 +551,7 @@ printk(BIOS_DEBUG, "adsr: basek = %llx, limitk = %llx, sizek = %llx.\n", basek, limitk, sizek); - /* see if we need a hole from 0xa0000 to 0xbffff */ + /* See if we need a hole from 0xa0000 (640K) to 0xbffff (768K) */ if ((basek < 640) && (sizek > 768)) { printk(BIOS_DEBUG,"adsr - 0xa0000 to 0xbffff resource.\n"); ram_resource(dev, (idx | 0), basek, 640 - basek); diff --git a/src/northbridge/amd/agesa/family15tn/northbridge.c b/src/northbridge/amd/agesa/family15tn/northbridge.c index d36c9d4..8c010ee 100644 --- a/src/northbridge/amd/agesa/family15tn/northbridge.c +++ b/src/northbridge/amd/agesa/family15tn/northbridge.c @@ -709,7 +709,7 @@ sizek = limitk - basek; - /* see if we need a hole from 0xa0000 to 0xbffff */ + /* See if we need a hole from 0xa0000 (640K) to 0xbffff (768K) */ if ((basek < ((8*64)+(8*16))) && (sizek > ((8*64)+(16*16)))) { ram_resource(dev, (idx | i), basek, ((8*64)+(8*16)) - basek); idx += 0x10; diff --git a/src/northbridge/amd/agesa/family16kb/northbridge.c b/src/northbridge/amd/agesa/family16kb/northbridge.c index 170a0d2..a343321 100644 --- a/src/northbridge/amd/agesa/family16kb/northbridge.c +++ b/src/northbridge/amd/agesa/family16kb/northbridge.c @@ -721,7 +721,7 @@ sizek = limitk - basek; - /* see if we need a hole from 0xa0000 to 0xbffff */ + /* See if we need a hole from 0xa0000 (640K) to 0xbffff (768K) */ if ((basek < ((8*64)+(8*16))) && (sizek > ((8*64)+(16*16)))) { ram_resource(dev, (idx | i), basek, ((8*64)+(8*16)) - basek); idx += 0x10; diff --git a/src/northbridge/amd/pi/00730F01/northbridge.c b/src/northbridge/amd/pi/00730F01/northbridge.c index 8a136b6..9889275 100644 --- a/src/northbridge/amd/pi/00730F01/northbridge.c +++ b/src/northbridge/amd/pi/00730F01/northbridge.c @@ -810,7 +810,7 @@ printk(BIOS_DEBUG, "node %d: basek=%08llx, limitk=%08llx, sizek=%08llx,\n", i, basek, limitk, sizek); - /* see if we need a hole from 0xa0000 to 0xfffff */ + /* See if we need a hole from 0xa0000 (640K) to 0xfffff (1024K) */ if ((basek < (0xa0000 >> 10) && (sizek > (0x100000 >> 10)))) { ram_resource(dev, (idx | i), basek, (0xa0000 >> 10) - basek); idx += 0x10; -- To view, visit https://review.coreboot.org/c/coreboot/+/62378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4acc895be00cfdef3ff0eef440f4b85fdb75edf8 Gerrit-Change-Number: 62378 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: nb/amd/*/*/northbridge.c: Change the comment 'hole from 0xa0000..' to...
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Michał Żygowski, Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62378 ) Change subject: nb/amd/*/*/northbridge.c: Change the comment 'hole from 0xa0000..' to reflect the code ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/northbridge/amd/agesa/family15tn/northbridge.c: https://review.coreboot.org/c/coreboot/+/62378/comment/903bb3ac_d4925153 PS1, Line 716: if ((basek < ((8*64)+(8*16))) && (sizek > ((8*64)+(16*16)))) { Wow, could this maybe be a bit less readable? :-/ -- To view, visit https://review.coreboot.org/c/coreboot/+/62378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4acc895be00cfdef3ff0eef440f4b85fdb75edf8 Gerrit-Change-Number: 62378 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 24 Apr 2022 21:34:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src: Drop unused Kconfig symbols
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Lance Zhao, Paul Menzel, Tim Wawrzynczak, Arthur Heymans, Patrick Rudolph, Elyes Haouas, Felix Held. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62362 ) Change subject: src: Drop unused Kconfig symbols ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: Sorry, this needs manual rebase. As always, thanks for all the work here. -- To view, visit https://review.coreboot.org/c/coreboot/+/62362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96380d4567356c81e17de469fd78cec2fcb7e5c9 Gerrit-Change-Number: 62362 Gerrit-PatchSet: 11 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Martin L Roth <martinroth(a)google.com> Gerrit-Attention: Lance Zhao Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 24 Apr 2022 21:28:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/purism/librem: Remove unused Kconfig file
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62363 ) Change subject: ec/purism/librem: Remove unused Kconfig file ...................................................................... ec/purism/librem: Remove unused Kconfig file Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I0d8dff53d98ae70b72d1850d18fd6408d3293356 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62363 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Martin L Roth <martinroth(a)google.com> --- D src/ec/purism/librem/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve diff --git a/src/ec/purism/librem/Kconfig b/src/ec/purism/librem/Kconfig deleted file mode 100644 index 0ea38c6..0000000 --- a/src/ec/purism/librem/Kconfig +++ /dev/null @@ -1,4 +0,0 @@ -config EC_PURISM_LIBREM - bool - help - Purism Librem EC -- To view, visit https://review.coreboot.org/c/coreboot/+/62363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d8dff53d98ae70b72d1850d18fd6408d3293356 Gerrit-Change-Number: 62363 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/purism/librem: Remove unused Kconfig file
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62363 ) Change subject: ec/purism/librem: Remove unused Kconfig file ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d8dff53d98ae70b72d1850d18fd6408d3293356 Gerrit-Change-Number: 62363 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 24 Apr 2022 21:26:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sb/intel/i82801ix/smihandler.c: Comment out dead increment
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Arthur Heymans, Patrick Rudolph, Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62541 ) Change subject: sb/intel/i82801ix/smihandler.c: Comment out dead increment ...................................................................... Patch Set 2: (1 comment) File src/southbridge/intel/i82801ix/smihandler.c: https://review.coreboot.org/c/coreboot/+/62541/comment/d4447b41_2a06179a PS2, Line 65: // data &= mask; : // if (smi1) : // southbridge_smi_command(data); : // return; Could we just remove all the commented out code instead? -- To view, visit https://review.coreboot.org/c/coreboot/+/62541 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifef67fc6415af1260d1a1df54f53fbe67f8860bb Gerrit-Change-Number: 62541 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 24 Apr 2022 21:24:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: {drivers,northbridge,security}: Remove unused <cpu/x86/lapic.h>
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61048 ) Change subject: {drivers,northbridge,security}: Remove unused <cpu/x86/lapic.h> ...................................................................... {drivers,northbridge,security}: Remove unused <cpu/x86/lapic.h> Found using: diff <(git grep -l '#include <cpu/x86/lapic.h>' -- src/) <(git grep -l 'xapic_read\|xapic_write\|xapic_send_ipi\|xapic_busy\|x2apic_read\|x2apic_write\|x2apic_send_ipi\|is_x2apic_mode\|lapic_read\|lapic_write\|lapic_update32\|lapic_send_ipi\|lapic_busy\|initial_lapicid\|lapicid\|stop_this_cpu\|enable_lapic\|disable_lapic\|setup_lapic' -- src/) |grep ">" Change-Id: Ie8fcf61a0604281c23cd3f589f1aa0cdbbd9366b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61048 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <martinroth(a)google.com> --- M src/drivers/generic/ioapic/ioapic.c M src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c M src/northbridge/amd/pi/00730F01/northbridge.c M src/security/intel/txt/common.c M src/security/intel/txt/getsec.c 5 files changed, 0 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/src/drivers/generic/ioapic/ioapic.c b/src/drivers/generic/ioapic/ioapic.c index 0097c59..8184484 100644 --- a/src/drivers/generic/ioapic/ioapic.c +++ b/src/drivers/generic/ioapic/ioapic.c @@ -3,7 +3,6 @@ #include <device/device.h> #include "chip.h" #include <arch/ioapic.h> -#include <cpu/x86/lapic.h> static void ioapic_init(struct device *dev) { diff --git a/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c b/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c index 9aef1b6..53d9182 100644 --- a/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c +++ b/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <cpu/cpu.h> #include <cpu/x86/mp.h> -#include <cpu/x86/lapic.h> #include <cpu/intel/microcode.h> #include <fsp/api.h> #include <fsp/ppi/mp_service_ppi.h> diff --git a/src/northbridge/amd/pi/00730F01/northbridge.c b/src/northbridge/amd/pi/00730F01/northbridge.c index 69dcc62..8a136b6 100644 --- a/src/northbridge/amd/pi/00730F01/northbridge.c +++ b/src/northbridge/amd/pi/00730F01/northbridge.c @@ -17,7 +17,6 @@ #include <Porting.h> #include <AGESA.h> #include <Topology.h> -#include <cpu/x86/lapic.h> #include <cpu/amd/msr.h> #include <cpu/amd/mtrr.h> #include <acpi/acpigen.h> diff --git a/src/security/intel/txt/common.c b/src/security/intel/txt/common.c index 14bd296..ea348d2 100644 --- a/src/security/intel/txt/common.c +++ b/src/security/intel/txt/common.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <cbfs.h> #include <cpu/x86/cr.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/security/intel/txt/getsec.c b/src/security/intel/txt/getsec.c index 16ffedd..e2cb6cd 100644 --- a/src/security/intel/txt/getsec.c +++ b/src/security/intel/txt/getsec.c @@ -3,7 +3,6 @@ #include <cf9_reset.h> #include <console/console.h> #include <cpu/intel/common/common.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/cr.h> #include <cpu/x86/cache.h> #include <cpu/x86/mp.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/61048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8fcf61a0604281c23cd3f589f1aa0cdbbd9366b Gerrit-Change-Number: 61048 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: {drivers,northbridge,security}: Remove unused <cpu/x86/lapic.h>
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Andrey Petrov, Patrick Rudolph, Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61048 ) Change subject: {drivers,northbridge,security}: Remove unused <cpu/x86/lapic.h> ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8fcf61a0604281c23cd3f589f1aa0cdbbd9366b Gerrit-Change-Number: 61048 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 24 Apr 2022 21:23:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022