coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: mb/google/skyrim: Configure SD card reader power sequence
by Ian Feng (Code Review) 25 Apr '22

25 Apr '22

Attention is currently required from: Raul Rangel, Eric Lai, Karthik Ramasubramanian. Ian Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63739 ) Change subject: mb/google/skyrim: Configure SD card reader power sequence ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/skyrim/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/63739/comment/6b3ebd0d_228237f8 PS5, Line 201: PAD_GPO > Can you try the following: `PAD_NFO(GPIO_27, PCIE_RST1_L, HIGH),` also update it in the ramstage lis […] I try modify to `PAD_NFO(GPIO_27, PCIE_RST1_L, HIGH),` in ramstage and SD Card are enumerated fine. -- To view, visit https://review.coreboot.org/c/coreboot/+/63739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I03d88d90acc03cdebcb1e83ed2e799dda8b5b735 Gerrit-Change-Number: 63739 Gerrit-PatchSet: 5 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 25 Apr 2022 03:41:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib: Add LPDDR5 DRAM type
by Scott Chao (Code Review) 25 Apr '22

25 Apr '22

Attention is currently required from: Subrata Banik. Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63680 ) Change subject: lib: Add LPDDR5 DRAM type ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Hi Subrata, can you help to review this CL? Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/63680 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98ba9e87b1a093b93434334a75c9a9252effa933 Gerrit-Change-Number: 63680 Gerrit-PatchSet: 2 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Mon, 25 Apr 2022 03:14:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: Fix camera LED flicker problem
by Shon Wang (Code Review) 25 Apr '22

25 Apr '22

Attention is currently required from: Paul Menzel, Tim Wawrzynczak. Shon Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63441 ) Change subject: mb/google/brya/var/vell: Fix camera LED flicker problem ...................................................................... Patch Set 7: Code-Review+1 (4 comments) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/63441/comment/e070f978_e7086a31 PS5, Line 10: , > . Done https://review.coreboot.org/c/coreboot/+/63441/comment/033cd303_9134864b PS5, Line 13: and prevent camera LED flicker > preventing camera LED flicker. Done https://review.coreboot.org/c/coreboot/+/63441/comment/bda28e34_b3775cc2 PS5, Line 16: flicker > flickers Done File src/mainboard/google/brya/variants/vell/overridetree.cb: https://review.coreboot.org/c/coreboot/+/63441/comment/33728b69_5e0744fd PS5, Line 314: register "on_seq.ops_cnt" = "4" : register "on_seq.ops[0]" = "SEQ_OPS_CLK_ENABLE(0, 0)" : register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(0, 5)" : register "on_seq.ops[2]" = "SEQ_OPS_GPIO_DISABLE(1, 5)" : register "on_seq.ops[3]" = "SEQ_OPS_GPIO_ENABLE(1, 5)" : : #_OFF : register "off_seq.ops_cnt" = "3" : register "off_seq.ops[0]" = "SEQ_OPS_GPIO_DISABLE(1, 0)" : register "off_seq.ops[1]" = "SEQ_OPS_GPIO_DISABLE(0, 0)" : register "off_seq.ops[2]" = "SEQ_OPS_CLK_DISABLE(0, 0)" : : device i2c 36 on end : end : chip drivers/intel/mipi_camera : register "acpi_hid" = "ACPI_DT_NAMESPACE_HID" > You do not mention these changes in the commit message. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I846ec4cb5c4527f5664699b31d0d561d390d938c Gerrit-Change-Number: 63441 Gerrit-PatchSet: 7 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jimmy Su <jimmy.su(a)intel.corp-partner.google.com> Gerrit-CC: Kevin Chiu <coreboot.test(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Mon, 25 Apr 2022 02:04:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Revert CdClock setting
by Simon Yang (Code Review) 25 Apr '22

25 Apr '22

Attention is currently required from: Nico Huber, Henry Sun, Tim Wawrzynczak, Angel Pons, Simon Yang, Kane Chen, Karthik Ramasubramanian. Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63808 ) Change subject: soc/intel/jasperlake: Revert CdClock setting ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/63808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I50d65e0caaf8f3f074322cff5bbdc68bdb1bbf78 Gerrit-Change-Number: 63808 Gerrit-PatchSet: 3 Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie.chen(a)intel.com> Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-CC: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 25 Apr 2022 01:47:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Revert CdClock setting
by Simon Yang (Code Review) 25 Apr '22

25 Apr '22

Attention is currently required from: Nico Huber, Henry Sun, Tim Wawrzynczak, Angel Pons, Simon Yang, Kane Chen, Karthik Ramasubramanian. Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63808 ) Change subject: soc/intel/jasperlake: Revert CdClock setting ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/63808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I50d65e0caaf8f3f074322cff5bbdc68bdb1bbf78 Gerrit-Change-Number: 63808 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jamie Chen <jamie.chen(a)intel.com> Gerrit-CC: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 25 Apr 2022 01:18:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake/retimer.c: Do not access TCSS devices on ADL-S
by Eric Lai (Code Review) 25 Apr '22

25 Apr '22

Attention is currently required from: Michał Żygowski. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63501 ) Change subject: soc/intel/alderlake/retimer.c: Do not access TCSS devices on ADL-S ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: If you don't select CONFIG_DRIVERS_INTEL_USB4_RETIMER, this won't be called. -- To view, visit https://review.coreboot.org/c/coreboot/+/63501 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I562b7195371f87154698690362bf957881160b89 Gerrit-Change-Number: 63501 Gerrit-PatchSet: 7 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Mon, 25 Apr 2022 00:59:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: console/Kconfig: Reverse NO_POST and depend on ARCH_X86
by Kyösti Mälkki (Code Review) 25 Apr '22

25 Apr '22

Attention is currently required from: Arthur Heymans. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63678 ) Change subject: console/Kconfig: Reverse NO_POST and depend on ARCH_X86 ...................................................................... Patch Set 2: (1 comment) File src/console/Kconfig: https://review.coreboot.org/c/coreboot/+/63678/comment/fd9b9fd3_a864e95b PS2, Line 418: depends on ARCH_X86 Well there are post_code() calls under device/ and lib/ and implementation separates the need for <arch/io.h>. So CONSOLE_POST would already work on ARM? -- To view, visit https://review.coreboot.org/c/coreboot/+/63678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I184bd5574db9a8817dc235846cc6fddf519e7121 Gerrit-Change-Number: 63678 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 24 Apr 2022 23:13:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Kconfig: Hide stage cache selection on !HAVE_ACPI_RESUME
by Kyösti Mälkki (Code Review) 25 Apr '22

25 Apr '22

Attention is currently required from: Arthur Heymans. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63677 ) Change subject: Kconfig: Hide stage cache selection on !HAVE_ACPI_RESUME ...................................................................... Patch Set 1: (1 comment) File src/Kconfig: https://review.coreboot.org/c/coreboot/+/63677/comment/121b8e5c_9a774cda PS1, Line 331: depends on HAVE_ACPI_RESUME With this HAVE_ACPI_RESUME=n implies NO_STAGE_CACHE=n, and resume_from_stage_cache() will actually call romstage_handoff_is_resume(). Not a big deal, maybe you want to add !CONFIG(HAVE_ACPI_RESUME) there? -- To view, visit https://review.coreboot.org/c/coreboot/+/63677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I005ebde53d99b946dc54644e17b07ca12b32c0a6 Gerrit-Change-Number: 63677 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 24 Apr 2022 22:58:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/coreinfo/coreboot_module.c: Remove 'break' after 'return'
by Elyes Haouas (Code Review) 25 Apr '22

25 Apr '22

Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61954 ) Change subject: payloads/coreinfo/coreboot_module.c: Remove 'break' after 'return' ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/61954/comment/868e0bf4_4a06f494 PS2, Line 7: unuseful > Remove "unuseful" to shorten the subject? Thx -- To view, visit https://review.coreboot.org/c/coreboot/+/61954 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb60115349ef7c4c35635021784138d45c5a8872 Gerrit-Change-Number: 61954 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Apr 2022 22:40:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/coreinfo/coreboot_module.c: Remove 'break' after 'return'
by Elyes Haouas (Code Review) 25 Apr '22

25 Apr '22

Attention is currently required from: Elyes Haouas. Hello build bot (Jenkins), Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61954 to look at the new patch set (#3). Change subject: payloads/coreinfo/coreboot_module.c: Remove 'break' after 'return' ...................................................................... payloads/coreinfo/coreboot_module.c: Remove 'break' after 'return' Change-Id: Icb60115349ef7c4c35635021784138d45c5a8872 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M payloads/coreinfo/coreboot_module.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/61954/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/61954 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb60115349ef7c4c35635021784138d45c5a8872 Gerrit-Change-Number: 61954 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022