coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/zork: fix SMMSTORE size, alignment in default FMAP
by Matt DeVillier (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Arthur Heymans, Karthik Ramasubramanian. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62443 ) Change subject: mb/google/zork: fix SMMSTORE size, alignment in default FMAP ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Just curious, what are you using SMMSTORE for? It's not enabled by default. it's enabled by default when Tianocore is the selected payload :) -- To view, visit https://review.coreboot.org/c/coreboot/+/62443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied04e93379e1507f5e6b2a1b71e4098a4561e5d8 Gerrit-Change-Number: 62443 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 02 Mar 2022 23:31:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork: fix SMMSTORE size, alignment in default FMAP
by Raul Rangel (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Matt DeVillier, Arthur Heymans, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62443 ) Change subject: mb/google/zork: fix SMMSTORE size, alignment in default FMAP ...................................................................... Patch Set 2: Code-Review+2 (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62443/comment/c03598ad_b329ee40 PS1, Line 9: 64k > > Where is this documented? […] Ack https://review.coreboot.org/c/coreboot/+/62443/comment/9e1d417d_7216d62e PS1, Line 12: asserts > src/drivers/smmstore/store. […] Ack Patchset: PS2: Just curious, what are you using SMMSTORE for? It's not enabled by default. -- To view, visit https://review.coreboot.org/c/coreboot/+/62443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied04e93379e1507f5e6b2a1b71e4098a4561e5d8 Gerrit-Change-Number: 62443 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 02 Mar 2022 23:21:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/tianocore: Fix up Kconfig repo, bootsplash options
by Matt DeVillier (Code Review) 02 Mar '22

02 Mar '22

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62548 ) Change subject: payloads/tianocore: Fix up Kconfig repo, bootsplash options ...................................................................... payloads/tianocore: Fix up Kconfig repo, bootsplash options Commit 0884f210 [payloads/tianocore: Rework Makefile] added a "custom" option for the edk2 payload, but neglected to clear the default edk2 repo and tag/branch fields, leaving the defaults for the UEFIPAYLOAD option. Clear these to make it ovbious they should be set by the user. It also removed the Kconfig guarding the use of a custom bootsplash image, leaving the default "bootsplash.bmp" which does not exist, causing a silent failure when building. Add a BMP of the coreboot logo as the default bootsplash and adjust the path/filename. Correct the help text since it was not adjusted when the "use" Kconfig was removed in 0084f210. Change-Id: I1b6af815564fc02eb93c4727d15963361095cc75 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M payloads/external/tianocore/Kconfig A payloads/external/tianocore/coreboot_logo.bmp 2 files changed, 5 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/62548/1 diff --git a/payloads/external/tianocore/Kconfig b/payloads/external/tianocore/Kconfig index 4194290..e7542dc 100644 --- a/payloads/external/tianocore/Kconfig +++ b/payloads/external/tianocore/Kconfig @@ -46,6 +46,7 @@ string "URL to git repository for edk2" default "https://github.com/tianocore/edk2" if TIANOCORE_UPSTREAM default "https://github.com/mrchromebox/edk2" if TIANOCORE_UEFIPAYLOAD || TIANOCORE_COREBOOTPAYLOAD + default "" if TIANOCORE_CUSTOM help coreboot supports an array of build options which can be found below. These options will only have an effect if the relevant options exist in the target repository. @@ -55,6 +56,7 @@ default "origin/uefipayload_202107" if TIANOCORE_UEFIPAYLOAD default "origin/master" if TIANOCORE_UPSTREAM default "origin/coreboot_fb" if TIANOCORE_COREBOOTPAYLOAD + default "" if TIANOCORE_CUSTOM help The commit's SHA-1 or branch name of the revision to use. This must exist in TIANOCORE_REPOSITORY, and in the case of a branch name, prefixed with origin i.e. @@ -94,17 +96,13 @@ config TIANOCORE_BOOTSPLASH_FILE string "Tianocore Bootsplash path and filename" - default "bootsplash.bmp" + default "payloads/external/tianocore/coreboot_logo.bmp" help - Select this option if you have a bootsplash image that you would - like to be used. If this option is not selected, the default - coreboot logo (European Brown Hare) will used. - The path and filename of the file to use as graphical bootsplash image. The file must be an uncompressed BMP, in BMP 3 format. - Linux can create these with the below command: - `convert splosh.bmp BMP3:splash.bmp` + Override the default option if you have a custom bootsplash image that + you would like to be used; otherwise, the coreboot logo will be used. This image will also be used as the BGRT boot image, which may persist through your OS boot process. diff --git a/payloads/external/tianocore/coreboot_logo.bmp b/payloads/external/tianocore/coreboot_logo.bmp new file mode 100644 index 0000000..3997e96 --- /dev/null +++ b/payloads/external/tianocore/coreboot_logo.bmp Binary files differ -- To view, visit https://review.coreboot.org/c/coreboot/+/62548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1b6af815564fc02eb93c4727d15963361095cc75 Gerrit-Change-Number: 62548 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Revert "soc/amd/common/vboot: Remove parameter to replay_transfer_buf...
by Martin Roth (Code Review) 02 Mar '22

02 Mar '22

Martin Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62532 ) Change subject: Revert "soc/amd/common/vboot: Remove parameter to replay_transfer_buffer_cbmemc" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/62532 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e5fe4b13cd8a96df3dd524565f5256790b5cf86 Gerrit-Change-Number: 62532 Gerrit-PatchSet: 1 Gerrit-Owner: Joey Madafferi <joeymadafferi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Revert "acpi/acpi: drop weak cpu_get_lapic_addr implementation"
by Martin Roth (Code Review) 02 Mar '22

02 Mar '22

Martin Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62533 ) Change subject: Revert "acpi/acpi: drop weak cpu_get_lapic_addr implementation" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/62533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic86a9c0c4cb0894cc75154176115dbed12296685 Gerrit-Change-Number: 62533 Gerrit-PatchSet: 1 Gerrit-Owner: Joey Madafferi <joeymadafferi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Revert "Documentation/mainboard: Add QEMU POWER9 to index site"
by Martin Roth (Code Review) 02 Mar '22

02 Mar '22

Martin Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62534 ) Change subject: Revert "Documentation/mainboard: Add QEMU POWER9 to index site" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/62534 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2e852318e08423de2bc67903b45b7569ed859db Gerrit-Change-Number: 62534 Gerrit-PatchSet: 1 Gerrit-Owner: Joey Madafferi <joeymadafferi(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Revert "Documentation/mainboard: Add QEMU POWER9 to index site"
by Matt DeVillier (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Felix Singer, Paul Menzel, Angel Pons, Joey Madafferi. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62534 ) Change subject: Revert "Documentation/mainboard: Add QEMU POWER9 to index site" ...................................................................... Patch Set 1: Code-Review-2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62534 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2e852318e08423de2bc67903b45b7569ed859db Gerrit-Change-Number: 62534 Gerrit-PatchSet: 1 Gerrit-Owner: Joey Madafferi <joeymadafferi(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Joey Madafferi <joeymadafferi(a)gmail.com> Gerrit-Comment-Date: Wed, 02 Mar 2022 23:09:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "acpi/acpi: drop weak cpu_get_lapic_addr implementation"
by Raul Rangel (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Joey Madafferi, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62533 ) Change subject: Revert "acpi/acpi: drop weak cpu_get_lapic_addr implementation" ...................................................................... Patch Set 1: Code-Review-2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic86a9c0c4cb0894cc75154176115dbed12296685 Gerrit-Change-Number: 62533 Gerrit-PatchSet: 1 Gerrit-Owner: Joey Madafferi <joeymadafferi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: Lance Zhao Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Joey Madafferi <joeymadafferi(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 23:04:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "soc/amd/common/vboot: Remove parameter to replay_transfer_buf...
by Raul Rangel (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Jason Glenesk, Marshall Dawson, Fred Reitberger, Rob Barnes, Karthik Ramasubramanian, Joey Madafferi, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62532 ) Change subject: Revert "soc/amd/common/vboot: Remove parameter to replay_transfer_buffer_cbmemc" ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: Joey seems to be a rogue actor. -- To view, visit https://review.coreboot.org/c/coreboot/+/62532 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e5fe4b13cd8a96df3dd524565f5256790b5cf86 Gerrit-Change-Number: 62532 Gerrit-PatchSet: 1 Gerrit-Owner: Joey Madafferi <joeymadafferi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Joey Madafferi <joeymadafferi(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 23:04:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/*/northbridge,root_complex: add comment about PCI BARs
by Raul Rangel (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Jason Glenesk, Marshall Dawson, Fred Reitberger, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62547 ) Change subject: soc/amd/*/northbridge,root_complex: add comment about PCI BARs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie480832e0d7954135d2171dda986e477ef7b6c09 Gerrit-Change-Number: 62547 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 23:00:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022